Skip to content

docs(rfc): let the dashboard agent offer a close-session chip when its work is done - #37053

Open
rnoack1 wants to merge 1 commit into
mainfrom
docs/rfc-agent-offered-close-chip
Open

rnoack1 wants to merge 1 commit into
mainfrom
docs/rfc-agent-offered-close-chip

Conversation

@rnoack1

@rnoack1 rnoack1 commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Record the decision that the default dashboard agent may offer a one-click close-session chip once its work is done.

#6823 adds that offer to the dashboard's critical rules, which changes what every dashboard session's agent may say at the end of its work. That is a change to a default, so the First Principles lane needs a decision recorded on the base branch first. Nothing records it today.

Why it matters

A user who is done must type a reply, which spends an LLM turn to say nothing, or find the sidebar ✕. The tag for this chip is already reserved in src/kiro_crew/constants.py and stripped on every channel, but no agent emits it and the dashboard does not render it.

Not a goal

What changed (motivation → approach → change)

  • docs/request-for-change/rfc-agent-offered-close-chip.md (new): the rule text, how the chip renders, that it closes through the sidebar close (closeSessionAsking), the two-click arm where no dialog would ask, the exit criteria, and the alternatives considered.
  • docs/request-for-change/README.md: one index row for it.

Code references were read on main at f9ebf3a1e2.

Tests

None needed: no code changes. python3 scripts/docs_lint.py passes with 0 findings.

No visual change: this PR adds a document only.

Related Issues

Implementation: #6823.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@rnoack1
rnoack1 requested review from a team and KiroCrewCaptain as code owners November 14, 2026 03:26
@rnoack1
rnoack1 requested a review from Zedmor November 14, 2026 03:26
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 14, 2026
@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision b566a4e45c48088462d09abd98a8eba0edaca201 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision b566a4e45c48088462d09abd98a8eba0edaca201 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of b566a4e45c48088462d09abd98a8eba0edaca201 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Docs-only draft RFC. The decision it records is reversible, it changes no code, and the code it cites exists on this tree.

Notes

[DESIGN-REVIEWED] b566a4e

Description read

[DESCRIPTION-READ] 1af9ffe0a4d56757ba8c46e12454cc03caae6e793bc0b8a59761167b3cbf8c1e

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of b566a4e45c48088462d09abd98a8eba0edaca201 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] b566a4e

False positive or not applicable? A repository writer can comment:
/ai-review override gpt b566a4e45c48088462d09abd98a8eba0edaca201 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed b566a4e45c48088462d09abd98a8eba0edaca201 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] b566a4e

Verdict parsed from the review's SHA-scoped output markers for commit b566a4e45c48088462d09abd98a8eba0edaca201.

False positive or not applicable? A repository writer can comment:
/ai-review override fable b566a4e45c48088462d09abd98a8eba0edaca201 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Nov 14, 2026
@rnoack1
rnoack1 force-pushed the docs/rfc-agent-offered-close-chip branch from a7cb560 to e8eb454 Compare November 14, 2026 05:10
@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 14, 2026
@KiroCrewCaptain

KiroCrewCaptain commented Nov 14, 2026 •

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: A person should decide

Why: the decider estimates a 6% chance that this change introduces a defect, within the 12% limit for approving on its own, but it is held at tier 2: design-doc-gate: D.

This PR changes docs only. It adds a draft RFC and one alphabetically placed index row. I checked the RFC's citations against the head tree and they hold. constants.py reserves `` as the dashboard close-session chip, and _is_string_tag_line strips it. `_DIFF_RULE_DASHBOARD` exists in `output_contract.py`. `confirmCloseSession` and `closeConfirmPrompt` work as described, including the doc comment saying a close keeps drafts. `isStringTagLine` exists in `keepVisibleMarker.ts`. No trust boundary moves: the chip is model-written but only acts on a user click, closes through the existing sidebar close path, and needs a second click wherever no dialog would ask. The status is `draft`, as the description says. CI and all review lanes are green.

Tier: 2, held for a person: design-doc-gate: D.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit b566a4e45c · 99 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 14, 2026
@rnoack1
rnoack1 force-pushed the docs/rfc-agent-offered-close-chip branch from e8eb454 to 03a3e81 Compare November 14, 2026 08:53
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 14, 2026
@rnoack1
rnoack1 force-pushed the docs/rfc-agent-offered-close-chip branch from 03a3e81 to a97a27b Compare November 14, 2026 12:57
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 14, 2026
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Nov 15, 2026
@rnoack1
rnoack1 force-pushed the docs/rfc-agent-offered-close-chip branch from eee3999 to a6a1af9 Compare November 16, 2026 01:50
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision labels Nov 16, 2026
@rnoack1
rnoack1 force-pushed the docs/rfc-agent-offered-close-chip branch from a6a1af9 to 00b15e9 Compare November 16, 2026 03:39
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 16, 2026
@rnoack1

rnoack1 commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

Hi @bolichen97, thanks for the design brief. Could you, or another maintainer, make the call on this RFC?

#6823 builds it. Its First Principles lane blocks until this RFC is accepted on main, and every other AI lane on #6823 passes.

Two decisions are needed:

  1. Accept the RFC (docs/request-for-change/rfc-agent-offered-close-chip.md, currently status: draft).
  2. Answer open question 1, whether to limit the offer further. This PR proposes no extra limit for now. The rule already says "clearly finished" and "never while something is still owed", the chip never closes on its own, and an idle close needs a second click. If wrong offers show up in practice, a follow-up can narrow the rule.

A yes on this PR is enough. I'll then flip the status to accepted with a link to your comment, and record the answer to open question 1. If you would rather not accept the RFC, you can post /ai-review override first-principles <head> product-shape: <decision> on #6823 instead.

@rnoack1
rnoack1 force-pushed the docs/rfc-agent-offered-close-chip branch from 00b15e9 to 0eb7b46 Compare November 16, 2026 12:56
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: passed Eligible automated validation passed for the current revision readiness: checking Automated validation is still running labels Nov 16, 2026
@rnoack1
rnoack1 force-pushed the docs/rfc-agent-offered-close-chip branch from 0eb7b46 to b49a6f8 Compare November 16, 2026 14:51
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 16, 2026
…s work is done

Records the product-shape decision behind #6823: the default dashboard agent may end a finished reply with <!-- option-action:close=<label> -->, and the dashboard renders it as a chip that closes the session through the sidebar close. It lands before the implementation because the First Principles lane reads the decision from the base branch.
@rnoack1
rnoack1 force-pushed the docs/rfc-agent-offered-close-chip branch from b49a6f8 to b566a4e Compare November 17, 2026 18:37
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 17, 2026
@rnoack1

rnoack1 commented Nov 17, 2026

Copy link
Copy Markdown
Contributor Author

Hi @buluoray, could you make the design call on this RFC? It has been waiting since 2026-11-14, and #6823, which builds it, is blocked only on this decision. All five AI lanes pass on #6823 at 2ed440de36.

The one decision: may the default dashboard agent offer a close-session chip when its work is done? The chip uses the existing sidebar close, and it needs a second click to confirm wherever that close would not ask on its own.

One known nit: the title and heading still say "one-click", although the body describes the second-click guard. I have the two-line fix ready and will push it whenever you want it in before acceptance.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants