Skip to content

fix(sidebar): mark the unfiled-sessions row like the unread-first row - #37094

Merged
bolichen97 merged 2 commits into
kirodotdev:mainfrom
gsboylan:fix/unfiled-row-check
Nov 18, 2026
Merged

bolichen97 merged 2 commits into
kirodotdev:mainfrom
gsboylan:fix/unfiled-row-check

Conversation

@gsboylan

@gsboylan gsboylan commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Let the sidebar menu's Unfiled sessions above folders row show that it is on the same way as the Move folders with unread chats to the top row in the same section.

The Folder order section of the sidebar's sort-and-filter menu holds two checkbox rows. Move folders with unread chats to the top (#25781) shows a check after its label while it is on, as the Folder order radio rows do. Unfiled sessions above folders (#22596) shows a filled box before its label, the style of the tag, model and folder filter rows further down the menu. Two toggles in one section that mark their on state in two ways read as two kinds of control.

Why it matters

Both toggles change how the folder list is drawn, so a person reads them as one group. With two marks for the same state, they have to learn two styles to see which options are on, and the box makes this row look like one of the filter lists.

Not a goal

  • Restyling the tag, model and folder filter rows. Their multi-select lists keep the box.
  • Moving the row, or the separator above it, within the menu.
  • Changing the setting, its config key or how it saves.

What changed (motivation → approach → change)

The Folder order section used two marks for a toggle that is on. The radio rows and the unread-first row draw the lucide Check icon after the label, at 14 px in the accent color. The unfiled-sessions row drew a 14 px box before the label, filled with the accent color and holding a smaller Check. In website/src/pages/chat-sidebar/SearchDock.tsx the row now renders its label and then, while the setting is on, the same Check element the unread-first row renders. Its menuitemcheckbox role, its aria-checked state and its click, which keeps the menu open, are unchanged.

Backwards compatibility

Compatible: only the mark that shows the row is on changes. The setting, its config key and its save are untouched.

Removes nothing: the row keeps its label, role, checked state and click behavior.

Tests

No test changes. The menu tests in website/src/test/ChatSidebar.unfiledAboveFolders.test.tsx and website/src/test/ChatSidebar.boardUnfiledAboveFolders.test.tsx find the row by its data-testid and read aria-checked, which this change keeps. Locally, those two files and the other three Folder order menu files passed under KIROCREW_ACT_STRICT=1 (5 files, 59 tests), every ChatSidebar.* test file plus the files that name SearchDock.tsx passed (168 files, 1801 tests), and npm run typecheck, eslint, npm run i18n:check, npm run gen:ui -- --check and npm run build passed.

Proof: not provable -- other: visual-only change, and no test reads the shape of the check mark

Manual verification

The dev stack (./dev-fullstack.sh) ran from this branch on a scratch copy of a dev data home, and a Playwright script clicked the menu rows. With Unfiled sessions above folders off, the row shows no mark. With it on, a check follows its label, the same mark Move folders with unread chats to the top shows when both are on. Each click saved the setting and left the menu open. The tag filter rows further down the menu keep their boxes.

Screenshots / video

Before, from #22596, with the setting on:

The Folder order section with the unfiled-sessions row on, marked by a filled box before its label.

After, both toggles on:

image

After, the unfiled-sessions row off:

image

Whole dropdown, for context

image

Related Issues

Refs #17073

Sibling sweep

Swept: git grep -nE 'rounded-\[3px\] border' -- website/src/pages/chat-sidebar/SearchDock.tsx
Sibling: website/src/pages/chat-sidebar/SearchDock.tsx:853 -- not affected -- the tag filter rows (line 853), the model filter's hide toggle and rows (lines 903 and 947) and the folder filter rows (line 1037) form multi-select lists that draw the box on every row

Pattern harvest

Not generalizable: the two rows came from separate PRs, and each matched a different section of the same menu, so one style choice was wrong once.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license, as the Licensing section of CONTRIBUTING.md describes.

The Folder order section of the sidebar's sort-and-filter menu holds
two checkbox rows. Move folders with unread chats to the top shows a
check after its label while it is on, as the radio rows above it do.
Unfiled sessions above folders shows a filled box before its label in
the style of the tag, model and folder filter rows, so the two toggles
in one section read as two kinds of control.

This commit draws the unfiled-sessions row the same way as the
unread-first row, with a check after its label while the setting is on.

Refs kirodotdev#17073
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention labels Nov 14, 2026
@gsboylan
gsboylan marked this pull request as ready for review November 16, 2026 21:34
@gsboylan
gsboylan requested review from a team and KiroCrewCaptain as code owners November 16, 2026 21:34

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving fd9f592. The Unfiled sessions above folders row now marks its on state with the same trailing 14 px accent Check as the unread-first row and the Folder order radios, and keeps its menuitemcheckbox role, aria-checked and click, so the two menu tests that read aria-checked still hold. One file, -6/+1. I approved the held fork CI runs; auto merge will be on.

AI-assisted, sent by Bolin Review bot

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 16, 2026
@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ✅ PASS

Premise-level review of 7c0cbd6aac7b14e0baa06fe7e8f18504049c7195 via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

The change is reversible and visual only. Its only support is symmetry with the row next to it, so it gets a note, not a block.

Notes

What this change ships

Inventory (1 items) — 0 justified

Intent: make the "Unfiled sessions above folders" toggle show its on state with the same mark as the "unread first" toggle beside it. ADDITION, though it is framed as a FIX.

  1. While on, the unfiled-sessions row shows a check after its label instead of a filled box before it (same element as SearchDock.tsx:656, 1 of 8 Check size={14} sites) — inherited (symmetry)

[FIRST-PRINCIPLES-REVIEWED] 7c0cbd6

Description read

[DESCRIPTION-READ] f96375e30695ca862c2ca539995fab6ef09246587ae10c1b9777b0a66496557e

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of 7c0cbd6aac7b14e0baa06fe7e8f18504049c7195 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the change only swaps the on-state mark for the Check the rows around it in the section already use. Screenshots of this revision are attached.

[DESIGN-REVIEWED] 7c0cbd6

Description read

[DESCRIPTION-READ] b17692e395dfff41da9678dcd3b28bd5dc1dfc7b7876ef843abeb1e2dcda13b2

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ✅ PASS

UX-level review of 7c0cbd6aac7b14e0baa06fe7e8f18504049c7195 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks: the screenshots show the changed check mark both on (attachment-02) and off (attachment-03). This lane has no blind read; a maintainer can push the branch to this repository to get one.

[UX-REVIEWED] 7c0cbd6

Description read

[DESCRIPTION-READ] 77ea72ed5bff08b6a196f1e3b847f05499e632009b4466b6ea0e3c133bcbd648

That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed 7c0cbd6aac7b14e0baa06fe7e8f18504049c7195 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 7c0cbd6

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed 7c0cbd6aac7b14e0baa06fe7e8f18504049c7195 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 7c0cbd6

@bolichen97
bolichen97 enabled auto-merge (squash) November 16, 2026 22:05
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 16, 2026
@bolichen97

Copy link
Copy Markdown
Contributor

@gsboylan the reds here are not from this PR. CI tested a merge with an old main (899d458). The failing backend test, test/test_search_docs.py::test_search_docs_ranks_the_page_the_query_is_about_first, passes on current main (5ff3fed), and the i18n, render benchmark and E2E jobs failed in the same stale run. Please rebase onto latest main and push; my approval stands and auto merge is on, so it will merge once CI is green.

AI-assisted, sent by Bolin Review bot

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 17, 2026
@bolichen97 bolichen97 closed this Nov 18, 2026
auto-merge was automatically disabled November 18, 2026 15:25

Pull request was closed

@bolichen97 bolichen97 reopened this Nov 18, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 18, 2026
@bolichen97
bolichen97 enabled auto-merge (squash) November 18, 2026 15:27
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 18, 2026
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 18, 2026
@bolichen97
bolichen97 merged commit b0e27fb into kirodotdev:main Nov 18, 2026
108 of 110 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants