Repository navigation
fix(sidebar): mark the unfiled-sessions row like the unread-first row - #37094
Conversation
The Folder order section of the sidebar's sort-and-filter menu holds two checkbox rows. Move folders with unread chats to the top shows a check after its label while it is on, as the radio rows above it do. Unfiled sessions above folders shows a filled box before its label in the style of the tag, model and folder filter rows, so the two toggles in one section read as two kinds of control. This commit draws the unfiled-sessions row the same way as the unread-first row, with a check after its label while the setting is on. Refs kirodotdev#17073
bolichen97
left a comment
There was a problem hiding this comment.
Approving fd9f592. The Unfiled sessions above folders row now marks its on state with the same trailing 14 px accent Check as the unread-first row and the Folder order radios, and keeps its menuitemcheckbox role, aria-checked and click, so the two menu tests that read aria-checked still hold. One file, -6/+1. I approved the held fork CI runs; auto merge will be on.
AI-assisted, sent by Bolin Review bot
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS The change is reversible and visual only. Its only support is symmetry with the row next to it, so it gets a note, not a block. Notes
What this change shipsInventory (1 items) — 0 justifiedIntent: make the "Unfiled sessions above folders" toggle show its on state with the same mark as the "unread first" toggle beside it. ADDITION, though it is framed as a FIX.
[FIRST-PRINCIPLES-REVIEWED] 7c0cbd6 Description read[DESCRIPTION-READ] f96375e30695ca862c2ca539995fab6ef09246587ae10c1b9777b0a66496557e That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the change only swaps the on-state mark for the [DESIGN-REVIEWED] 7c0cbd6 Description read[DESCRIPTION-READ] b17692e395dfff41da9678dcd3b28bd5dc1dfc7b7876ef843abeb1e2dcda13b2 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5, fork) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks: the screenshots show the changed check mark both on (attachment-02) and off (attachment-03). This lane has no blind read; a maintainer can push the branch to this repository to get one. [UX-REVIEWED] 7c0cbd6 Description read[DESCRIPTION-READ] 77ea72ed5bff08b6a196f1e3b847f05499e632009b4466b6ea0e3c133bcbd648 That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
|
@gsboylan the reds here are not from this PR. CI tested a merge with an old main (899d458). The failing backend test, AI-assisted, sent by Bolin Review bot |
Pull request was closed
Problem / Motivation
Goal: Let the sidebar menu's Unfiled sessions above folders row show that it is on the same way as the Move folders with unread chats to the top row in the same section.
The Folder order section of the sidebar's sort-and-filter menu holds two checkbox rows. Move folders with unread chats to the top (#25781) shows a check after its label while it is on, as the Folder order radio rows do. Unfiled sessions above folders (#22596) shows a filled box before its label, the style of the tag, model and folder filter rows further down the menu. Two toggles in one section that mark their on state in two ways read as two kinds of control.
Why it matters
Both toggles change how the folder list is drawn, so a person reads them as one group. With two marks for the same state, they have to learn two styles to see which options are on, and the box makes this row look like one of the filter lists.
Not a goal
What changed (motivation → approach → change)
The Folder order section used two marks for a toggle that is on. The radio rows and the unread-first row draw the lucide
Checkicon after the label, at 14 px in the accent color. The unfiled-sessions row drew a 14 px box before the label, filled with the accent color and holding a smallerCheck. Inwebsite/src/pages/chat-sidebar/SearchDock.tsxthe row now renders its label and then, while the setting is on, the sameCheckelement the unread-first row renders. Itsmenuitemcheckboxrole, itsaria-checkedstate and its click, which keeps the menu open, are unchanged.Backwards compatibility
Compatible: only the mark that shows the row is on changes. The setting, its config key and its save are untouched.
Removes nothing: the row keeps its label, role, checked state and click behavior.
Tests
No test changes. The menu tests in
website/src/test/ChatSidebar.unfiledAboveFolders.test.tsxandwebsite/src/test/ChatSidebar.boardUnfiledAboveFolders.test.tsxfind the row by itsdata-testidand readaria-checked, which this change keeps. Locally, those two files and the other three Folder order menu files passed underKIROCREW_ACT_STRICT=1(5 files, 59 tests), everyChatSidebar.*test file plus the files that nameSearchDock.tsxpassed (168 files, 1801 tests), andnpm run typecheck,eslint,npm run i18n:check,npm run gen:ui -- --checkandnpm run buildpassed.Proof: not provable -- other: visual-only change, and no test reads the shape of the check mark
Manual verification
The dev stack (
./dev-fullstack.sh) ran from this branch on a scratch copy of a dev data home, and a Playwright script clicked the menu rows. With Unfiled sessions above folders off, the row shows no mark. With it on, a check follows its label, the same mark Move folders with unread chats to the top shows when both are on. Each click saved the setting and left the menu open. The tag filter rows further down the menu keep their boxes.Screenshots / video
Before, from #22596, with the setting on:
After, both toggles on:
After, the unfiled-sessions row off:
Whole dropdown, for context
Related Issues
Refs #17073
Sibling sweep
Swept:
git grep -nE 'rounded-\[3px\] border' -- website/src/pages/chat-sidebar/SearchDock.tsxSibling: website/src/pages/chat-sidebar/SearchDock.tsx:853 -- not affected -- the tag filter rows (line 853), the model filter's hide toggle and rows (lines 903 and 947) and the folder filter rows (line 1037) form multi-select lists that draw the box on every row
Pattern harvest
Not generalizable: the two rows came from separate PRs, and each matched a different section of the same menu, so one style choice was wrong once.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the project's Apache-2.0 license, as the Licensing section of CONTRIBUTING.md describes.