Skip to content

docs(rfc): withdraw the host_pressure record, wake and pause; keep the critical refusal - #37170

Merged
iamwhatever merged 1 commit into
mainfrom
docs/withdraw-host-pressure-rfc
Nov 15, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
docs/withdraw-host-pressure-rfc

Conversation

@iamwhatever

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Record on main that the repository owner withdrew the host-pressure record, conductor wake and pause rule, and kept only the critical create refusal.

The repository owner, verbatim: "我的想法是缩小,其实只要给个简单指示,说明派活要先查资源,然后给AI工具查资源不就好了?为什么改那么多代码" and "开精简 PR,只留 critical 拒绝。" In English: the conductor only needs a short rule to check resources before it dispatches, and the resource_status tool already does that; keep only the critical refusal.

Why it matters

The code trim #37164 removes a conductor behaviour that rfc-work-ledger-resource-pressure.md on main still records as decided. The First Principles lane reads that decision from the base branch, so the withdrawal must be on main first, in its own PR, before the trim can pass.

Not a goal

What changed (motivation → approach → change)

Backwards compatibility

Compatible: docs only; no code, config or behaviour changes here.

Removes nothing: the withdrawn design text stays in the RFC as the record; only its status lines change.

Tests

Proof: not provable -- docs or config only

docs-lint passes locally.

Manual verification

N/A — docs only.

Related Issues

Part of #36301

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners November 14, 2026 09:30
@iamwhatever
iamwhatever requested a review from buluoray November 14, 2026 09:30
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 14, 2026
@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision c73b40a308323fc35f8bc804353e845586b1a132 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of c73b40a308323fc35f8bc804353e845586b1a132 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

This PR only changes documentation: it records the owner's withdrawal, removes nothing that code reads, and leaves the withdrawn text in place as the record.

Notes

[DESIGN-REVIEWED] c73b40a

Description read

[DESCRIPTION-READ] d74b35931cf88aa066d5b21eda910a42e7af76677311d37067c2c242968bb277

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision c73b40a308323fc35f8bc804353e845586b1a132 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

iamwhatever pushed a commit that referenced this pull request Nov 14, 2026
…t pressure

The repository owner narrowed rfc-work-ledger-resource-pressure on 2026-11-14:
the conductor checks resource_status before it dispatches, and only one piece
of code stays. This removes the rest of #36481:

- src/kiro_crew/host_pressure.py (the host record) and its RESERVED_ROOT_DIRS slot
- ResourcePressureNotifier's episode id, pressure_sink, level-change wake and
  pending flush (back to its pre-#36481 behaviour)
- the pressure wake in conductor_wake and WorkLedgerProbe
- conductor.host_pressure in work_ledger_read
- the host_pressure conductor rule in spec_prompts, crewmate_prompts.json and
  goal-conductor SKILL.md, its parity anchor, and its work-ledger.md section
- test/test_work_ledger_host_pressure.py; the golden and spec-byte pins go
  back to their pre-#36481 values

Kept: _refuse_if_host_critical in _create_item (409 via the live
admission_check). Its code is renamed host_pressure_critical ->
host_memory_critical, since nothing named host_pressure is left. Its tests
move to test/test_work_ledger_host_memory_refusal.py.

The withdrawal itself is recorded in the RFC by #37170, which lands first.
@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed c73b40a308323fc35f8bc804353e845586b1a132 — this comment is updated in place on each push.

Review details

No findings.

Notes:

[OPUS-REVIEWED] c73b40a

Verdict parsed from the review's SHA-scoped output markers for commit c73b40a308323fc35f8bc804353e845586b1a132.

False positive or not applicable? A repository writer can comment:
/ai-review override fable c73b40a308323fc35f8bc804353e845586b1a132 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of c73b40a308323fc35f8bc804353e845586b1a132 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] c73b40a

False positive or not applicable? A repository writer can comment:
/ai-review override gpt c73b40a308323fc35f8bc804353e845586b1a132 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 14, 2026
@KiroCrewCaptain

KiroCrewCaptain commented Nov 14, 2026 •

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: Approve

Why: the decider estimates a 7% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes.

Docs-only RFC status change recording the owner's withdrawal of the host_pressure record, wake, pause rule and §12, keeping only the critical create refusal. Claims check out against main: _refuse_if_host_critical exists and is called from _create_item. in-progress is a valid status in the vocabulary and in the First Principles lane's accepted set. The withdrawn design text is kept as the record. The person-wait-hold §12 line and the README row are updated to match. This follows the RFC-first-in-its-own-PR process. No code or behaviour changes.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit c73b40a308 · 62 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@iamwhatever
iamwhatever force-pushed the docs/withdraw-host-pressure-rfc branch from b03d169 to 7fe600e Compare November 14, 2026 11:01
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 14, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 14, 2026
iamwhatever pushed a commit that referenced this pull request Nov 14, 2026
…t pressure

The repository owner narrowed rfc-work-ledger-resource-pressure on 2026-11-14:
the conductor checks resource_status before it dispatches, and only one piece
of code stays. This removes the rest of #36481:

- src/kiro_crew/host_pressure.py (the host record) and its RESERVED_ROOT_DIRS slot
- ResourcePressureNotifier's episode id, pressure_sink, level-change wake and
  pending flush (back to its pre-#36481 behaviour)
- the pressure wake in conductor_wake and WorkLedgerProbe
- conductor.host_pressure in work_ledger_read
- the host_pressure conductor rule in spec_prompts, crewmate_prompts.json and
  goal-conductor SKILL.md, its parity anchor, and its work-ledger.md section
- test/test_work_ledger_host_pressure.py; the golden and spec-byte pins go
  back to their pre-#36481 values

Kept: _refuse_if_host_critical in _create_item (409 via the live
admission_check). Its code is renamed host_pressure_critical ->
host_memory_critical, since nothing named host_pressure is left. Its tests
move to test/test_work_ledger_host_memory_refusal.py.

The withdrawal itself is recorded in the RFC by #37170, which lands first.
@iamwhatever
iamwhatever force-pushed the docs/withdraw-host-pressure-rfc branch from 7fe600e to 701b8c1 Compare November 14, 2026 15:43
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 14, 2026
@iamwhatever
iamwhatever force-pushed the docs/withdraw-host-pressure-rfc branch from 701b8c1 to 0efcbcf Compare November 14, 2026 17:18
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 14, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Nov 14, 2026
@iamwhatever
iamwhatever force-pushed the docs/withdraw-host-pressure-rfc branch from 0efcbcf to c73b40a Compare November 15, 2026 03:13
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 15, 2026
@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

This PR's Goal records a decision by the repository owner: withdraw the host_pressure record, the wake and the pause rule, and keep only the critical create refusal. That decision stays with the owner. The owner or a maintainer needs to confirm the quoted ruling on this PR before it can merge. Neither this PR nor #36301 has a comment that records it yet.

Review result on this head: no blocking findings. The change touches docs only, in 3 files under docs/request-for-change/. PR Readiness is green. Each claim checks out on main. _refuse_if_host_critical exists in work_ledger_writes.py, is called only from _create_item, and calls the live admission_check(). #36657 closed without merging. The audit commit 16e11a1 is on main. The section 5 test 6 cases exist in test/test_work_ledger_host_pressure.py. Merge order is this PR first, then #37164. Done well: the withdrawn design text stays in the RFC as the record, and the header names exactly which sections are withdrawn and which piece stays in force.

For the security review: nothing to note. The change keeps the critical refusal and widens no security, sandbox or approval gate.

Optional:

@iamwhatever

Copy link
Copy Markdown
Contributor Author

Simplify the design on resource detection while dispatching worker

@iamwhatever
iamwhatever merged commit ecbe3c4 into main Nov 15, 2026
97 checks passed
@iamwhatever
iamwhatever deleted the docs/withdraw-host-pressure-rfc branch November 15, 2026 12:39
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 15, 2026
iamwhatever pushed a commit that referenced this pull request Nov 15, 2026
…t pressure

The repository owner narrowed rfc-work-ledger-resource-pressure on 2026-11-14:
the conductor checks resource_status before it dispatches, and only one piece
of code stays. This removes the rest of #36481:

- src/kiro_crew/host_pressure.py (the host record) and its RESERVED_ROOT_DIRS slot
- ResourcePressureNotifier's episode id, pressure_sink, level-change wake and
  pending flush (back to its pre-#36481 behaviour)
- the pressure wake in conductor_wake and WorkLedgerProbe
- conductor.host_pressure in work_ledger_read
- the host_pressure conductor rule in spec_prompts, crewmate_prompts.json and
  goal-conductor SKILL.md, its parity anchor, and its work-ledger.md section
- test/test_work_ledger_host_pressure.py; the golden and spec-byte pins go
  back to their pre-#36481 values

Kept: _refuse_if_host_critical in _create_item (409 via the live
admission_check). Its code is renamed host_pressure_critical ->
host_memory_critical, since nothing named host_pressure is left. Its tests
move to test/test_work_ledger_host_memory_refusal.py.

The withdrawal itself is recorded in the RFC by #37170, which lands first.
KiroCrewCaptain pushed a commit that referenced this pull request Nov 15, 2026
…t pressure (#37164)

The repository owner narrowed rfc-work-ledger-resource-pressure on 2026-11-14:
the conductor checks resource_status before it dispatches, and only one piece
of code stays. This removes the rest of #36481:

- src/kiro_crew/host_pressure.py (the host record) and its RESERVED_ROOT_DIRS slot
- ResourcePressureNotifier's episode id, pressure_sink, level-change wake and
  pending flush (back to its pre-#36481 behaviour)
- the pressure wake in conductor_wake and WorkLedgerProbe
- conductor.host_pressure in work_ledger_read
- the host_pressure conductor rule in spec_prompts, crewmate_prompts.json and
  goal-conductor SKILL.md, its parity anchor, and its work-ledger.md section
- test/test_work_ledger_host_pressure.py; the golden and spec-byte pins go
  back to their pre-#36481 values

Kept: _refuse_if_host_critical in _create_item (409 via the live
admission_check). Its code is renamed host_pressure_critical ->
host_memory_critical, since nothing named host_pressure is left. Its tests
move to test/test_work_ledger_host_memory_refusal.py.

The withdrawal itself is recorded in the RFC by #37170, which lands first.

Co-authored-by: Joe Guo <zejiangg@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants