Repository navigation
refactor(dashboard): name the decision model by its role in the UI - #37185
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks. This changes copy only. The one renamed id ( [DESIGN-REVIEWED] 48beff7 Description read[DESCRIPTION-READ] 2af6b0b4629f5dd2d9075dcab18d2383ec6227cdc336b6881b1d8d5e0664825f That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS This is a copy change that follows the Goal. Only one user-visible refusal still names the provider. Notes
What this change shipsInventory (10 items) — 9 justifiedIntent: people who use a decision provider other than Jev stop seeing a hosted product's name across the decision features. ADDITION (a relabel).
[FIRST-PRINCIPLES-REVIEWED] 48beff7 Description read[DESCRIPTION-READ] b36a0742407c86eea3009080a0e321fea6e44325d7ae3640968f568942a4e2d1 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)UX-level review of UX-Verdict: PASS cannot evaluate: missing screenshots of the model picker's "Auto (decision model)" label and of the memory-recall, tool-risk and model-route strips, whose copy this PR rewrites. Evidence gaps
Notes
[UX-REVIEWED] 48beff7 Description read[DESCRIPTION-READ] 7b6284c7abf57b689b1c819a802a3498061ab313430ce951d062418d84325e97 That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Review detailsNo findings. Both candidates were falsified against the code. [OPUS-REVIEWED] 48beff7 Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
ab04b50 to
ce387d8
Compare
Code change approver recommendation: A person should decideWhy: the decider estimates a 12% chance that this change introduces a defect, within the 12% limit for approving on its own, but it changes 2342 lines, more than the 400 it may approve on its own. Copy-only rename of Jev to "the decision model" across the UI, catalogs and docs. The one behavioural surface, session_set_model's owner-only refusal, now refuses the new label "Auto (decision model)" as well as the old spellings, and the parametrized test covers it. The settings id rename developer.decisions-jev → developer.decisions has a LEGACY_ID_EXACT redirect. The backend highlight targets and DECISIONS_SETTING_ID are updated, and nothing else uses the old id. Settings rows whose ids still contain "jev" are hand-written entries with fixed ids. The renamed doc headings have no inbound anchors, and the tests asserting doc wording were updated. A new catalog test enforces neutral wording. Linux backend and frontend CI are green; the Windows failure is unrelated. Remaining gaps (one Jev refusal in slot_model.py, doc index drift) don't block. An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
ce387d8 to
b2bcaa0
Compare
b2bcaa0 to
26b0a67
Compare
26b0a67 to
22ea773
Compare
22ea773 to
b383d6e
Compare
The decision feature read as one product: the model picker said Auto (Jev), the transcript said Jev chose, the settings card said Decisions (Jev). Jev is one provider among several, so name the role instead. Sixty-one catalog strings, in English and the eleven other languages, now say the decision model. Seven strings stay: the ones about the Jev provider's own entry (its option, API key, accuracy note and judge option). A catalog test pins that list, so a new string cannot leak the provider name back into neutral wording. The owner-only refusal of session_set_model now also catches the new label, so an agent cannot store it as a pending model. The capture scripts use the new labels. The settings card's registry id moves from developer.decisions-jev to developer.decisions with its label, and the old id is added to the legacy highlight table so saved links and command-bar history still land on the switch. The generated registry, UI index and pseudolocale are regenerated.
Follow the UI rename into the places a reader meets the same words: the shipped decisions guide, the feature map and specs, two owner-only refusal messages, and the help text of two decision settings. The Jev provider keeps its own name where the text is about that provider. config-baseline.json is regenerated for the changed help text.
b383d6e to
48beff7
Compare
Problem / Motivation
Goal: The chat UI, settings card and docs name the decision feature by its role ("the decision model"), with Jev appearing only as one provider among several.
Today the model picker says "Auto (Jev)", the transcript says "Jev chose: run after this turn" and "Jev picked the wrong skills", and the settings card is titled "Decisions (Jev)". A person who runs a local model or a SageMaker endpoint still reads a hosted product's name on every surface. The governance PR (#36271) made Jev one provider entry in the picker; this PR makes the rest of the wording agree.
Why it matters
Every user of the decision features reads this wording, including people who never turn Jev on and administrators who disable it. The product name on neutral surfaces says the feature needs one vendor, which is no longer true.
Not a goal
jevprovider id (auto_jev,jev_label,provider: "jev"). Only user-visible text changes.docs/request-for-change/andCHANGELOG.md.What changed (motivation → approach → change)
Approach: say "the decision model" wherever the text is about the feature, and keep "Jev" only where it is about the provider.
Auto (decision model),The decision model chose: run after this turn, card titleDecisions). Seven strings keep the name, all of them the Jev provider's own entry. The same 61 keys are translated in the eleven other languages, each using the term that language already uses for "decision model".en.context.jsonno longer say the name is a Latin-script product name.developer.decisions-jevbecomesdeveloper.decisions, and the old id is added toLEGACY_ID_EXACTso saved?highlight=links and command-bar history still land on the switch. The generated registry, the UI index and the pseudolocale are regenerated.decisionModelNeutralWording.test.ts) fails when any language names Jev outside the seven provider-entry keys, and when the allow list names a key that no longer says Jev.config-baseline.jsonis regenerated for that help text.Backwards compatibility
Compatible: no catalog key, config value or wire id changes; only displayed text and the settings registry id of one card.
Reader:
website/src/components/commandPalette/settingsSearchCore.ts:DECISIONS_SETTING_ID-- crew page (settings search) -- updated todeveloper.decisionsin this PR;settingsSearchGovernance.test.tsandsettingsCoverage.test.tspin it against the generated registry.Reader:
website/src/hooks/useSettingHighlight.ts:LEGACY_ID_EXACT-- crew page (?highlight=links) and command bar (frecency) -- maps the old id to the new one;settingHighlightAliases.test.tspins the mapping and that no legacy key is a live id.Reader:
website/src/components/commandPalette/settingsRegistry.gen.tsandsrc/kiro_crew/docs/settings-registry.generated.json-- crew page, agent-facing settings docs -- regenerated withnpm run gen:settings; the freshness gate compares them with the live extraction.Reader:
src/kiro_crew/docs/ui-index.generated.json-- agent-facing UI index -- regenerated withnpm run gen:ui.Tests
website/src/i18n/decisionModelNeutralWording.test.ts(new): one case per language plus the stale allow-list case. With one string put back to "Jev latency", the English case fails.settingHighlightAliases.test.ts: the old Decisions id resolves todeveloper.decisions.npm run i18n:checkpasses withI18N_BASE_REF=origin/main(19 checks, 0 changed-value findings). Python:test_config_baseline.py, the model-route and session-control suites (182 tests) pass.Proof: not provable -- copy-only change
Manual verification
Built the SPA and ran the capture scripts for the decision strip, the send-mode picker and the settings card (images below). Not run: a real gateway with a hosted Jev key.
Screenshots / video
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement