Skip to content

test(tracing): expect the kirocrew.step span in the OTLP wire tests (#1643) - #37188

Closed
kyleseaman wants to merge 1 commit into
mainfrom
crew/devmate/fix-otlp-wire-tests
Closed

kyleseaman wants to merge 1 commit into
mainfrom
crew/devmate/fix-otlp-wire-tests

Conversation

@kyleseaman

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Turn main's Backend Tests green again by updating two OTLP wire tests to the span tree a traced turn now exports.

Main is red. CI run 43580582401 on 16e11a1870 fails Backend Tests shard 2 on Linux and Windows:

  • test/tracing/test_tracing_otlp.py::test_a_traced_turn_reaches_a_loopback_receiver_with_its_vault_header: the exported span-name set has an extra kirocrew.step.
  • test/tracing/test_tracing_otlp.py::test_the_exit_flush_sends_spans_still_queued: assert 5 == 4.

Why it matters

Every PR's Backend Tests shard 2 inherits this red until main is fixed, so unrelated PRs cannot reach a clean readiness verdict.

Not a goal

  • Any change to tracing code or to the span tree itself.
  • Any other test or CI lane.

What changed (motivation → approach → change)

Two merges crossed. #37005 (tracing phase 4a) added a derived kirocrew.step span to every traced turn, so one turn now exports five spans. #36721 installed the otlp extra in CI, which is what makes these requires_otlp wire tests run at all. #37005's CI ran on a base from before #36721, so it never ran them; main has both.

The new span is intended (the documented tree in docs/system-specs/modules/metrics.md and test_tracing_turns.py already expect it), so the tests were stale, not the product. Both tests now compare against one named set, _TURN_SPANS, that lists kirocrew.step explicitly. The exit-flush test asserts the exact set instead of a count of 4, so it still fails if a span is lost or added.

Backwards compatibility

Compatible: test-only change; no product code moves.

Removes nothing: the asserts compare exact sets, as before.

Tests

Updated test/tracing/test_tracing_otlp.py (the two tests above).

Proof: not provable -- test-only change

Run locally in a Python 3.13 venv with the otlp extra installed (as CI installs it):

Manual verification

N/A — the change is two test assertions; the local runs above cover them.

Related Issues

Part of #1643

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@kyleseaman
kyleseaman requested review from a team and KiroCrewCaptain as code owners November 14, 2026 10:46
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 4a9cca00c8af0d353263ccc40f80e4fc725d17b2 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 4a9cca00c8af0d353263ccc40f80e4fc725d17b2 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 4a9cca00c8af0d353263ccc40f80e4fc725d17b2 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

This only updates stale tests to match the span tree the specs already define, and the exact-set assertion is stricter than the old count.

[DESIGN-REVIEWED] 4a9cca0

Description read

[DESCRIPTION-READ] 9b5056ec3d15d34cf57a0a3782291e1cc08bbf55d0a46d20cdbadaad1a11dfc8

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 4a9cca00c8af0d353263ccc40f80e4fc725d17b2 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 4a9cca0

Verdict parsed from the review's SHA-scoped output markers for commit 4a9cca00c8af0d353263ccc40f80e4fc725d17b2.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 4a9cca00c8af0d353263ccc40f80e4fc725d17b2 false-positive: <reason, 20 to 500 characters>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 4a9cca00c8af0d353263ccc40f80e4fc725d17b2 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 4a9cca0

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 4a9cca00c8af0d353263ccc40f80e4fc725d17b2 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 14, 2026
@kyleseaman

Copy link
Copy Markdown
Contributor Author

Closing: main's red was already fixed by #37171, which landed first with the same change.

@kyleseaman kyleseaman closed this Nov 14, 2026
@kyleseaman
kyleseaman deleted the crew/devmate/fix-otlp-wire-tests branch November 14, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant