Repository navigation
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the field is additive, defaults to empty, a revert walks it back cleanly, and screenshots of this revision are attached. [DESIGN-REVIEWED] 3ab9354 Description read[DESCRIPTION-READ] c474780093ee2ccef356f59738c2e024c0ac2f7f10455764e91559cd6a08573b That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Starters are empty by default, so nobody's chat changes unless the owner sets them. Each new piece has its own job. Only a duplicated drop-filter is worth trimming. Notes
What this change shipsInventory (8 items) — 7 justifiedIntent: a Bot's owner pins a few prompts so a newcomer can start the Bot's empty chat with one press. This is an ADDITION.
[FIRST-PRINCIPLES-REVIEWED] 3ab9354 Description read[DESCRIPTION-READ] 32acc3897378655cbdeb0cf01f1e7a45aa8adaa683eb5fc0c215fbdbb2d54444 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS No primary control was misread. The blind reader correctly identified the starter buttons, the starters box and Save, and every new state has a screenshot. Notes
[UX-REVIEWED] 3ab9354 Description read[DESCRIPTION-READ] 8e3b6e0fb02a5b2383ba953c1c789d04f4f5030fb832150be9e36e44811bed73 That sha256 names everything this verdict read: the PR description, plus the 15 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Code change approver recommendation: A person should decideWhy: the decider thinks the change is probably fine but estimates a 14% chance that this change introduces a defect, above the 12% limit for approving on its own. Adds an owner-only Tier: 2, held for a person: design-doc-gate: D. An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
c15bf4a to
a8a89ae
Compare
|
UX: no screenshot of the owner's editor. Added in a8a89ae. The description now shows the real Profile settings box in light and dark, once after an edit with Save enabled and once after a save that left a fifth line out, with the "left out" note. This also covers the Design note asking for an image of the box. A press already sends at once, and the box's hint says so ("a press sends that prompt"). The note about naming dropped lines in normal text is not changed in this PR. The note stays the catalog string so it is translated, and the gateway's warnings are English text only. Code change approver: |
a8a89ae to
74cb03c
Compare
|
UX: after a partial save, the box shows text that was not saved (span 52dd2a4a9d68). Fixed in 74cb03c. The save's answer now carries the kept Opus: the feature-map row fills two of six cells (docs/feature-map/README.md:208). Fixed in 74cb03c. The row now has six cells. Reach: GPT: saved starters stop an enterprise or LTS start (src/kiro_crew/config/loader_pipeline.py:1031). Fixed in 74cb03c. CI: Backend Tests (3.12, 2), |
Sensitive change review
|
74cb03c to
eb06a92
Compare
|
UX: the partial-save note opens with "Not saved." and lists every rule (span 2756ef9602f9). Fixed in eb06a92. Each value Opus: |
Sensitive change review
|
de3e9ee to
9054744
Compare
|
Rebased onto current main ( Settings Back silently discarding unsaved starters is fixed in |
Sensitive change review
|
9054744 to
2d650e4
Compare
|
The starters box no longer replaces an unsaved draft when the roster refreshes ( |
Sensitive change review
|
2d650e4 to
caa63a9
Compare
|
Stale roster props undo a partial save ( The "changed elsewhere" note had no screenshot. Light and dark captures of the real box with a draft open after another window saved a different list are added to the description ( |
Sensitive change review
|
Sensitive change review
|
Sensitive change review
|
Sensitive change review
|
A new Bot's chat opens on nothing, and a person has no hint of what it is for. The owner can now pin up to four one-line prompts to a Bot, and its empty chat shows them as buttons. Pressing one sends that prompt as the first message through the same send path as typed text. The list is stored as agents.<name>.starters and set from the Bot's Profile settings through the existing agent update route. Each starter is bounded to 120 characters and four per Bot. A value that is blank, too long, repeated, past the fourth, not text, holds a control or format character, or looks like a credential is left out, named in the answer's warnings and given a reason the editor shows beside the line, and the rest are kept; a hand-edited config drops the same values with a log warning and never fails to load. A credential-shaped value is not quoted in any warning. The roster row carries the list and leaves out anything the roster would mask, and the config view leaves out any starter its agent free-text mask would change. A Bot cannot edit its own starters and the share file does not carry them. Strings are added to every catalog.
Sensitive change review
|
Problem / Motivation
Goal: a Bot's owner can pin up to four short prompts to the Bot, and its empty chat offers them as buttons, so a new person sees what the Bot is for and starts with one press.
A Bot's chat opens on nothing until the Bot has said something.
git grep -i -E "conversation.?starter|suggested.?prompts"overwebsite/srcfinds only unrelated hits.Why it matters
The empty chat is the first thing a person sees after choosing a Bot. A prompt the owner wrote costs one press.
Not a goal
.kirobotfile (received text would need its own review card row), or editable by the Bot itself.What changed
The Bot record has no field for prompts, so the chat has nothing to show.
src/kiro_crew/member_starters.py(new):clean_startersreturns the starters that pass, a warning for each value left out, and its place and reason code (too_long,repeated,over_limit,credential,not_text,empty). Each is cleaned as a display name is (members._strip_controls). A value is left out when it is not text, empty, over 120 characters, credential-shaped (external_text_requires_redaction), a repeat, or past the fourth.config/sections_session.py,config/loader_pipeline.py: the Bot record gainsstarters, default empty. The loader cleans a hand-edited value, so a bad value never fails a load.config-baseline.jsonis regenerated.dashboard/agent_admin/crew_update.py: the update route acceptsstarters. It saves what passes and answers with the keptstarters,starters_left_out(place and reason) andwarnings. A non-list keeps the saved value and warns; never a 400.dashboard/handlers/members_roster.py,core_config_view.py: the roster row carriesstarters, andGET /api/config/kirocrewmasksagents.*.startersitem by item. A starter the mask would change is left out, not shown as a sentinel. A ratchet holds everylist[str]Bot field to the mask.website/:CrewmateStarters.tsxshows the buttons while a loaded Bot chat holds no row and no turn runs, one per row (max-two-buttons-per-row); a press callsdoSend.CrewStartersGroup.tsxis a box in Profile settings, one starter per line. After a save it shows the starters kept, and a note under Save lists each line left out with its reason. A failed save shows anErrorNoticewith aNo hand-offcomment naming the unsaved draft (errors-use-error-notice). The box reports its unsaved draft and a save in flight to the Profile page's leave guards, the ones Goals and Export use: Back, Escape, close and a route leave ask before they drop a draft, and wait while a save runs. The box judges its draft against the list the gateway last confirmed (the first load, a roster read with a new list, or its own save answer), so stale roster props after a save never undo it; a changed list from elsewhere keeps the draft and says so.security_posture.py:member_starters.pyjoinsNON_EGRESS_REDACTION_MODULES; it returns no redacted text.pluralKeys.json,docs/crew-members.mdand thedocs/feature-map/README.mdrow.Rounds: r1 to r10 layout, save answer, reason codes, mask, rebases, failed-save state, Back guard; r11 a draft survives a refresh; r12 a save survives stale roster props.
Backwards compatibility
A Bot with no
starterskey reads as an empty list, so starters are off by default and its empty chat is drawn as before. A save that does not namestartersanswers exactly as on main (a test passes on main). A full config save writes"starters": []per Bot, like every other Bot field.Tests
test_member_starters.pyand two inChatPane.crewmate.test.tsxfail. Each later fix has a test that failed on the previous source; r11's three refresh cases and r12's stale-props case inCrewStartersGroup.test.tsxfail on the old head.test_member_starters.py,test_config_agent_fields_redaction.py, the two roster contract tests,test_config_baseline.py,test_facade_mirror_guards.pyandtest_security_posture.py, and the seven Static Ratchet Gate files give 429 passed. Inwebsite/, the members pages andChatPane.crewmate.test.tsxgive 1,264 passed; the i18n suites give 1,261 passed andnpm run i18n:checkexits 0. eslint,tsc, black, flake8, isort, mypy, the ratchet gates and the lane CI checks pass.python -m pytest test/test_member_starters.py -n0; inwebsite/:npx vitest run src/test/ChatPane.crewmate.test.tsx src/pages/members/CrewStartersGroup.test.tsx src/pages/members/MembersPage.schedules.test.tsxManual verification
Real components on loopback. The failed-save pair keeps the draft under "Could not save the starters. Try again."; the last pair shows the note when the saved list changed elsewhere.
Sibling sweep
Sibling:
members_parts/self_edit.py-- not affected --startersis not inSELF_EDITABLE_FIELDSSibling:
crewmate_bundle.py,crewmate_bundle_export.py-- not affected -- no starters in the share fileSibling:
website/src/pages/chat/page/ChatEmptyState.tsx-- not affected -- the main chat's empty state is not a Bot'sPattern harvest
Rule candidate: review-prompt
Pattern: owner-written text that a button later sends is bounded and cleaned where it enters, dropped with a warning rather than refused, and named in a warning by its place, never quoted.
Related Issues
None.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement