Repository navigation
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this adds one button under the recap, reuses the existing reopen and guarded-open paths, and removes nothing. Notes
[DESIGN-REVIEWED] 0c0092b Description read[DESCRIPTION-READ] 2c7d95b40b4f30d9cc81ddb901d68b52133238216f784925f3c3310c401e0fa1 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. The maintainer decision on the base commit (2026-11-12, issue #36175) asks for this button, and the reopen reuses Notes
What this change shipsInventory (6 items) — 5 justifiedIntent: let a Bot owner go from a session's recap on the Bot's Sessions tab into that session, reopening it first if it is closed. This is an ADDITION.
[FIRST-PRINCIPLES-REVIEWED] 0c0092b Description read[DESCRIPTION-READ] d9a44f7c1b38c291d568aef20fdd0898a2adef6cf154916590cc99983655fc26 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. The blind reader read Open session and Reopen session correctly and would press both, and the screenshots cover every new state except the short Reopening… label. Notes
[UX-REVIEWED] 0c0092b Description read[DESCRIPTION-READ] 41b05115433b3bfd5123efd16b187d70efa3088a6bf29edeaf4a595e20218d97 That sha256 names everything this verdict read: the PR description, plus the 11 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findings (all downgraded on adjudication)GPT 6.1 flagged blocking issues on This comment is updated in place on each push. Review detailsBLOCKING -- website/src/pages/members/MateSessionsList.tsx:248 -- Polling can cancel navigation after a successful reopen
Adjudication (Opus 5.5) — is blocking on each finding proportionate?F1 — LOW. I confirmed every condition the failure needs:
Recovery is visible and takes one click. False positive or not applicable? A repository writer can comment: |
Code change approver recommendation: A person should decideWhy: the decider thinks the change is probably fine but estimates a 20% chance that this change introduces a defect, above the 12% limit for approving on its own. Adds the Open/Reopen session button under the recap on a Bot's Sessions tab, which the 2026-11-12 maintainer decision asks for. It asks the page's unsaved-edits question first, then opens the session through the existing navigation, or reopens a closed one first with reopenCrewSession, the same call the chat page's Workers list makes; it moves the person only when the reopen took the view. A session on another crew gets a line and no button. Every new path has a test, the strings are in all 12 languages and the docs match the code; CI is green. The one real gap is a regroup race that can skip the navigation after a successful reopen: one extra click, no data loss. It and the small guard duplication are left as notes. Tier: 2, held for a person: design-doc-gate: D. An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
1c6e0b4 to
037142c
Compare
|
The design is signed off. A maintainer recorded it on main in docs/decisions/2026-11-12-a-bots-sessions-tab-opens-a-session-and-shows-the-task-it-was-last-given.md (#36187), so this PR now waits for a maintainer approval. Review result on this head: nothing blocks. The diff matches that decision point by point. A row click still expands the recap. The recap has one button, which says "Reopen session" for a closed session. The unsaved-edits question comes before any reopen. A failed reopen shows an inline ErrorNotice, and a remote-crew row shows a line and no button. The button is a labelled type=button and uses aria-disabled while busy. All 8 new strings are in all 13 locale files. The tests resolve their own promises and use no sleeps or clocks. The PR reuses reopenCrewSession and its Optional:
|
|
Hello maintainers: this PR is ready for review. At 037142c readiness passes and auto-merge is armed.
Thank you for taking a look. |
|
Hi @RohanK6, thanks for this work. Heads-up: #37915 takes a different approach to #36175, and the two PRs conflict. New approach (owner decision, restated in #37915 (comment)):
This replaces the recap "Open session" button from #37298, and the new decision entry supersedes the 2026-11-12 entry this PR is built on. So once #37915 lands, #37298 would no longer apply. Could you hold this PR (keep auto-merge off) until #37915 settles? Happy to hear if you see a case the side-panel flow misses. |
A Bot's Sessions tab is the only list of the sessions it dispatched, and nothing on it opened one. The opened recap now carries one button. Open session asks the page's unsaved-edits question, then opens the session in the chat view. A closed session reads Reopen session and is reopened from its saved conversation first, the way the Workers list does; a failed reopen keeps the person on the page and says so. A session on another crew gets a line instead of a button. Fixes #36175
037142c to
0c0092b
Compare
|
Closing as superseded by #37915 (merged 2026-11-17 23:59Z by a maintainer), which closed #36175. It replaces the in-place recap this PR added a button to: a row now opens the session in the side panel's Sessions tab, with Reopen session for a closed one and no open for a remote one. Rebasing this PR would put a second, conflicting way in onto that design. Thank you for the reviews. |
Pull request was closed
Problem / Motivation
Goal: Let a person open any session on a Bot’s Sessions tab in the chat view, straight from its recap, reopening a closed one first.
A Bot’s Sessions tab lists the sessions it dispatched, and a click expands a row into a recap. Nothing on the row or in the recap opens the session. A Bot’s sessions leave the person’s own session lists for this tab, so it is the only list of them, and the only way to read what a worker did, or to type to it, was History or search. The maintainer recorded the change in
docs/decisions/2026-11-12-a-bots-sessions-tab-opens-a-session-and-shows-the-task-it-was-last-given.md(#36187).Why it matters
Every Bot owner who wants to check on or steer a worker hits this. The tab shows which session matters, then gives no way in.
Not a goal
What changed (motivation → approach → change)
MateSessionsList.tsx): the opened recap gets one button under it. It asks the page’s unsaved-edits question first, then opens/chat?sid=<key>, the same navigation a session link in the Bot’s chat uses (openSessionGuarded).reopenCrewSession, the call the chat page’s Workers list makes, and opens the session only when that reopen took the view. A failed reopen keeps the person on the page and says so under the button.keepPanelis false, so the session lands as a live one does, with no Workers panel held open beside it.remote_crewnames no local session, so it shows one line naming that crew and no button.aria-disabled), ignores a second press and its name says “Reopening <title>…”.MembersPageSidePanel.tsxexposes the Schedules guard on its own (confirmSessionLeave) and the raw chat-page open (openSessionOnChatPage), so the question can come before the reopen;MembersPageProfile.tsxpasses both to the list.crew-mode.mdand the feature map describe the button.Backwards compatibility
Compatible: the tab gains a button; the row click, the recap and every other way off the page behave as before.
Removes nothing: the change only adds a control under the recap.
Tests
MateSessionsList.test.tsx: a live session opens after the question; a refused question opens nothing; a closed session’s recap says it is closed, then it is reopened with its key and title, the button holds and names the reopen, then the reopened key opens; a failed reopen shows the line and stays; a reopen that did not take the view moves nobody; a reopen that lands after the tab closed moves nobody; StrictMode still opens; a remote session has a line and no button; the row click alone never asks or opens.MembersPageProfile.drivingTitle.test.tsx: the Profile card wires the list to the side panel’s guard and chat-page open.MateSessionsList.tsxreverted to main (7 failed, 25 passed before the review fixes added two more).Manual verification
Rendered the real
MateSessionsListin headless Chromium from a static harness build (en and de), with three sessions: a live one, a closed one whose reopen fails, and one on another crew.Screenshots / video
Before (main): the opened recap has no way into the session.
After: a live session’s recap with Open session.
After: a closed session, with the closed line, after a failed reopen.
After: a session on another crew.
Related Issues
Fixes #36175
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project’s Apache-2.0 license.