Repository navigation
test: tighten stale comments in the slack tests - #37320
Conversation
Rewrite review-round, SHA and fix-history narration in the slack tests as present-tense rules with their reasons. Comments only; no test behaviour changes.
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS The change only rewrites comments in Slack tests. It changes no behaviour, takes nothing away and renders nothing new, so there is no design to judge. [DESIGN-REVIEWED] ed8bc44 Description read[DESCRIPTION-READ] d9cc59c6b84cfbdc08fe119b027147714d092ca661194350f7b74f9ecb973883 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Code change approver recommendation: ApproveWhy: the decider estimates a 3% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes. I read all ten hunks in the diff. Every change rewrites a comment and none touches code, assertions, fixtures or flake-ok markers, so test behaviour can't change. That matches the description's "comments only" claim and its non-goals. I checked the comments whose accuracy relies on code. The new note in An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: test (10 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: comment-only edits inside ten Slack test files; no test logic, assertion or fixture changes.
Problem / Motivation
Goal: Make the comments in the
test/test_slack*.pytests true and useful to someone changing the Slack code, keeping every reason and gotcha, with no change to test behavior.Several comments in the Slack tests point at review rounds and commits a reader cannot open ("GPT 6.1 review on fb9677d", "BLOCKING (GPT #593)", "round on ed6d3b0", "Review regressions") or describe the fix instead of the rule ("Before the fix only the assistant row was pushed", "exactly as the pre-fix bug").
Why it matters
A reader needs to know what the test holds and why. Review IDs and fix history say neither, and age badly once the fix is old.
Not a goal
test/test_slack*.py.What changed (motivation → approach → change)
Review-round and fix-history narration is rewritten as the present-tense rule; section headers name what the tests cover.
0 or CAP-> CAP pre-fix (accidentally correct), but the explicit check keeps it robust."0 or CAPalso gives CAP here by accident; the explicit check is what holds it."Ten files: 22 insertions, 22 deletions.
goal_scan.py astcheckagainst the merge-base:files checked: 10 code-changed: 0 docstring-only: 0.Backwards compatibility
Compatible: test-only change, comments only.
Removes nothing: no code, key, path, record or function is removed or renamed.
Tests
Proof: not provable -- comment-only change; the AST check shows no code difference
The ten touched files plus
test/test_flake_pattern_ratchet.pypass on this branch (pytest -n 2 -p no:randomly: 629 passed).flake8,check_black_formatting.py,check_comment_history.pyandcheck_brand_name.pypass; no added line is over 100 columns.Manual verification
N/A — comment-only change.
Related Issues
N/A — part of the test comment quality pass.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the project's Apache-2.0 license.