Repository navigation
test: tighten stale comments in session tests other prs touch - #37334
Conversation
Rewrite review-round section headers and Regression: openers in the session markdown, autocompact override and usage tests as present-tense rules. These files were skipped in the session pass because other open PRs touch them. Comments only; no test behaviour changes.
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Comment-only test change: no code, behavior or reader is affected, so nothing blocks. [DESIGN-REVIEWED] 4f6fddc Description read[DESCRIPTION-READ] 37e5236b356f09562eeb221011df46f3b2024655a5484943c9bf08f05037451d That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Approving. On head 4f6fddc the change is comments only in three test files. Each file parses to the same AST at the merge-base and at the head. A diff that ignores whitespace and comments leaves only two removed blank lines. PR Readiness passed on this head. The new section headers match the tests under them. The rewritten comments are accurate, for example the OverflowError handling in _validate_autocompact_pct. The hunks do not collide with the open PRs that touch the same files.
Done well: past-tense "Regression: X was uncaught" stories now state the rule each test holds, and review-round labels became names for what the tests check.
Optional:
test/test_session_markdown.py:1137still has the review-round header "current-head scanner-state regressions", and:1434says "The other direction of F1". Rewording them to state the rule would finish this file. A follow-up in the same series is fine.
Problem / Motivation
Goal: Make the comments in the session test files that other open PRs touch short, true and useful, the same pass the rest of the session tests got, with no change to test behavior.
Three session test files carry review-round section headers ("GPT 6.1 current-head findings 1-5", "fork-lane review, second round") and
Regression:openers that describe the old bug in past tense instead of the rule the test holds.Why it matters
A reader needs to know what each group of tests covers and what must hold. Review-round names and past-tense bug stories say neither.
Not a goal
test_gpt_N_*names stay).What changed (motivation → approach → change)
Three files (
test_session_markdown.py,test_session_autocompact_override.py,test_session_usage.py): 19 insertions, 23 deletions.goal_scan.py astcheckagainst the merge-base:files checked: 3 code-changed: 0 docstring-only: 0. Open PRs #36873, #36630 and #34722 touch these files; the change is comment-only, so either side rebases cleanly.Backwards compatibility
Compatible: test-only change, comments only.
Removes nothing: no code, key, path, record or function is removed or renamed.
Tests
Proof: not provable -- comment-only change; the AST check shows no code difference
The three touched files plus
test/test_flake_pattern_ratchet.pypass on this branch (pytest -n 2 -p no:randomly: 386 passed).flake8,check_comment_history.pyandcheck_brand_name.pypass; no added line is over 100 columns.Manual verification
N/A — comment-only change.
Related Issues
N/A — part of the test comment quality pass.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the project's Apache-2.0 license.