Skip to content

fix: 0.13 backport, name Node.js under an npm install command (MiMo Code, #36761) - #37357

Merged
buluoray merged 1 commit into
release/0.13.0from
crew/slack/backport-0.13.0-mimo
Nov 14, 2026
Merged

buluoray merged 1 commit into
release/0.13.0from
crew/slack/backport-0.13.0-mimo

Conversation

@buluoray

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Ship the MiMo Code harness fixes that merged on main after the 0.13 cut in 0.13.

release/0.13.0 already carries the MiMo Code harness itself (#24732, #36290). Since the cut (a29fcc3c2e6b), one user-facing fix on main touches it: #36761. MiMo Code installs through npm, and the Agent Harness card showed the npm install command without saying it needs Node.js and npm.

One commit, made with git cherry-pick -x onto release/0.13.0 head 1fe3510b2fa2. It applied with no conflict.

Pick Main commit What 0.13 users get
#36761 5317defe6456 The Agent Harness card adds one line under an agent's npm ... install command that names Node.js and links its download page, so a MiMo Code (or other npm-installed harness) user knows what to install first. curl installers get no line.

Why it matters

A user without Node.js who copies the shown command gets npm: command not found and no hint why.

Not a goal

What changed (motivation → approach → change)

Cherry-pick only. No hunk was hand-resolved.

Backwards compatibility

Compatible. One added line of help text on the Agent Harness card; no key, path or record removed.

Tests

Test changes come from the pick (website/src/test/AgentBackendTab.test.tsx).

On this head: tsc -p tsconfig.app.json clean, AgentBackendTab.test.tsx passes, scripts/check-i18n-keys.mjs OK. The pick touches no Python.

It also applies cleanly next to the open batch 1 part 2 (#37355): part 2, then this pick, then batch 1 part 3 all cherry-pick with no conflict.

Manual verification

N/A. Unit coverage above; the same change is on main.

Screenshots / video

Why no screenshot: a cherry-pick of #36761, which passed Design and UX review on main with its own evidence.

Related Issues

Backport of #36761.

Sibling sweep

Siblings: none -- the backport touches the same sites #36761 changed on main

Pattern harvest

Not generalizable: backport of an already-reviewed fix (#36761)

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license.

The Agent Harness detail for an absent harness showed its install
command bare. For OpenCode that is `npm i -g opencode-ai@1`, and on a
host without Node.js it fails with "npm: command not found" while the
card never says that npm comes with Node.js. Several other harnesses
send an `npm i -g` command too.

AgentInstallDetail now adds one muted line under an install command
that starts with `npm `: the command needs Node.js and npm on the
gateway host, with a link to the Node.js download page. A curl
installer or an empty command gets no line. The component backs both
Settings > Agent Harness and the first-run agent picker, so both get
the line. The new key is translated in every shipped catalog.

Closes #36377

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 5317def)
@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 14, 2026 21:25
@buluoray
buluoray requested review from iamwhatever and removed request for a team November 14, 2026 21:25
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of bb63375e2bc439629fe60ebd1512ce9753a81564 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing a screenshot of the Node.js hint line under an npm install command on the Agent Harness card. This PR attaches no image, so the blind read was not performed.

Evidence gaps

  • New hint line in AgentInstallDetail: the line "This command needs Node.js and npm on the gateway host. Download Node.js" appears below the copy-command box only when install_command starts with npm . The blind-read report says "BLIND READ NOT PERFORMED: the PR description carries no image attachment", and the screenshot list is empty. Saying fix: name node.js and npm under an agent's npm install command #36761 had its own evidence on main doesn't close this, because no artifact from fix: name node.js and npm under an agent's npm install command #36761 is admitted for this revision. To close it, attach a screenshot to this PR's description of the card for an npm-installed harness such as MiMo Code, showing the new line and the "Download Node.js" link.

Notes

  • The link carries the label's whole meaning, but it's styled text-accent inside text-muted 12px text. Check in the screenshot that "Download Node.js" stands out from the muted sentence in both light and dark themes.

[UX-REVIEWED] bb63375

Description read

[DESCRIPTION-READ] 0e4fbd14e384a9aff271accd3ab177fa7c426fe9dc55c285ba9ba11bd8770acb

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of bb63375e2bc439629fe60ebd1512ce9753a81564 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: it is a clean cherry-pick that adds one help line under the existing install command, and it is not a new page, panel, control set or default mode.

Notes

  • The workflow found no rendered evidence for this revision (no attachments, no committed images). A screenshot from the release branch would still confirm the line renders the same way there as it does on main.

[DESIGN-REVIEWED] bb63375

Description read

[DESCRIPTION-READ] 43fc54d97abd20d1922f11c81d815dc5668e6431ba6cbd2ac012901619ee8f39

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of bb63375e2bc439629fe60ebd1512ce9753a81564 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks: a one-line help hint, backported unchanged from #36761, for a defect the test cites as #36377.

What this change ships

Inventory (3 items) — 3 justified

Intent: a 0.13 user installing an npm-based harness (MiMo Code and others) learns that the command needs Node.js before it fails with "npm: command not found". FIX (backport).

  1. The Agent Harness card shows a new line under an npm ... install command that names Node.js and npm and links to the Node.js download page. — justified
  2. A curl install command, or no command at all, gets no such line. — justified
  3. The same line is translated into all 14 locale catalogs. — justified

[FIRST-PRINCIPLES-REVIEWED] bb63375

Description read

[DESCRIPTION-READ] 71b28fbb4818df2dee90c28c424419e645b03f3197b1a3cbbb1d0273a8f2394e

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed bb63375e2bc439629fe60ebd1512ce9753a81564 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] bb63375

Verdict parsed from the review's SHA-scoped output markers for commit bb63375e2bc439629fe60ebd1512ce9753a81564.

False positive or not applicable? A repository writer can comment:
/ai-review override fable bb63375e2bc439629fe60ebd1512ce9753a81564 false-positive: <reason, 20 to 500 characters>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of bb63375e2bc439629fe60ebd1512ce9753a81564 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] bb63375

False positive or not applicable? A repository writer can comment:
/ai-review override gpt bb63375e2bc439629fe60ebd1512ce9753a81564 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 14, 2026
@buluoray
buluoray merged commit 7870452 into release/0.13.0 Nov 14, 2026
22 checks passed
@buluoray
buluoray deleted the crew/slack/backport-0.13.0-mimo branch November 14, 2026 21:43
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants