Repository navigation
build(ui-index): drop the digest and count lines that every UI change edited (#37406) - #37473
Conversation
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. The PR changes only the generated index's metadata header, build scripts, tests and docs, and adds or changes no control a user can see, so the missing blind read leaves no evidence gap. [UX-REVIEWED] 7146a33 Description read[DESCRIPTION-READ] 44d8c3c679e9143ce9a83ed86ef9fa7e98afdd2cbe99d2c20f7c8b538c9da6ff That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this is a clean backport of #37406. Every reader of the removed [DESIGN-REVIEWED] 7146a33 Description read[DESCRIPTION-READ] 0bb38f3ddbee6d0b8f24c092f4adf266368404986607afa015fd1208e25517e4 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS This is a clean backport of #37406. Every item comes from that change, and the conflict it removes is real and is the stated Goal. What this change shipsInventory (6 items) — 6 justifiedIntent: stop backport PRs that change UI on different pages from conflicting on the generated find_ui index. This is a FIX (backport).
[FIRST-PRINCIPLES-REVIEWED] 7146a33 Description read[DESCRIPTION-READ] 8b344094606717233cf62ab88180b1001f858cf6f80559c50c8ff7c039aca70d That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Review detailsNo findings. Notes:
[OPUS-REVIEWED] 7146a33 Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Problem / Motivation
Goal: Backport #37406 to release/0.13.0, so backport PRs that change UI on different pages stop conflicting on
src/kiro_crew/docs/ui-index.generated.json.#37406 removed the two lines at the top of the generated find_ui index (
input_digestand the per-kind counts) that changed on almost every UI change. Backport PRs into this branch hit the same conflicts as PRs intomain.Why it matters
Each conflict means a rebase, a regenerated file and a full CI restart for the backport PR.
Not a goal
What changed (motivation → approach → change)
One cherry-pick of the squash commit of #37406 (
git cherry-pick -x). The only conflict was the generated index itself; it was resolved by runningnpm run gen:uion this branch's sources.gen-ui-index.mjs --checkpasses.Backwards compatibility
Compatible: same as #37406. The freshness check still compares the whole file, and every reader of the removed keys gets them from code (see #37406's reader list).
Reader: src/kiro_crew/ui_index_load.py:_attach_auto -- chat --
input_digestcomes fromparse_index_text; test_find_ui_auto.pyReader: src/kiro_crew/guide_catalog.py:ui_auto_tier -- chat -- reads the base index through
parse_index_text; test_guide_observe.pyTests
Ran on this branch: test_find_ui_auto, test_find_ui_browse, test_guide_observe, test_ui_index_facade, test_facade_mirror_guards, test_find_ui, test_guide_ui_show_auto (505 passed; the one failure,
continue with github, is the known #32670 and fails without this change too), andgen-ui-index.mjs --check.Manual verification
N/A — a clean cherry-pick of a change verified on
mainin #37406.Related Issues
Part of #37396
Checklist