Skip to content

build(ui-index): drop the digest and count lines that every UI change edited (#37406) - #37473

Merged
buluoray merged 1 commit into
release/0.13.0from
crew/slack/backport-0.13.0-ui-index
Nov 15, 2026
Merged

buluoray merged 1 commit into
release/0.13.0from
crew/slack/backport-0.13.0-ui-index

Conversation

@buluoray

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Backport #37406 to release/0.13.0, so backport PRs that change UI on different pages stop conflicting on src/kiro_crew/docs/ui-index.generated.json.

#37406 removed the two lines at the top of the generated find_ui index (input_digest and the per-kind counts) that changed on almost every UI change. Backport PRs into this branch hit the same conflicts as PRs into main.

Why it matters

Each conflict means a rebase, a regenerated file and a full CI restart for the backport PR.

Not a goal

What changed (motivation → approach → change)

One cherry-pick of the squash commit of #37406 (git cherry-pick -x). The only conflict was the generated index itself; it was resolved by running npm run gen:ui on this branch's sources. gen-ui-index.mjs --check passes.

Backwards compatibility

Compatible: same as #37406. The freshness check still compares the whole file, and every reader of the removed keys gets them from code (see #37406's reader list).

Reader: src/kiro_crew/ui_index_load.py:_attach_auto -- chat -- input_digest comes from parse_index_text; test_find_ui_auto.py
Reader: src/kiro_crew/guide_catalog.py:ui_auto_tier -- chat -- reads the base index through parse_index_text; test_guide_observe.py

Tests

Ran on this branch: test_find_ui_auto, test_find_ui_browse, test_guide_observe, test_ui_index_facade, test_facade_mirror_guards, test_find_ui, test_guide_ui_show_auto (505 passed; the one failure, continue with github, is the known #32670 and fails without this change too), and gen-ui-index.mjs --check.

Manual verification

N/A — a clean cherry-pick of a change verified on main in #37406.

Related Issues

Part of #37396

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 15, 2026 03:07
@buluoray
buluoray requested review from cruisercohen and removed request for a team November 15, 2026 03:07
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 7146a33d25714a1ca0c8a1ec1986037bd30d90cd — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing to check. The PR changes only the generated index's metadata header, build scripts, tests and docs, and adds or changes no control a user can see, so the missing blind read leaves no evidence gap.

[UX-REVIEWED] 7146a33

Description read

[DESCRIPTION-READ] 44d8c3c679e9143ce9a83ed86ef9fa7e98afdd2cbe99d2c20f7c8b538c9da6ff

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 7146a33d25714a1ca0c8a1ec1986037bd30d90cd — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this is a clean backport of #37406. Every reader of the removed input_digest loads the index through parse_index_text, and nothing reads the removed counts.

[DESIGN-REVIEWED] 7146a33

Description read

[DESCRIPTION-READ] 0bb38f3ddbee6d0b8f24c092f4adf266368404986607afa015fd1208e25517e4

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 7146a33d25714a1ca0c8a1ec1986037bd30d90cd — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

This is a clean backport of #37406. Every item comes from that change, and the conflict it removes is real and is the stated Goal.

What this change ships

Inventory (6 items) — 6 justified

Intent: stop backport PRs that change UI on different pages from conflicting on the generated find_ui index. This is a FIX (backport).

  1. The committed ui-index.generated.json no longer carries an input_digest line — justified
  2. The committed index's coverage no longer carries per-kind counts, tiers or the registered-control total; the generator's summary and --report still print them — justified
  3. Readers now work out the digest themselves as sha256 of the file's text (parse_index_text), so _attach_auto and ui_auto_tier keep matching the auto tier — justified
  4. The generator stamps base_input_digest from the exact bytes it writes, not from a digest of the re-serialized index — justified
  5. buildUiIndex returns its counts as stats and no longer takes an inputDigest input — justified
  6. The mcp.md and ci-and-reviews.md wording now says the file carries no digest or count line — justified

[FIRST-PRINCIPLES-REVIEWED] 7146a33

Description read

[DESCRIPTION-READ] 8b344094606717233cf62ab88180b1001f858cf6f80559c50c8ff7c039aca70d

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 7146a33d25714a1ca0c8a1ec1986037bd30d90cd — this comment is updated in place on each push.

Review details

No findings.

Notes:

  • website/scripts/lib/ui-index.mjs:780: this comment points to index_input_digest, but the reader the PR adds is parse_index_text in ui_index_load.py.

[OPUS-REVIEWED] 7146a33

Verdict parsed from the review's SHA-scoped output markers for commit 7146a33d25714a1ca0c8a1ec1986037bd30d90cd.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 7146a33d25714a1ca0c8a1ec1986037bd30d90cd false-positive: <reason, 20 to 500 characters>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 7146a33d25714a1ca0c8a1ec1986037bd30d90cd and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 7146a33

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 7146a33d25714a1ca0c8a1ec1986037bd30d90cd false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 15, 2026
@buluoray
buluoray merged commit 600df21 into release/0.13.0 Nov 15, 2026
22 checks passed
@buluoray
buluoray deleted the crew/slack/backport-0.13.0-ui-index branch November 15, 2026 03:35
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant