Skip to content

refactor: 0.13 backport, rename Ultra Mode to conductor mode (#36924, #37095) - #37506

Merged
buluoray merged 3 commits into
release/0.13.0from
crew/slack/backport-0.13.0-conductor-rename
Nov 15, 2026
Merged

buluoray merged 3 commits into
release/0.13.0from
crew/slack/backport-0.13.0-conductor-rename

Conversation

@buluoray

@buluoray buluoray commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: 0.13 users see the feature under its final name, conductor mode, so they do not meet "Ultra Mode" in 0.13 and a new name again in 0.14.

Backport onto release/0.13.0 (head 22392729303, after #37514) of the two main PRs that renamed Ultra Mode to conductor mode. The rename is user-facing: UI strings in every locale, settings labels and their search entries, gateway notices, agent prompts and skills, shipped docs and specs. It also renames the code names, the conductor_mode_only refusal code, the telemetry.traces_conductor_mode config key and the trace values, as on main.

Pick Main commit What it does
#36924 176820cd7a Renames every user-facing "Ultra Mode" and the code names that carried it to conductor mode; adds the decision entry for the name.
#37095 36a018f0d7 Renames the four names the first PR kept (refusal code, config key, trace kind and values) and drops the old-spelling compatibility code. Ultra Mode only ever ran behind the default-off feature preview, so no saved value needs the old name.

Both PRs passed review on main.

Why it matters

The feature ships in 0.13 behind its preview flag. Without the rename, 0.13 users who try it learn "Ultra Mode", then see every label, setting and notice change name in 0.14.

Not a goal

  • Any conductor behaviour change. Only names change.
  • The rest of main's later conductor work.

What changed (motivation → approach → change)

Two cherry-picks with git cherry-pick -x, plus one test commit. Neither pick applies cleanly on 0.13: main renamed lines that 0.13 does not have yet, and 0.13 has lines main changed later. Every conflict was resolved the same way: keep 0.13's own text and apply the rename to it. Files main changed but 0.13 does not have (crew_log/projection_objects.py, test/test_warm_task_brief_welcome.py) stay absent. Two feature-map cells were set to main's exact wording, and the find_ui index (ui-index.generated.json, guidePlans.gen.ts) was regenerated with npm run gen:ui. The decisions index gains the two rename entries.

Hand-resolved hunks, each keeping both sides:

The check that the rename is complete: for every file under src, website/src, test and config-baseline.json, the count of remaining ultra names (ultra mode, UltraMode, ultra_, ultra-) equals main's count for that file.

The test commit re-pins the conductor spec digests in test/test_agent_refactor_spec_bytes.py (kirocrew-conductor.json, kirocrew-ledger-conductor.json) and the _CONDUCTOR_SYSTEM_PROMPT hash in test/test_agent_refactor_contracts.py. Main re-pinned the same pins in #36924, but 0.13 builds those specs from its own prompts, so the values differ from main's. Every other pinned spec keeps its bytes.

Backwards compatibility

Compatible for anyone who never turned on the Ultra Mode preview, which is off by default. A preview user who set telemetry.traces_ultra_mode must use telemetry.traces_conductor_mode, as on main (#37095).

Tests

Release PRs get no backend test lanes in CI, so tests ran locally on this head (on top of #37514), one pytest process per batch of 20 files, no xdist:

  • The backend test files the rename touches or that import a module it changes (210 files): 7,928 passed, 1 failed. That one (test_kas_cli_floor.py::test_a_pinned_link_flipped_after_the_check_never_runs_unsandboxed) fails the same way on a clean release/0.13.0.
  • test_agent_refactor_spec_bytes.py, test_agent_refactor_contracts.py, test_mate_conductor_parity.py, test_work_ledger.py, test_agent_no_tools_notice.py, the find_ui tests and test/tracing: 720 passed, 0 failed. The conductor spec digests re-pinned in the third commit still match after fix: 0.13 backport batch 2, part 2 (Slack-reported KAS fixes, small completions) #37514.

Frontend on this head: tsc -p tsconfig.app.json clean, scripts/check-i18n-keys.mjs OK, npm run gen:ui -- --check clean, the 31 vitest files the rename touches pass. flake8 and black on every Python file in the diff: clean. The per-file count of remaining old names equals main's.

The AI review lanes fail closed on this PR because its diff is over 1 MB. Both picks were reviewed on main.

Manual verification

N/A. A rename; the same change is on main.

Screenshots / video

Why no screenshot: a text-only rename of labels that main's PRs already reviewed; no layout changes.

Related Issues

Backport of #36924 and #37095.

Sibling sweep

Siblings: none -- the per-file count of remaining old names equals main's

Pattern harvest

Not generalizable: backport of an already-reviewed rename

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...). A backport keeps one commit per pick.
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license.

@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 15, 2026 04:40
@buluoray
buluoray requested review from chenmingwei23 and removed request for a team November 15, 2026 04:40
@github-actions

github-actions Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Sensitive Change Review

Sensitive files changed:

  • src/kiro_crew/security_posture_sinks_gateway.py

  • No reasoning template for cfa522f yet.

How to clear this check:

  1. The PR author posts the template below as a PR comment, with
    every field filled (N/A needs a reason). Keep the
    Head commit line: it must name the current head SHA.
  2. The check turns green within a minute, with no push.
  3. A new push resets this check: post it again for the new head.

Only the author's comment counts this way. A reviewer can instead
paste the filled template into an "Approve" review on this head.
Merging still needs a reviewer's approval.

## Sensitive change review
- Head commit: cfa522fa2cdb95e24d1d17cdb7c6a796383b892d
- What rule changed:
- Before -> after (what was allowed/blocked, now):
- Worst case if wrong (breaks commands / leaks secret / locks user out):
- Evidence checked (which sandbox result proves it):
- No regression:
  - Tools still work (which tools/commands were run, result):
  - Backward compatible (old config / old data / old callers still work, how checked):
  - Existing tests (which suites passed on this head):
- How to undo:

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 15, 2026
@github-actions

github-actions Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of cfa522fa2cdb95e24d1d17cdb7c6a796383b892d — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

This backports a rename to 0.13 that maintainers already ruled on (#36869, #37086). Behaviour does not change, and the removed old-spelling compatibility only ever applied behind a preview that is off by default.

What this change ships

Inventory (9 items) — 9 justified

Intent: 0.13 users meet the preview feature under its final name, conductor mode, and never see the name change again in 0.14. FIX (a backported relabel).

  1. Every user-facing "Ultra Mode" label, notice and string becomes "conductor mode", in all locales — justified
  2. The feature-preview settings search entry moves from developer.ultra-mode to developer.conductor-mode (id and highlight route) — justified
  3. Config key telemetry.traces_ultra_mode becomes telemetry.traces_conductor_mode, with no fallback — justified
  4. Refusal code ultra_mode_only becomes conductor_mode_only — justified
  5. Trace root kind, round trace kind and span names (conductor_mode round N) are renamed — justified
  6. Agent prompts, skills and gateway notices say "conductor mode" — justified
  7. Shipped docs, specs and AGENTS.md router row are renamed — justified
  8. Two maintainer decision entries and their index rows are carried over from main — justified
  9. Conductor spec digests and the prompt hash are re-pinned to 0.13's own prompt bytes — justified

[FIRST-PRINCIPLES-REVIEWED] cfa522f

Description read

[DESCRIPTION-READ] f9a3a88d1eee95353f954c1c60016f5b62129dd37e839c9bbc3f157a19faa8e5

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed cfa522fa2cdb95e24d1d17cdb7c6a796383b892d — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] cfa522f

Verdict parsed from the review's SHA-scoped output markers for commit cfa522fa2cdb95e24d1d17cdb7c6a796383b892d.

False positive or not applicable? A repository writer can comment:
/ai-review override fable cfa522fa2cdb95e24d1d17cdb7c6a796383b892d false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of cfa522fa2cdb95e24d1d17cdb7c6a796383b892d and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] cfa522f

False positive or not applicable? A repository writer can comment:
/ai-review override gpt cfa522fa2cdb95e24d1d17cdb7c6a796383b892d false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Nov 15, 2026
@buluoray

Copy link
Copy Markdown
Contributor Author

/ai-review override gpt 2b1cd20 not-applicable: the finding is the by-design recorded-decisions gate on the two superseding decision entries; they are the same entries a maintainer already ruled on for #36924 and #37095 on main, carried unchanged into the 0.13 backport

@buluoray

Copy link
Copy Markdown
Contributor Author

/ai-review override design 2b1cd20 not-applicable: the diff is the mechanical conductor-mode rename from #36924 and #37095 and exceeds the lane's 1 MB limit; Opus and First Principles both passed this head with no findings

@buluoray

Copy link
Copy Markdown
Contributor Author

/ai-review override ux 2b1cd20 not-applicable: the diff is the mechanical conductor-mode rename from #36924 and #37095 and exceeds the lane's 1 MB limit; the UX of the rename was reviewed and overridden on main for the same reason

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@buluoray recorded a not-applicable release (class not-applicable) for the gpt AI finding on 2b1cd20271f3a5abc9d9510c66f48d050cba8971.

the finding is the by-design recorded-decisions gate on the two superseding decision entries; they are the same entries a maintainer already ruled on for #36924 and #37095 on main, carried unchanged into the 0.13 backport

This decision applies only to this commit. A new push requires a new judgment.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@buluoray recorded a not-applicable release (class not-applicable) for the ux AI finding on 2b1cd20271f3a5abc9d9510c66f48d050cba8971.

the diff is the mechanical conductor-mode rename from #36924 and #37095 and exceeds the lane's 1 MB limit; the UX of the rename was reviewed and overridden on main for the same reason

This decision applies only to this commit. A new push requires a new judgment.

@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ human override accepted

@buluoray overrode this lane for 2b1cd20271f3a5abc9d9510c66f48d050cba8971 via /ai-review override (this commit only).

The crew feature's final product name is conductor mode. Every
user-facing place that said Ultra Mode says conductor mode: UI strings
in all locales (kept untranslated), settings labels and their generated
search entries, gateway notices, agent prompts and skills, shipped docs,
specs and the feature map. Code names that carried the old name
(components, CSS classes and tokens, test ids, i18n keys, tests, capture
harnesses) follow it, with a ConductorMode / conductor_mode /
conductor-mode stem so they never collide with the existing conductor
agent-role names.

Saved state keeps working: ids that never said ultra stay (crew_mode,
dashboard.new_chat_crew_mode, mc-preview-crew-mode), the ultra_mode_only
refusal code and the ultra root_kind trace value keep their spelling, and
a transcript that stored the old agent-switch notice still renders as
that notice. A new decision entry records the rename and maps the
earlier entries to the new name; those entries stay as written.

Hand-resolved backport; original author: Bolin Chen.

(cherry picked from commit 176820c)
Ultra Mode only ever lived behind the default-off feature preview, so
no old spelling needs to keep working. Rename the four names the first
rename kept: the remote-dispatch refusal code is conductor_mode_only,
the config key is telemetry.traces_conductor_mode, and the trace
root_kind value and round trace kind are conductor_mode, with spans
named "conductor_mode round N" and "conductor_mode outcome ...".

Drop the compatibility code: the gateway notice no longer matches the
stored "Ultra Mode" agent-switch wording, and the comments that said a
value keeps its old spelling are gone. Title Case labels write the name
in lower case too ("Start New Chats in conductor mode"). A new decision
entry records both, superseding part of the entry that named the
feature.

Hand-resolved backport; original author: Bolin Chen.

(cherry picked from commit 36a018f)
…ename

The rename changes the text of the two conductor agent specs and of
_CONDUCTOR_SYSTEM_PROMPT. Main re-pinned the same pins in #36924, but
release/0.13.0 builds those specs from its own prompts, so its digests
differ from main's. Only kirocrew-conductor.json and
kirocrew-ledger-conductor.json change; every other pinned spec keeps its
bytes.
@buluoray
buluoray force-pushed the crew/slack/backport-0.13.0-conductor-rename branch from 2b1cd20 to cfa522f Compare November 15, 2026 06:56
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 15, 2026
@buluoray
buluoray merged commit bc7e02d into release/0.13.0 Nov 15, 2026
20 of 25 checks passed
@buluoray
buluoray deleted the crew/slack/backport-0.13.0-conductor-rename branch November 15, 2026 07:24
@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant