Repository navigation
test(metrics): run the off-offer tests on a stand-in default home - #37547
chenmingwei23 wants to merge 1 commit into
Conversation
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this is a test-only fix scoped to the one class whose behaviour needs the default home. [DESIGN-REVIEWED] 64851cd Description read[DESCRIPTION-READ] 44f03979a8afc7228f4d806d108933e8da47d1811baf49fee416e5b955b0e90f That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — 🔴 changes requested (blocking)GPT 6.1 found at least one blocking issue that must be resolved before merging This comment is updated in place on each push. BLOCKING -- test/metrics/test_kiro_export_destination.py:394 -- Use the independent patch stack for the autouse fixture
[BLOCK-MERGE] 64851cd Adjudication (Opus 5.5) — is blocking on each finding proportionate?F1: the rule is blocking, and this is a newly added autouse fixture that uses the shared [ADJUDICATION] 64851cd total=1 uphold=1 downgrade=0 False positive or not applicable? A repository writer can comment: |
Problem / Motivation
Goal:
TestOffOfferruns on a stand-in default data home again, so its three red tests on main pass while still proving a non-default home is not asked.Three
TestOffOffertests are red on main (87b11b5ef2). Two PRs crossed. #37460 removed thehomefixture'sis_default_home() -> Truepatch, becausedestinations()no longer checks the home. #37463, merged after it, added its ownis_default_home()check tooff_offer_due(): the offer is asked on the default home only. The test's private home is not the default one, so the offer is never due there.Why it matters
Main is red on every backend run that collects this file, so every open PR inherits three failures it did not cause.
Not a goal
off_offer_due(): asking only on the default home is the intent of feat(privacy): offer Turn on once to installs off only by an old written false #37463 and stays.What changed (motivation → approach → change)
The offer tests need the default home; the rest of the file needs the real one. So
TestOffOffergets a class-local autouse fixture that patchesbeacon.is_default_hometoTrue. Its existinghomecase still patches it back toFalseand asserts the offer is not due.Backwards compatibility
Test-only change. No product code changes.
Tests
test/metrics/test_kiro_export_destination.py::TestOffOffer: 19 passed (the 3 that were red included), serial.Manual verification
Not applicable: test-only change.
Screenshots / video
Not applicable: no UI change.
Related Issues
Fixes #37546
Related: #37460, #37463
Sibling sweep
The other classes in this file run on the real non-default home on purpose (#37460's
test_a_non_default_home_gets_it) and are left as they are.Pattern harvest
Checklist