Skip to content

fix: 0.13 release branch, doc lint and branch-level test reds (#37171, #37451, #37530, #37539) - #37633

Merged
buluoray merged 2 commits into
release/0.13.0from
fix/0.13-doc-lint
Nov 16, 2026
Merged

buluoray merged 2 commits into
release/0.13.0from
fix/0.13-doc-lint

Conversation

@chenmingwei23

@chenmingwei23 chenmingwei23 commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The Source Gates "Lint documentation trees" step passes on release/0.13.0 again, so 0.13 backport PRs are not red for a reason they did not cause.

./scripts/docs-lint.sh fails on release/0.13.0 itself (base de4155bd70, run 43709803472) with three FAIL groups:

  • docs not reachable from any index: docs/decisions/2026-11-13-the-crew-mode-feature-is-named-conductor-mode.md
  • documentation paths cited from code that do not exist: src/kiro_crew/session_head.py:8 and test/test_session_head.py:3 cite docs/request-for-change/rfc-kas-session-head-in-agent-prompt.md
  • backticked repo paths that name no file: the same RFC, cited from docs/architecture/context-management.md, docs/system-specs/modules/memory-skills-hooks.md and docs/system-specs/modules/providers.md

Why it matters

Source Gates is a blocking job. While the release branch fails it, every 0.13 backport PR (#37598, #37551, #37553) is red, and a real doc-lint regression in a backport cannot be told apart from this one.

Not a goal

  • No code change. session_head.py and its test stay as they are on the branch.
  • No change to the docs linter or its baseline.
  • No other doc sync from main beyond the two index rows and the one RFC.

What changed (motivation → approach → change)

Symptom: the doc lint fails on the release branch. Root cause: backports brought the decision doc and the code citing the RFC, but not the decision index row or the RFC file. Change: take both from main as they are there.

  • docs/decisions/README.md: add main's index row for the 2026-11-13 conductor-mode name decision, in the same place main has it.
  • docs/request-for-change/rfc-kas-session-head-in-agent-prompt.md: copied unchanged from main (it came in with docs(rfc): send a new chat's session-stable head as the KAS agent prompt #36964).
  • docs/request-for-change/README.md: add main's index row for that RFC, at the top of the table as on main.

Once Source Gates passed, the backend shards showed a second branch-level red: test/tracing/test_tracing_otlp.py fails on bare release/0.13.0 too (2 failed, 91 passed locally on de4155bd70). The branch has #37005, which adds a kirocrew.step span, but not #37171, the test update that expects it. The second commit cherry-picks #37171 unchanged (test only, +8/-2).

The same commit also fixes the third branch-level red. TestSelfModuleIndexIsLinear::test_the_scan_is_linear_not_quadratic in test/test_denied_commands_security_cost.py failed three runs in a row on its 0.5 s budget (0.522 s, 0.511 s, 0.509 s) and passes locally. Main fixed this flake in three test-only commits: #37451 (hold the budget to the minimum of five readings), #37530 (read it with the tracer paused) and #37539 (count work, not CPU time). Those picks conflict one by one here because main's file also carries #28293 (test-only), so the commit takes main's end state of test/test_denied_commands_security_cost.py and test/denied_commands_security_helpers.py (the helpers diff equals #37539's), plus the #37539 hunk of docs/system-specs/common/testing-conventions.md. No src/ change; every kiro_crew symbol the two files import exists on this branch. Folded into the second commit to keep the PR at two commits.

Backwards compatibility

Compatible: docs and test files only; no src/ change, so nothing that works today stops working.

Removes nothing: the diff adds two index rows and one doc file, widens two span assertions to the span #37005 already emits, and replaces wall-clock budgets in the deny-gate cost tests with main's work-count checks; no product behaviour is taken away.

Tests

Proof: not provable -- test-only change

./scripts/docs-lint.sh on the final tree prints "All documentation checks passed" with 0 FAIL lines (before: 3 FAIL groups). python3 scripts/docs_lint.py --test passes.

test/tracing/test_tracing_otlp.py: 2 failed on the bare base, 93 passed with the #37171 pick.

test/test_denied_commands_security_cost.py: 111 passed in each of 3 local runs. The 13 other test files that import denied_commands_security_helpers: 2296 passed, 1 skipped.

Manual verification

N/A -- the doc linter run above is the check this PR fixes; CI runs the same script.

Related Issues

Unblocks the Source Gates job on #37598, #37551 and #37553. Backports #37171, #37451, #37530 and #37539.

Sibling sweep

Swept: ./scripts/docs-lint.sh on release/0.13.0 (lists every unindexed doc and every missing cited doc path)
Sibling: docs/decisions/README.md -- changed here
Sibling: docs/request-for-change/README.md -- changed here
Sibling: test/tracing/test_tracing_otlp.py -- changed here (the other branch-level red, found by the backend shards)
Sibling: test/test_denied_commands_security_cost.py -- changed here (timing flake red three runs in a row on this branch)

Pattern harvest

Not generalizable: a backport carried code that cites a doc without the doc; the existing doc lint already catches this class, which is how it was found.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

…on-head)

The Source Gates "Lint documentation trees" step fails on release/0.13.0
itself, so every 0.13 backport PR goes red on it.

- Link 2026-11-13-the-crew-mode-feature-is-named-conductor-mode.md from
  docs/decisions/README.md with main's index row.
- Bring docs/request-for-change/rfc-kas-session-head-in-agent-prompt.md
  from main (#36964) and its README index row. session_head.py, its test
  and three docs on the branch already cite it.

Docs only; no code changes. scripts/docs-lint.sh passes on the result.
@chenmingwei23
chenmingwei23 requested review from bolichen97 and removed request for a team November 15, 2026 14:52
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 15, 2026
@github-actions

github-actions Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 0e116828e530eb66721076dd71ce5d069d4f9fa0 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 0e116828e530eb66721076dd71ce5d069d4f9fa0 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 0e116828e530eb66721076dd71ce5d069d4f9fa0 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this is a docs-and-tests-only backport of main's end state, and the private symbols the new tests read are on the branch.

Notes

[DESIGN-REVIEWED] 0e11682

Description read

[DESCRIPTION-READ] 6101cf436bae9f14dfd857b379f4211a375e74379c32d5477875167b76322e53

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 0e116828e530eb66721076dd71ce5d069d4f9fa0 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 0e11682

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 0e116828e530eb66721076dd71ce5d069d4f9fa0 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 0e116828e530eb66721076dd71ce5d069d4f9fa0 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 0e11682

Verdict parsed from the review's SHA-scoped output markers for commit 0e116828e530eb66721076dd71ce5d069d4f9fa0.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 0e116828e530eb66721076dd71ce5d069d4f9fa0 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Nov 15, 2026
…#37539

Two backend tests on release/0.13.0 were red for reasons main has
already fixed in test-only commits:

- test/tracing/test_tracing_otlp.py expected four spans, but #37005
  (already on the branch) adds kirocrew.step. Cherry-picked #37171
  unchanged.
- TestSelfModuleIndexIsLinear failed three runs in a row on the 0.5 s
  budget (0.522 s, 0.511 s, 0.509 s). Took main's end state of
  test/test_denied_commands_security_cost.py and
  test/denied_commands_security_helpers.py, which carries #37451 (min of
  five readings), #37530 (tracer paused) and #37539 (count work, not CPU
  time), plus the #37539 hunk of
  docs/system-specs/common/testing-conventions.md. The picks conflict
  one by one because the file also carries #28293, a test-only change.

No src/ changes.

(cherry picked from commit 6de8528)
@chenmingwei23 chenmingwei23 changed the title fix: 0.13 release branch, doc lint (decision doc index, rfc-kas-session-head) fix: 0.13 release branch, doc lint and branch-level test reds (#37171, #37451, #37530, #37539) Nov 15, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 15, 2026
@buluoray
buluoray merged commit b45ee13 into release/0.13.0 Nov 16, 2026
148 of 155 checks passed
@buluoray
buluoray deleted the fix/0.13-doc-lint branch November 16, 2026 03:35
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants