Skip to content

docs(decisions): propose that a Bot's chat carries the app tools its owner ticked it for - #37812

Open
chenmingwei23 wants to merge 1 commit into
mainfrom
docs/decision-bot-chat-app-tools-v2
Open

chenmingwei23 wants to merge 1 commit into
mainfrom
docs/decision-bot-chat-app-tools-v2

Conversation

@chenmingwei23

@chenmingwei23 chenmingwei23 commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Docs only. Adds one proposed entry to docs/decisions and its README row. Merge order: this PR first, then the implementation PR #37813. It builds on #32983 (merged), which added permissions.bots and the per-app ticked Bots.

Problem / Motivation

Goal: record the maintainer decision that lets a Bot's own chat carry the tools of an app its owner ticked it for, so #37813 has a decision to cite.

The 2026-11-02 entry says a Bot's chat (the conductor) runs the stock conductor spec and takes nothing from the Bot's file. That leaves no way for an app the owner trusts to give a Bot its tools in the Bot's own chat. #32983 lets an app see and wake the Bots the owner ticked for it, but a woken Bot still cannot call the app's tools from its chat.

Why it matters

An owner who ticks a Bot for an app expects that Bot to work with the app from its own chat, with its own memory. Today the only route is a worker, which costs a second turn and puts the Bot's words in the worker. #37813 changes that behaviour, and the decisions ledger is where a change to a recorded decision must be recorded first.

Not a goal

What changed (motivation -> approach -> change)

The entry narrows one sentence of the 2026-11-02 entry and one of the 2026-11-04 entry (decided by @iamwhatever: "a mate's conductor mounts only Crew's own MCP servers"), behind the default-off bot_chat_app_tools feature preview: an app's MCP server joins one Bot's chat, built per session like the Bot's worker spec, only while the app is enabled, offers the server in contributes.botChatServers, holds the owner-approved tools Bot scope in permissions.bots, and the owner ticked that Bot. Losing any of those starts the chat's next turn on a fresh conversation without the server. The shared conductor spec is still written from source.

The 2026-11-04 entry's reason is that a conductor only analyzes and dispatches. The entry's ## Why answers it directly: a Bot's own chat is also where the owner talks to the Bot and where its memory lives, so an app tool used there answers in that chat; routing it through a worker adds a turn and splits the reply across two chats. The exception is kept to the ticked Bot and the preview, so the reason still holds for every other conductor.

The tools scope extends the field #32983 added (a third scope next to read and wake) instead of adding a second switch.

Backwards compatibility

Compatible: docs only; nothing that works today changes.

Removes nothing: the diff adds one decision file and one README row.

Tests

N/A -- docs only. The decisions index and history checks run in CI.

Proof: not provable -- docs or config only

Manual verification

N/A -- docs only.

Related Issues

Implementation: #37813. Builds on #32983.

Open items before merge

  • The entry is a proposal: its Decided by: line is PENDING until maintainers restate it on this PR: @iamwhatever, who decided the 2026-11-04 entry this narrows, and @bolichen97 or @buluoray, who decided the 2026-11-02 entry. Both restatements are needed. The entry is then updated to name them, link those comments under Evidence, and take the restatement's date in its filename and Date: line, because entries are immutable after merge.
  • Open question for the feat(app-sdk): let an app read and wake the Bots the owner gives it #32983 author: tools as a third permissions.bots scope, or a field of its own? It is settled here before merge, since changing it later takes a new superseding entry.
  • A superseding entry needs a maintainer override on the decisions rule; that is the maintainer's call, not the author's.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision d9c7929a084fc6593124c0cdd662d006d753f1e9 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision d9c7929a084fc6593124c0cdd662d006d753f1e9 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — 🔴 changes requested (blocking)

GPT 6.1 found at least one blocking issue that must be resolved before merging d9c7929a084fc6593124c0cdd662d006d753f1e9. 1 of 1 blocking finding(s) are security-class and were withheld from adjudication, so the blocking verdict stands.

This comment is updated in place on each push.

BLOCKING -- docs/decisions/2026-11-15-a-bots-chat-carries-the-app-tools-its-owner-ticked-it-for.md:23 -- Superseding entry requires maintainer evidence and override

  • The pull request that adds this entry, and the maintainer comment that restates it (to be linked).
    Trigger: Merging this PR adds an indexed entry superseding two recorded decisions without linking an on-record maintainer decision; labeling it PENDING does not exempt it from the ledger rules.
    Outcome: The proposal becomes an immutable ledger entry without the evidence required to authorize the change. The base rule also explicitly blocks every superseding-entry PR pending a maintainer override.
    Anchor: recorded-decisions-are-not-regressions
    Fix: Link the maintainer’s on-record decision, finalize its attribution and decision date before merge, and obtain the required maintainer override.

[BLOCK-MERGE] d9c7929
[GPT-REVIEWED] d9c7929

Adjudication (Opus 5.5) — is blocking on each finding proportionate?

No adjudicable findings were provided.

F1 (fenced): the harm rung is governance ceiling, because a decision nobody made would enter an immutable ledger. I confirmed the conditions on disk:

  • docs/decisions/2026-11-15-a-bots-chat-carries-the-app-tools-its-owner-ticked-it-for.md:3 says Decided by: PENDING.
  • Lines 5–6 of that file carry two Supersedes: lines.
  • Line 23 is a placeholder: "(to be linked)". It links no maintainer statement.
  • .review-base-rules/AUTOSDE.yaml:898-942 (blocking: true) flags both a superseding entry and an entry with no linked on-record decision.

Recovery path: none within the ledger, since entries are written once and are only replaced by a new superseding entry. This happens on the PR's ordinary merge path, not in a rare corner case, so the claim stands.

[ADJUDICATION] d9c7929a084fc6593124c0cdd662d006d753f1e9 total=0 uphold=0 downgrade=0
[GPT-ADJUDICATED] d9c7929a084fc6593124c0cdd662d006d753f1e9

[ADJUDICATION-FENCED] d9c7929a084fc6593124c0cdd662d006d753f1e9 fenced=1 flagged=0
UPHOLD-FENCED F1 docs/decisions/2026-11-15-a-bots-chat-carries-the-app-tools-its-owner-ticked-it-for.md:23 -- The entry supersedes two decisions while its decider is still PENDING and its evidence is unlinked, and merging as-is is the ordinary path, not an extreme one, so only a maintainer's restated decision plus an override can clear it.
[GPT-ADJUDICATED-FENCED] d9c7929a084fc6593124c0cdd662d006d753f1e9

False positive or not applicable? A repository writer can comment:
/ai-review override gpt d9c7929a084fc6593124c0cdd662d006d753f1e9 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of d9c7929a084fc6593124c0cdd662d006d753f1e9 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the PR adds one decision entry and its index row. The entry's Decided by: PENDING is held for a maintainer to restate it and override the rule, which is how the decisions README says a superseding entry gets in.

Notes

  • The open question, whether tools should be a third permissions.bots scope or a field of its own, should be settled before merge. Once merged, entries can't be edited, so changing that answer would take another superseding entry.

[DESIGN-REVIEWED] d9c7929

Description read

[DESCRIPTION-READ] 06b9e40366ade9cf954939e2a4619ee216d2f8b0bfad381b7badde810d629560

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — 🔴 changes requested (blocking)

Reviewed d9c7929a084fc6593124c0cdd662d006d753f1e9 — this comment is updated in place on each push.

This entry records a decision no maintainer has made yet. Its Decided by: line says PENDING, its Evidence links no maintainer statement, and it partly reverses two recorded conductor decisions without the maintainer override the rule requires.

BLOCKING — docs/decisions/2026-11-15-a-bots-chat-carries-the-app-tools-its-owner-ticked-it-for.md:3
Decided by: PENDING. Proposal only, not a decision: ... / - The pull request that adds this entry, and the maintainer comment that restates it (to be linked).
Trigger: The PR merges as it stands. The two Evidence links (#32983, #37813) are implementation PRs, and neither carries a maintainer's statement of this decision.
Outcome: The ledger gains an immutable entry that nobody decided. Once merged, the PENDING line and the "(to be linked)" placeholder can only be corrected by another superseding entry.
Anchor: recorded-decisions-are-not-regressions
Fix: Have a MAINTAINERS.md maintainer restate the decision in a comment on this PR. Then put their name and role on the Decided by: line and replace the placeholder Evidence bullet with that comment's URL.

BLOCKING — docs/decisions/2026-11-15-a-bots-chat-carries-the-app-tools-its-owner-ticked-it-for.md:5
Supersedes: 2026-11-02-a-crewmates-worker-carries-its-template-policy.md (in part: ...) / Supersedes: 2026-11-04-conductors-stay-simple-and-new-abilities-go-to-workers.md (in part: "a mate's [conductor] mounts only Crew's own MCP servers", ...)
Trigger: The rule flags every PR whose entry carries a Supersedes: line, and this entry has two.
Outcome: Merging partly reverses two recorded maintainer decisions: that a mate's conductor mounts only Crew's own MCP servers, and that a Bot's chat takes nothing from the Bot's file. No owner has approved either reversal.
Anchor: recorded-decisions-are-not-regressions
Fix: No code change is needed. A maintainer has to override the flag, ideally the person who decided the 2026-11-04 entry, restating the decision on this PR as the first item asks.

[BLOCK-MERGE] d9c7929
[OPUS-REVIEWED] d9c7929

Verdict parsed from the review's SHA-scoped output markers for commit d9c7929a084fc6593124c0cdd662d006d753f1e9.

False positive or not applicable? A repository writer can comment:
/ai-review override fable d9c7929a084fc6593124c0cdd662d006d753f1e9 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 16, 2026
@chenmingwei23
chenmingwei23 force-pushed the docs/decision-bot-chat-app-tools-v2 branch from 86c4090 to b55ce0e Compare November 16, 2026 05:06
@chenmingwei23

Copy link
Copy Markdown
Contributor Author

@iamwhatever (you decided the 2026-11-04 conductors-stay-simple entry) and @buluoray: please review this proposal. If you agree, restate the decision in a comment on this PR, then post /ai-review override gpt and /ai-review override fable on the current head.

What it asks: behind the default-off bot_chat_app_tools preview, an app's MCP server joins one Bot's own chat only when the owner approved the app's tools Bot scope and ticked that Bot. It narrows the 2026-11-02 and 2026-11-04 entries for that one case; Ultra Mode, skills and every other new server still go to workers. Implementation: #37813, which waits for this PR.

Open question: tools as a third permissions.bots scope (as in #37813), or a field of its own?

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 16, 2026
@chenmingwei23
chenmingwei23 force-pushed the docs/decision-bot-chat-app-tools-v2 branch from b55ce0e to a708ddd Compare November 16, 2026 12:21
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 16, 2026
@chenmingwei23

chenmingwei23 commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor Author

Backend Tests (3.12, 7) and Backend Tests (Windows) (2) were red on main, not on this docs-only change: both failed only test_denied_commands_security_ssh_self.py::TestSshFloorNestingDepth::test_the_gate_refuses_a_nest_past_the_bound_without_an_exception, which failed the same way on main 5cffe12 (the gate's 32-deep substitution cap from #37875 answered before the ssh floor). Coverage Gate followed them.

Update: the fix #37964 is merged (529da1e). This PR is rebased onto main 529da1e and pushed as d9c7929, so those checks rerun on the fixed main.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 16, 2026
@chenmingwei23
chenmingwei23 force-pushed the docs/decision-bot-chat-app-tools-v2 branch from a708ddd to d9c7929 Compare November 16, 2026 13:56
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 16, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: action required A blocking check or review needs attention

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants