Repository navigation
ci: 0.13 release branch, install Playwright's ubuntu24.04 Chromium on the ubuntu-26.04 runner (#37653) - #37818
Conversation
…k runner (#37653) Playwright 1.58.2 has no ubuntu26.04 host entry, and kirocrew-linux-4-core now boots ubuntu-26.04, so every fork PR's E2E, render benchmark and i18n render gate fail at 'npx playwright install chromium'. On that image only, set PLAYWRIGHT_HOST_PLATFORM_OVERRIDE to the ubuntu24.04 build and carry it through GITHUB_ENV to the steps that launch the browser. Part of #37647. (cherry picked from commit b5ac843)
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this is a clean backport of a CI-only fix, limited to Ubuntu 26.04+ hosts, and every other host runs the same command as before. [DESIGN-REVIEWED] 85a6953 Description read[DESCRIPTION-READ] 6002b57dfc8372e33a65921d5f789799a67206625bcddcaeaaa21d9a60e47f4f That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS A clean cherry-pick of main's fix for a CI failure that has been reproduced, applied to all three install sites on the branch. Nothing blocks. Not checked: whether Playwright's ubuntu24.04 Chromium launches on ubuntu-26.04 (this PR's own Render Benchmark job proves it). Notes
What this change shipsInventory (3 items) — 2 justifiedIntent: let 0.13 backport PRs get a working Playwright Chromium on the ubuntu-26.04 fork runner. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] 85a6953 Description read[DESCRIPTION-READ] d9529e5d8e2134304ec77611ef4f54e3d8a2a0fb4969408869d0ebf1f0f1e72c That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
bolichen97
left a comment
There was a problem hiding this comment.
Approving 85a6953ce7. This is a clean cherry-pick of #37653 onto release/0.13.0: the added and removed lines in ci.yml and test/test_e2e_ci_scheduling.py match the #37653 merge commit line for line. On main that change already got Render Benchmark and E2E green on the ubuntu-26.04 runner. No failures here so far; the Windows shards and PR Readiness are still running, and auto merge will wait for them.
AI-assisted, sent by Bolin Review bot
Problem / Motivation
Goal: Backport #37653 to
release/0.13.0so 0.13 backport PRs get a working Playwright Chromium on the fork runner.On
release/0.13.0(tip b45ee13), Render Benchmark (counter budgets) runs onkirocrew-linux-4-core, which now boots ubuntu-26.04. Playwright 1.58.2 has no ubuntu26.04 host entry, sonpx playwright install chromiumstops withError: ERROR: Playwright does not support chromium on ubuntu26.04-x64(seen on #37598, also on its rerun). Every 0.13 backport PR goes red on that job whatever it changes.Why it matters
Release-branch backports cannot go green until the install step works on the new image.
Not a goal
What changed
A clean
git cherry-pick -xof main's b5ac843 (#37653), no conflicts. The threenpx playwright install chromiumsteps in.github/workflows/ci.yml(the onlyplaywright installsteps on the release branch) first read/etc/os-release. On Ubuntu 26.04 or later only, they setPLAYWRIGHT_HOST_PLATFORM_OVERRIDE=ubuntu24.04-<arch>and write it toGITHUB_ENV, so later steps that launch the browser resolve the same build. Other hosts run the step as before.test/test_e2e_ci_scheduling.pynow finds the install step by arunwhose last line is the install command, instead of the exactruntext.Backwards compatibility
Compatible: hosts that are not Ubuntu 26.04+ run the same command with the same environment.
Removes nothing.
Tests
test/test_e2e_ci_scheduling.py,test/test_playwright_e2e.py,test/test_browser_recording_skill.py,test/test_github_workflow_security.py,test/test_workflow_security.py,test/test_workflow_permissions.py: 97 passed, 2 skipped.test/test_prepare_pr_profiles.py: 51 passed.Related Issues
Backport of #37653. Part of #37647.
Checklist