Skip to content

ci: 0.13 release branch, install Playwright's ubuntu24.04 Chromium on the ubuntu-26.04 runner (#37653) - #37818

Merged
bolichen97 merged 1 commit into
release/0.13.0from
fix/0.13-playwright-ubuntu2604
Nov 16, 2026
Merged

bolichen97 merged 1 commit into
release/0.13.0from
fix/0.13-playwright-ubuntu2604

Conversation

@chenmingwei23

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Backport #37653 to release/0.13.0 so 0.13 backport PRs get a working Playwright Chromium on the fork runner.

On release/0.13.0 (tip b45ee13), Render Benchmark (counter budgets) runs on kirocrew-linux-4-core, which now boots ubuntu-26.04. Playwright 1.58.2 has no ubuntu26.04 host entry, so npx playwright install chromium stops with Error: ERROR: Playwright does not support chromium on ubuntu26.04-x64 (seen on #37598, also on its rerun). Every 0.13 backport PR goes red on that job whatever it changes.

Why it matters

Release-branch backports cannot go green until the install step works on the new image.

Not a goal

What changed

A clean git cherry-pick -x of main's b5ac843 (#37653), no conflicts. The three npx playwright install chromium steps in .github/workflows/ci.yml (the only playwright install steps on the release branch) first read /etc/os-release. On Ubuntu 26.04 or later only, they set PLAYWRIGHT_HOST_PLATFORM_OVERRIDE=ubuntu24.04-<arch> and write it to GITHUB_ENV, so later steps that launch the browser resolve the same build. Other hosts run the step as before.

test/test_e2e_ci_scheduling.py now finds the install step by a run whose last line is the install command, instead of the exact run text.

Backwards compatibility

Compatible: hosts that are not Ubuntu 26.04+ run the same command with the same environment.

Removes nothing.

Tests

  • test/test_e2e_ci_scheduling.py, test/test_playwright_e2e.py, test/test_browser_recording_skill.py, test/test_github_workflow_security.py, test/test_workflow_security.py, test/test_workflow_permissions.py: 97 passed, 2 skipped.
  • test/test_prepare_pr_profiles.py: 51 passed.
  • The real proof is this PR's own Render Benchmark (counter budgets) job, which runs on the ubuntu-26.04 runner.

Related Issues

Backport of #37653. Part of #37647.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

…k runner (#37653)

Playwright 1.58.2 has no ubuntu26.04 host entry, and kirocrew-linux-4-core
now boots ubuntu-26.04, so every fork PR's E2E, render benchmark and i18n
render gate fail at 'npx playwright install chromium'. On that image only,
set PLAYWRIGHT_HOST_PLATFORM_OVERRIDE to the ubuntu24.04 build and carry it
through GITHUB_ENV to the steps that launch the browser.

Part of #37647.

(cherry picked from commit b5ac843)
@chenmingwei23
chenmingwei23 requested review from bolichen97 and removed request for a team November 16, 2026 04:58
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 85a6953ce70802b7d14505d7835809a8c89fb5c9 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 85a6953ce70802b7d14505d7835809a8c89fb5c9 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this is a clean backport of a CI-only fix, limited to Ubuntu 26.04+ hosts, and every other host runs the same command as before.

[DESIGN-REVIEWED] 85a6953

Description read

[DESCRIPTION-READ] 6002b57dfc8372e33a65921d5f789799a67206625bcddcaeaaa21d9a60e47f4f

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 85a6953ce70802b7d14505d7835809a8c89fb5c9 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

A clean cherry-pick of main's fix for a CI failure that has been reproduced, applied to all three install sites on the branch. Nothing blocks.

Not checked: whether Playwright's ubuntu24.04 Chromium launches on ubuntu-26.04 (this PR's own Render Benchmark job proves it).

Notes

  • Item 1, oversized: the 6-line host-guard block is pasted three times in ci.yml, so the copies can drift. Subtraction: none in this PR. It mirrors main byte-for-byte, and merging the copies only on the release branch would split it from main.

What this change ships

Inventory (3 items) — 2 justified

Intent: let 0.13 backport PRs get a working Playwright Chromium on the ubuntu-26.04 fork runner. This is a FIX.

  1. On Ubuntu 26.04+, all three Chromium install steps use the ubuntu24.04 build. Grepping playwright install in .github finds 3 sites, all covered. Tag: oversized (the block is copied three times).
  2. On that host, later steps in the same job inherit the platform override through GITHUB_ENV. Tag: justified.
  3. The scheduling test now finds the install step by the last line of its run, not by exact text. Tag: justified.

[FIRST-PRINCIPLES-REVIEWED] 85a6953

Description read

[DESCRIPTION-READ] d9529e5d8e2134304ec77611ef4f54e3d8a2a0fb4969408869d0ebf1f0f1e72c

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 85a6953ce70802b7d14505d7835809a8c89fb5c9 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 85a6953

Verdict parsed from the review's SHA-scoped output markers for commit 85a6953ce70802b7d14505d7835809a8c89fb5c9.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 85a6953ce70802b7d14505d7835809a8c89fb5c9 false-positive: <reason, 20 to 500 characters>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 85a6953ce70802b7d14505d7835809a8c89fb5c9 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 85a6953

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 85a6953ce70802b7d14505d7835809a8c89fb5c9 false-positive: <reason, 20 to 500 characters>

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving 85a6953ce7. This is a clean cherry-pick of #37653 onto release/0.13.0: the added and removed lines in ci.yml and test/test_e2e_ci_scheduling.py match the #37653 merge commit line for line. On main that change already got Render Benchmark and E2E green on the ubuntu-26.04 runner. No failures here so far; the Windows shards and PR Readiness are still running, and auto merge will wait for them.

AI-assisted, sent by Bolin Review bot

@bolichen97
bolichen97 merged commit b50ca01 into release/0.13.0 Nov 16, 2026
89 of 90 checks passed
@bolichen97
bolichen97 deleted the fix/0.13-playwright-ubuntu2604 branch November 16, 2026 05:37
@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants