Skip to content

ci: 0.13 backport, install Playwright's ubuntu24.04 Chromium on ubuntu-26.04 runners (#37653, #37703) - #37830

Merged
buluoray merged 2 commits into
release/0.13.0from
crew/slack/backport-0.13.0-playwright-u26
Nov 16, 2026
Merged

buluoray merged 2 commits into
release/0.13.0from
crew/slack/backport-0.13.0-playwright-u26

Conversation

@buluoray

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Make the Playwright lanes (E2E, Render Benchmark, i18n render gate) run on release/0.13.0 again now that the CI runner boots ubuntu-26.04.

Backport onto release/0.13.0 (head b45ee13fbcf). Two commits, made with git cherry-pick -x. Both applied with no conflict; nothing was hand-resolved.

Pick Main commit What it does on the release branch
#37653 b5ac843ac1c3 On an ubuntu 26+ runner only, sets PLAYWRIGHT_HOST_PLATFORM_OVERRIDE to the ubuntu24.04 build before npx playwright install chromium, and carries it through GITHUB_ENV to the steps that launch the browser. Every other host is left as it was.
#37703 6ee86c9b56b6 test/test_workflow_playwright_host_guard.py fails when a workflow installs Playwright without that guard; docs/ci/ci-and-reviews.md names the rule.

Why it matters

Playwright 1.58.2 has no ubuntu26.04 host entry, so every release PR with a frontend change fails Render Benchmark (counter budgets) with Playwright does not support chromium on ubuntu26.04-x64. #37598 shows that red now, and its rerun failed the same way.

Not a goal

  • Upgrading Playwright.

What changed (motivation → approach → change)

Cherry-picks only. No hunk was hand-resolved and no line is new.

Backwards compatibility

Compatible. CI-only; hosts below ubuntu 26 run the same commands as before.

Tests

test/test_workflow_playwright_host_guard.py and test/test_e2e_ci_scheduling.py on this head: 23 passed. scripts/docs_lint.py: all documentation checks passed.

Manual verification

N/A. The lanes this PR touches run on it.

Screenshots / video

N/A: no frontend change.

Related Issues

Part of #37647. Backport of #37653 and #37703.

Sibling sweep

Siblings: none -- the guard test checks every Playwright install in the release workflows, and it passes

Pattern harvest

Not generalizable: backport of already-reviewed CI fixes (#37653, #37703)

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)

…k runner (#37653)

Playwright 1.58.2 has no ubuntu26.04 host entry, and kirocrew-linux-4-core
now boots ubuntu-26.04, so every fork PR's E2E, render benchmark and i18n
render gate fail at 'npx playwright install chromium'. On that image only,
set PLAYWRIGHT_HOST_PLATFORM_OVERRIDE to the ubuntu24.04 build and carry it
through GITHUB_ENV to the steps that launch the browser.

Part of #37647.

(cherry picked from commit b5ac843)
@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 16, 2026 05:22
@buluoray
buluoray requested review from mbriones98 and removed request for a team November 16, 2026 05:22
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision aed74366d335e6b15d6cfba35bcede1988f34eec touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of aed74366d335e6b15d6cfba35bcede1988f34eec — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this is a clean backport of a CI-only stopgap. The release branch pins Playwright 1.58.2, ci.yml is the only workflow that installs Playwright, and CI runs the guarded steps itself.

Notes

  • The guard ships three identical copies in ci.yml. Upgrading Playwright to 1.65.1 on the release branch would remove all of it, but the PR rules that out as not a goal, which is reasonable for a backport.

[DESIGN-REVIEWED] aed7436

Description read

[DESCRIPTION-READ] 4fab65f754c3a454561e58b50c9e1421f337a49520debb5b4fc4afcba378541b

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of aed74366d335e6b15d6cfba35bcede1988f34eec — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Both commits are cherry-picks of fixes already reviewed on main, made for a stated red lane (#37598). All three playwright install sites in .github/workflows/ carry the guard.

What this change ships

Inventory (5 items) — 4 justified

Intent: get the release-branch Playwright lanes (E2E, Render Benchmark, i18n render gate) running again on ubuntu-26.04 runners. This is a FIX.

  1. On ubuntu 26 and later, the three Chromium install steps fetch the ubuntu24.04 build. Other hosts are unchanged. — justified
  2. The override reaches the later steps that launch the browser, through GITHUB_ENV. — justified
  3. A new test fails when a workflow installs Playwright without the guard. — justified
  4. ci-and-reviews.md gains a section on runner image moves and playwright install. — justified
  5. test_e2e_ci_scheduling.py's install-step match now accepts a multi-line run that ends with the install. — undeclared (the test edit is needed because the step shape changed)

[FIRST-PRINCIPLES-REVIEWED] aed7436

Description read

[DESCRIPTION-READ] 081131893250f694425e8efd4f68ea58033e21c5e17f942e6c12385d530757b5

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed aed74366d335e6b15d6cfba35bcede1988f34eec — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] aed7436

Verdict parsed from the review's SHA-scoped output markers for commit aed74366d335e6b15d6cfba35bcede1988f34eec.

False positive or not applicable? A repository writer can comment:
/ai-review override fable aed74366d335e6b15d6cfba35bcede1988f34eec false-positive: <reason, 20 to 500 characters>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of aed74366d335e6b15d6cfba35bcede1988f34eec and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] aed7436

False positive or not applicable? A repository writer can comment:
/ai-review override gpt aed74366d335e6b15d6cfba35bcede1988f34eec false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 16, 2026
@buluoray
buluoray merged commit 065b894 into release/0.13.0 Nov 16, 2026
142 of 147 checks passed
@buluoray
buluoray deleted the crew/slack/backport-0.13.0-playwright-u26 branch November 16, 2026 06:52
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants