Repository navigation
ci: 0.13 backport, install Playwright's ubuntu24.04 Chromium on ubuntu-26.04 runners (#37653, #37703) - #37830
Conversation
…k runner (#37653) Playwright 1.58.2 has no ubuntu26.04 host entry, and kirocrew-linux-4-core now boots ubuntu-26.04, so every fork PR's E2E, render benchmark and i18n render gate fail at 'npx playwright install chromium'. On that image only, set PLAYWRIGHT_HOST_PLATFORM_OVERRIDE to the ubuntu24.04 build and carry it through GITHUB_ENV to the steps that launch the browser. Part of #37647. (cherry picked from commit b5ac843)
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this is a clean backport of a CI-only stopgap. The release branch pins Playwright 1.58.2, ci.yml is the only workflow that installs Playwright, and CI runs the guarded steps itself. Notes
[DESIGN-REVIEWED] aed7436 Description read[DESCRIPTION-READ] 4fab65f754c3a454561e58b50c9e1421f337a49520debb5b4fc4afcba378541b That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Both commits are cherry-picks of fixes already reviewed on main, made for a stated red lane (#37598). All three What this change shipsInventory (5 items) — 4 justifiedIntent: get the release-branch Playwright lanes (E2E, Render Benchmark, i18n render gate) running again on ubuntu-26.04 runners. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] aed7436 Description read[DESCRIPTION-READ] 081131893250f694425e8efd4f68ea58033e21c5e17f942e6c12385d530757b5 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Problem / Motivation
Goal: Make the Playwright lanes (E2E, Render Benchmark, i18n render gate) run on
release/0.13.0again now that the CI runner boots ubuntu-26.04.Backport onto
release/0.13.0(headb45ee13fbcf). Two commits, made withgit cherry-pick -x. Both applied with no conflict; nothing was hand-resolved.b5ac843ac1c3PLAYWRIGHT_HOST_PLATFORM_OVERRIDEto the ubuntu24.04 build beforenpx playwright install chromium, and carries it throughGITHUB_ENVto the steps that launch the browser. Every other host is left as it was.6ee86c9b56b6test/test_workflow_playwright_host_guard.pyfails when a workflow installs Playwright without that guard;docs/ci/ci-and-reviews.mdnames the rule.Why it matters
Playwright 1.58.2 has no ubuntu26.04 host entry, so every release PR with a frontend change fails
Render Benchmark (counter budgets)withPlaywright does not support chromium on ubuntu26.04-x64. #37598 shows that red now, and its rerun failed the same way.Not a goal
What changed (motivation → approach → change)
Cherry-picks only. No hunk was hand-resolved and no line is new.
Backwards compatibility
Compatible. CI-only; hosts below ubuntu 26 run the same commands as before.
Tests
test/test_workflow_playwright_host_guard.pyandtest/test_e2e_ci_scheduling.pyon this head: 23 passed.scripts/docs_lint.py: all documentation checks passed.Manual verification
N/A. The lanes this PR touches run on it.
Screenshots / video
N/A: no frontend change.
Related Issues
Part of #37647. Backport of #37653 and #37703.
Sibling sweep
Siblings: none -- the guard test checks every Playwright install in the release workflows, and it passes
Pattern harvest
Not generalizable: backport of already-reviewed CI fixes (#37653, #37703)
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)