Skip to content

fix(connections): say a hand-written mcp.json row is the user's to change on Connect - #37864

Open
cruisercohen wants to merge 2 commits into
mainfrom
fix/35817-connect-hand-written-row
Open

cruisercohen wants to merge 2 commits into
mainfrom
fix/35817-connect-hand-written-row

Conversation

@cruisercohen

@cruisercohen cruisercohen commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: When a Connections card's Connect meets a row the user wrote by hand in their own mcp.json, the card says where that row is and what to change, instead of failing with "server 'notion' not found".

A card claims an MCP row named for its slug at the registry URL. For a needs_auth row, Connect first reads the stored spec with GET /api/mcp/custom/{name} to rewrite its URL. That read finds only rows Kiro Crew stores itself, so for a hand-written global mcp.json row (for example notion at https://mcp.notion.com/mcp/) it answered 404 and the card showed Action failed: server 'notion' not found (#35817).

Why it matters

A user who added a provider by hand and then presses Connect on its card gets an error that reads like a bug and gives no way forward.

Not a goal

What changed (motivation → approach → change)

In ConnectionsPage.tsx connect(), a 404 from the stored-spec read now becomes a plain error: the provider is set up by hand in the user's own mcp.json under that name, Kiro Crew does not change that file, and removing that entry lets Connect add the provider here. Nothing is written and no sign-in starts on that path. Any other error from the read is passed on unchanged. At that 404 the card reads the server list fresh (fetchQuery with staleTime: 0, since ['mcp-servers'] never goes stale on its own): if the user has already removed the row, Connect adds the provider in the same press instead of repeating the message. If the fresh row is held by no raw scope (every non-kirocrew presence flag false), only the gateway's rendered agent config still lists it (a restart keeps it, since the rebuild starts from that file), and an add would collide with that name, so the card asks the user to press Uninstall on that entry in MCP Servers, then Apply, then Connect. Uninstall's purge also strips the rendered copy (new string connect_rendered_copy_only, in every catalog; each translation names the tab by that catalog's own nav.mcp_servers label).

The new string pages.connectionsPage.connect_hand_written_row is translated in every catalog under website/src/i18n/locales/, uses {{productName}} for the product name, and en-XA is regenerated.

Backwards compatibility

Compatible: rows Kiro Crew stores itself still read, rewrite and sign in exactly as before; only the 404 branch changes its message.

Removes nothing: the 404 already ended Connect; it now ends it with a message that names the file.

Tests

website/src/test/ConnectionsPage.coverage.test.tsx › says a hand-written mcp.json row is the user's to change instead of "not found": the stored-spec read rejects with a 404, and the card's alert names the user's own mcp.json and does not say "not found". No spec update, re-enable or mint call is made. It fails on main's ConnectionsPage.tsx and passes on this head. adds the provider on Connect once the user removes the hand-written row keeps the row in the list through the first alert, empties it, and asserts the next single Connect reaches mcpCustomAdd; Cancel on that wait then uninstalls the new entry, which pins the waiting card's kind: stored ? 'reconnect' : 'new' (it fails with main's existing ? ...). passes any other stored-spec read error through unchanged pins that a 500 shows its own error and writes nothing. points to Uninstall in MCP Servers when only the rendered copy still holds the removed row pins the copy-only case: Uninstall message, no add, update or mint. ConnectionsPage.coverage.test.tsx (99 tests) and the i18n suites (82 files, 1270 tests) pass on this head, and tsc and eslint are clean.

Proof: not provable -- frontend test (prove.py runs Python only)

Manual verification

Not run against a live gateway with a hand-written row; the test drives the real page with a 404 from the same API client the gateway answers.

Screenshots / video

The card's feedback line before and after, rendered with the real catalog and the card's inline ErrorNotice:

Dark theme: before and after

Light theme: before and after

The card's feedback line for the copy-only case (connect_rendered_copy_only), under the first-press message, from the same render path, with the card's "Action failed:" wrapping:

Light theme: rendered-copy-only message

Dark theme: rendered-copy-only message

Related Issues

Closes #35817

Sibling sweep

Swept: git grep -n "mcpCustomGet" -- website/src ':!website/src/test'
Sibling: website/src/pages/connections/ConnectionsPage.tsx -- changed here
Sibling: website/src/components/McpCustomServerModal.tsx -- not affected -- edits only rows the MCP tab lists as Kiro Crew's own

Pattern harvest

Not generalizable: this is the one card path that reads a Kiro Crew-only endpoint for a row it may not own.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@cruisercohen
cruisercohen requested review from a team and KiroCrewCaptain as code owners November 16, 2026 07:01
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 16, 2026
@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 23f0c1c8857280bab3317aaa8bf2fe55cefc40a1 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. Each item comes from #35817, or is needed so the message's own "remove it, then press Connect" step actually works.

What this change ships

Inventory (4 items) — 4 justified

Intent: a user who wrote a provider row by hand in their own mcp.json and presses Connect on its card is told where the row lives and what to change. This is a FIX.

  1. When the saved-spec read returns 404, Connect now says the row was written by hand in the user's mcp.json and that Kiro Crew does not change that file. It no longer says "server 'notion' not found". — justified
  2. At that 404, the card reads the server list fresh. If the user has already removed the row, the same press adds the provider. — justified
  3. If only Kiro Crew's own copy of the row is left, the card tells the user to press Uninstall in MCP Servers, then Apply, then Connect. This is a new message in every catalog. — justified
  4. When a press adds a new entry, its wait counts as a new connect, not a reconnect, so Cancel removes the entry it wrote. — justified

[FIRST-PRINCIPLES-REVIEWED] 23f0c1c

Description read

[DESCRIPTION-READ] 98d5708e1d5ecbb714a54eeffab7ecbc1e96f8fdc21dba2072b87f364b91f8fb

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 23f0c1c8857280bab3317aaa8bf2fe55cefc40a1 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: a 404 that was a dead end now either names a fix the user can apply or goes on to add the provider, and nothing is newly written or taken away.

Notes

  • The description's ## Backwards compatibility has both a Compatible: line and a Removes nothing: line. The patch does remove nothing, so keep just the Removes nothing line.
  • The rendered-copy-only branch keys off the presence flags. If a server row has no presence at all, it gets the hand-written message, which tells the user to edit a file that no longer holds the row. Fine for now; worth checking if presence can be missing.

[DESIGN-REVIEWED] 23f0c1c

Description read

[DESCRIPTION-READ] 650bcba0b05132f06d3438886da949627199256b1079798bba50f7d15792c144

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 23f0c1c8857280bab3317aaa8bf2fe55cefc40a1 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks. The PR adds no controls, only two error strings. Both appear in the screenshots, and the blind reader understood what each one asks.

Notes

  • connect_hand_written_row: the reader knew what to do but not where: "I don't know where 'mcp.json' lives or how to open and edit it." Since the row's presence scope is already known when the message is built, name the file's actual path (for example, the global ~/.kiro/settings/mcp.json) instead of "your own mcp.json".
  • connect_rendered_copy_only: the reader would "hesitate to press 'Uninstall': it sounds like it could wipe out my Notion setup." Add a clause that says this is safe, such as "this removes only {{productName}}'s leftover copy."

[UX-REVIEWED] 23f0c1c

Description read

[DESCRIPTION-READ] d0a595e85cd07c83eabe18a45ac90a55ce893bcf39bd296ad50b592d81716198

That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 23f0c1c8857280bab3317aaa8bf2fe55cefc40a1 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 23f0c1c

Verdict parsed from the review's SHA-scoped output markers for commit 23f0c1c8857280bab3317aaa8bf2fe55cefc40a1.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 23f0c1c8857280bab3317aaa8bf2fe55cefc40a1 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 23f0c1c8857280bab3317aaa8bf2fe55cefc40a1 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 23f0c1c

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 23f0c1c8857280bab3317aaa8bf2fe55cefc40a1 false-positive: <reason, 20 to 500 characters>

@cruisercohen
cruisercohen force-pushed the fix/35817-connect-hand-written-row branch from 2a5e6ce to 579aa13 Compare November 16, 2026 07:24
@cruisercohen

Copy link
Copy Markdown
Contributor Author

Integration (in-process gateway) is red on test/integration/test_boot_smoke.py::test_a_second_boot_touches_only_known_module_globals (kiro_crew.apps.hidden_sessions._app_ids). This PR changes only the dashboard; the red comes from main and #37846 fixes it. This PR will rebase onto main once that lands.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 16, 2026
@cruisercohen

Copy link
Copy Markdown
Contributor Author

Rebased onto main 85d0512, which carries the boot-smoke fix #37933 (579aa13 -> 72cacd7, range-diff =, no code change); CI re-running.

@cruisercohen
cruisercohen force-pushed the fix/35817-connect-hand-written-row branch from 579aa13 to 72cacd7 Compare November 16, 2026 11:24
@cruisercohen
cruisercohen enabled auto-merge (squash) November 16, 2026 11:24
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 16, 2026
@cruisercohen
cruisercohen force-pushed the fix/35817-connect-hand-written-row branch from 72cacd7 to c911a07 Compare November 17, 2026 13:50
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 17, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. The 404 message is a clear improvement, and the first test checks the right things: no update, no re-enable and no sign-in start on a row Kiro Crew does not own. One problem in the second commit needs a fix before this can merge.

  1. website/src/pages/connections/ConnectionsPage.tsx:563: the re-read runs too early. It fires when the 404 arrives, while the hand-written row is still in the user's mcp.json, so the refetch caches the same row again. The ['mcp-servers'] query inherits staleTime: Infinity from website/src/api/queryClient.ts. It polls only while a card is waiting after a mint, and I found no WebSocket target that refreshes it when mcp.json changes. So if the user removes the row as the new message tells them and presses Connect, the card still passes the cached row, mcpCustomGet returns 404 again, and they see the same message. Only the third press adds the provider. The comment at :561-562 says this case works, but it does not.
    Smallest fix: move the fresh read to the point of decision. In the 404 branch (or at the start of connect when existing is set), await queryClient.fetchQuery({ queryKey: ['mcp-servers'], queryFn: () => api.mcpServers(), staleTime: 0 }). If serverForConnection(provider, fresh) no longer finds a row, take the mcpCustomAdd path. Otherwise throw connect_hand_written_row.
    Then fix the test at website/src/test/ConnectionsPage.coverage.test.tsx:1758. Today mcpServers.mockResolvedValueOnce([row]) falls back to the [] default on the re-read fired at the 404, so the removal happens before the alert shows. Keep the row in the list through the first alert, return [] only after it, and assert that the next Connect reaches mcpCustomAdd.

Optional:

  • The message says every 404 is a row in "your own mcp.json", but the endpoint returns 404 for any row outside Kiro Crew's own scope. existing.presence could pick the right file or wording.
  • Add one test where mcpCustomGet rejects with new ApiError(500, 'boom'). It would pin the body's promise that other errors pass through unchanged.
  • The body's "What changed" and "Tests" sections do not mention the re-read or the second test. A short line in each would help.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: passed Eligible automated validation passed for the current revision labels Nov 17, 2026
@cruisercohen
cruisercohen force-pushed the fix/35817-connect-hand-written-row branch from 9481730 to f285520 Compare November 18, 2026 19:51
@cruisercohen

Copy link
Copy Markdown
Contributor Author

Thanks, you were right: the re-read ran at the 404 while the row was still there, so it re-cached it. Fixed on f285520 (the second commit now carries the fix; the first is unchanged).

  • website/src/pages/connections/ConnectionsPage.tsx:560-575: at the 404 the card now awaits queryClient.fetchQuery({ queryKey: ['mcp-servers'], queryFn: () => api.mcpServers(), staleTime: 0 }). If serverForConnection(provider, fresh) finds no row, Connect takes the mcpCustomAdd path in the same press; otherwise it throws connect_hand_written_row. The comment there now says why the read happens at the decision. The waiting card's kind follows the path actually taken.
  • website/src/test/ConnectionsPage.coverage.test.tsx › adds the provider on Connect once the user removes the hand-written row: the row stays in the list through the first alert, then the list empties and one more Connect must reach mcpCustomAdd (with mcpCustomGet called twice). On 4cee0f2 the second press hits the cached row and repeats the 404, so this test fails there.
  • Optional items: added passes any other stored-spec read error through unchanged (a 500 shows its own error and writes nothing), and the body's What changed and Tests sections now mention the re-read and both tests. I left the message wording for out-of-scope rows as is.

Vitest does not run on my host, so CI is the check for these tests.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 18, 2026
@cruisercohen
cruisercohen force-pushed the fix/35817-connect-hand-written-row branch from f285520 to 314d6b8 Compare November 18, 2026 20:06
@cruisercohen

Copy link
Copy Markdown
Contributor Author

Follow-up on 314d6b8 for the GPT 6.1 finding on f285520: when the user removes the global row, the gateway's rendered agent config still lists it until a restart.

  • website/src/pages/connections/ConnectionsPage.tsx:570-581: after the fresh read at the 404, if the row is held by no raw scope (every non-kirocrew presence flag is false), the card now asks the user to restart Kiro Crew and then press Connect. A row a raw scope still holds keeps the hand-written-row message, and no row at all still takes the add path.
  • Test asks for a restart when only the gateway's rendered copy still holds the removed row: shows the restart message and makes no add, update or mint call. It fails on f285520, which repeats the removal message.

So the copy-only case now asks for a restart. Skipping the restart would mean changing the backend collision rule: api_mcp_custom_add answers 409 for a name found in the rendered copy. I can do that as a separate follow-up if you want it; it is not in this PR.

@cruisercohen
cruisercohen force-pushed the fix/35817-connect-hand-written-row branch from 314d6b8 to 3487fb1 Compare November 18, 2026 20:27
@cruisercohen

Copy link
Copy Markdown
Contributor Author

Correction to my previous comment (issuecomment-6990145225): a restart does not clear the copy. The gateway's rebuild at boot starts from the existing rendered agent config, so the row survives a restart and Connect would show the same message again. Uninstall in MCP Servers does clear it: its purge strips the rendered copy as well as every scope (_purge_server_config in dashboard/handlers/mcp_config_purge.py). After that /api/mcp has no row and the add's name check passes.

Fixed on 3487fb1:

  • website/src/pages/connections/ConnectionsPage.tsx:570-582: in the copy-only case, the card now tells the user to press Uninstall on that entry in MCP Servers, then Apply, then Connect. It no longer mentions a restart. The string is updated in every catalog and en-XA is regenerated.
  • Test points to Uninstall in MCP Servers when only the rendered copy still holds the removed row: checks the Uninstall message, that no restart is mentioned, and that no add, update or mint call is made. It fails on 314d6b8, which shows the restart message.

Letting Connect handle this case without the Uninstall step would still need the backend collision-rule change. I can do that as a separate follow-up.

@cruisercohen
cruisercohen force-pushed the fix/35817-connect-hand-written-row branch from 3487fb1 to 4e62174 Compare November 18, 2026 21:11
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 18, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround. This head fixes the issue from my earlier review. One evidence gap still blocks merge.

Earlier review, item by item:

  • Re-read at the point of decision: fixed. The fresh fetchQuery with staleTime: 0 now runs inside the 404 handler, and a missing row takes the mcpCustomAdd path in the same press.
  • Test shape: fixed. The second test keeps the row in the list through the first alert, then empties it and checks that the next Connect reaches mcpCustomAdd.
  • Optional items: the 500 pass-through test was added, and the body now covers the re-read. You explained why you kept the out-of-scope wording.

Blocking:

  1. website/src/pages/connections/ConnectionsPage.tsx:578: no screenshot shows the new connect_rendered_copy_only error. Trigger: the row's presence flags are false for every scope except kirocrew, so Connect throws the "In MCP Servers, press Uninstall on ... and then Apply, then press Connect" message into the card's ErrorNotice. Outcome: this is the longest new user-facing string in the change, and no reviewer has seen it rendered. The two attached images show only the hand-written-row message. The UX lane names this as its evidence gap on this head. Its BLOCK was published as PASS only because the comment had no Trigger and Outcome lines, so the gap is still open. Smallest fix: attach a light and a dark screenshot from this head of the card showing this message, rendered the same way as the existing pair, then re-run the UX lane. No code change is needed.

PR Readiness is also red on Backend Tests (Windows) (8), in test/test_bare_session_handle_guard.py. This PR changes no backend or Python test file, so that red does not come from this diff. A rebase onto current main should clear it.

Optional:

  • In each translated catalog, connect_rendered_copy_only keeps the English tab name "MCP Servers". The tab itself is translated there (es "Servidores MCP", de "MCP-Server"). Using each catalog's nav.mcp_servers value would match what the user sees.
  • No test pins the kind: stored ? 'reconnect' : 'new' change. Pressing Cancel after the same-press add in the second test, and asserting mcpApply with uninstall: true, would catch a revert.

…4 so Connect adds the provider once the row is removed, or points to Uninstall when only the rendered copy holds it
@cruisercohen
cruisercohen force-pushed the fix/35817-connect-hand-written-row branch from 4e62174 to 23f0c1c Compare November 19, 2026 10:19
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 19, 2026
@cruisercohen

Copy link
Copy Markdown
Contributor Author

Thanks. Answered on head 23f0c1c (still 2 commits, rebased onto green main 910f01f).

Blocking:

  • Screenshot of connect_rendered_copy_only: done. A light and a dark still are now in the PR body under "Screenshots / video". They render the real catalog through the card's inline ErrorNotice, the same path as the existing pair, with the first-press message above for comparison. Fixture names only (provider Notion, server notion). They come from this head; the catalog text in them is the English value, which this push did not change.

Windows backend 8 (test/test_bare_session_handle_guard.py): rebased onto main 910f01f, which contains main's fix d032162. git range-diff shows both commits identical apart from the two optional items below.

Optional, both done:

  • Each translated catalog now names the tab by its own nav.mcp_servers value inside connect_rendered_copy_only (es "Servidores MCP", de "MCP-Server", and so on). The hi and bn strings keep the informal form, and the i18n suites pass locally (82 files, 1270 tests). en-XA regenerates unchanged.
  • The second test now presses Cancel after the same-press add and asserts mcpApply with [{ name: 'notion', uninstall: true }]. It fails when kind: stored ? ... is put back to main's existing ? ... (checked locally).

ConnectionsPage.coverage.test.tsx (99 tests), tsc and eslint pass locally.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 19, 2026
@cruisercohen

Copy link
Copy Markdown
Contributor Author

Follow-up: I replaced the two new stills so they carry the card's "Action failed:" wrapping, as the live card and the existing pair do (the UX lane noted the first versions dropped it). Same head 23f0c1c, same render path, message text unchanged.

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow-up. This head closes everything from my earlier reviews.

Earlier items:

  • Fresh read at the point of decision, and a test that keeps the row through the first alert: fixed on the previous head, and still in place here.
  • Screenshots of connect_rendered_copy_only: fixed. The light and dark stills in the body show the card's "Action failed:" wrapping, and the UX lane passed on this head.
  • Optional items: done. Each catalog now names the tab with its own nav.mcp_servers label, and the second test presses Cancel to pin kind: stored ? 'reconnect' : 'new'.

What I checked on this head: the 404 from GET /api/mcp/custom/{name} only means there is no row Kiro Crew stores itself. A message branch never writes or starts a sign-in. Errors other than a 404 pass through unchanged. The add path still hits the backend's 409 name-collision guard. The copy-only check matches how presence is defined. The four new tests each pin one branch and run deterministically. What I liked most: the decision runs on a fresh read, so a single Connect press does the right thing whether the row is still there, already gone, or left only in the rendered agent config.

Optional:

  • website/src/test/ConnectionsPage.coverage.test.tsx:1758 and :1784 use a test client whose default staleTime is already 0, so they would stay green if staleTime: 0 were deleted from the fresh fetchQuery. The shipped client uses Infinity. Mounting these two tests with queryDefaults: { staleTime: Infinity }, as ConnectionsPage.coverage.connect.test.tsx:407 does, would pin that option.
  • If a user edits the URL of the hand-written row instead of removing it, the fresh read finds no matching row and the add returns a generic "name already in use". Nothing is written. Before returning null, you could check whether fresh still holds a row named existing.name and show connect_hand_written_row in that case.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: action required A blocking check or review needs attention

Projects

None yet

Development

Successfully merging this pull request may close these issues.

a connections card's connect fails with 404 on a hand-written mcp.json row it owns

2 participants