Skip to content

test: 0.13 backport, let codex's own bubblewrap preflight decide its inner-sandbox branch (#37677) - #37865

Closed
jeeshofone wants to merge 102 commits into
kirodotdev:release/0.13.0from
jeeshofone:backport/0.13-37677-codex-bwrap-preflight
Closed

jeeshofone wants to merge 102 commits into
kirodotdev:release/0.13.0from
jeeshofone:backport/0.13-37677-codex-bwrap-preflight

Conversation

@jeeshofone

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The two codex inner-sandbox contract tests stop failing Real Adapter Contract Tests on release/0.13.0 pull requests.

Backport onto release/0.13.0 (base b50ca01235). One commit, made with git cherry-pick -x of main's f89e02dba8 (#37677). It applied with no conflict and nothing was hand-resolved.

On the release branch, test_real_codex_acp_git_status_runs_inside_its_own_sandbox and test_real_codex_acp_network_runs_only_when_crew_allows fail with exit=0 assertion errors: codex runs both steps, but the test expects codex's bwrap: refusal. Seen on #37831 and #37819.

Why it matters

Every release/0.13.0 pull request routed to such a runner shows a red Real Adapter Contract Tests check that its diff cannot fix, which hides real adapter regressions on the release branch.

Not a goal

What changed (motivation → approach → change)

The release branch's test decided "can this host build codex's sandbox?" from Crew's own userns probe first, and ran codex's bubblewrap preflight only when Crew's probe said yes. On a runner where Crew's probe is refused and codex's bubblewrap is allowed, the "no" skipped the check that would have said "yes". #37677 makes codex's own preflight decide whenever it gives a verdict, with Crew's probe as the fallback, and writes the rule into testing-conventions.md, the writing-tests skill, AUTOSDE.yaml and the real-adapter-contract row of docs/ci/ci-and-reviews.md.

Cherry-pick only. Every added and removed line matches main's commit. The only difference from main's patch is one unchanged context line in docs/ci/ci-and-reviews.md (the new-test-stability row, which on 0.13 lacks main's real_venv marker).

Backwards compatibility

Compatible: test-only and docs.

Removes nothing: no test, assertion, step or check is removed.

Tests

test/test_codex_inner_sandbox_approval.py on this head: 12 passed, 8 skipped (the live tests skip without codex-acp installed). pre_push_gate.py --base release/0.13.0: 24 ran, 0 failed. Semgrep with semgrep/ rules on the changed test file: 0 findings.

Proof: not provable -- test-only change

Manual verification

Read the failing Real Adapter job logs on #37831 and #37819; both show the two exit=0 assertions. This pull request's own Real Adapter lane runs the live tests.

Related Issues

Fixes #37863

Backport of #37677.

Sibling sweep

Siblings: none -- git log origin/release/0.13.0..origin/main on the test file shows #37677 is the only missing commit

Pattern harvest

Not generalizable: backport of already-reviewed changes

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

bolichen97 and others added 30 commits November 13, 2026 09:28
Start the 0.13.0 insider line on release/0.13.0. The three version
files declare 0.13.0-rc.1, as release.md asks of a release branch that
is cutting RCs, and the tag v0.13.0-rc.1 goes on this commit once it
merges.

CHANGELOG.md gains the 0.13.0 section, written once under its final
heading from the commits main took after the 0.12 branch point, less
the fixes 0.12.1 and 0.12.2 already shipped. The shipped 0.12.2 section
is already on main, so nothing else in the file changes.
…irodotdev#36536)

The local-destructive-rm-rf-root row matches its pattern anywhere in the
text, so `rm -rf /tmp/build && mkdir -p /tmp/build` was refused as a
deletion rooted at the filesystem root. Only the literal -rf spelling is
refused: -fr, -r -f and --recursive --force already pass on main, so the
row protected nothing for these paths and only pushed agents to respell.

The row now reads a view of the command in which the words of each plain
`rm` whose every operand is a direct /tmp/<name> entry are blanked. The
rm must be the unquoted program word (after kiro-cli's "Running:" title
prefix at most), every word literal (no $, glob, brace, paren, quote or
escape), no `--`, nothing glued on either edge (a backtick or paren
there lets bash add operands), and each operand exactly one component
under /tmp, so no folder on the way can be a symlink an earlier command
planted. Redirections stay in the text. Every other row, and the rm
floor for / and ~, still read the full text.

Four existing tests used /tmp/<name> as an always-refused example; they
now use /srv/<name> (or /etc), keeping what each test checks.

Replay of 25 recorded rm-row false positives: 17 now allowed; every
recorded true positive is still refused. No catalog regex changed.

Co-authored-by: Joe Guo <zejiangg@amazon.com>
(cherry picked from commit 3b22e33)
…is (kirodotdev#36538)

Co-authored-by: Joe Guo <zejiangg@amazon.com>
(cherry picked from commit e80a131)
…irodotdev#36603)

The KAS engine sends one extra model request at a session's first
prompt to title the session for kiro-cli's own session list. Crew
titles its chats itself and never reads that title, so apply_spawn_env
sets KIRO_DISABLE_SESSION_TITLE_LLM=true on both routes; an inherited
value wins.

Closes kirodotdev#35799

(cherry picked from commit 5275a5d)
…at (kirodotdev#36530)

Every chat starts Kiro Crew's own MCP servers, and each loads its tool
handlers right after its tool list. kirocrew-guide, kirocrew-mate and
kirocrew-cron imported all of kiro_crew.mcp_core for its HTTP verbs and
identity resolvers, which loads the whole core server: about 970
package modules and 90 MB per process, three times per chat.

The verbs (_send, _get, _post, _patch, _put, _delete) move to the
gateway owner, mcp_core_parts/gateway.py, beside the target resolution
they already used. mcp_core stays their import path and patch surface
through its mirror facade. The three servers import the verbs and the
identity resolvers from mcp_core_parts, so their handler modules load
about 310 to 430 package modules and never the core server. The listing
import-budget test now also bounds each small server's handler import.

The default agent's never-defer row also gains its six most used small
own tools (autonudge_stop, memory_recall, nothing_to_do,
search_chat_history, skill_search, wait), picked by how many default-
agent sessions called each at least once. A first use of one no longer
costs a tool-load model call. The row grows by 1,491 schema tokens; its
budget moves from 3,300 to 4,950.

(cherry picked from commit 5ea941c)
…irodotdev#36362)

While the official catalog is unreachable, or the listing is backing
off after a failed fetch, every store listing raised CatalogUnavailable
into a broad except that logged a full stack trace at WARNING. That is
an expected answer and it recurs on every listing, so the log filled
with identical tracebacks. Both listing paths had it: list_registry's
inventory, and the catalog-first listing's _catalog_installable_rows.

Catch CatalogUnavailable first at both sites and log through one
helper, official_catalog.log_unavailable: one WARNING line naming the
cause, the stack at DEBUG. Any other exception keeps its traceback at
WARNING, since that one is a bug, not an outage. The app-kit-platform
spec records the split.

(cherry picked from commit 62f35ec)
kirodotdev#36558)

The sweep that stops the app backends a gateway spawned is a dashboard
cleanup hook, and aiohttp runs cleanup hooks only after in-flight
requests drain (up to 60s). An open /api/logs stream holds that drain
past the 10s graceful budget, so the budget cuts the shutdown before
the sweep runs and os._exit leaves every backend and its sandbox
wrapper running under PID 1, still holding its port.

The exit path now runs the same sweep after the graceful shutdown,
before its hard exit. When the cleanup hook already ran, the tracking
table is empty and the sweep returns at once. Adopted backends stay
excluded, as before.

(cherry picked from commit ee81308)
…) (kirodotdev#36238)

* perf(crew): one scheduler for crew-workers reads: no overlap, capped, backoff, If-None-Match (Refs kirodotdev#36154)

A page that is hidden no longer re-reads the list, a re-read never cancels
or doubles one in flight, at most two list requests are out per origin so a
send always finds a free connection, slow answers widen the wait, and the
client sends the last ETag and keeps its cached list on a 304.

* fix(crew): crew-workers reads wait for a free slot; ETag read by lowercase name (Refs kirodotdev#36154)

A read over the cap now waits in a FIFO queue and reads fresh data instead
of resolving with the cached list, cold loads obey the cap too, and a
rejected read frees its slot. Header names are case-insensitive, so the ETag
is read in lowercase, which the untranslated-literal gate does not flag.

---------

Co-authored-by: kirocrew-agent <agent@kirocrew.local>
(cherry picked from commit db39373)
… write (kirodotdev#36534)

Co-authored-by: Joe Guo <zejiangg@amazon.com>
(cherry picked from commit ac45981)
…e prompt (kirodotdev#36593)

* perf(acp): record the process tree beside the start and the turn end

The runtime walked its process tree in front of the person three
times: after the initialize handshake, after session/new or
session/load, and at the end of every turn. On macOS that walk starts
a pgrep per process and a ps per pid, 352 ms with no servers and
954 ms with 64 on the first prompt alone, and 68 to 105 ms at the end
of each warm turn.

Only a kill or a teardown reads that record. So the spawn, every
session start and the shared runtime's turn end now start the same
guarded pass as a task, and every reader that signals or takes a kill
handle waits for it first: _kill_inner before it signals the root,
and refresh_process_tree before its own walk. The identity data and
its checks are unchanged; the record is written before anything acts
on it.

Part of kirodotdev#36582

* perf(kas): read the MCP config scopes once per agent projection

The KAS custom-agent projection asked mcp_server_muted_in_any_store
about each declared server, and each call re-read every MCP config
scope through the sensitive-path fence. Two loops did that per start,
so the projection grew with the user's servers: 214 ms with 30 servers
on Linux against 45 ms with none, and 359 ms with 64 on macOS.

Both loops now read mcp_scope_muted_aliases once and hand the set to
the predicate, through the same reader and patch seam. The answer per
server and the payload are the same.

Part of kirodotdev#36582

(cherry picked from commit aeb98eb)
…irodotdev#35590)

An app agent such as Mochi took a granted server's launch spec only
from its template, the Kiro global mcp.json and the managed servers,
so a server added on the MCP Management page, installed from a
registry or contributed by the edition was skipped with "no launch
spec found" while the app reported the policy applied. A built-in
app's grant now reads the default agent's own spec ahead of the
global file, the rebuild's merge of those sources with the store
winning a tie, and leaves out other apps' own servers. A
user-installed app writes its own grant file and no owner consent
covers what it names, so its grant keeps main's sources. A copied
entry that is muted is withheld: turned off, not yet consented, or a
secret:// reference the rebuild withholds.

Enabling an app, or re-installing an installed one from the registry
(how a registry-sourced app updates), wrote its <app>:<server> entries
into the agent spec and stopped, so on a harness that does not watch
the spec file a chat already open never got the change. These routes
now end with the step an MCP page write ends with, as update, disable
and uninstall already do; the enable decides it from the app's record
as it stands inside the lifecycle lock. A fresh install registers
nothing for the disabled record it writes, so it needs no step.

Closes kirodotdev#33020

(cherry picked from commit 712d24f)
…irodotdev#36194) (kirodotdev#36262)

A slot-detail page stops at 1.5 MB of serialized rows, cut from the old end;
the newest row is always sent, so a row over the budget goes alone and is never
dropped. next_before and has_more point at the first row actually sent. The
finished body goes through conditional_json_response: ETag/304 and gzip, no
change to the response shape.

Co-authored-by: kirocrew-agent <agent@kirocrew.local>
(cherry picked from commit b77f3df)
…odotdev#36550)

opencode 1.x keeps a saved session on the directory it was created in.
A session/load naming another cwd split the session across two of its
instances: approval replies went to the wrong one and were dropped, and
the MCP servers sent with the load (Kiro Crew's own tools) were mounted
where the model was not.

Add ACP_BACKENDS_CWD_BOUND_SESSIONS (opencode). When the stored cwd of
a member's saved session differs from the folder the chat now starts
in, the allocator does not hand the client the resume sid, so the start
opens session/new in the new folder and the conversation is replayed
as text. kiro-cli takes the cwd from each load and keeps native resume.

Fixes kirodotdev#35459

(cherry picked from commit a67f6ed)
…v#35510)

On a KAS main harness with no stored Kiro Crew sign-in, agents run on
kiro-cli's login. When the usage API refused that credential, the Kiro
account popup showed the passive "No active Kiro sign-in" notice, as if
nobody had signed in, with no error and no agent hand-off.

The usage reply now marks a refused credential with
credential_rejected, and the popup shows that state as the error
notice with the agent hand-off. A missing credential keeps the passive
notice, and a stored Kiro Crew sign-in keeps its own lapsed notice.

Closes kirodotdev#35483

(cherry picked from commit 94155a1)
…irodotdev#36818)

The shared reader behind the [AGENT SYSTEM PROMPT] block now takes
kiro-cli's systemPrompt spelling, expands $VAR and ~ in a file:// path,
checks the resolved path with the same rule the KAS reader uses, and
names a prompt file it cannot use in one WARNING. It reuses
acp/kas_prompt.py (spec_prompt, the new expand_prompt_ref) and
acp/kas_prompt_paths.py rather than copying them.

Co-authored-by: Joe Guo <zejiangg@amazon.com>
(cherry picked from commit 4c7a874)
…dotdev#29602)

Inside a memory-limited container /proc/meminfo reports the VM or node
the container runs on, so /api/system showed that machine's total and
free memory while spawn admission sized against the container's cgroup
limit. On an 8 GiB Fargate task with a 7.75 GiB container limit the
gauge read 15.4 GB total.

The cgroup walk admission uses now also returns the tightest limit
(_container_cgroup_reading). Session import's (limit, headroom) reader,
_cgroup_memory_bounds, drops its own limit loop and reads that walk, and
/api/system calls it, so the Linux memory figures are bounded by the
limit and the headroom under it. The agents slice stays out of the
gauge: it caps agent processes, not the machine.

(cherry picked from commit 848e002)
…nded (Refs kirodotdev#36194) (kirodotdev#36845)

Turn-end and reconnect refreshes (refreshSlot, warmSlotCache, switchSlot and
the pane hydrate all read the newest bounded page through api.chatSlotDetail)
now ask for a cursor (cursor=1) and echo it on the next read, with
If-None-Match set to the last ETag. A refresh that missed nothing gets a 304;
one that missed rows gets only the rows from since on. A cursor the server
rejects (400) or a delta that does not fit the held page is read whole.

A cursor-mode page is now cut by the same byte budget as a plain page, so the
dashboard's reads keep the bound from kirodotdev#36262.

warmSlotCache no longer reads the whole transcript when the count-matched
bound declines (legacy rows with no timestamp): it reads one clamp-sized page
and walks older pages, as refreshSlot and switchSlot do.

Co-authored-by: kirocrew-agent <agent@kirocrew.local>
(cherry picked from commit 714b0d5)
…ev#36829)

On KAS, a chat whose project has files in .kiro/hooks got the "hook
files in .kiro/hooks do not run" notice again on every new backend
session, so each reconnect, reload or restart added one more copy.

The chat now keeps a mark of the project folder and the sorted file
names, the way the KAS telemetry notice does, and saves it on the
chat's metadata line. The notice shows again only for another folder
or another set of files.

Closes kirodotdev#36821

(cherry picked from commit 911bde8)
…ev#36207)

With Kiro CLI saved as the harness on a computer where Kiro CLI runs
on Kiro Agent, the Kiro CLI row in Settings > Agent Harness said "New
sessions switch from Kiro Agent to Kiro CLI." and showed a "Use Kiro
CLI" button. The button saved the value that was already saved, so
nothing changed and the panel showed the same two lines again.

The row now shows no button in that state and says that Kiro CLI runs
on Kiro Agent. Every other row keeps its button, and so does the Kiro
CLI row when Kiro CLI does not run on Kiro Agent.

Closes kirodotdev#36170

(cherry picked from commit ecf7d56)
…kirodotdev#36069)

A shared MCP server that waits for an approval showed nowhere outside
the MCP Servers page, so a pause could go unseen for days. The Customize rail
row and its MCP Servers tab carry the count of such servers, read by
the shell from the same status query the servers list's notice uses;
the tab's label is a plural catalog key. The gateway
records a refusal when it starts, so the socket's connect handler marks
that read stale and the shell's own poll runs only every five minutes.

The paused row's hint compared the approved and the new command lines
as lists. One line is drawn per launch, so one program listed twice
before and three times after read as a changed command although only
its env differed. The lines are compared as a set, and the env hint
says the program is the same and only its environment variables
changed. A line that carries a redaction tag never reads as the same
program.

(cherry picked from commit 21b6680)
…odotdev#36756)

The harnesses AcpClient starts directly (claude, OpenCode, goose, pi,
Copilot, DeepSeek) do not go through the runtime's retrying spawn factory,
so a CreateProcess refusal with winerror 5 or 1260 reached the chat as a
generic error. The shared launch tail now marks such an error at process
creation, naming the binary; ensure_ready keeps its one retry and then
raises the existing AcpSpawnBlocked for a marked error only, so the chat
shows the policy card. An access denied after the process started (a file
cleanup) is not marked and is unchanged. Detection only: nothing changes
how or whether the binary is started.

Co-authored-by: Joe Guo <zejiangg@amazon.com>
(cherry picked from commit 0b32483)
…ng (kirodotdev#36819)

On a host whose ceiling came from central distribution, KAS-managed MCP
children exited before MCP initialize ("Connection closed"): the sandbox
masked policy_cache, so a cache-only child found no ceiling.

The sandbox's existing read-only cache lift (enterprise_policy_cache_view)
now applies when central_ceiling_installed(), not only in an LTS build, and
keeps its refusals. The gateway derives the cache-only markers
(policy_cache_only_env) for the harness env, managed MCP declarations, the
KAS projection and the discovery probe. A cache-only child accepts a
source-less distribution block.

Closes kirodotdev#36775
Supersedes kirodotdev#36710

Co-authored-by: Joe Guo <zejiangg@amazon.com>
Co-authored-by: Pedro Evangelista <pedro.evangelista@mindera.com>
(cherry picked from commit 918a1c8)
…#36913)

The MCP page's sharing card hid its whole memory row whenever either
figure was missing. With sharing off no stub runs, so "with sharing"
has no stub price and is null, and the row vanished exactly when the
reading of what MCP servers use now matters most.

"Using now" now shows whenever it was read, on its own. "With sharing"
and its arrow show only when that figure was read too. No placeholder
stands in for a missing figure.

Part of kirodotdev#36884

(cherry picked from commit ed9d0b0)
…kirodotdev#36586)

While config.json has a change made outside Kiro Crew pending review,
every trust write the built-in adoption APPLY pass makes is refused
with PendingEditBlocksSave. The pass caught it as an unexpected error
and logged a full traceback at ERROR for each pinned app on every
boot, although nothing is wrong: the built-in keeps running and the
staged ledger is retried at the next start.

Treat that refusal as the expected state it is. The pin's outcome is
waiting_for_review, its ledger is left untouched, and the pass logs one
warning naming the pending file and every waiting app, with each trace
at DEBUG. Recording the legacy nav of an already adopted app waits the
same way, at DEBUG only.

Part of kirodotdev#26967

(cherry picked from commit 4579388)
A Bot's chat is a ChatPane, whose replies go through the shared bubble
(renderAssistantBubble). That bubble passed meta.redactions but never
meta.blocked_links, so a removed link stayed as its raw
"[REDACTED: suspicious URL to <host>]" text: no chip, no card, no
"Allow for this host". The bubble now passes the records on the same
local-slot rule as the lock tags, so a window drawing another gateway's
rows keeps the plain text and what can be allowed does not change.

After Allow or Undo, the chat page reloads only the slot it shows. A
pane now re-reads its own slot on the same event, so the restored link
replaces the chip in a Bot's chat too.

Closes kirodotdev#36862

(cherry picked from commit 8c58e18)
…ts (kirodotdev#31546)

A provider marks its one-run work directory (cron_<job>_<run>, subagent_<id>,
...) once, in start(), and its shutdown reclaim removes it. A runtime started
or resumed again for the same session after that reclaim -- a failed resume
that starts fresh, a killed runtime that respawns -- handed KAS a deleted cwd.
Node's spawn reports a missing cwd as "spawn <command> ENOENT", so every
managed MCP server failed naming a binary that exists, e.g.:

  KAS managed MCP initialization failed: kirocrew-cron: failed
  (spawn .../python3.12/bin/python3.12 ENOENT)

Defense in depth:
- Prevent: on the unbound (non-macOS) path, _session_work_dir re-creates a
  missing directory whose name has a one-run shape and whose parent is the
  workspace root, through mark_run_dir, so the reclaim and the sweep see the
  same provenance. A one-run name anywhere else is never created, only
  logged. Any other cwd skips the check and its thread hop, so a chat or
  title start reaches the admission gate in the same order as before.
  Errors are swallowed; the guard never adds a start failure.
- Diagnose: a managed MCP readiness failure with ENOENT names the
  session cwd when it no longer exists.

Docs: acp-client.md run work directory section.

Co-authored-by: Ray Xu <buluoray@gmail.com>
Co-authored-by: RAVI KUMAR <14358622+kingravi17@users.noreply.github.com>
(cherry picked from commit d1f38d7)
…otdev#36761)

The Agent Harness detail for an absent harness showed its install
command bare. For OpenCode that is `npm i -g opencode-ai@1`, and on a
host without Node.js it fails with "npm: command not found" while the
card never says that npm comes with Node.js. Several other harnesses
send an `npm i -g` command too.

AgentInstallDetail now adds one muted line under an install command
that starts with `npm `: the command needs Node.js and npm on the
gateway host, with a link to the Node.js download page. A curl
installer or an empty command gets no line. The component backs both
Settings > Agent Harness and the first-run agent picker, so both get
the line. The new key is translated in every shipped catalog.

Closes kirodotdev#36377

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 5317def)
buluoray and others added 14 commits November 14, 2026 22:27
…irodotdev#35002)

A user in Normal mode had no dashboard way to stop the prompt for one
MCP tool; the only path was a hand-written KAS permissions.yaml that
also skips Kiro Crew's gate.

Add an "Always allow" toggle beside each tool in Customize ->
Connections -> MCP Servers and an "Always allow this tool" row in the
approval card's Trust menu. Both write the identity-keyed
hooks.auto_approve_tools entry @server/tool through the endorsed config
writer and wait for the watcher, so the next call uses it with no
restart. The grant is answered by the gate's operator-grants tier after
every deny rule and governance check, so all floors still win.

No grant for wildcards, kirocrew-* servers, app or Connection servers,
a server a confirm_tools pattern covers, or while config.local.json
sets the list; the controls show the reason. The card grants only the
ref the server stamped on the pending card, and every write is
owner-only.

Part of kirodotdev#34936

(cherry picked from commit 515f704)
…rodotdev#36903)

The ssh-to-self floor read a backtick or $( inside a single-quoted
argument as a live command substitution. Bash keeps that text as
plain characters, so a PR body or commit message that quotes an ssh
example in Markdown code spans was refused although nothing runs.

The shared payload walk now reads substitution openers with the
quote state the shell uses: one inside '...' or $'...' opens no
nested frame. Double quotes, unquoted text, sh -c and eval scripts,
and heredocs a shell runs still open one, so every real refusal
stays. The catalog pattern row is unchanged.

Closes kirodotdev#36887

(cherry picked from commit 3397952)
…ev#36395)

* feat: add kirocrew models to list the names --model accepts

`kirocrew chat --model`, `cron add --model` and `agent.model` take a
model name, but the only place to learn the valid names was the
dashboard picker, and a script could not ask at all.

`kirocrew models` prints the configured backend's models from the
running gateway's own /api/models answer (the picker's list, with its
catalog cache and entitlement narrowing), each with its exact --model
string, label and a marker on the configured default. `--json` prints
the same for scripts, and `kirocrew models NAME` says whether a name
is valid and suggests the closest names when it is not, exiting 1.
A signed-out backend or an unavailable list is reported and exits 1.

Fixes kirodotdev#36039

* fix: admit the kirocrew models secret send on /api/models

`kirocrew models` sends only X-Internal-Secret from loopback, but
/api/models was in neither internal path set, so token auth refused it
with "Token required" on every run. Add it to the mixed set beside the
picker's cookie path; a non-loopback request still needs the cookie.

Also stop inviting a retry for a 503 that a retry cannot clear, and
read the bundled KAS engine's sign-in code as signed out.

(cherry picked from commit 3bdb64a)
…odotdev#36352)

Where the Linux sandbox seals the settings files, an edit made outside
Kiro Crew is held for review and every ordinary save of that file is
refused until the owner applies or discards it in Settings > Security.
A gateway without the dashboard (--slack-only) had no way to do that.

kirocrew config pending lists each held file with its changed keys and
the exact apply/discard command for the version shown; apply and
discard run the Settings routes' own writer (resolve_pending), refuse
any other version, refuse inside an agent sandbox and audit to SEL.
The refusal sentence and the load warning name the command.

The command writes from a second process, so the ordinary
denied_commands.json and computer_use.json saves refuse a held file
before they read it: a dashboard save can no longer read the old copy
and publish it over an Apply that landed from the terminal.

Closes kirodotdev#31817

(cherry picked from commit 872fc44)
…he newest (kirodotdev#36608)

When one live skill has several pending updates (ones queued before the
one-per-skill replacement existed, or edited after queueing), approving
any of them moves the live skill past the others' base, so the server
refuses them afterwards and they had to be dismissed one card at a time.

The pending panel now orders updates for the same target by created_at.
A card with a later update queued shows "Newer update exists". An
approvable update card with older ones queued names them under an
unchecked "Also dismiss N older updates to <skill>" box; when checked, a
successful approval is followed by one dismiss-all call with exactly
those slugs. Approve itself, its checks and the server routes are
unchanged, and a refused approval dismisses nothing.

(cherry picked from commit 80ed0f0)
The crew feature's final product name is conductor mode. Every
user-facing place that said Ultra Mode says conductor mode: UI strings
in all locales (kept untranslated), settings labels and their generated
search entries, gateway notices, agent prompts and skills, shipped docs,
specs and the feature map. Code names that carried the old name
(components, CSS classes and tokens, test ids, i18n keys, tests, capture
harnesses) follow it, with a ConductorMode / conductor_mode /
conductor-mode stem so they never collide with the existing conductor
agent-role names.

Saved state keeps working: ids that never said ultra stay (crew_mode,
dashboard.new_chat_crew_mode, mc-preview-crew-mode), the ultra_mode_only
refusal code and the ultra root_kind trace value keep their spelling, and
a transcript that stored the old agent-switch notice still renders as
that notice. A new decision entry records the rename and maps the
earlier entries to the new name; those entries stay as written.

Hand-resolved backport; original author: Bolin Chen.

(cherry picked from commit 176820c)
Ultra Mode only ever lived behind the default-off feature preview, so
no old spelling needs to keep working. Rename the four names the first
rename kept: the remote-dispatch refusal code is conductor_mode_only,
the config key is telemetry.traces_conductor_mode, and the trace
root_kind value and round trace kind are conductor_mode, with spans
named "conductor_mode round N" and "conductor_mode outcome ...".

Drop the compatibility code: the gateway notice no longer matches the
stored "Ultra Mode" agent-switch wording, and the comments that said a
value keeps its old spelling are gone. Title Case labels write the name
in lower case too ("Start New Chats in conductor mode"). A new decision
entry records both, superseding part of the entry that named the
feature.

Hand-resolved backport; original author: Bolin Chen.

(cherry picked from commit 36a018f)
…ename

The rename changes the text of the two conductor agent specs and of
_CONDUCTOR_SYSTEM_PROMPT. Main re-pinned the same pins in kirodotdev#36924, but
release/0.13.0 builds those specs from its own prompts, so its digests
differ from main's. Only kirocrew-conductor.json and
kirocrew-ledger-conductor.json change; every other pinned spec keeps its
bytes.
…y destination (kirodotdev#22397, kirodotdev#37183) (kirodotdev#37471)

Backport to release/0.13.0 of three main commits, picked with
git cherry-pick -x in main's merge order and squashed into one commit:

- kirodotdev#22397 (e58c25a): record local usage
  metrics by default, with disk caps and a CLI notice. Existing opt-outs
  are kept: heartbeat off with telemetry.enabled unset, telemetry.enabled
  false (quoted and non-bool values included), KIROCREW_TELEMETRY=0,
  DO_NOT_TRACK=1.
- kirodotdev#33422 (ffd2339): RFC update,
  telemetry.enabled now defaults to true. Docs only.
- kirodotdev#37183 (c1222b9): the public build sends
  the reviewed PRODUCT_METRICS list to Kiro telemetry once privacy notice
  v3 has been shown; notice v3 names it; the OTLP exporter becomes a base
  dependency.

Hand-resolved for 0.13: in docs/guides/telemetry-otlp-export.md the intro,
the telemetry.enabled row and the collection/egress paragraph take the
pick's text, and 0.13's own text is kept elsewhere. The pick's one-line
additions to config_all_settings.py and its test are left out: the All
settings page is not on 0.13.

Also fixes the settings help for telemetry.enabled and beacon_enabled and
the TelemetryConfig docstring, which said default recording sends nothing
off the machine, and regenerates config-baseline.json.


(cherry picked from commit e58c25a)
(cherry picked from commit ffd2339)
(cherry picked from commit c1222b9)

Co-authored-by: Raymond Chen <chenmingwei23@users.noreply.github.com>
…on-head)

The Source Gates "Lint documentation trees" step fails on release/0.13.0
itself, so every 0.13 backport PR goes red on it.

- Link 2026-11-13-the-crew-mode-feature-is-named-conductor-mode.md from
  docs/decisions/README.md with main's index row.
- Bring docs/request-for-change/rfc-kas-session-head-in-agent-prompt.md
  from main (kirodotdev#36964) and its README index row. session_head.py, its test
  and three docs on the branch already cite it.

Docs only; no code changes. scripts/docs-lint.sh passes on the result.
…dotdev#37451, kirodotdev#37530, kirodotdev#37539

Two backend tests on release/0.13.0 were red for reasons main has
already fixed in test-only commits:

- test/tracing/test_tracing_otlp.py expected four spans, but kirodotdev#37005
  (already on the branch) adds kirocrew.step. Cherry-picked kirodotdev#37171
  unchanged.
- TestSelfModuleIndexIsLinear failed three runs in a row on the 0.5 s
  budget (0.522 s, 0.511 s, 0.509 s). Took main's end state of
  test/test_denied_commands_security_cost.py and
  test/denied_commands_security_helpers.py, which carries kirodotdev#37451 (min of
  five readings), kirodotdev#37530 (tracer paused) and kirodotdev#37539 (count work, not CPU
  time), plus the kirodotdev#37539 hunk of
  docs/system-specs/common/testing-conventions.md. The picks conflict
  one by one because the file also carries kirodotdev#28293, a test-only change.

No src/ changes.

(cherry picked from commit 6de8528)
…k runner (kirodotdev#37653) (kirodotdev#37818)

Playwright 1.58.2 has no ubuntu26.04 host entry, and kirocrew-linux-4-core
now boots ubuntu-26.04, so every fork PR's E2E, render benchmark and i18n
render gate fail at 'npx playwright install chromium'. On that image only,
set PLAYWRIGHT_HOST_PLATFORM_OVERRIDE to the ubuntu24.04 build and carry it
through GITHUB_ENV to the steps that launch the browser.

Part of kirodotdev#37647.

(cherry picked from commit b5ac843)

Co-authored-by: Bolin Chen <bolichen@amazon.com>
@jeeshofone
jeeshofone requested review from a team and KiroCrewCaptain as code owners November 16, 2026 07:01
@jeeshofone
jeeshofone requested review from bolichen97 and removed request for a team November 16, 2026 07:01
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention labels Nov 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ⏭️ skipped

Revision f69b40580af5be97d44f5520fc38a4d812057e86 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of f69b40580af5be97d44f5520fc38a4d812057e86 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Clean cherry-pick of main's reviewed #37677: the test now asks codex's own bubblewrap preflight with the binary codex runs. It is test and docs only and easy to revert.

Notes

  • The rewritten test_no_bubblewrap_or_no_userns_runs_no_preflight was an old pin, but it pinned an ordering, not a behaviour. The PR names the measured cause for reversing it (the ubuntu-26.04 EPERM against NET-200), so it doesn't trip the pin-reversal trigger.

[DESIGN-REVIEWED] f69b405

Description read

[DESCRIPTION-READ] f6f28db1c32b619d472a05f42a0eb18d37df19cb7c2b5704c08b19cc4ad4c45f

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ✅ PASS

Premise-level review of f69b40580af5be97d44f5520fc38a4d812057e86 via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

This is a clean cherry-pick of #37677. It fixes the cause: Crew's userns probe could veto codex's own bubblewrap preflight, and now codex's preflight decides. The one reversed pin is explained in the description with a measured runner case.

What this change ships

Inventory (6 items) — 6 justified

Intent: stop the two codex inner-sandbox live tests from failing Real Adapter Contract Tests on release/0.13.0 pull requests. This is a FIX.

  1. Codex's own bubblewrap preflight now decides which result the live test requires, even when Crew's userns probe says no — justified
  2. Crew's userns probe answers only when the preflight finds no bubblewrap or fails for a reason that is not a known host refusal — justified
  3. The replaced pin test_no_bubblewrap_or_no_userns_runs_no_preflight is now "no bubblewrap" only, and the description gives the reason — justified
  4. A new unit test covers the ubuntu-26.04 case: Crew's probe says no and the preflight passes; the refusal test now runs with both probe answers — justified
  5. The rule is written into testing-conventions.md, the writing-tests skill and AUTOSDE.yaml rule 13 — justified
  6. The real-adapter-contract row in ci-and-reviews.md now describes the new probe order — justified

[FIRST-PRINCIPLES-REVIEWED] f69b405

Description read

[DESCRIPTION-READ] e79cce395bd7ddf220e4ca0a2f3cf13b8e4dfff804bd6e79de2f48afad24620a

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed f69b40580af5be97d44f5520fc38a4d812057e86 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] f69b405

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed f69b40580af5be97d44f5520fc38a4d812057e86 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] f69b405

@jeeshofone

Copy link
Copy Markdown
Contributor Author

The release line was re-cut onto main at 91aa0e1 (2fae50a, 0.13.0-rc.2), which already includes #37677 (f89e02d). This backport is no longer needed, so I'm closing it. The branch stays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.