Repository navigation
feat(claude): show child thinking, grandchildren, title and hints - #37870
KiroCrewCaptain wants to merge 1 commit into
Conversation
Sensitive Change ReviewSensitive files changed:
|
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS The blind read was unavailable: all six screenshots were admitted, but the first pass stopped before describing any of them. Re-run this workflow to get a comprehension read of the hint, thinking and nesting surfaces. Evidence gaps
Notes
[UX-REVIEWED] 3dd5eff Description read[DESCRIPTION-READ] d59bd065fa71b962fab56f14c26e73f91ab1f789a04a0702293350a79885fa8e That sha256 names everything this verdict read: the PR description, plus the 9 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: each reader is gated on its own claude-only Notes
[DESIGN-REVIEWED] 3dd5eff Description read[DESCRIPTION-READ] 18ea0022e023ff1a1c61c690b071833e2d0fab4446d3a53098e402374308d287 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. All four readers are new, run only on the claude backend ( Not checked: the claude-agent-acp 0.107.0 What this change shipsInventory (8 items) — 7 justifiedIntent: let a person on the Claude backend see the rest of what Claude Code sends (child thinking, grandchild agents, the session title, command argument hints). ADDITION; it closes #37141's remaining half.
[FIRST-PRINCIPLES-REVIEWED] 3dd5eff Description read[DESCRIPTION-READ] ed81901ab2853380323c71e28818b73d5f8184c3d9663192de78b934c4107f18 That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
8365d6f to
89b2ab5
Compare
Sensitive change review
|
On agent.acp_backend = "claude" the dashboard still dropped four things claude-agent-acp sends (the second half of #37141): - A native Agent-tool child's agent_thought_chunk now becomes EVENT_SUBAGENT_THINKING and streams to that child's Subagents card as a collapsed reasoning block (subagent_thinking, stream-redacted per card, ephemeral like chat_thinking). - A Crew subagent running on claude now draws the Agent-tool children and Workflow agents its own session starts as one-level nested cards under its card (native:<run>:<child>), with Stop routed to the run's own client, reconnect replay, and close-before-done on every terminal path. Crew depth, counting and approvals are unchanged. - session_info_update.title replaces only Crew's own echo fallback title after Crew's chat_done chain; a model, user, member, pinned or fork title is never replaced. - An available_commands_update command's input.hint reaches the composer's / menu, bounded where the command list is stored. Each reader is gated on a new positive ACP_BACKENDS_* set. Picking a Claude Code custom agent stays unoffered: a switch can apply an agent definition's permission mode, MCP servers and hooks, which Crew does not observe mid-session; the spec records why.
89b2ab5 to
3dd5eff
Compare
Sensitive change review
|
|
This changes behaviour users already rely on, so it needs a design sign-off from a maintainer before it can merge. A maintainer will post the decision here. Review result on this head: no blocking findings. Child thinking, slash-command hints and the echo-only title adoption fit groups (5) and (6) of the decision recorded on #37141. The grandchildren part is different. It covers run child cards, the root-tab relay, Stop routing to the run's client, the What the review checked: every new reader sits behind a positive claude-only Optional:
|
Problem / Motivation
Goal: On the Claude backend, the dashboard shows the rest of what claude-agent-acp sends: a native child agent's thinking on its card, the agents a Crew subagent starts under that subagent's card, the session title Claude Code generates, and each slash command's argument hint.
Closes #37141's remaining half. #37512 shipped the first half. These four were still dropped on
agent.acp_backend = "claude":_child_textreturns""for thought chunks)EVENT_SUBAGENT_LIST/EVENT_SUBAGENT_ACTIVITY)session_info_update.titleavailable_commands_updateinput.hint_note_advertised_commands; the/menu shows no argument syntaxWhy it matters
A person running Crew on the Claude backend cannot see what a child agent is reasoning, cannot see or stop the agents a Crew subagent starts, and gets a sidebar title that just repeats their first message whenever Crew's own title call fails. The
/menu lists Claude Code's commands without saying what arguments they take.Not a goal
agentconfig option). A switch replaces the main-thread persona and can apply the agent definition's permission mode, MCP servers and hooks, which Crew does not observe mid-session. Crew keeps not reading or writing it; the spec records why.chat_thinking).toolNameas a trusted identity, prompt suggestions, image bytes in tool results, ACP v2: still out of scope, as in Claude backend: show the ACP surfaces the dashboard drops (Workflow agents, background tasks, checklist, retries, images, mode) #37141.What changed (motivation → approach → change)
Each gap had the same root: the frame reached
AcpClientand a reader dropped it. Each fix adds one reader behind its own positiveACP_BACKENDS_*set (claude only) on the seam the Kiro path already uses, and nothing Crew trusts or auto-approves changes.acp/native_child_thinking.pyturns a tracked child'sagent_thought_chunkintoEVENT_SUBAGENT_THINKING(ACP_BACKENDS_NATIVE_CHILD_THINKING).chat_turn/native_cards.pystream-redacts it per card (redactors capped atNATIVE_CHILD_ROSTER_CAP, overflow counted and logged) and sendssubagent_thinking {id, slot, text}to subagent subscribers. The card shows it in the existingThinkingBlock, collapsed, above Output, capped at 20k characters client-side. Never persisted or replayed, likechat_thinking.subagent_manager/native_child_cards.pygives a claude Crew run (ACP_BACKENDS_RUN_NATIVE_CHILD_CARDS) its own bounded tracker (64 cards) fed through the chat's own reconcilers, with idsnative:<run>:<child>.dashboard/run_native_card_relay.pyrelays the four card frames into the root tab. Stop goes to the run's ownAcpClientand ends the run's wait on that child's pending approval; a run's terminal path closes its open grandchild cards before its ownsubagent_done; reconnect replays them. The Subagents panel indents them one level under their run (website/src/utils/subagentNesting.ts). Crew depth, counting, continuation and approvals are unchanged: grandchildren are display-only.acp/harness_title.pykeeps the session's own latestsession_info_update.title(256 characters, control characters spaced, redacted). After Crew's wholechat_donetitle chain,dashboard/chat_title_harness.pyputs it in place of the title only when that title is exactly Crew's echo fallback and the candidate passes Crew's own title validator (ACP_BACKENDS_SESSION_TITLE). A model, user, member, pinned or fork title is never replaced;chat_title.pyandchat_send.pyare untouched.client_transport.bounded_commands, the command-list bound main already has, now also keeps each command'sinput.hint(stripped, scrubbed, cut to 160 characters; no key when absent). The/menu shows the hint as muted text on the chat's own session rows only, onAcpClientand on the shared runtime alike.claude-code-provider.mdsays why, and a pin test checks Crew never writes config idagent.Specs updated in the same commit: claude-code-provider, acp-client, subagent, harness-parity, harness-onboarding, learn-cron-dashboard, history.
Backwards compatibility
Compatible: every reader is new and gated on a claude-only set; other backends take exactly main's paths. A stored command row gains an optional
hintkey; readers that do not know it ignore it.Removes nothing: no key, route, frame, row or bound is removed or tightened.
Tests
New:
test_acp_advertised_command_rows.py,test_claude_session_title.py,test_chat_title_harness.py, native-child thinking and run-card tests,SlashCommandMenu.hint.test.tsx,ActivityViewer.thinking.test.tsx, subagent nesting tests. Locally on the head: the related backend set (8252 passed), tsc clean, 88 related vitest files (1314 passed); black, isort, flake8, mypy, file-line cap, agent-sdk boundary, comment history, brand name and harness parity all pass.Proof: not provable -- other: four features; each new test asserts a frame or row main never produces
Manual verification
Live smoke on an isolated pod (claude backend, claude-agent-acp 0.107.0): pending. One scenario script per gap is ready; results will be posted as a PR comment.
Screenshots / video
Rendered from the real components with fixture data through the repo's capture harness (
website/capture/, vite + Playwright, loopback only).The
/menu: session commands with an argument hint (/loop,/debug) beside rows without one.A native child card: its reasoning collapsed above Output, then expanded.
Grandchild cards indented one level under the Crew subagent run that started them; the next run is back at the top level.
Related Issues
Closes #37141
Checklist
Contribution License Agreement
Contributed under the project's Apache-2.0 license.