Repository navigation
test: drop the shared_scratch keyword #37826 removed from ChatRuntimeKey - #37945
Conversation
#37615 added test_claude_leaves_each_per_session_field_out_of_the_key with shared_scratch=None in the ChatRuntimeKey.build call. #37826, cut before #37615 landed, removed that keyword-only parameter, so on main the test's five cases raise TypeError and red every backend run. Drop the keyword from the test's base arguments. The key no longer carries the scratch directory at all, which is what #37826 intended.
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this is a one-line test fix that brings the call in line with the [DESIGN-REVIEWED] 8f2da54 Description read[DESCRIPTION-READ] 3f29cdec7545448ded259b9e259c60ecc53163fd33b267e112b5b55612a53dae That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Problem / Motivation
Goal: Main's backend test runs go green again after #37826 removed a keyword a test written in parallel still passes.
test/test_chat_runtime_tree_sharing.py::test_claude_leaves_each_per_session_field_out_of_the_key(added by #37615) builds aChatRuntimeKeywithshared_scratch=None. #37826 was cut before #37615 landed and removed that keyword-only parameter fromChatRuntimeKey.build. Both merged, so on main 93511d9 all five parametrized cases raiseTypeError: ChatRuntimeKey.build() got an unexpected keyword argument 'shared_scratch'.Why it matters
Every PR's backend shard that collects this file is red until main is fixed, and Coverage Gate fails closed with it.
Not a goal
ChatRuntimeKeyor what the key carries; fix(acp): share a chat runtime by session tree, not by recorded scratch directory #37826's design stands.What changed (motivation → approach → change)
Symptom: five
TypeErrorfailures on main. Cause: a semantic merge between #37615 (adds the call withshared_scratch=None) and #37826 (removes the parameter). Change: drop the oneshared_scratch=Noneline from the test's base arguments, which matches the key #37826 intended (it no longer carries the scratch directory).Backwards compatibility
Compatible: test-only, one line removed; no product code changes.
Tests
python -m pytest -n0 test/test_chat_runtime_tree_sharing.pyon main 93511d9: 5 failed, 44 passed. With this change: 49 passed. flake8 clean.Manual verification
N/A: test-only change.
Screenshots / video
N/A: no user-facing change.
Related Issues
Follow-up to #37826 (Refs #37816) and #37615.
Sibling sweep
git grep -n "shared_scratch=" origin/main -- testfinds no otherChatRuntimeKey.buildcall passing the removed keyword; the remaining hits set a_shared_scratchattribute on test doubles, which #37826 kept.Pattern harvest
Two PRs that each pass alone can red main when one removes a parameter the other starts using. Nothing new to add to the conventions: CI on the second PR ran against a base that did not have the first.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the project's Apache-2.0 license.