Skip to content

test: drop the shared_scratch keyword #37826 removed from ChatRuntimeKey - #37945

Merged
bolichen97 merged 1 commit into
mainfrom
fix/main-red-tree-sharing-kwarg
Nov 16, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
fix/main-red-tree-sharing-kwarg

Conversation

@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

Problem / Motivation

Goal: Main's backend test runs go green again after #37826 removed a keyword a test written in parallel still passes.

test/test_chat_runtime_tree_sharing.py::test_claude_leaves_each_per_session_field_out_of_the_key (added by #37615) builds a ChatRuntimeKey with shared_scratch=None. #37826 was cut before #37615 landed and removed that keyword-only parameter from ChatRuntimeKey.build. Both merged, so on main 93511d9 all five parametrized cases raise TypeError: ChatRuntimeKey.build() got an unexpected keyword argument 'shared_scratch'.

Why it matters

Every PR's backend shard that collects this file is red until main is fixed, and Coverage Gate fails closed with it.

Not a goal

What changed (motivation → approach → change)

Symptom: five TypeError failures on main. Cause: a semantic merge between #37615 (adds the call with shared_scratch=None) and #37826 (removes the parameter). Change: drop the one shared_scratch=None line from the test's base arguments, which matches the key #37826 intended (it no longer carries the scratch directory).

Backwards compatibility

Compatible: test-only, one line removed; no product code changes.

Tests

python -m pytest -n0 test/test_chat_runtime_tree_sharing.py on main 93511d9: 5 failed, 44 passed. With this change: 49 passed. flake8 clean.

Manual verification

N/A: test-only change.

Screenshots / video

N/A: no user-facing change.

Related Issues

Follow-up to #37826 (Refs #37816) and #37615.

Sibling sweep

git grep -n "shared_scratch=" origin/main -- test finds no other ChatRuntimeKey.build call passing the removed keyword; the remaining hits set a _shared_scratch attribute on test doubles, which #37826 kept.

Pattern harvest

Two PRs that each pass alone can red main when one removes a parameter the other starts using. Nothing new to add to the conventions: CI on the second PR ran against a base that did not have the first.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

#37615 added test_claude_leaves_each_per_session_field_out_of_the_key
with shared_scratch=None in the ChatRuntimeKey.build call. #37826,
cut before #37615 landed, removed that keyword-only parameter, so on
main the test's five cases raise TypeError and red every backend run.

Drop the keyword from the test's base arguments. The key no longer
carries the scratch directory at all, which is what #37826 intended.
@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 8f2da54cb8e32eb7ecb98b988638d548d112f283 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 8f2da54cb8e32eb7ecb98b988638d548d112f283 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 8f2da54cb8e32eb7ecb98b988638d548d112f283 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this is a one-line test fix that brings the call in line with the ChatRuntimeKey.build signature #37826 left behind.

[DESIGN-REVIEWED] 8f2da54

Description read

[DESCRIPTION-READ] 3f29cdec7545448ded259b9e259c60ecc53163fd33b267e112b5b55612a53dae

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 8f2da54cb8e32eb7ecb98b988638d548d112f283 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 8f2da54

Verdict parsed from the review's SHA-scoped output markers for commit 8f2da54cb8e32eb7ecb98b988638d548d112f283.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 8f2da54cb8e32eb7ecb98b988638d548d112f283 false-positive: <reason, 20 to 500 characters>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 8f2da54cb8e32eb7ecb98b988638d548d112f283 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 8f2da54

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 8f2da54cb8e32eb7ecb98b988638d548d112f283 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 16, 2026
@bolichen97
bolichen97 merged commit d2f22f2 into main Nov 16, 2026
95 checks passed
@bolichen97
bolichen97 deleted the fix/main-red-tree-sharing-kwarg branch November 16, 2026 12:19
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants