Repository navigation
test: expect the deny gate's depth cap to refuse a 128-deep ssh nest - #37972
bolichen97 wants to merge 1 commit into
Conversation
#37820 asserted that a 128-deep $( ) nest is named by the ssh floor's rule. #37875 then added a depth cap in the deny gate that refuses anything past 32 substitutions before any floor walks it, so the same command now comes back with the cap's reason. Each PR was green alone; together they turned main red and failed 11 PRs. The test still checks what it was written for: the gate refuses the nest and raises no exception. The ssh floor's own bound is still covered by the floor-level tests in the same class.
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: a test-only change that brings a stale assertion in line with the deny gate's depth cap added in #37875. The test's real job, refusing the nest without raising an exception, is still checked. [DESIGN-REVIEWED] aeffaf0 Description read[DESCRIPTION-READ] 67be0640cccf73d132d2477546e5d1f888c8a8da3361da7c3fbee938435beac9 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
main is red on
test/test_denied_commands_security_ssh_self.py::TestSshFloorNestingDepth::test_the_gate_refuses_a_nest_past_the_bound_without_an_exception(11 PRs failed, e.g. https://github.com/kirodotdev/KiroCrew/actions/runs/43869438393/job/133309772408).Cause: a semantic merge conflict. #37820 asserted the 128-deep nest is named by the ssh floor rule
sandbox-escape-ssh-self. #37875 then added the deny gate's own cap that refuses anything nested past 32 substitutions before the floors walk it, so the gate now returns the cap's reason. Each PR was green on its own base.Fix: the test now asserts the gate refuses the nest with the cap's reason and raises no exception, which is what it was written to check. The ssh floor's own bound stays covered by the floor-level tests in the same class.
Evidence:
test_denied_commands_security_ssh_self.py+test_denied_commands_security_nesting.py: 415 passed locally. On unmodified main the old assertion returns<unmapped:Blocked by security policy: substitution nesting deeper than 32 ...>.Test-only; no product code or CI config.