Skip to content

test: expect the deny gate's depth cap to refuse a 128-deep ssh nest - #37972

Closed
bolichen97 wants to merge 1 commit into
mainfrom
crew/LinuxFlackyGuard/ssh-nest-depth-cap
Closed

bolichen97 wants to merge 1 commit into
mainfrom
crew/LinuxFlackyGuard/ssh-nest-depth-cap

Conversation

@bolichen97

Copy link
Copy Markdown
Contributor

main is red on test/test_denied_commands_security_ssh_self.py::TestSshFloorNestingDepth::test_the_gate_refuses_a_nest_past_the_bound_without_an_exception (11 PRs failed, e.g. https://github.com/kirodotdev/KiroCrew/actions/runs/43869438393/job/133309772408).

Cause: a semantic merge conflict. #37820 asserted the 128-deep nest is named by the ssh floor rule sandbox-escape-ssh-self. #37875 then added the deny gate's own cap that refuses anything nested past 32 substitutions before the floors walk it, so the gate now returns the cap's reason. Each PR was green on its own base.

Fix: the test now asserts the gate refuses the nest with the cap's reason and raises no exception, which is what it was written to check. The ssh floor's own bound stays covered by the floor-level tests in the same class.

Evidence: test_denied_commands_security_ssh_self.py + test_denied_commands_security_nesting.py: 415 passed locally. On unmodified main the old assertion returns <unmapped:Blocked by security policy: substitution nesting deeper than 32 ...>.

Test-only; no product code or CI config.

#37820 asserted that a 128-deep $( ) nest is named by the ssh floor's rule.
#37875 then added a depth cap in the deny gate that refuses anything past 32
substitutions before any floor walks it, so the same command now comes back
with the cap's reason. Each PR was green alone; together they turned main red
and failed 11 PRs. The test still checks what it was written for: the gate
refuses the nest and raises no exception. The ssh floor's own bound is still
covered by the floor-level tests in the same class.
@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners November 16, 2026 13:18
@bolichen97
bolichen97 requested a review from CrysisDeu November 16, 2026 13:18
@bolichen97
bolichen97 enabled auto-merge (squash) November 16, 2026 13:18
@bolichen97

Copy link
Copy Markdown
Contributor Author

Closing in favour of #37964, which fixes the same main break and also keeps the ssh floor's bound checked at the gate's cap. I'll merge #37964 once its CI is green.

@bolichen97 bolichen97 closed this Nov 16, 2026
auto-merge was automatically disabled November 16, 2026 13:19

Pull request was closed

@bolichen97
bolichen97 deleted the crew/LinuxFlackyGuard/ssh-nest-depth-cap branch November 16, 2026 13:19
@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision aeffaf01c138ca55ad3b4701b8c6d016e661dce6 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision aeffaf01c138ca55ad3b4701b8c6d016e661dce6 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of aeffaf01c138ca55ad3b4701b8c6d016e661dce6 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: a test-only change that brings a stale assertion in line with the deny gate's depth cap added in #37875. The test's real job, refusing the nest without raising an exception, is still checked.

[DESIGN-REVIEWED] aeffaf0

Description read

[DESCRIPTION-READ] 67be0640cccf73d132d2477546e5d1f888c8a8da3361da7c3fbee938435beac9

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed aeffaf01c138ca55ad3b4701b8c6d016e661dce6 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] aeffaf0

Verdict parsed from the review's SHA-scoped output markers for commit aeffaf01c138ca55ad3b4701b8c6d016e661dce6.

False positive or not applicable? A repository writer can comment:
/ai-review override fable aeffaf01c138ca55ad3b4701b8c6d016e661dce6 false-positive: <reason, 20 to 500 characters>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of aeffaf01c138ca55ad3b4701b8c6d016e661dce6 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] aeffaf0

False positive or not applicable? A repository writer can comment:
/ai-review override gpt aeffaf01c138ca55ad3b4701b8c6d016e661dce6 false-positive: <reason, 20 to 500 characters>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant