Repository navigation
docs(rfc): record the Slack Code channel decisions the next pull requests build on - #38124
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS This is a docs-only RFC amendment that records decisions already made. It adds no code, removes no reader and changes no surface that renders. [DESIGN-REVIEWED] c980649 Description read[DESCRIPTION-READ] 53814c24fe9ed3275259f3b6fe0992e32011247e741c124e5ba810da7f4ba8bd That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
…ests build on Amends rfc-slack-code-channels.md with the owner's decisions on helper agents turning on with a first enable of Code channels, the default agent and Always use conductor mode, the context bar's action items and single PR slot, Plan-canvas comments, the PR and Workers tabs and the tab limit, and the work board's per-row PR and CI, combined Code tab, wrap-up outcomes and idle !stop reply. Records what #21993 shipped: no reactions in bound code channels, and the board files no helper agents. Updates the RFC index row.
7cfd419 to
c980649
Compare
Code change approver recommendation: A person should decideWhy: the decider estimates a 10% chance that this change introduces a defect, within the 12% limit for approving on its own, but it is held at tier 2: design-doc-gate: D. This PR changes docs only. It amends the Slack Code channels RFC and its README index row to record decisions the owner has already made, so the code PRs that follow can rely on them. I checked its "on main" claims against the head code and they hold:
The trust sweep found nothing that fails open:
Tier: 2, held for a person: design-doc-gate: D. An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
|
This changes behaviour users already rely on, so it needs a design sign-off from a maintainer before it can merge. A maintainer will post the decision here. To propose a design, follow the request-for-change process in CONTRIBUTING.md (docs/request-for-change/). Review result on this head: no blocking findings. The diff touches only the RFC and the request-for-change README. We checked each "on main" claim at the audited commit 09e5482, which is an ancestor of main. Optional:
|
Problem / Motivation
Goal: Record the owner's decisions on what a Slack code channel shows and runs, on main, before the code pull requests that build them.
The First Principles lane blocks a code pull request that changes product shape unless the decision is already in an RFC on the base branch. An RFC edit inside the code pull request does not count; in its words on #22370, "Changing the RFC inside the PR only proposes the decision; it doesn't record it." Several Slack Code pull requests change what a code channel shows or runs, and
docs/request-for-change/rfc-slack-code-channels.md(statuspartial) does not describe those changes on main09e5482863.Why it matters
Without the decisions on main, each of these pull requests is blocked until the owner posts an override, and posts it again after every push. One docs-only amendment, merged first, records them once.
Not a goal
src/ortest/file changes, and nothing is generated.docs/decisionsentry: an RFC amendment does not need one (docs(rfc): a code channel's Stop also stops its helper agents #35935 had none).What changed (motivation → approach → change)
The amendment follows #35935: a dated "Amended 2026-11-16" item under the document's status line that names each decision, its date, its section and what main has today, then the text in the sections it amends. It takes effect when the owner merges this amendment.
What each part records, and the pull request it unblocks:
slack.code_channel_dispatch) turn on with a first enable of Code channels; a stored value, including an explicit off, is kept; a missing or unreadable config reads off. Decided 2026-11-13.feat/code-channel-helpers-default-on)agent.crew_mode_agent, over the channel default agent and the folder's agent. The auto folder's legacykirocrew-conductorreads as unset. The session carries no conductor mode stamp, so its helper agents stay filed in the channel's folder. Decided 2026-11-13; given the conductor mode name on 2026-11-16.code_channel_actionevent is subscribed. Decided 2026-10-23.!stop"feat/slack-code-channel-board-diff)The front matter's
last-audited,audited-atandimplementation-prs(adds #21993) are brought up to date, and the index row indocs/request-for-change/README.mdrecords the amendment and what main has. Each "on main" statement was checked in the code at09e5482863:features.AUTO_FOLDER_AGENTiskirocrew-conductor,slack_code_settings.pynever savescode_channel_dispatchon a Code channels enable,slack/code_channels/has noactions.py,views.py,comments.pyorworkspace/worker_prs.py, the manifest subscribes nocode_channel_action, and an idle!stopgives only a count of running helper agents.Backwards compatibility
Compatible: documentation only; no code, config or behaviour changes.
Removes nothing: the change adds text and rewrites lines that described the old shape: open question 2's "link items only", the auto folder's
kirocrew-conductordefault and its "· kirocrew-conductor" settings label, the agent row of the resolution order, the context bar's "(≤5 items: repo, branch, PR, CI)", thecode_channelsmanifest row's events, "With all of them off" (now "With every switch off"), and a qualifier after the status line's "so no default changes". No section or reader goes away.Tests
Proof: not provable -- docs or config only
On this head:
./scripts/docs-lint.sh,scripts/docs_lint.py --test, the brand-name, comment-history, feature-map, changelog-history and decisions-history source gates, and in one run every test file that namesrequest-for-change(42),test_docs_lint_fact_checks.py,test_interactions_options.pyand every test that scans all Markdown docs (15): 3,141 passed, 2 skipped.Manual verification
N/A — documentation only. Each section was checked against the code hunk of the pull request it unblocks.
Related Issues
None. This records decisions; the code pull requests follow.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license.