Skip to content

test(website): name each diff-scoped gate wiring instead of counting them - #38296

Merged
bolichen97 merged 1 commit into
mainfrom
crew/LinuxFlackyGuard/render-verdict-wiring-list
Nov 17, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
crew/LinuxFlackyGuard/render-verdict-wiring-list

Conversation

@bolichen97

@bolichen97 bolichen97 commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Two PRs that each add a diff-scoped CI gate can no longer break main for everyone by both bumping one total in renderVerdict.test.ts.

website/src/test/renderVerdict.test.ts::CI supplies a base commit on both paths > wires every diff-scoped gate step asserted expect(wirings).toHaveLength(13). #38250 (METRICS_SCHEMA_BASE_REF) and #38097 (EMOJI_ICON_BASE_REF) each added a wiring; each was green on its own base, but together main had 14 and the test failed on every PR (15 PRs blocked at the 23:16 PST scan) until #38295 bumped it to 14.

Why it matters

A total is a merge-unsafe ratchet: every PR that adds a gate edits the same number, so any two that merge close together leave main red for all PRs until someone notices. This is the fourth main break of this kind today.

Not a goal

  • Changing which workflows are scanned or what each wiring must contain (the base.sha assertions below are unchanged).
  • Adding or removing any CI gate.

What changed (motivation → approach → change)

Symptom: main red on every PR after two gate PRs merged → root cause: the test pins a total, not the set → change: the test now asserts the sorted list of *_BASE_REF env names, one per line. Two PRs that each add a gate edit different lines, so git shows the overlap instead of a silent semantic conflict, and the test still fails when a gate is added or removed without updating the list.

Backwards compatibility

Compatible: test-only; the list matches the 14 wirings on main.

Tests

Manual verification

N/A — test-only change.

Screenshots / video

N/A — no UI change.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 17, 2026
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 56acec89eb8e9e4c2b31c4815daca3f4e44663b8 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 56acec89eb8e9e4c2b31c4815daca3f4e44663b8 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing to check. The PR only changes a test file (website/src/test/renderVerdict.test.ts) and adds or changes no user-visible control, so the missing screenshots leave no evidence gap.

[UX-REVIEWED] 56acec8

Description read

[DESCRIPTION-READ] cec8d7885ceda04a1a61bd825fbfb9285871f2069edc208a1a71ab72be6ab938

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 56acec89eb8e9e4c2b31c4815daca3f4e44663b8 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: replacing the shared total with a sorted list of names is the merge-safe ratchet that testing-conventions already describes, and it is aimed at the main break the PR names.

Notes

  • The hunk changes the comment from "nine of the fourteen wirings" to "nine of the thirteen", but the new list has 14 entries. The prose count goes stale again, so drop the number from the comment altogether.

[DESIGN-REVIEWED] 56acec8

Description read

[DESCRIPTION-READ] 9517fc7c3b13b53f62b666124b1d2cb67c55013f5aa0a800f4b79acf09defcd0

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 56acec89eb8e9e4c2b31c4815daca3f4e44663b8 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 56acec8

Verdict parsed from the review's SHA-scoped output markers for commit 56acec89eb8e9e4c2b31c4815daca3f4e44663b8.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 56acec89eb8e9e4c2b31c4815daca3f4e44663b8 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 56acec89eb8e9e4c2b31c4815daca3f4e44663b8 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 56acec8

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 56acec89eb8e9e4c2b31c4815daca3f4e44663b8 false-positive: <reason, 20 to 500 characters>

…them

EMOJI_ICON_BASE_REF). Only one bumped toHaveLength(13), so the two green PRs
together left main at 14 wirings and the test red on every PR. A total is a
merge-unsafe ratchet: list the env names one per line, so two PRs that each
add a gate edit different lines and git surfaces any overlap.
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 17, 2026
@bolichen97
bolichen97 force-pushed the crew/LinuxFlackyGuard/render-verdict-wiring-list branch from 3aa84e8 to 56acec8 Compare November 17, 2026 07:33
@bolichen97
bolichen97 marked this pull request as ready for review November 17, 2026 07:34
@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners November 17, 2026 07:34
@bolichen97
bolichen97 requested a review from CrysisDeu November 17, 2026 07:34
@bolichen97
bolichen97 enabled auto-merge (squash) November 17, 2026 07:34
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 17, 2026
@bolichen97
bolichen97 merged commit 5c747a0 into main Nov 17, 2026
103 of 108 checks passed
@bolichen97
bolichen97 deleted the crew/LinuxFlackyGuard/render-verdict-wiring-list branch November 17, 2026 08:33
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant