Repository navigation
docs(rfc): app SDK browser, a permission-gated view, read and annotate surface - #38322
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this is a draft RFC that changes only docs and adds no code, surface or take-away. Notes
[DESIGN-REVIEWED] ee5e08b Description read[DESCRIPTION-READ] c7ac46900bb3cd28b4a7f0c616120c24c5a187ba89929e6df1e5cabdf78a1ed7 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
eb28483 to
8f055a0
Compare
|
This adds a new concept, so it needs a design sign-off from a maintainer before it can merge. A maintainer will post the decision here. To propose a design, follow the request-for-change process in CONTRIBUTING.md (docs/request-for-change/). Review result on this head: nothing blocks. The diff changes docs only: the new draft Optional notes for the signer:
|
8f055a0 to
ee5e08b
Compare
Code change approver recommendation: A person should decideWhy: the decider estimates an 8% chance that this change introduces a defect, within the 12% limit for approving on its own, but it changes 550 lines, more than the 400 it may approve on its own. Docs-only draft RFC plus one README index row. I checked its claims about main against the code: the api_browser_op gates, the allow-all OpContext.url_allowed default, the requested-URL check that runs only in the shim, APP_SDK_LEVEL=10, the chat_slot_sdk trust wording, AppHost having no iframe, the staged grant helpers, the browserSites support and the governance ceiling filter in bridges_agents. All hold. The trust model says plainly that the grant is consent and not isolation, and that execution trust is the boundary. It moves no boundary, because app pages already run with the owner's cookie. The only problems are wording, so I approve. Tier: 2, held for a person: design-doc-gate: D. An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
|
Post-merge input for the implementation PRs: this RFC merged at 21:48 PST with status still Review input on the RFC as merged ( The claims about main hold: A. #38333 already put a requested-URL check in the gateway, for app slots. B. C. Register D. The shim's URL copy (Design Review note): agreed. Describe it as an early-fail convenience, so the gateway check stays the one that decides. Open questions
One process note: the file merged with A team member must sign off on this design; this comment is review input only. AI-assisted, sent by Bolin Review bot |
…n app's own slot Implements step 1c of RFC #38322. BrowserView wraps the dashboard's live view (BrowserLiveCardCanvas, browserLiveStore) and adds no channel or route. Behind the app_browser_sdk preview; a slot the gateway did not stamp with the app's name shows denied. A hand-back note no agent op took is sent once: by a mounted chat surface (which now calls preventDefault), else by the store. APP_SDK_LEVEL 10 -> 11.
…n app's own slot Implements step 1c of RFC #38322. BrowserView wraps the dashboard's live view (BrowserLiveCardCanvas, browserLiveStore) and adds no channel or route. Behind the app_browser_sdk preview; a slot the gateway did not stamp with the app's name shows denied. A hand-back note no agent op took is sent once: by a mounted chat surface (which now calls preventDefault), else by the store. APP_SDK_LEVEL 10 -> 11.
…x.browser (RFC #38322 step 1a)
…n app's own slot Implements step 1c of RFC #38322. BrowserView wraps the dashboard's live view (BrowserLiveCardCanvas, browserLiveStore) and adds no channel or route. Behind the app_browser_sdk preview; a slot the gateway did not stamp with the app's name shows denied. A hand-back note no agent op took is sent once: by a mounted chat surface (which now calls preventDefault), else by the store. APP_SDK_LEVEL 10 -> 11.
…x.browser (RFC #38322 step 1a)
…n app's own slot Implements step 1c of RFC #38322. BrowserView wraps the dashboard's live view (BrowserLiveCardCanvas, browserLiveStore) and adds no channel or route. Behind the app_browser_sdk preview; a slot the gateway did not stamp with the app's name shows denied. A hand-back note no agent op took is sent once: by a mounted chat surface (which now calls preventDefault), else by the store. APP_SDK_LEVEL 10 -> 11.
…n app's own slot Implements step 1c of RFC #38322. BrowserView wraps the dashboard's live view (BrowserLiveCardCanvas, browserLiveStore) and adds no channel or route. Behind the app_browser_sdk preview; a slot the gateway did not stamp with the app's name shows denied. A hand-back note no agent op took is sent once: by a mounted chat surface (which now calls preventDefault), else by the store. APP_SDK_LEVEL 10 -> 11.
…x.browser (RFC #38322 step 1a)
…n app's own slot Implements step 1c of RFC #38322. BrowserView wraps the dashboard's live view (BrowserLiveCardCanvas, browserLiveStore) and adds no channel or route. Behind the app_browser_sdk preview; a slot the gateway did not stamp with the app's name shows denied. A hand-back note no agent op took is sent once: by a mounted chat surface (which now calls preventDefault), else by the store. APP_SDK_LEVEL 10 -> 11.
…x.browser (RFC #38322 step 1a)
…n app's own slot Implements step 1c of RFC #38322. BrowserView wraps the dashboard's live view (BrowserLiveCardCanvas, browserLiveStore) and adds no channel or route. Behind the app_browser_sdk preview; a slot the gateway did not stamp with the app's name shows denied. A hand-back note no agent op took is sent once: by a mounted chat surface (which now calls preventDefault), else by the store. APP_SDK_LEVEL 10 -> 11.
…n app's own slot Implements step 1c of RFC #38322. BrowserView wraps the dashboard's live view (BrowserLiveCardCanvas, browserLiveStore) and adds no channel or route. Behind the app_browser_sdk preview; a slot the gateway did not stamp with the app's name shows denied. A hand-back note no agent op took is sent once: by a mounted chat surface (which now calls preventDefault), else by the store. APP_SDK_LEVEL 10 -> 11.
…n app's own slot Implements step 1c of RFC #38322. BrowserView wraps the dashboard's live view (BrowserLiveCardCanvas, browserLiveStore) and adds no channel or route. Behind the app_browser_sdk preview; a slot the gateway did not stamp with the app's name shows denied. A hand-back note no agent op took is sent once: by a mounted chat surface (which now calls preventDefault), else by the store. APP_SDK_LEVEL 10 -> 11.
…n app's own slot Implements step 1c of RFC #38322. BrowserView wraps the dashboard's live view (BrowserLiveCardCanvas, browserLiveStore) and adds no channel or route. Behind the app_browser_sdk preview; a slot the gateway did not stamp with the app's name shows denied. A hand-back note no agent op took is sent once: by a mounted chat surface (which now calls preventDefault), else by the store. APP_SDK_LEVEL 10 -> 11.
…n app's own slot (#39020) Implements step 1c of RFC #38322. BrowserView wraps the dashboard's live view (BrowserLiveCardCanvas, browserLiveStore) and adds no channel or route. Behind the app_browser_sdk preview; a slot the gateway did not stamp with the app's name shows denied. A hand-back note no agent op took is sent once: by a mounted chat surface (which now calls preventDefault), else by the store. APP_SDK_LEVEL 10 -> 11. Co-authored-by: Raymond Chen <raymondchen625@gmail.com>
…n app's own slot (#39020) Implements step 1c of RFC #38322. BrowserView wraps the dashboard's live view (BrowserLiveCardCanvas, browserLiveStore) and adds no channel or route. Behind the app_browser_sdk preview; a slot the gateway did not stamp with the app's name shows denied. A hand-back note no agent op took is sent once: by a mounted chat surface (which now calls preventDefault), else by the store. APP_SDK_LEVEL 10 -> 11. Co-authored-by: Raymond Chen <raymondchen625@gmail.com>
…n app's own slot (#39020) Implements step 1c of RFC #38322. BrowserView wraps the dashboard's live view (BrowserLiveCardCanvas, browserLiveStore) and adds no channel or route. Behind the app_browser_sdk preview; a slot the gateway did not stamp with the app's name shows denied. A hand-back note no agent op took is sent once: by a mounted chat surface (which now calls preventDefault), else by the store. APP_SDK_LEVEL 10 -> 11. Co-authored-by: Raymond Chen <raymondchen625@gmail.com>
…n app's own slot (#39020) Implements step 1c of RFC #38322. BrowserView wraps the dashboard's live view (BrowserLiveCardCanvas, browserLiveStore) and adds no channel or route. Behind the app_browser_sdk preview; a slot the gateway did not stamp with the app's name shows denied. A hand-back note no agent op took is sent once: by a mounted chat surface (which now calls preventDefault), else by the store. APP_SDK_LEVEL 10 -> 11. Co-authored-by: Raymond Chen <raymondchen625@gmail.com>
…n app's own slot (#39020) Implements step 1c of RFC #38322. BrowserView wraps the dashboard's live view (BrowserLiveCardCanvas, browserLiveStore) and adds no channel or route. Behind the app_browser_sdk preview; a slot the gateway did not stamp with the app's name shows denied. A hand-back note no agent op took is sent once: by a mounted chat surface (which now calls preventDefault), else by the store. APP_SDK_LEVEL 10 -> 11. Co-authored-by: Raymond Chen <raymondchen625@gmail.com>
…n app's own slot (#39020) Implements step 1c of RFC #38322. BrowserView wraps the dashboard's live view (BrowserLiveCardCanvas, browserLiveStore) and adds no channel or route. Behind the app_browser_sdk preview; a slot the gateway did not stamp with the app's name shows denied. A hand-back note no agent op took is sent once: by a mounted chat surface (which now calls preventDefault), else by the store. APP_SDK_LEVEL 10 -> 11. Co-authored-by: Raymond Chen <raymondchen625@gmail.com>
…n app's own slot (#39020) Implements step 1c of RFC #38322. BrowserView wraps the dashboard's live view (BrowserLiveCardCanvas, browserLiveStore) and adds no channel or route. Behind the app_browser_sdk preview; a slot the gateway did not stamp with the app's name shows denied. A hand-back note no agent op took is sent once: by a mounted chat surface (which now calls preventDefault), else by the store. APP_SDK_LEVEL 10 -> 11. Co-authored-by: Raymond Chen <raymondchen625@gmail.com>
…x.browser (RFC #38322 step 1a)
…n app's own slot (#39020) Implements step 1c of RFC #38322. BrowserView wraps the dashboard's live view (BrowserLiveCardCanvas, browserLiveStore) and adds no channel or route. Behind the app_browser_sdk preview; a slot the gateway did not stamp with the app's name shows denied. A hand-back note no agent op took is sent once: by a mounted chat surface (which now calls preventDefault), else by the store. APP_SDK_LEVEL 10 -> 11. Co-authored-by: Raymond Chen <raymondchen625@gmail.com>
…n app's own slot (#39020) Implements step 1c of RFC #38322. BrowserView wraps the dashboard's live view (BrowserLiveCardCanvas, browserLiveStore) and adds no channel or route. Behind the app_browser_sdk preview; a slot the gateway did not stamp with the app's name shows denied. A hand-back note no agent op took is sent once: by a mounted chat surface (which now calls preventDefault), else by the store. APP_SDK_LEVEL 10 -> 11. Co-authored-by: Raymond Chen <raymondchen625@gmail.com>
…x.browser (RFC #38322 step 1a)
…n app's own slot (#39020) Implements step 1c of RFC #38322. BrowserView wraps the dashboard's live view (BrowserLiveCardCanvas, browserLiveStore) and adds no channel or route. Behind the app_browser_sdk preview; a slot the gateway did not stamp with the app's name shows denied. A hand-back note no agent op took is sent once: by a mounted chat surface (which now calls preventDefault), else by the store. APP_SDK_LEVEL 10 -> 11. Co-authored-by: Raymond Chen <raymondchen625@gmail.com>
…x.browser (RFC #38322 step 1a)
…n app's own slot (#39020) Implements step 1c of RFC #38322. BrowserView wraps the dashboard's live view (BrowserLiveCardCanvas, browserLiveStore) and adds no channel or route. Behind the app_browser_sdk preview; a slot the gateway did not stamp with the app's name shows denied. A hand-back note no agent op took is sent once: by a mounted chat surface (which now calls preventDefault), else by the store. APP_SDK_LEVEL 10 -> 11. Co-authored-by: Raymond Chen <raymondchen625@gmail.com>
Problem / Motivation
Goal: Let an App Kit app show, read and annotate the browser page that its Bot uses, through a public SDK surface instead of private imports and patches.
Crew has a browser (the
browsertool, a live view, user takeover). An app has none of it:ctxhas nobrowserand@kirocrew/app-sdkexports no browser view. The one app that needs it, Browser Collab, works only by importing about a dozen private gateway modules and by carrying three patches against Crew. This RFC turns that into a manifest permission, a backendctx.browser, and a front-endBrowserView, behind one preview flag that is off by default.Why it matters
Every app that wants to show or read a page has the same problem. A patch that one user carries cannot be reviewed, versioned or removed, and it gives one app a back door that others are denied. A public surface puts the identity checks in one place.
Not a goal
inject(writing content into a page). Phase 1 has none; the RFC lists the minimum a second RFC must meet.rfc-app-agent-tools-third-party-grant.mdand feat(apps): list a third-party app's agentTools on an opt-in prompted kirocrew-apps server #17015 own them. This RFC adds no server, grant family or flag for them.rfc-app-sandbox-isolation.md.What changed (motivation -> approach -> change)
Adds
docs/request-for-change/rfc-app-sdk-browser.md(statusdraft) and one index row in the RFC README.Approach, chosen over the alternatives in the document:
run_browser_op, extracted fromapi_browser_op, that the route andctx.browserboth call. The URL check on the requested address, the lock, the takeover hold, the tab binding and the on/off check then exist once.BrowserViewwraps the existing live-view component and hooks. No new channel, no new route._appstamp, and tabs come fromLiveHub.targets_of.app-grants, approved by the owner after install. A verb added by an update waits for the owner.chat_slot_sdk.py: a grant is consent to a stable interface, not isolation; execution trust is the boundary.Backwards compatibility
Removes nothing: a docs-only change (one new file and one README row). The RFC itself proposes only additive changes (an optional manifest field, a flag that is off, an SDK level bump).
Tests
N/A - docs only. Every claim about main was checked against origin/main at 5d18d11. Proof: not provable -- docs or config only.
Manual verification
N/A - no behavior changes. The RFC text was read against the cited code paths on main.
Related Issues
Builds on #17015 and the accepted rfc-app-agent-tools-third-party-grant.md (tracking issue #32727).
Checklist
Contribution License Agreement
Contributions are accepted under the project Apache-2.0 license.