Skip to content

fix(privacy): name store apps in the privacy chapter and bump the notice to 4 (#38145) - #38347

Merged
KiroCrewCaptain merged 1 commit into
mainfrom
docs/privacy-store-app-names-38145
Nov 17, 2026
Merged

KiroCrewCaptain merged 1 commit into
mainfrom
docs/privacy-store-app-names-38145

Conversation

@chenmingwei23

@chenmingwei23 chenmingwei23 commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The Privacy chapter tells every user which app names can leave the machine, and users who already acknowledged the previous notice see it once more.

kirocrew.app.installed is now in PRODUCT_METRICS on main (#38157, src/kiro_crew/metrics/product_metrics.py), so the public store name of a store app can leave the machine in the next release. The chapter's "What is collected" list does not say so, and notice v3 already shipped in v0.13.0-rc.2, so users who acknowledged v3 would never see a new line.

Why it matters

The chapter is where users are told what leaves their machine. Without the line and a version bump, every user who acknowledged v3 is never told that app names are sent.

Not a goal

  • No change to what is collected or sent.
  • No change to the Kiro telemetry export gate (kiro_export.NOTICE_VERSION stays 3).
  • No change to the Settings > Privacy page layout.

What changed (motivation -> approach -> change)

  • New key components.privacyChapter.collectedApps in website/src/i18n/locales/en.manual.json: "Which built-in apps are installed or used, and which store apps are installed, by their public store name. Apps you add from anywhere else are counted without a name." The wording follows what main sends: the only metric that carries a store app's public name is kirocrew.app.installed (record_app_installed, called from store_origin.count_first_install), which also fires for apps the default-apps pass installs; kirocrew.app.task.completed names only built-ins and sends private for store apps.
  • The same key in the 12 other locale files (bn, de, es, fr, hi, it, ja, ko, pt, ru, zh-CN translated; en-XA regenerated with npm run i18n:pseudo), the same file set recent keys use (fix(dashboard): show one calm offline state when a relay Crew's host or the local gateway stops #38103).
  • website/src/components/PrivacyChapter.tsx: the key is added to COLLECTED_KEYS after collectedFeatures.
  • Notice version bumped 3 -> 4 in src/kiro_crew/beacon.py and website/src/components/privacyNotice.ts, per the rule both files state ("bump this whenever the notice says something new"). beacon.py notes what version 4 adds. A user whose stored privacy_ack_version is 3 sees the chapter once more while local recording is on.
  • kiro_export.NOTICE_VERSION stays 3. notice_shown checks kiro_telemetry_ack_version >= NOTICE_VERSION (or the terminal stamp, now written as 4), so a v3 acker keeps exporting after the bump.
  • Docs: docs/system-specs/modules/metrics.md now says both versions are 4; docs/guides/telemetry-otlp-export.md rows say "notice version 3 or later".

Backwards compatibility

Compatible: a stored ack of 3 is still accepted by the Kiro telemetry export gate; the dashboard shows the chapter once more to v3 ackers whose recording is on, and an install off only by an old build's written false that chose Keep off on v3 sees the off form once more, as off_offer_due documents ("once the current notice is acknowledged").

Removes nothing: the diff adds a string key, renders it and raises the notice version.

Tests

  • test/metrics/test_kiro_export_destination.py: new test_a_v3_ack_still_exports_after_the_notice_moves_on (ack 3 with notice 4 still exports; fails if NOTICE_VERSION follows the bump) and test_an_ack_of_the_current_notice_exports (ack 4 exports). Tests that meant "the current notice was acknowledged" now write beacon.PRIVACY_NOTICE_VERSION; the terminal stamp check matches what notice.py writes.
  • test/test_telemetry_consent_notice.py, website/src/test/App.test.tsx: version pins 3 -> 4.
  • website/src/components/PrivacyChapter.test.tsx: asserts the new bullet renders.
  • Ran: pytest -n 2 on test_kiro_export_destination, test_api_theme_config, test_telemetry_consent_notice, test_usage_notice, test_config_all_settings, test_cli_commands_coverage_memory_eval (442 passed). vitest run on PrivacyChapter, privacyNotice, firstRun.dismiss, App and 11 i18n gate files (383 passed). tsc -p tsconfig.app.json clean. black, flake8 and isort clean on the changed Python files.

Proof: not provable -- other: a version bump plus copy; the new v3-export test was shown to fail by setting kiro_export.NOTICE_VERSION to 4 locally

Manual verification

Rendered the real SPA with fixture APIs (first-run Privacy chapter due) in Chromium at 1100x820 and confirmed the new bullet shows under "What is collected".

Screenshots / video

First-run Privacy chapter, light theme, with the new bullet third in "What is collected":

Privacy chapter with the new app-names bullet

Related Issues

Refs #38145

Sibling sweep

Swept: git grep -nE "PRIVACY_NOTICE_VERSION =|NOTICE_VERSION =|collectedFeatures" -- src website/src
Sibling: src/kiro_crew/beacon.py -- changed here
Sibling: website/src/components/privacyNotice.ts -- changed here
Sibling: src/kiro_crew/metrics/kiro_export.py -- not affected -- its NOTICE_VERSION names the notice that first listed Kiro telemetry, which is still 3
Sibling: src/kiro_crew/metrics/notice.py -- not affected -- the terminal notice line lists no collected items, so it names no apps

Pattern harvest

Not generalizable: the notice copy and its version are product decisions; the bump rule is already written next to both version constants, and a reviewer lane enforced it here.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 17, 2026
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of c0de3adb2645586f835f0003cdd4f67cb9e81593 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks: the version bump follows the rule both version files state ("bump both when the notice says something new"), and the new line covers kirocrew.app.installed, which is already in PRODUCT_METRICS.

What this change ships

Inventory (6 items) — 5 justified

Intent: tell every user, including anyone who already acknowledged notice v3, that store app names can now leave the machine. This is a FIX.

  1. The Privacy chapter's "What is collected" list gains a third bullet naming built-in and store apps — justified
  2. The same bullet is translated in 12 locales — justified
  3. Users who acknowledged notice v3 see the Privacy chapter once more while recording is on — justified
  4. On hosts with no dashboard (headless), the one-line terminal notice prints once more with its old text, which does not mention apps (notice.py:125, :151) — undeclared
  5. Kiro telemetry export still accepts a v3 acknowledgement after the notice moves to 4 — justified
  6. The terminal stamp for Kiro telemetry is now written as 4 — justified

[FIRST-PRINCIPLES-REVIEWED] c0de3ad

Description read

[DESCRIPTION-READ] bd8524b0923d8058a4ecb26f4f8e23d46d08888c176a0c6839d5e78612caeb7b

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of c0de3adb2645586f835f0003cdd4f67cb9e81593 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

No design-level concerns. This is one new line of copy plus the version bump the notice rule requires, and keeping kiro_export.NOTICE_VERSION at 3 means people who acknowledged notice v3 keep exporting.

Notes

  • The screenshot in the description did not reach the evidence list (0 images downloaded). The new bullet goes into an existing list, so it is not a new or reshaped surface, but re-attach the image so the UX lanes can see it.

[DESIGN-REVIEWED] c0de3ad

Description read

[DESCRIPTION-READ] 944a9175096d5a0c0f17523ff23e782bafcb638cbb037ba528e47a2956c46cdf

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of c0de3adb2645586f835f0003cdd4f67cb9e81593 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing a screenshot of the new "What is collected" bullet. The PR description's image was not admitted, so no blind read ran.

Evidence gaps

  • New bullet components.privacyChapter.collectedApps in the first-run Privacy chapter. The blind-read report says "BLIND READ NOT PERFORMED: the PR description carries no image attachment", and the screenshot list is empty, so nobody has seen how this bullet renders. To close the gap, attach the light-theme Privacy chapter screenshot that the description promises (where it now reads "[image removed]") as a github.com/user-attachments asset. A narrow-width view is also needed, because this bullet is two sentences while its neighbours are short fragments.

Notes

  • The English string is two sentences and about three times longer than its sibling bullets, so the list stops being easy to scan. Shorten it to something like "Names of built-in apps you use, and store apps you install (by store name); other apps are counted without a name."

[UX-REVIEWED] c0de3ad

Description read

[DESCRIPTION-READ] 160ca68caf5ca1d05b1212d72cf1a4b6e1a14a99f340f05c9cea285bd3bdbefc

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed c0de3adb2645586f835f0003cdd4f67cb9e81593 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] c0de3ad

Verdict parsed from the review's SHA-scoped output markers for commit c0de3adb2645586f835f0003cdd4f67cb9e81593.

False positive or not applicable? A repository writer can comment:
/ai-review override fable c0de3adb2645586f835f0003cdd4f67cb9e81593 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of c0de3adb2645586f835f0003cdd4f67cb9e81593 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] c0de3ad

False positive or not applicable? A repository writer can comment:
/ai-review override gpt c0de3adb2645586f835f0003cdd4f67cb9e81593 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 17, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this before the release that starts sending app names. One line in the new copy describes the wrong trigger, and it needs a fix before merge.

  1. website/src/i18n/locales/en.manual.json:3990 (collectedApps), plus the same text in the 12 other locales and the regex at website/src/components/PrivacyChapter.test.tsx:80. The bullet says names are sent for apps "you open and use". On main, the only metric that carries a store app's public name is kirocrew.app.installed. record_app_installed (metrics/feature_usage.py) labels it with app_public_id. It is called only from store_origin.count_first_install, and registry_pipeline/install.py runs that on a first registry install with via set to store or default. The default-apps pass (apps/default_installs.py) installs apps disabled with via="default". Trigger: the default-apps pass installs a store app, or a user installs a store app and never opens it. Outcome: the app's name is still sent, while the chapter the user acknowledged says only apps they open and use are named. kirocrew.app.task.completed uses app_label, which names only shipped built-ins, so no open or use event sends a store name today. Smallest fix: reword the key in all 13 locales so install is the trigger. For example: "Which built-in and store apps are installed or used, by their public store name. Apps you add from anywhere else are counted without a name." Then update the test regex to match. Can you make that change in this PR?

Optional:

  • Notice v3 already shipped in v0.13.0-rc.2. Anyone who acknowledged v3 there will not see the chapter again when this line arrives. A maintainer may want to decide whether this counts as "something new" under the bump rule in privacyNotice.ts. If it does, bump the version, or note in the body that those users are knowingly not shown the chapter again.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 17, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick rewording. The new line now names install as the trigger, it is in all 13 locales, and the test pins the English sentence. One item still blocks merge.

Earlier review on f78c939:

  • Item 1 (the "open and use" trigger): fixed on this head. All 13 locales and the test regex now use the install wording.
  • Optional item (notice version): the body now records the choice. The open question about it is below.
  1. website/src/components/PrivacyChapter.tsx:22 with website/src/components/privacyNotice.ts:19 and src/kiro_crew/beacon.py:154. This PR adds a new item to the "What is collected" list but leaves PRIVACY_NOTICE_VERSION at 3. Both files say to bump it when the notice says something new. Trigger: a user on v0.13.0-rc.2, the tag that first carries version 3, pressed Keep on, so their stored privacy_ack_version is 3. They then upgrade to a build with #38157 and this PR. Outcome: firstRun.tsx:99 shows the chapter again only when privacyAckVersion < PRIVACY_NOTICE_VERSION, and both values are 3. That user never sees the new bullet, but record_app_installed now sends store app names from their machine. Stable v0.12.2 upgraders and new installs are not affected. The body calls keeping version 3 an "owner decision", but no maintainer comment on this PR or on #38145 records that decision. The AI review BLOCK on this head also has no disposition and no override, so PR Readiness stays red. Smallest fix, pick one:
    • (a) Bump PRIVACY_NOTICE_VERSION to 4 in beacon.py and privacyNotice.ts, add a line to the beacon.py comment saying what version 4 adds, and update the "both 3" text in metrics.md. kiro_export.py gates on its own NOTICE_VERSION = 3, so leave that at 3. Please check that Kiro telemetry export does not pause for v3 ackers, and add a test for it. The bump also shows the chapter and the headless notice once more to people who acknowledged v3.
    • (b) A maintainer records the decision on this PR to knowingly not show the chapter again to people who acknowledged v3 on the prerelease, and a repository writer posts an AI review override for that finding citing it. Then point the body at that comment.

Optional:

  • The copy says store apps are named when "installed or used", but only an install sends a store app's name. A use event labels a store app as private. I suggested that wording last round. It errs toward telling users more than is sent, so it is safe. If you want it exact, use something like "built-in apps installed or used, and store apps installed, by their public name" in all 13 locales and the test.
  • The change edits shipped UI copy, so fix(privacy): or feat(privacy): would describe it better than docs:. The title gate accepts either.

@chenmingwei23 chenmingwei23 changed the title docs(privacy): name store apps in the privacy chapter's collected list (#38145) fix(privacy): name store apps in the privacy chapter and bump the notice to 4 (#38145) Nov 17, 2026
…ice to 4 (#38145)

kirocrew.app.installed is now a product metric (#38157), so a store app's
public name can leave the machine on install. Add a 'What is collected' line
that says so in all 13 locales and render it in PrivacyChapter: built-in apps
are named when installed or used, store apps when installed, and apps added
from anywhere else are counted without a name.

Bump PRIVACY_NOTICE_VERSION 3 -> 4 in beacon.py and privacyNotice.ts, since
the notice says something new and v3 already shipped in v0.13.0-rc.2. Keep
kiro_export.NOTICE_VERSION at 3, so a v3 acker keeps exporting to Kiro
telemetry, and pin that with a test. Update the version pins and the docs.
@chenmingwei23
chenmingwei23 force-pushed the docs/privacy-store-app-names-38145 branch from b3113d2 to c0de3ad Compare November 17, 2026 14:18
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 17, 2026
@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Addressed on c0de3ad (one commit), for the review on b3113d2:

  1. Notice version: took option (a), per the maintainer's ruling. PRIVACY_NOTICE_VERSION is 4 in src/kiro_crew/beacon.py and website/src/components/privacyNotice.ts; the beacon.py comment says what version 4 adds; metrics.md says "both 4"; the telemetry-otlp-export.md rows say "notice version 3 or later". kiro_export.NOTICE_VERSION stays 3. New tests in test/metrics/test_kiro_export_destination.py: test_a_v3_ack_still_exports_after_the_notice_moves_on (ack 3 with notice 4 still exports; it fails when NOTICE_VERSION is set to 4) and test_an_ack_of_the_current_notice_exports. The "owner decision to keep 3" line is gone from the body.
  2. Optional copy: now "Which built-in apps are installed or used, and which store apps are installed, by their public store name. Apps you add from anywhere else are counted without a name." in all 13 locales, with the test regex and the screenshot updated.
  3. Optional title: now fix(privacy): ....

CI on c0de3ad: 87 pass, 0 fail, 0 pending; Opus 5.5 Review passes; PR Readiness success.

@KiroCrewCaptain
KiroCrewCaptain enabled auto-merge (squash) November 17, 2026 16:10

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking option (a). Nothing still blocks on this head.

Earlier review on b3113d2:

  • Item 1 (notice version): fixed. PRIVACY_NOTICE_VERSION is 4 in both beacon.py and privacyNotice.ts. kiro_export.NOTICE_VERSION stays 3. test_a_v3_ack_still_exports_after_the_notice_moves_on pins that people who acknowledged v3 keep exporting.
  • Optional copy wording: done in all 13 locales and the test regex. Store apps are now named only on install.
  • Optional title: done.

What this review checked on c0de3ad: every reader of the version moved together, and no literal 3 that should have moved was left behind. The new bullet matches what main sends (app_public_id on install, app_label for built-ins only). The new tests are isolated and use no clock or sleep. PR Readiness passed. A good choice here is keeping the export gate apart from the notice version and adding a test that fails if anyone later moves the two together.

Optional:

  • docs/system-specs/modules/metrics.md:268 still says the off offer applies while "notice version 3" is not yet acknowledged. docs/guides/telemetry-otlp-export.md:219 still says "Keep off is not asked again". After the bump, a v3 Keep off user is asked once more. Both lines could name the current notice version instead.
  • Headless starts (gateway --no-dashboard, run, chat) print the existing one-line notice, and the off offer line where it applies, once more for v3 users. Neither line names apps. A sentence under Backwards compatibility would record this. Right now the sibling sweep calls notice.py "not affected".
  • The UX and Design lanes ran before the screenshot reached the body, so a lane re-run would let them see it. A narrow-width view (about 390px) would also show how the longer bullet wraps.

@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 17, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 17, 2026
@KiroCrewCaptain
KiroCrewCaptain merged commit 50f650c into main Nov 17, 2026
105 of 107 checks passed
@KiroCrewCaptain
KiroCrewCaptain deleted the docs/privacy-store-app-names-38145 branch November 17, 2026 16:43
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants