Repository navigation
fix(i18n): spell crew one way in the hindi catalog - #38370
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the PR changes Hindi catalog text only and adds [DESIGN-REVIEWED] 3efd526 Description read[DESCRIPTION-READ] 973a8734c6620a29895da8d276d4134ac9f3488f413ee6c23805f5f5cdb8f83d That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks: this is a catalog-text fix tied to #36383, and its one guard extends an existing test to one more locale. Notes
What this change shipsInventory (6 items) — 5 justifiedIntent: Hindi readers see "crew" spelled one way (
[FIRST-PRINCIPLES-REVIEWED] 3efd526 Description read[DESCRIPTION-READ] 84f631e4774353e1424f10f0f31b0cefab2f60092231e6e2d77cd9c682bab613 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks: this PR changes Hindi wording only, and the before/after shots of the four main surfaces show one consistent spelling, Notes
[UX-REVIEWED] 3efd526 Description read[DESCRIPTION-READ] d0ec5543ab228f9598a5c15921afde570376d81698fc58c27a119e27db90c7ad That sha256 names everything this verdict read: the PR description, plus the 12 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
a532b35 to
ccf7ed9
Compare
|
Rebased: main moved in [operator: bolichen97] |
|
Rebased: main moved in
[operator: bolichen97] |
ccf7ed9 to
9dab0f6
Compare
|
[operator: bolichen97] The one red on this head is The fix is #39545. This PR waits for it to merge, then picks it up and re-runs CI. Every other check on this head is green, and the Design, First Principles and UX reviews pass. |
35 Hindi catalog values kept the generic noun crew in Latin letters while the rest of the catalog writes क्रू, so one screen showed both spellings (Settings > Remote Crew put "crew स्वतः कनेक्ट करें" beside "वे क्रू जिन पर ..."). Those values now say क्रू, the three that name the Remote Crew feature or its Settings tab use the tab's Hindi label रिमोट क्रू, and a capitalised Crew stays Latin only where the English source names this install with it. The catalog check that keeps a Latin crew out of five other catalogs reads the Hindi one too, style/hi.md states the rule, and the find_ui index carries the two edited labels it holds.
|
Rebased: main moved in
[operator: bolichen97] |
9dab0f6 to
3efd526
Compare
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
I reviewed head 3efd526. The change only edits Hindi catalog text, adds Hindi to the existing Latin crew check, and updates the Hindi style guide and the regenerated UI index. On this head the crew noun, style, QA and glossary i18n tests all pass. The extended check fails against the base Hindi catalog, so the new guard really catches a Latin crew. The UI index check reports the committed index is current. Placeholders and markup tags are kept, and the quoted menu label matches its real Hindi value, so nothing blocks.
Problem / Motivation
Goal: The Hindi dashboard spells "crew" one way, क्रू, everywhere except the product name, so one screen no longer mixes Latin
crewwithक्रू.35 values in the Hindi catalog kept the generic noun crew in Latin letters while about 210 others write
क्रू. On Settings → रिमोट क्रू the auto-connect toggle readcrew स्वतः कनेक्ट करेंdirectly aboveवे क्रू जिन पर तुम स्विच कर सकते हो; the launch form saidcrew के लिए Kiro साइन-इन, and the default destination setting saidडिफ़ॉल्ट गंतव्य crew.Why it matters
A Hindi reader sees the same thing named two ways on one panel and cannot tell whether
crewandक्रूare different things. The style guide keeps only product names in Latin script, and nothing stopped a new Hindi value from adding another Latincrew.Not a goal
रिमोट क्रू), andremoteCrewPanel.reported_host_hint, which lacked a clause its English source has.Crewwhere the English source capitalises it as the name of this install (sharedCrew.*andcomponents.sharedCrews.*, the project hooks notice,Fix with Crew,Crew और Bot).~/.kiro/crewpaths, and the quoted English-only Electron dialog label.What changed (motivation → approach → change)
Symptom: mixed
crew/क्रूon one screen. Cause: older values on the Remote Crew panel and a few other surfaces were written before the catalog settled onक्रू, and the check that keeps a Latincrewout of five other catalogs did not read the Hindi one.hi.json, 35 values whose English uses the generic noun crew / crews / CREW or the Remote Crew nameक्रू, in the तुम register and the masculine agreement the rest of the catalog gives it; the three that name the Remote Crew feature or its Settings tab sayरिमोट क्रू, the two "Send a copy" hints quote that menu item's Hindi label,एक प्रतिलिपि भेजें, andreported_host_hintgains the clause its English source hascrewNounNative.test.tshias well, so a Hindi value with a Latincreworcrewsfails itstyle/hi.mdui-index.generated.jsonBackwards compatibility
Compatible: catalog text only; no key is added, removed or renamed, and placeholders are unchanged.
Removes nothing: only Hindi display strings change and one locale joins an existing test; no key, path, function or record is taken away.
Tests
crewNounNative.test.ts›hi: no value spells the generic noun in Latin letters: fails onmainwith 25 keys listed, passes after; the other five locales pass both ways. The file's 7 tests pass five runs in a row and with--sequence.shuffle. The other 10 of the 35 edited values (a capitalisedCreworCREW,Remote Crew, a quoted English label) are outside what the scan reads.style/hiStyle.test.tspasses withI18N_BASE_REFset to the base, so its changed-value checks (तुम register, no Latin full stop) judge the 35 edited values.Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
On Ubuntu 24.04.5 LTS (Linux x86_64): two isolated gateways on 127.0.0.1 with throwaway
KIROCREW_HOMEs, one servingmainand one this branch, the dashboard driven by Playwright Chromium withlocale: 'hi-IN'(the app pickedlang="hi"), first-run screens dismissed, Remote Crew management turned on and one placeholder SSH crew added so the default destination setting renders. For the teammate notice, management was turned off and the browser answered/api/auth/mewithowner_ok: false, so the page saw a viewer who is not the Crew's owner. Before onmain, after on this branch's rebuilt frontend:crew स्वतः कनेक्ट करें,डिफ़ॉल्ट गंतव्य crewक्रू स्वतः कनेक्ट करो,डिफ़ॉल्ट गंतव्य क्रूcrew के लिए Kiro साइन-इनक्रू के लिए Kiro साइन-इनरिमोट crew सिर्फ़ Crew के मालिक …रिमोट क्रू सिर्फ़ Crew के मालिक …Remote Crew इसका उल्टा हैरिमोट क्रू इसका उल्टा है~/.kiro/crewpath)The crew switcher's tooltip for a newly added Shared Crew (
instanceTabBar.switch_crew_new_team_crew, nowक्रू बदलो, नया साझा Crewlike its two siblings'क्रू बदलें) needs a relay Shared Crew to appear and was not captured.Happy path: the same page with
locale: 'en-US'still readsAuto-connect crews,Crews you can switch toandDefault destination crew;en.jsonis untouched.Screenshots / video
Settings → रिमोट क्रू (auto-connect toggle and default destination), before and after:
Launch form, teammate notice, feature previews, English
Related Issues
Closes #36383
Sibling sweep
Swept: the bn, hi, ja, ko, zh-CN and ru catalogs with the
crewNounNative.test.tsdetector (a Latincrew/crewsword outside placeholders, code spans, product names and the quoted English labels), plus each capitalisedCrewinhi.jsonagainst its English value (104 values; one, the crew switcher's new-Shared-Crew tooltip, wrote the generic noun asCrewand is fixed here)Sibling: website/src/i18n/locales/hi.json -- changed here
Sibling: src/kiro_crew/docs/ui-index.generated.json -- changed here
Sibling: website/src/i18n/locales/bn.json -- not affected -- fixed in #37301, read by the same test
Sibling: website/src/i18n/locales/ja.json -- not affected -- fixed in #37301, read by the same test
Sibling: website/src/i18n/locales/ko.json -- not affected -- fixed in #37301, read by the same test
Sibling: website/src/i18n/locales/zh-CN.json -- not affected -- fixed in #37301, read by the same test
Sibling: website/src/i18n/locales/ru.json -- not affected -- fixed in #37301, read by the same test
Pattern harvest
Rule candidate: lint
Pattern: a non-glossary term left in Latin script inside a translated catalog value while the catalog has a native spelling for it
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.