Skip to content

fix(i18n): spell crew one way in the hindi catalog - #38370

Merged
KiroCrewCaptain merged 1 commit into
mainfrom
fix/36383-hindi-crew-spelling
Nov 20, 2026
Merged

KiroCrewCaptain merged 1 commit into
mainfrom
fix/36383-hindi-crew-spelling

Conversation

@bolichen97

@bolichen97 bolichen97 commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The Hindi dashboard spells "crew" one way, क्रू, everywhere except the product name, so one screen no longer mixes Latin crew with क्रू.

35 values in the Hindi catalog kept the generic noun crew in Latin letters while about 210 others write क्रू. On Settings → रिमोट क्रू the auto-connect toggle read crew स्वतः कनेक्ट करें directly above वे क्रू जिन पर तुम स्विच कर सकते हो; the launch form said crew के लिए Kiro साइन-इन, and the default destination setting said डिफ़ॉल्ट गंतव्य crew.

Why it matters

A Hindi reader sees the same thing named two ways on one panel and cannot tell whether crew and क्रू are different things. The style guide keeps only product names in Latin script, and nothing stopped a new Hindi value from adding another Latin crew.

Not a goal

  • Rewording any Hindi value beyond the noun, except the verb or gender agreement the noun drags with it, the three values that name the Remote Crew feature or its Settings tab (now the tab's Hindi label रिमोट क्रू), and remoteCrewPanel.reported_host_hint, which lacked a clause its English source has.
  • A capitalised Crew where the English source capitalises it as the name of this install (sharedCrew.* and components.sharedCrews.*, the project hooks notice, Fix with Crew, Crew और Bot).
  • The English title of the "Remote Crew on EC2" guide, ~/.kiro/crew paths, and the quoted English-only Electron dialog label.
  • Other languages' catalogs (fix(i18n): write the generic noun crew in each script in bn, ja, ko, zh-CN, ru #37301 covered bn, ja, ko, zh-CN and ru).

What changed (motivation → approach → change)

Symptom: mixed crew / क्रू on one screen. Cause: older values on the Remote Crew panel and a few other surfaces were written before the catalog settled on क्रू, and the check that keeps a Latin crew out of five other catalogs did not read the Hindi one.

Where Now
hi.json, 35 values whose English uses the generic noun crew / crews / CREW or the Remote Crew name क्रू, in the तुम register and the masculine agreement the rest of the catalog gives it; the three that name the Remote Crew feature or its Settings tab say रिमोट क्रू, the two "Send a copy" hints quote that menu item's Hindi label, एक प्रतिलिपि भेजें, and reported_host_hint gains the clause its English source has
crewNounNative.test.ts reads hi as well, so a Hindi value with a Latin crew or crews fails it
style/hi.md §3 states the rule; §7 lists the check
ui-index.generated.json regenerated: the find_ui index carries the Hindi labels of two edited values

Backwards compatibility

Compatible: catalog text only; no key is added, removed or renamed, and placeholders are unchanged.

Removes nothing: only Hindi display strings change and one locale joins an existing test; no key, path, function or record is taken away.

Tests

  • crewNounNative.test.ts › hi: no value spells the generic noun in Latin letters: fails on main with 25 keys listed, passes after; the other five locales pass both ways. The file's 7 tests pass five runs in a row and with --sequence.shuffle. The other 10 of the 35 edited values (a capitalised Crew or CREW, Remote Crew, a quoted English label) are outside what the scan reads.
  • style/hiStyle.test.ts passes with I18N_BASE_REF set to the base, so its changed-value checks (तुम register, no Latin full stop) judge the 35 edited values.

Proof: not provable -- frontend test (prove.py runs Python only)

Manual verification

On Ubuntu 24.04.5 LTS (Linux x86_64): two isolated gateways on 127.0.0.1 with throwaway KIROCREW_HOMEs, one serving main and one this branch, the dashboard driven by Playwright Chromium with locale: 'hi-IN' (the app picked lang="hi"), first-run screens dismissed, Remote Crew management turned on and one placeholder SSH crew added so the default destination setting renders. For the teammate notice, management was turned off and the browser answered /api/auth/me with owner_ok: false, so the page saw a viewer who is not the Crew's owner. Before on main, after on this branch's rebuilt frontend:

View Before After Latin crew lines
Settings → रिमोट क्रू crew स्वतः कनेक्ट करें, डिफ़ॉल्ट गंतव्य crew क्रू स्वतः कनेक्ट करो, डिफ़ॉल्ट गंतव्य क्रू 4 → 1 (the placeholder crew's own name)
Launch form crew के लिए Kiro साइन-इन क्रू के लिए Kiro साइन-इन 2 → 0
Teammate notice, same tab रिमोट crew सिर्फ़ Crew के मालिक … रिमोट क्रू सिर्फ़ Crew के मालिक … 1 → 0
Feature previews, जुड़े हुए कंप्यूटर hint Remote Crew इसका उल्टा है रिमोट क्रू इसका उल्टा है 3 → 1 (the ~/.kiro/crew path)

The crew switcher's tooltip for a newly added Shared Crew (instanceTabBar.switch_crew_new_team_crew, now क्रू बदलो, नया साझा Crew like its two siblings' क्रू बदलें) needs a relay Shared Crew to appear and was not captured.

Happy path: the same page with locale: 'en-US' still reads Auto-connect crews, Crews you can switch to and Default destination crew; en.json is untouched.

Screenshots / video

Settings → रिमोट क्रू (auto-connect toggle and default destination), before and after:

before: crew स्वतः कनेक्ट करें
after: क्रू स्वतः कनेक्ट करो

Launch form, teammate notice, feature previews, English

before: crew के लिए Kiro साइन-इन
after: क्रू के लिए Kiro साइन-इन
before: रिमोट crew सिर्फ़ Crew के मालिक
after: रिमोट क्रू सिर्फ़ Crew के मालिक
before: Remote Crew इसका उल्टा है
after: रिमोट क्रू इसका उल्टा है
English unchanged

Related Issues

Closes #36383

Sibling sweep

Swept: the bn, hi, ja, ko, zh-CN and ru catalogs with the crewNounNative.test.ts detector (a Latin crew/crews word outside placeholders, code spans, product names and the quoted English labels), plus each capitalised Crew in hi.json against its English value (104 values; one, the crew switcher's new-Shared-Crew tooltip, wrote the generic noun as Crew and is fixed here)
Sibling: website/src/i18n/locales/hi.json -- changed here
Sibling: src/kiro_crew/docs/ui-index.generated.json -- changed here
Sibling: website/src/i18n/locales/bn.json -- not affected -- fixed in #37301, read by the same test
Sibling: website/src/i18n/locales/ja.json -- not affected -- fixed in #37301, read by the same test
Sibling: website/src/i18n/locales/ko.json -- not affected -- fixed in #37301, read by the same test
Sibling: website/src/i18n/locales/zh-CN.json -- not affected -- fixed in #37301, read by the same test
Sibling: website/src/i18n/locales/ru.json -- not affected -- fixed in #37301, read by the same test

Pattern harvest

Rule candidate: lint
Pattern: a non-glossary term left in Latin script inside a translated catalog value while the catalog has a native spelling for it

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 3efd526710f34aef84fbf3a3a57b69155bc7af9f — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the PR changes Hindi catalog text only and adds hi to an existing check. The before and after screenshots are attached.

[DESIGN-REVIEWED] 3efd526

Description read

[DESCRIPTION-READ] 973a8734c6620a29895da8d276d4134ac9f3488f413ee6c23805f5f5cdb8f83d

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 3efd526710f34aef84fbf3a3a57b69155bc7af9f — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks: this is a catalog-text fix tied to #36383, and its one guard extends an existing test to one more locale.

Notes

  • Item 4 — rides along: the extra clause in reported_host_hint is outside the noun fix. It matches the English source (never dials it — the connection rides the crew that reaches it) and the ## Not a goal section declares it, so it adds no surface.

What this change ships

Inventory (6 items) — 5 justified

Intent: Hindi readers see "crew" spelled one way (क्रू) instead of mixed Latin crew and क्रू on the same screen. FIX.

  1. About 35 Hindi strings now say क्रू instead of Latin crew/Crew/CREW — justified
  2. Edited Hindi strings switch from the आप form (करें) to the तुम form (करो) — justified
  3. "Remote Crew" and the Settings tab name now read रिमोट क्रू — justified
  4. The reported-host hint gains the clause its English source has — rides along
  5. The crew native-script test now also reads the Hindi catalog — justified
  6. The Hindi style guide states the rule and lists the check — justified

[FIRST-PRINCIPLES-REVIEWED] 3efd526

Description read

[DESCRIPTION-READ] 84f631e4774353e1424f10f0f31b0cefab2f60092231e6e2d77cd9c682bab613

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 3efd526710f34aef84fbf3a3a57b69155bc7af9f — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks: this PR changes Hindi wording only, and the before/after shots of the four main surfaces show one consistent spelling, क्रू.

Notes

  • instanceTabBar.switch_crew_new_team_crew now reads क्रू बदलो, but the two tooltips beside it say क्रू बदलें. Users will see two politeness levels (बदलो vs बदलें) in one switcher. No screenshot shows this tooltip.
  • The blind reader saw an "Ask the agent" link with a switch drawn over it on the crew row (shots 01, 02 and 09, in Hindi and English). This PR didn't cause it, but it's worth its own issue.

[UX-REVIEWED] 3efd526

Description read

[DESCRIPTION-READ] d0ec5543ab228f9598a5c15921afde570376d81698fc58c27a119e27db90c7ad

That sha256 names everything this verdict read: the PR description, plus the 12 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 3efd526710f34aef84fbf3a3a57b69155bc7af9f — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 3efd526

Verdict parsed from the review's SHA-scoped output markers for commit 3efd526710f34aef84fbf3a3a57b69155bc7af9f.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 3efd526710f34aef84fbf3a3a57b69155bc7af9f false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 3efd526710f34aef84fbf3a3a57b69155bc7af9f and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 3efd526

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 3efd526710f34aef84fbf3a3a57b69155bc7af9f false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 17, 2026
@bolichen97
bolichen97 force-pushed the fix/36383-hindi-crew-spelling branch from a532b35 to ccf7ed9 Compare November 18, 2026 03:16
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in src/kiro_crew/docs/ui-index.generated.json and website/src/i18n/locales/hi.json since this head went green (61bef4e -> ae205cb); CI re-running. Main had added two Hindi values this PR's rule covers, so the same commit now spells them क्रू too: pages.settings.instancesPanel.owner_only (a Latin crew the extended crewNounNative.test.ts would reject after merge) and connectedComputers.preview.hint (Remote Crew -> रिमोट क्रू, the Settings tab's Hindi label).

[operator: bolichen97]

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 18, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in website/src/i18n/locales/hi.json (ae205cb -> 5c7dcb8), and that file conflicted with this branch; CI re-running.

[operator: bolichen97]

@bolichen97
bolichen97 force-pushed the fix/36383-hindi-crew-spelling branch from ccf7ed9 to 9dab0f6 Compare November 19, 2026 15:32
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 19, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

[operator: bolichen97] The one red on this head is Backend Tests (Windows) (5) (https://github.com/kirodotdev/KiroCrew/actions/runs/44555975595/job/135676266270): test_pr_watchers.py::TestCloneLifecycleAndExport::test_the_head_branch_comes_from_the_live_status and ::test_the_pass_fix_is_exported_to_the_pr_queue fail with watcher never reached {'exhausted'}. That is the Windows flake tracked in #39485, not this change: the same node ids fail on main at this PR's base 5c7dcb8 (https://github.com/kirodotdev/KiroCrew/actions/runs/44554922820/job/135682196631), and this PR touches only the Hindi catalog, its style guide, one i18n test and the generated UI index.

The fix is #39545. This PR waits for it to merge, then picks it up and re-runs CI. Every other check on this head is green, and the Design, First Principles and UX reviews pass.

35 Hindi catalog values kept the generic noun crew in Latin letters
while the rest of the catalog writes क्रू, so one screen showed both
spellings (Settings > Remote Crew put "crew स्वतः कनेक्ट करें" beside
"वे क्रू जिन पर ..."). Those values now say क्रू, the three that name
the Remote Crew feature or its Settings tab use the tab's Hindi label
रिमोट क्रू, and a capitalised Crew stays Latin only where the English
source names this install with it.

The catalog check that keeps a Latin crew out of five other catalogs
reads the Hindi one too, style/hi.md states the rule, and the find_ui
index carries the two edited labels it holds.
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in website/src/i18n/locales/hi.json and src/kiro_crew/docs/ui-index.generated.json (5c7dcb8 -> 49e045e); CI re-running.

[operator: bolichen97]

@bolichen97
bolichen97 force-pushed the fix/36383-hindi-crew-spelling branch from 9dab0f6 to 3efd526 Compare November 20, 2026 00:25
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 20, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed head 3efd526. The change only edits Hindi catalog text, adds Hindi to the existing Latin crew check, and updates the Hindi style guide and the regenerated UI index. On this head the crew noun, style, QA and glossary i18n tests all pass. The extended check fails against the base Hindi catalog, so the new guard really catches a Latin crew. The UI index check reports the committed index is current. Placeholders and markup tags are kept, and the quoted menu label matches its real Hindi value, so nothing blocks.

@KiroCrewCaptain
KiroCrewCaptain merged commit c71731b into main Nov 20, 2026
99 checks passed
@KiroCrewCaptain
KiroCrewCaptain deleted the fix/36383-hindi-crew-spelling branch November 20, 2026 01:33
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hindi UI: 'crew' stays in Latin letters in dozens of strings while most say 'क्रू'

2 participants