Skip to content

feat(apps): pin agent-worlds and ops-mission-control for adoption - #38443

Merged
bolichen97 merged 1 commit into
mainfrom
feat/pin-agent-worlds-omc
Nov 17, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
feat/pin-agent-worlds-omc

Conversation

@bolichen97

@bolichen97 bolichen97 commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A host that has Agent Worlds or Ops Mission Control as a built-in moves onto the app's own repository at its next restart, keeping its data, its provider tokens, its settings, its crons and whether the app was enabled.

Both apps now live in their own repositories (KiroCrewCaptain/kirocrew-app-agent-worlds, KiroCrewCaptain/kirocrew-app-ops-mission-control), carrying every change their wheel copies have on main, with green CI on ubuntu, macOS and Windows. Their last blockers have merged: #37426 (an app page reads the person's sessions through the SDK, which Agent Worlds' page calls) and #37459 (the agent's file tools fence an installed app's credentialMasks, which keeps Ops Mission Control's moved token store fenced as tightly as today's root file). The wheel's adoption pin table names neither app yet, so no host adopts them and every fix to either keeps having to land twice.

Why it matters

Until a pin row exists, neither app can leave core: every host keeps running the wheel copy, and the removal of the built-ins in #26967 cannot start for them.

Not a goal

  • Changing the adoption machinery, the D12 equality rule, the seam-level scan in scripts/adoption_pin.py, or either app's declared permissions or credential masks.
  • Deleting either wheel copy (src/kiro_crew/apps/builtins/agent_worlds/, the Worlds page under website/src/pages/, src/kiro_crew/apps/builtins/ops_mission_control/, website/src/apps/ops-mission-control/); only each app.json version moves.
  • Moving the wheel copy's Ops Mission Control token store or removing its core rows: ops_mission_control_secrets.json stays fenced, and the adopted tree keeps it as its downgrade copy. That is fix: move ops secret store under its data dir and declare its mask #34296's lane.
  • Changing any other pin row, and pinning code-review-sage, mochi or crew-companion.

What changed (motivation → approach → change)

Each app gets an adoption pin row, so at its next restart a host whose record is the built-in switches to the app's own repository at the pinned commit, keeping data/, .app_secret, the grants, the crons and the enabled flag. Each row is the output of scripts/adoption_pin.py compute, copied into adoption-pins.json and the _SHIPPED_PINS table, after code-review-sage's:

App Version Pinned commit minAppSdkLevel
agent-worlds 1.0.0 to 1.0.2 433c1e48900b 8 (useHostSessions, which its page calls)
ops-mission-control 0.1.0 to 0.1.2 92e26de80e09 10 (the credentialMasks directory entry secrets/)

Each wheel built-in app.json version moves to its pin's: a first-adoption pin must equal it (D12). compute accepts Agent Worlds at 7 (it reads only the manifest and Python, and finds the exact permissions.api entries); the row says 8 because the page calls useHostSessions (app-kit-platform §18j). Ops Mission Control's "credentialMasks": ["secrets/"] is refused below 10 since #37459.

E9 holds nothing back for either app. Agent Worlds' repository declares the same permissions.api list as its wheel copy and nothing else. Ops Mission Control's declares the same permissions and agentTools as its wheel copy, plus the secrets/ mask, which only narrows what an agent reaches. Its crons keep their names, schedules and enabled flags; their prompts name the SOPs at the adopted skill's path.

Ops Mission Control's adopted tree keeps the provider tokens in data/secrets/secrets.json, which the OS sandbox and the agent's file tools both mask. On its first read with no store there, it copies the data-home root ops_mission_control_secrets.json in and keeps that file, rewritten on every save or revoke, as the copy a downgraded wheel copy reads, so core's rows for it stay.

What the pinned trees carry. Agent Worlds was ported from main 33979525d8; its wheel-copy changes since, #37426 (the port's basis), #37549 (no polling from a hidden tab) and #38097 (lucide chevrons), are in KiroCrewCaptain/kirocrew-app-agent-worlds#3, released as 1.0.2 by KiroCrewCaptain/kirocrew-app-agent-worlds#4. Ops Mission Control was synced to main af94fac51f; KiroCrewCaptain/kirocrew-app-ops-mission-control#5 carries every change since: #37218 (the ledger import stands down while a memory provider replaces Crew's memory), #38368 (Japanese strings), the comment-only #37469 and #37953, and the fixture updates #37408 and #37597 the newer host needs; KiroCrewCaptain/kirocrew-app-ops-mission-control#6 released 0.1.2. The test-home changes #38037, #38040 and #38041 serve core's temp-dir residue guard and are not ported. No later commit, up to main 758622b385, touched either wheel copy, its strings or its store art.

App repo: KiroCrewCaptain/kirocrew-app-agent-worlds@433c1e4

App repo: KiroCrewCaptain/kirocrew-app-ops-mission-control@92e26de

Wheel-copy base: agent-worlds@2e2503671fed2ca0b5c76bcf158e75fe34eae0e7

Wheel-copy base: ops-mission-control@2e2503671fed2ca0b5c76bcf158e75fe34eae0e7

The owning specs record the adoption (app-kit-platform §18j, ops-mission-control.md).

Merge order: #38478 (code-review-sage), which also appended a row after md-notebook in both files, has landed; these two rows follow its row in both files.

#34296 (open, conflicting) moves the wheel copy's store to data/secrets.json. This pin does not depend on it: an adopted host runs the repository tree, which moves the store itself. Once this lands, that change also lands in the app repository first (its App repo: line), matching the repository's data/secrets/ layout, as the layout note on #34296 asks.

Backwards compatibility

Compatible: two rows are added and two versions move up. A host whose record is builtin-owned adopts at the next restart and keeps data/, .app_secret, the grants, the crons and enabled. A host that cannot adopt (an older SDK level, a pending config review, a file beside app.json) keeps the wheel copy unchanged.

Removes nothing: both wheel copies, their /worlds and /ops-mission-control routes, Ops Mission Control's root token file and its core rows, and every existing pin row stay.

Tests

test/test_builtin_adoption_pins.py::test_the_shipped_pin_file_validates_and_pins_exactly_the_shipped_table takes the two new rows and fails with the pin file of main; test_every_shipped_pin_matches_its_wheel_built_in_version holds the two version bumps.

Proof: PROVEN test/test_builtin_adoption_pins.py::test_the_shipped_pin_file_validates_and_pins_exactly_the_shipped_table (head 08b28a5)

Determinism: no test logic changes, only the pinned data table. Run serially on this branch: every test/ file that names adoption_pin, adoption-pins, agent_worlds, agent-worlds, ops_mission_control or ops-mission-control (52 files, test_builtin_adoption_*.py, test_agent_worlds_permission_parity.py, test_builtin_permission_parity.py, test_core_ops_mission_control_decoupling.py, test_app_agent_tools_adopted.py and test_released_builtin_skill_copies.py among them), both wheel copies' tests/ and test/test_flake_pattern_ratchet.py: 5454 passed, 7 skipped. Black, isort, flake8, mypy, subprocess-encoding, comment-history, brand-name, line-cap and harness-parity gates and scripts/docs-lint.sh pass. .github/scripts/adopted_wheel_copy_check.py passes on this body, and fails when the two Wheel-copy base: lines name the previous port bases 33979525d8 and af94fac51f (naming agent_worlds/app.json, and ledger_index.py, models.py and SettingsPanel.tsx). No frontend change.

Manual verification

scripts/adoption_pin.py compute with a throwaway HOME and KIROCREW_HOME: agent-worlds at 433c1e48900b with --min-sdk-level 8 prints the committed row, and 7 prints the same row at 7 while 6 is refused for the exact permissions.api entries; ops-mission-control at 92e26de80e09 with --min-sdk-level 10 prints the committed row, and 9 is refused for the credentialMasks tool-gate use. Each pinned commit is the head of its repository's main, with every check run green. Every row measured over the network before #38478 landed (one at a time, since verify stops at its first refusal): sixteen rows ok, both new ones included; the rebase onto it changes neither new row. md-notebook's row, unchanged here, is refused: it was pinned at 8 one hour before #37459 made any credentialMasks a level-10 use.

Upgrade smoke on isolated loopback gateways (throwaway homes, each app's row as KIROCREW_HARNESS_ADOPTION_PINS, a real GitHub fetch). Each home was first booted on main with an empty harness table, so the record was the built-in, then this branch booted twice (STAGE, APPLY), once with the app enabled at the upgrade and once with it disabled.

Agent Worlds (a marker file in data/, since the app keeps no state of its own):

Check Enabled Disabled
Boot 1 stages the pinned commit; the record stays the built-in PASS PASS
Boot 2 adopts: origin: registry, commit 433c1e48900b, version 1.0.2, enabled kept PASS PASS
data/ byte-equal, grants kept, trust bound to the repository PASS PASS
/api/apps row carries the legacy nav /worlds, Gamepad2 PASS PASS
The bundle served is the pinned ui/dist/index.mjs; /worlds and /apps/agent-worlds render in headless Chromium with no page error PASS PASS
The page's declared reads (/api/crons, /api/spawn, /api/chat/slots, ...) answer 200 PASS PASS (after enable)
No agent tool or MCP server listed for it, none expected PASS PASS
Boot 3 is a no-op; disable, enable, restart PASS PASS
Uninstall keeps only data/; after a restart no built-in comes back PASS PASS
Reinstall from the store (trust prompt, install, enable, restart): same data, one record PASS PASS

The refusal of a path outside permissions.api happens in the browser SDK, so a gateway probe cannot see it; the app's tests and AppSdkHostSessions.test.tsx pin it.

Ops Mission Control (a provider token saved through the app's own route into the root file, settings, a ledger entry, a cron moved off its default):

Check Enabled Disabled
Boot 1 stages the pinned commit over git; the record stays the built-in PASS PASS
Boot 2 adopts: origin: registry, commit 92e26de80e09, version 0.1.2, enabled kept, trust bound to the repository, legacy nav /ops-mission-control, Radio PASS PASS
config.json, ledger.jsonl, the grant store, the policy file and the root token file unchanged PASS PASS
The four crons keep their ids, schedules and enabled flags (the switched-off ledger-hygiene included); the SOP path their prompts name exists PASS PASS (none while disabled, as on main)
The bundle served is the pinned ui/dist/index.mjs; /ops-mission-control and /apps/ops-mission-control answer 200 PASS PASS
GET /state shows the provider configured; the first read copies the token into data/secrets/secrets.json (0600 in a 0700 directory), same value by hash, root file kept PASS PASS (after enable)
The agent's file tools refuse both token files and a temp file beside the store, read and write, and the hook denies a file read of both; a ledger read is allowed PASS PASS (also before the move)
Inside the agent sandbox (standard and strict), cat cannot read either token file, while the ledger reads PASS PASS
ops_mission_control_api is listed and GET /state answers 200 through it; a path outside its list is refused PASS PASS
Boot 3 is a no-op; disable, enable, restart PASS PASS
Uninstall keeps data/ with secrets/ and the root file; after a restart no built-in comes back PASS PASS
Reinstall from the store (trust prompt, install, enable, restart): one record, token and ledger intact PASS PASS

Disabling and enabling the adopted app re-creates its crons from the manifest, so a cron the person switched off comes back at its default; the built-in on main does exactly the same, so this pin changes nothing there.

No ERROR or traceback in any Ops Mission Control gateway's stderr across 14 boots. The only tracebacks in the Agent Worlds runs come from the dashboard's own ACP spawns when the headless browser opened it ("Not logged in": the throwaway homes have no CLI login), the same in a built-in baseline home. Reinstall ran against the published catalog with only the app's row switched to git at its pinned commit (the KiroCrewApps PR below), served at official_catalog._open_catalog; with today's builtin rows an adopted record has no install source until that PR lands, as for every earlier pin.

Related Issues

Part of #26967

Unblocked by #37426 and #37459. Catalog rows: the kirodotdev/KiroCrewApps PR linked in a comment below switches both apps to git at the same commits. It is not auto-merged: the driver merges it right after this PR lands.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 08b28a5efef06ca3e9ee99c053454c5a82680605 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@bolichen97

Copy link
Copy Markdown
Contributor Author

Catalog rows: kirodotdev/KiroCrewApps#86 switches agent-worlds and ops-mission-control to git sources at the two commits this PR pins (433c1e48900b, 92e26de80e09). It is not auto-merged; it lands right after this PR.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 08b28a5efef06ca3e9ee99c053454c5a82680605 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Data-only pin rows that follow the code-review-sage precedent; nothing is taken away, and a host that cannot adopt keeps running the wheel copy.

Notes

  • To meet D12, each wheel copy now reports the pinned version (1.0.2 and 0.1.2) without the app repositories' code changes. A host that cannot adopt (older SDK level, pending review) will show a version number its code doesn't match. This is reversible and goes away once the built-ins are removed under Move every built-in app out to KiroCrewApps and forbid built-in apps #26967.

[DESIGN-REVIEWED] 08b28a5

Description read

[DESCRIPTION-READ] 1f35bd27a48d2bc3b3a29c4f153191cbfa7efd4648b198484c11c611e9ca6cb1

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 08b28a5efef06ca3e9ee99c053454c5a82680605 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

This is data only: two pin rows and the two version bumps they require. AGENTS.md's "No built-in apps" rule and #26967 require these apps to leave core, so it isn't a product-shape choice made inside this PR.

Not checked: whether the pinned commits and hashes match the external repositories' contents.

What this change ships

Inventory (6 items) — 6 justified

Intent: let hosts running the built-in Agent Worlds or Ops Mission Control switch to each app's own repository at restart, keeping their data. ADDITION.

  1. Hosts with built-in Agent Worlds switch to the app's own repository at the next restart (pin row, SDK level 8) — justified
  2. Hosts with built-in Ops Mission Control switch to the app's own repository at the next restart (pin row, SDK level 10) — justified
  3. Agent Worlds' wheel copy reports version 1.0.2 instead of 1.0.0 — justified
  4. Ops Mission Control's wheel copy reports version 0.1.2 instead of 0.1.0 — justified
  5. The owning specs record each adoption and the downgrade copy of the token file — justified
  6. The shipped-pins test table carries both new rows — justified

[FIRST-PRINCIPLES-REVIEWED] 08b28a5

Description read

[DESCRIPTION-READ] c80f30032e3fc4c28ad4c847afd51b1ba6da2dbfad968726a277914d9603078d

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 08b28a5efef06ca3e9ee99c053454c5a82680605 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 08b28a5

Verdict parsed from the review's SHA-scoped output markers for commit 08b28a5efef06ca3e9ee99c053454c5a82680605.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 08b28a5efef06ca3e9ee99c053454c5a82680605 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 08b28a5efef06ca3e9ee99c053454c5a82680605 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 08b28a5

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 08b28a5efef06ca3e9ee99c053454c5a82680605 false-positive: <reason, 20 to 500 characters>

@bolichen97
bolichen97 force-pushed the feat/pin-agent-worlds-omc branch 2 times, most recently from b43dfe0 to b26fa70 Compare November 17, 2026 14:12
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Nov 17, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Review on head b26fa70 found no blocking issues. The core diff is data only: two pin rows in adoption-pins.json and in the test table, plus the two wheel version bumps that D12 requires. Reviewers recomputed each row's archive sha256 and tree digest with this head's own adoption code, and both match. pinned_tree_refusal returns none for both trees. The SDK level scan gives Agent Worlds level 8 (it is refused at 6) and Ops Mission Control level 10 (it is refused at 9). test/test_builtin_adoption_pins.py passes (94 tests), and a revert of each hunk turns a test red. Both pinned commits are the current main of their app repositories, and permissions, agentTools and cron tuples match the wheel copies.

Security: core security code does not change here. The pinned Ops Mission Control tree adds credentialMasks: ["secrets/"], which only narrows what an agent can reach. The root token file and its core mask rows stay in place as the downgrade copy, so a host that rolls back keeps its tokens fenced.

Done well: every integrity claim in the body can be reproduced, including the level just below each pin that is refused, and the Wheel-copy base commits make the port easy to audit.

Optional:

  • The App repo: hygiene gate only watches src/kiro_crew/apps/builtins// and website/src/apps//. Agent Worlds' page under website/src/pages/ (WorldsPage.tsx, scenes/, useAgentSync, usePopoutSync) and src/kiro_crew/builtin_skills/ops-mission-control/ are outside it. Once this pin lands, an edit there can drift away from adopted hosts and nothing warns. A follow-up issue could let a pin row name extra wheel-copy paths.
  • The body reports that the md-notebook row on main fails verify, because #37459 counts credentialMasks as level 10. Only PR bodies record this so far. Consider an issue or a one-row PR that re-pins it at 10.

@github-actions github-actions Bot added readiness: checking Automated validation is still running merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: passed Eligible automated validation passed for the current revision labels Nov 17, 2026
Agent Worlds and Ops Mission Control now live in their own
repositories under KiroCrewCaptain, carrying every wheel-copy change on
main, with green CI on ubuntu, macOS and Windows. Their rows are the
output of scripts/adoption_pin.py compute and are added to
adoption-pins.json and the _SHIPPED_PINS table, so a host whose record
is builtin-owned moves onto the app's own tree at its next restart and
keeps data/, the app secret, the grants, the crons and enabled.

Agent Worlds is pinned at minAppSdkLevel 8, the level of the
useHostSessions export its page calls. Ops Mission Control is pinned at
10: its tree keeps the provider tokens in data/secrets/ behind a
credentialMasks directory entry, which the agent's file tools fence
from that level (#37459); it copies the data-home root store in on
first read and keeps it as the downgrade copy.

Each wheel built-in app.json version moves to its pinned version, since
a first-adoption pin must equal it (D12). Both repositories declare the
same permissions as their wheel copy (Ops Mission Control adds only the
mask, which narrows), so E9 holds nothing back. The owning specs record
the adoption.

Part of #26967
@bolichen97
bolichen97 force-pushed the feat/pin-agent-worlds-omc branch from b26fa70 to 08b28a5 Compare November 17, 2026 16:05
@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 17, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed head 08b28a5, a rebase of the previously approved b26fa70 onto current main. The range-diff shows identical added lines, and only the context row changed. The two new pins for agent-worlds and ops-mission-control are byte-identical to the earlier head. Main's code-review-sage row stays intact in both the adoption pin file and the test's shipped-pin table, with the new rows appended after it in the same order. The adoption pin test module passes on this head, and I found no behavioural, security or test defect blocking the merge.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 17, 2026
@bolichen97
bolichen97 merged commit eb15dd8 into main Nov 17, 2026
103 of 109 checks passed
@bolichen97
bolichen97 deleted the feat/pin-agent-worlds-omc branch November 17, 2026 17:12
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 17, 2026
KiroCrewCaptain pushed a commit to kirodotdev/KiroCrewApps that referenced this pull request Nov 17, 2026
…tories (#86)

Both former built-ins switch from a builtin source to a git source in
their KiroCrewCaptain repositories, pinned at the commits Kiro Crew's
adoption pin table names for them in kirodotdev/KiroCrew#38443:
agent-worlds 433c1e48900b (1.0.2) and ops-mission-control
92e26de80e09 (0.1.2). Each row gets the note the other adopted apps
carry and the KiroCrewCaptain author URL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants