Skip to content

feat(relay): list Team Crews with no settings and host a team Crew from its key alone - #38801

Open
cruisercohen wants to merge 2 commits into
mainfrom
relay-zero-config
Open

cruisercohen wants to merge 2 commits into
mainfrom
relay-zero-config

Conversation

@cruisercohen

@cruisercohen cruisercohen commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A desktop app user sees the Team Crews they can open with nothing to set, and a team Crew host goes live from its crew API key alone.

Today a desktop app user sees no Team Crews until someone runs kirocrew config set tunnel.relay_viewer_enabled true. A hand-set tunnel.relay_viewer_relay_domain can also filter the list and pin where a Crew opens. A team Crew host needs three steps: the credential reference, tunnel.relay_lease_token_type set to API_KEY, and kirocrew remote-control on.

Why it matters

People added to a team Crew expect to open it from the desktop app after signing in, and a hidden config key means most never see the list. Flipping a default would not reach them: config.json stores every key, so a changed default reaches only new installs. Each extra host setting is one more way for a team host setup to go wrong.

Not a goal

  • Turning on hosting for personal Crews. A Kiro sign-in alone never starts hosting, and Remote Control stays off by default.
  • Showing Team Crews in a browser tab or the installed web app. The desktop bridge gate stays.
  • Reading a crew API key from the environment.
  • Making a workload-identity host usable. That waits for the workload identity changes.

What changed (motivation → approach → change)

Client. The gate is a stored setting, so it is removed, not flipped.

  • dashboard/handlers/relay_viewer.py: the crews, seen and token routes always answer, with their checks unchanged. A set relay domain is ignored, with one warning in the gateway log; each Crew opens at the address the control plane lists. tunnel.relay_viewer_enabled stays in config/integration_sections.py as a deprecated, ignored field so an existing config still loads; config-baseline.json and the comments in website/src/api/client.ts follow.
  • useRelayViewerCrews.ts: signed out, remote access off, access denied, or a generic load failure hides the Team Crews group and the Shared Crews cards; the gateway log keeps the code (relay viewer: crews -> <code>). Refusals about a listed Crew, a throttle or setup still show; a loaded list stays through a failure.
  • While refused or signed out the list is read every 15 minutes, never sooner than a throttle asks.

Because a signed-out user sees nothing in Team Crews, the list-level sign-in item and links #38437 and #38304 added under that notice never show; sign-in stays in Settings, and a listed Crew's Open refusal still links to the Kiro account tab.

Host.

  • relay_client/provider.py, lease.py: with tunnel.relay_lease_token_type empty, a credential stored as secret://NAME or an absolute file path sends API_KEY. The new value NONE sends no type.
  • remote_control/defaults.py, setting.py, guard.py, cli.py: a set lease credential (not empty and not kiro-sign-in) starts hosting at the next start. Turning Remote Control off writes the new tunnel.relay_turned_off (config/section_builders.py).

Exposure: Only hosts with a team key or a workload credential in tunnel.relay_lease_credential start hosting, on every build except LTS, which ignores the tunnel settings. An organization with remote access off refuses the host, which retries every 15 minutes at most; a Builder ID or social sign-in is refused locally. Personal hosting on your own sign-in stays opt-in with kirocrew remote-control on. Turning Remote Control off writes tunnel.relay_turned_off, which outranks the key; a malformed marker, an off overlay over an unreadable config.json, or an unreadable config.local.json over a key-only host also keeps it off. Settings cannot clear that marker, and the dashboard still cannot turn Remote Control on.

Release note: "A host that was not hosting before this release does not start hosting because of it; turn it on with remote-control on. A fresh install whose config.json already holds a key before this release first loads it needs remote-control on too."

Upgrade: on the first load by this build, config/migration.py writes only tunnel.relay_turned_off: true to config.json, once, under the config write lock, when the merged config stores a key with no marker and relay_enabled not true; the check leaves one adoption ledger record on every host, which shows nowhere unless the marker was written; a later load never overwrites a recorded marker. If config.local.json turned hosting off over a stored true, removing that line turns hosting back on: a stored true outranks the marker. A seeded pod's floor writes it too (pod/runtime.py).

Docs: remote-crew.md gives the team host setup: a key in Settings > Secrets, one config set line, restart.

Backwards compatibility

Reader: src/kiro_crew/dashboard/handlers/relay_viewer.py:_settings -- crew page -- stops reading the viewer flag and the domain; test_every_route_answers_with_the_old_setting_false
Reader: src/kiro_crew/auth/service.py:_load_relay_viewer_cps_url -- crew page -- stops reading the viewer flag; test_poll_idc_asks_the_relay_viewer_control_plane_first
Reader: src/kiro_crew/dashboard/handlers/config_all_settings.py:READONLY_PATHS -- crew page -- drops the deprecated flag, adds the off marker; test_config_all_settings.py
Reader: website/src/components/TeamCrewsGroup.tsx:TeamCrewsSwitcher -- chat -- hides on a quiet refusal; TeamCrewsGroup.test.tsx "shows no sign-in item and no notice for a hidden 409 SIGNED_OUT list refusal"
Reader: website/src/components/SharedCrewsCards.tsx:SharedCrewsCards -- crew page -- hides with the hook; SharedCrewsCards.test.tsx "renders nothing on a 409 SIGNED_OUT list refusal"
Reader: src/kiro_crew/config/superseded_defaults.py:adopted_superseded -- doctor -- leaves out a Remote Control check that changed nothing; test_doctor_says_nothing_about_adoption_when_none_happened
Reader: src/kiro_crew/edition_locks.py:relay_selected -- release -- follows the credential rule; test_remote_control_credential_hosting.py

Tests

The 15 new and changed Python test files pass 663 of 663, three runs in a row, and the 23 ratchet test files pass 330 of 330. Determinism: the round's new and changed host tests passed 20 runs at -n0 (87 each), 10 at -n 4 beside two sibling files (191 each) and one shuffled run (seed 4781, 87 passed). The backend scoped run's only failures also fail on main without this change, in files this PR does not touch.

  • Client: the routes answer with the old flag false; a set domain is ignored with one warning; the Team Crews group and the Shared Crews cards hide on signed out, remote access off, access denied and generic failures; a loaded list stays through a server error; the poll waits 15 minutes after an access refusal, honours Retry-After, stops while signed out and lists the Crews once a sign-in lands, without a reload.
  • Host: test_relay_client_lease_token_type.py (empty type sends API_KEY for a secret or a file, NONE sends none, a workload reference is never a crew key) and test_remote_control_credential_hosting.py (a set credential starts hosting, a sign-in alone never does, off is kept across reload and Settings, the browser cannot clear the marker).
  • Upgrade: test_remote_control_legacy_off.py (a host not hosting before stays off, a key held only in config.local.json too, remote-control on clears it, a key set later hosts, a downgrade and re-upgrade never re-run it, a failed marker write or a degraded load stays off without crashing, an unreadable ledger keeps it off and is left as is, two loads at once write once, an overlay off over a stored true lands the marker and the record, a writer turning hosting on during the write wins, an unreadable overlay keeps a key-only host off with nothing written, a stale record never overwrites a written marker's, a briefly unreadable overlay does not keep a working host off, an overlay with no config.json keeps a host that looks off off, the notice) and test_pod_seed_relay_off.py.
  • Each new test fails without its change.

Proof: PROVEN test/test_kas_login_service.py::test_poll_idc_asks_the_relay_viewer_control_plane_first[old-setting-off], test/test_pod_env.py::TestSeedSanitization::test_overwrites_non_dict_tunnel, test/test_relay_client_lease.py::test_the_token_type_setting_names_the_lease_calls_header[-API_KEY], test/test_relay_client_lease.py::test_a_refused_credential_stop_names_the_token_type_for_each_kind_of_credential, test/test_relay_client_lease_profile.py::test_the_default_config_sends_todays_bytes (head 57e17332fc6b)

Manual verification

A desktop app check was not run. The screenshots below are from our own static build of the dashboard on 127.0.0.1 in headless Chromium, with the desktop bridge stubbed and mock data only. A real lease call needs a crew API key and is left to the release check.

Screenshots / video

Crew switcher, signed in with a mock Team Crew: the Team Crews group lists it.

Team Crews group, signed in

Crew switcher, signed out: no Team Crews group and no notice.

Team Crews hidden, signed out

After a loaded list, a re-read that answers a server error: the list stays

Team Crews kept through a server error

Related Issues

N/A

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 47e36483b3afd677f3d34feab2d40c9af43bceec — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: existing hosts stay off through the one-time off marker, the tunnel lock still caps hosting, and the reshaped Team Crews surface comes with three rendered images.

Notes

  • Most of the new upgrade logic exists only because a stored credential now starts hosting: the in-memory keep-off for unreadable files, the module-level _RELAY_KEEP_OFF_PATHS and _RELAY_RETRIED_PATHS sets, and the in-lock relay_base_seen compare. Inferring the token type alone would cut team host setup to credential plus remote-control on, with none of that state machine. Re-weigh whether skipping that one step is worth carrying the machinery for good.
  • The off marker, tunnel.relay_turned_off, is written to every upgraded config.json that holds a credential. If credential-starts-hosting is ever reverted, that key stays on disk as a dead field. Plan its removal the way relay_viewer_enabled is handled here: deprecated, ignored, still loads.
  • The PR does two separate things: it removes the viewer gate on the client, and it lets a credential start hosting on the host. They could ship and revert separately. The client half has no upgrade risk and should not have to be rolled back if the host half is.

[DESIGN-REVIEWED] 47e3648

Description read

[DESCRIPTION-READ] 43e174a8c54e8316f41cbea0505dfe822a9cc73e82cbbe1e309d4e778019628d

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — 🔴 BLOCK

Premise-level review of 47e36483b3afd677f3d34feab2d40c9af43bceec — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: BLOCK

product-shape change without accepted RFC: the Team Crews list is now always on for everyone, and setting a lease credential now starts hosting. No RFC on the base commit records either default.

Notes

  • Item 3 — rides along: "A set relay domain is ignored" removes the domain filter and pin. The Goal ("with nothing to set") does not need that, and no defect is cited. Subtraction: keep reading tunnel.relay_viewer_relay_domain in relay_viewer.py and drop the warning plus the rewritten test_a_crew_is_kept_only_under_the_set_domain_or_with_none_set.
  • Item 5 — rides along: with an empty relay_lease_token_type, a secret:///file credential now sends API_KEY, so an existing IAM Identity Center–token host has to learn about NONE. Subtraction: defer the empty→API_KEY default and TOKEN_TYPE_NONE, and let the team host set API_KEY in its one config line.

What this change ships

Inventory (8 items) — 4 justified

Intent: a desktop user sees their Team Crews without any config, and a team Crew host goes live from its key alone. ADDITION.

  1. Team Crews group and Shared Crews cards show by default, with no flag — product shape, no RFC
  2. Signed-out, access-off, denied and generic failures hide the list; a refused list is polled every 15 min — justified
  3. A set relay domain no longer filters the list or pins where a Crew opens — rides along
  4. The list-level sign-in item and its links never show — justified
  5. Empty token type sends API_KEY for a stored credential; new NONE value — rides along
  6. A set lease credential starts hosting at the next start — product shape, no RFC
  7. New tunnel.relay_turned_off marker, written by Remote Control off — justified
  8. Upgrade migration writes the off marker on hosts that were not hosting — justified

Blockers

product-shape change without accepted RFC: Team Crews on by default (item 1)
Trigger: "The gate is a stored setting, so it is removed, not flipped". Every route now answers whatever tunnel.relay_viewer_enabled says. The base RFC list has no non-draft entry for the relay viewer or Team Crews.
Outcome: the default for every desktop install changes, and nobody recorded that decision.
Clears when: an RFC covering the always-on Team Crews list is merged non-draft on the base (then push or rebase), or a maintainer posts /ai-review override first-principles 47e36483b3afd677f3d34feab2d40c9af43bceec product-shape: <decision>.

product-shape change without accepted RFC: hosting starts from the credential (item 6)
Trigger: "a set lease credential (not empty and not kiro-sign-in) starts hosting at the next start". Remote Control used to need an explicit remote-control on. No non-draft RFC on the base list covers this.
Outcome: what Remote Control does by default changes for credential-bearing hosts, and nobody recorded that decision.
Clears when: an RFC covering credential-triggered hosting is merged non-draft on the base (then push or rebase), or a maintainer posts /ai-review override first-principles 47e36483b3afd677f3d34feab2d40c9af43bceec product-shape: <decision>.

[FIRST-PRINCIPLES-REVIEWED] 47e3648

Description read

[DESCRIPTION-READ] 93056589f92a749f3a1f003c7df972ba7f42a5c4bc33b03a343ec7b53af542f8

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 47e36483b3afd677f3d34feab2d40c9af43bceec — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

No new controls. Both states this PR changes are in the screenshots: the Team Crews group showing (shot-01) and hidden (shot-02).

Notes

  • When the user is signed out, the whole Team Crews group now disappears, and so does the sign-in item fix: make Team Crew screens work for teammates over the relay #38437 added. The blind reader said: "Nothing on screen says why the team part is missing." Someone who has just been added to a team gets no hint to sign in. Consider one muted "Sign in to see Team Crews" row that shows only for SIGNED_OUT.
  • The reader could not tell green "connected" (Build host) from green "online" (Platform team). This PR doesn't change those labels, so it's a follow-up.

[UX-REVIEWED] 47e3648

Description read

[DESCRIPTION-READ] 2e7685159a52947aba58a75aef36e9fbd98d1bb9b01d742bf9572656898e2883

That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 47e36483b3afd677f3d34feab2d40c9af43bceec — this comment is updated in place on each push.

Review details

No findings.

Notes:

  • The comment at src/kiro_crew/config/loader_pipeline.py:523 says the Remote Control check is "Decided on the base … before the overlay merge", but the code at lines 598–606 decides it on the merged view after the merge.

[OPUS-REVIEWED] 47e3648

Verdict parsed from the review's SHA-scoped output markers for commit 47e36483b3afd677f3d34feab2d40c9af43bceec.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 47e36483b3afd677f3d34feab2d40c9af43bceec false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — 🔴 changes requested (blocking)

GPT 6.1 found at least one blocking issue that must be resolved before merging 47e36483b3afd677f3d34feab2d40c9af43bceec. 1 of 1 blocking finding(s) are security-class and were withheld from adjudication, so the blocking verdict stands.

This comment is updated in place on each push.

BLOCKING -- src/kiro_crew/config/loader_pipeline.py:1440 -- Cache-hit reloads can lose Remote Control’s keep-off decision (origin: validation)

if doc.relay_keep_off:
Trigger: On a running credential-only host with relay_enabled: false, an unsealed hand edit changes relay_turned_off from false to "true". The /api/remote-control worker publishes the validated cache, then ConfigWatch._load_with_doc() consumes it before the first worker reaches persist_write_back().
Outcome: The cache-hit document loses relay_keep_off. The watcher sees the previous hosting-enabled values, finds no tunnel change and advances its fingerprint; the relay therefore keeps running instead of applying the malformed marker’s keep-off decision.
Anchor: defect
Fix: Store relay_keep_off in the validated-cache sidecar and restore it on cache hits, so each cached document preserves the decision independently of the process-wide set.
Sites: src/kiro_crew/config/loader_pipeline.py:425 (cache-hit reconstruction); src/kiro_crew/config/loader_pipeline.py:780 (cache publication).
[BLOCK-MERGE] 47e3648
[GPT-REVIEWED] 47e3648

Adjudication (Opus 5.5) — is blocking on each finding proportionate?

F1 (fenced; I'm upholding it). I checked the conditions in the code:

  • A cache hit at src/kiro_crew/config/loader_pipeline.py:425-435 rebuilds the ConfigDocument with no relay_keep_off, and the cache entry written at src/kiro_crew/config/loader_pipeline.py:782-792 never stores it.
  • A hand edit like "true" sets keep-off through _relay_marker_malformed (src/kiro_crew/config/migration.py:208). But the only thing that carries keep-off across loads is the process-wide set, filled at src/kiro_crew/config/loader_pipeline.py:1440-1441, and that runs only when persist_write_back runs.

So a watcher load in that gap can leave a remote-access tunnel running against the operator's off choice, with no retry on unchanged bytes. The race window is narrow, but the inputs are ordinary (a hand edit plus a concurrent API request), so a FLAG isn't justified.

[ADJUDICATION] 47e36483b3afd677f3d34feab2d40c9af43bceec total=0 uphold=0 downgrade=0
[GPT-ADJUDICATED] 47e36483b3afd677f3d34feab2d40c9af43bceec

[ADJUDICATION-FENCED] 47e36483b3afd677f3d34feab2d40c9af43bceec fenced=1 flagged=0
UPHOLD-FENCED F1 src/kiro_crew/config/loader_pipeline.py:1440 -- The cache sidecar drops relay_keep_off and only persist_write_back fills the process-wide set, so a concurrent cache-hit reload can keep Remote Control hosting against an operator's off marker, from an ordinary hand edit and API call, not an extreme combination.
[GPT-ADJUDICATED-FENCED] 47e36483b3afd677f3d34feab2d40c9af43bceec

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 47e36483b3afd677f3d34feab2d40c9af43bceec false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added the readiness: action required A blocking check or review needs attention label Nov 17, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 18, 2026
@cruisercohen

Copy link
Copy Markdown
Contributor Author

span=5749030c4a14

fixed in cc8ba49: the pod seed floor (_apply_seed_config_floor in src/kiro_crew/pod/runtime.py) now also writes tunnel.relay_turned_off: true, so a seeded pod that keeps a lease credential does not select the relay.
test/test_pod_seed_relay_off.py::test_a_seeded_credential_does_not_start_hosting seeds a credential and asserts relay_selected is False; it fails without the change.

@cruisercohen

Copy link
Copy Markdown
Contributor Author

span=5749030c4a14

fixed in cc8ba49: a one-time adoption in src/kiro_crew/config/migration.py writes only tunnel.relay_turned_off: true on the first load by this build, under the config write lock, when a lease credential is stored with relay_enabled: false and no marker. The adoption ledger records the check so it never runs again.
test/test_remote_control_legacy_off.py::test_a_host_turned_off_before_the_upgrade_stays_off covers the turned-off host; the same file covers a key only in config.local.json, remote-control on clearing it, a downgrade and re-upgrade, and a failed write staying off.

@cruisercohen

Copy link
Copy Markdown
Contributor Author

span=236aa930dc94

fixed in cc8ba49: a one-time adoption in src/kiro_crew/config/migration.py writes only tunnel.relay_turned_off: true on the first load by this build, under the config write lock, when a lease credential is stored with relay_enabled: false and no marker, so an upgrade does not re-enable a host that was turned off. The adoption ledger records the check so it never runs again.
test/test_remote_control_legacy_off.py::test_a_host_turned_off_before_the_upgrade_stays_off fails without the change.

@cruisercohen

Copy link
Copy Markdown
Contributor Author

Owner decision on the product shape. Remote Control stays off by default, and signing in never turns it on by itself. A host that was not hosting before this release does not start hosting because of it. The owner turns it on with kirocrew remote-control on. Team Crews no longer needs a separate viewer setting, and a person who is signed out sees nothing there. I accept this change in shape without a separate RFC. It removes a setting and keeps the default safe, and the PR body lists what is left for later.

@cruisercohen

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles cc8ba49 owner-decision: owner decision recorded at #38801 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@cruisercohen recorded a owner-decision release (class owner-decision) for the first-principles AI finding on cc8ba49a2de975d201ae4117e011ebcb2b185127.

owner decision recorded at #38801 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded, but the following reviewer lane(s) could not be re-run automatically: First Principles Review. Re-run the lane's latest workflow run for cc8ba49a2de975d201ae4117e011ebcb2b185127 manually from the Actions tab.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 18, 2026
@cruisercohen

Copy link
Copy Markdown
Contributor Author

span=0823735da92d

Rebutted: hiding Team Crews and Shared Crews on a generic load failure (a service error, an unreachable control plane or a transport failure, all shown today with the same generic text) is the ruled product shape of this change, not a removed guard. A person whose relay list does not load sees no Team Crews and no notice, the same as a person who is signed out.
The behaviour is pinned in website/src/components/TeamCrewsGroup.test.tsx: "Signed out, remote access off, access denied, and every load failure with the generic text: a person with no relay access sees no Team Crews and no notice", with rows 502 SERVICE_ERROR, 502 UNREACHABLE and 500 with no code.
The gateway log keeps the code (relay viewer: crews -> <code>), a list that loaded stays through a later failure, and refusals about a listed Crew, a throttle or setup still show with their recovery items.

@cruisercohen

Copy link
Copy Markdown
Contributor Author

span=f19d52db6b9b

fixed in b5c8281: the load records the base config.json turn-on keys (relay_enabled, relay_turned_off) before the overlay merge, and the in-lock re-check writes the marker into config.json while those keys are unchanged. An off in config.local.json over a stored true now lands the marker and the record, so later loads keep the cache. A writer that turns hosting on in between still wins, and config.local.json is never written.
test/test_remote_control_legacy_off.py::test_an_overlay_off_over_a_base_on_lands_the_marker_and_records_the_check fails without the change.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 18, 2026
@cruisercohen

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles b5c8281 owner-decision: owner decision recorded at #38801 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@cruisercohen recorded a owner-decision release (class owner-decision) for the first-principles AI finding on b5c828158d31d91d056fc95547fb539a809bc710.

owner decision recorded at #38801 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 18, 2026
@cruisercohen

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles fbfc1ce owner-decision: owner decision recorded at #38801 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@cruisercohen recorded a owner-decision release (class owner-decision) for the first-principles AI finding on fbfc1cec99de7781f8c6957b73e584ea6cb461e0.

owner decision recorded at #38801 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded, but the following reviewer lane(s) could not be re-run automatically: First Principles Review. Re-run the lane's latest workflow run for fbfc1cec99de7781f8c6957b73e584ea6cb461e0 manually from the Actions tab.

@cruisercohen

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 098393a owner-decision: owner decision recorded at #38801 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@cruisercohen recorded a owner-decision release (class owner-decision) for the first-principles AI finding on 098393a8968f632cb892cd906698356ffbb7ef9a.

owner decision recorded at #38801 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@cruisercohen

Copy link
Copy Markdown
Contributor Author

span=7def4fb5bf12

fixed in 0dbbb87: a one-time upgrade step writes tunnel.relay_lease_token_type: NONE into config.json, recorded with the existing Remote Control check, for a host that was hosting at the upgrade (relay_enabled: true) on a secret:// or absolute-file credential with no type. That host keeps sending no TokenType. Nothing else changes: a typed host, a host not hosting, and a new key-only host keep their behaviour. It writes nothing when config.local.json names the type or config.json cannot be read, and never writes config.local.json. In the lock it re-checks the base switches, the base credential and the empty type.
test/test_remote_control_legacy_off.py::test_a_host_hosting_on_an_untyped_stored_credential_gets_none_once fails without the change.

@cruisercohen

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 0dbbb87 owner-decision: owner decision recorded at #38801 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@cruisercohen recorded a owner-decision release (class owner-decision) for the first-principles AI finding on 0dbbb870145d918e7849bcc1a8ec388c448ea38f.

owner decision recorded at #38801 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded, but the following reviewer lane(s) could not be re-run automatically: First Principles Review. Re-run the lane's latest workflow run for 0dbbb870145d918e7849bcc1a8ec388c448ea38f manually from the Actions tab.

@cruisercohen

Copy link
Copy Markdown
Contributor Author

span=0b88fd613097

fixed in d1b8532: a disk read where both files read and nothing keeps the host off now removes the path from the process-wide keep-off set, whatever the one-time check returns, so a briefly unreadable config.local.json no longer keeps a working host off until restart. The carry is still applied on cache hits while a file stays unreadable.
test/test_remote_control_legacy_off.py::test_a_briefly_unreadable_overlay_does_not_keep_a_working_host_off fails without the change.

@cruisercohen

Copy link
Copy Markdown
Contributor Author

span=6c337e978474

fixed in d1b8532: a configuration with no config.json and a readable config.local.json now gets the same in-memory keep-off as an unreadable base (relay_keep_off_without_base): an overlay holding relay_enabled: false with a lease credential and no marker does not host. Nothing is written and no check is recorded until config.json exists, and the keep-off holds on cache hits.
test/test_remote_control_legacy_off.py::test_an_overlay_with_no_config_json_keeps_a_host_that_looks_off_off fails without the change.

@cruisercohen

Copy link
Copy Markdown
Contributor Author

span=0823735da92d

fixed in d1b8532: after a SIGNED_OUT refusal the list is read again only on a real transition of the sign-in status, a status answer that was not signed in followed by one that is, newer than the refusal. A refused refresh that keeps reporting authenticated: true no longer re-reads the list on every status poll, so the 15-minute signed-out backoff holds.
website/src/components/TeamCrewsGroup.test.tsx "after SIGNED_OUT ignores status polls that keep saying signed in, which a refused refresh still does" fails without the change.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 18, 2026
@cruisercohen

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles d1b8532 owner-decision: owner decision recorded at #38801 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@cruisercohen recorded a owner-decision release (class owner-decision) for the first-principles AI finding on d1b8532f7a6ad6b6864d4f29e78ad376db81f933.

owner decision recorded at #38801 (comment)

This decision applies only to this commit. A new push requires a new judgment.

…ings

The desktop app's Team Crews list needed tunnel.relay_viewer_enabled
turned on, and a set tunnel.relay_viewer_relay_domain could filter the
list and pin where a Crew opened. Now the viewer is on in every desktop
app with nothing to set.

- The viewer routes always answer. tunnel.relay_viewer_enabled is kept
  as a deprecated, ignored setting so an existing config still loads.
- A set relay domain is ignored, with one warning in the gateway log;
  each Crew opens at the exact address the control plane lists.
- A person with no relay access sees no Team Crews: a list read refused
  as signed out, remote access off, access denied, or any load failure
  with the generic text hides the group and the Shared Crews cards. A
  generic load failure after a list has loaded keeps the last good list
  until the next good read. Refusals about a listed Crew, a throttle or
  this install's setup still show, and the gateway log keeps every code.
- After a refusal the list is read less often: every 15 minutes after
  remote access off or access denied, not at all while signed out (a
  sign-in reads it again), and never sooner than a throttle asks.
- The remote Crew guide and the configuration reference say so.
A team Crew host on a crew API key had to set the credential reference,
tunnel.relay_lease_token_type = API_KEY, and turn Remote Control on.

- Token type: an empty token type with a credential stored as
  secret://NAME or an absolute file path now sends API_KEY. A new
  explicit value, NONE, sends no TokenType header, for a host that keeps
  an IAM Identity Center bearer in a secret or a file. An explicit
  API_KEY or EXTERNAL_IDP is sent as before, and a reference that is
  neither a secret nor a file is never taken for a crew API key.
- Starting: a set lease credential (not empty and not kiro-sign-in)
  starts hosting at the next start, with no remote-control on step.
  Turning Remote Control off writes the new tunnel.relay_turned_off
  marker, which outranks the credential and which the Settings page
  cannot clear; turning it on clears it. A Kiro sign-in alone never
  starts hosting, and Remote Control stays off by default.
- Upgrade: every config.json stores relay_enabled false, so on the
  first load by this build a stored key with relay_enabled false and
  no marker gets tunnel.relay_turned_off once, through the config write
  lock, and the adoption ledger records the check. A host that was not
  hosting before this release does not start hosting because of it.
- The pod seed floor writes the same marker, so a seeded pod never
  hosts on the operator's credential.
- The setting help, the 401 hint, the off notice and the remote Crew
  guide say so.
tim-finnigan
tim-finnigan previously approved these changes Nov 18, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 18, 2026
@cruisercohen

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in config-baseline.json, docs/feature-map/README.md, docs/system-specs/modules/cli.md, docs/system-specs/modules/config.md, src/kiro_crew/config/integration_sections.py, src/kiro_crew/config/section_builders.py and src/kiro_crew/remote_control/cli.py since this head went green (5ca1430 -> 37911da); CI re-running.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 18, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: action required A blocking check or review needs attention

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants