Skip to content

fix(sidebar): a paused Pinned chip lets the other status chips narrow pinned rows - #38902

Open
rnoack1 wants to merge 1 commit into
mainfrom
fix/paused-pinned-chip-hides-pins
Open

rnoack1 wants to merge 1 commit into
mainfrom
fix/paused-pinned-chip-hides-pins

Conversation

@rnoack1

@rnoack1 rnoack1 commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Pausing the Pinned status chip makes the other status chips narrow pinned sessions too, so the pause has a visible effect.

Click the Pinned chip to pause it while In progress (or Unread) is on. The chip reads Pinned (17) · paused, but every pinned session stays listed and the "Pinned · always shown" caption stays. The pause looks broken.

Why it matters

Anyone who pins many sessions and filters by Unread or In progress cannot see just the pinned sessions that match. The Pinned chip offers a pause that does nothing, which reads as a bug.

Not a goal

  • Changing what an active Pinned chip does. Pinned rows stay exempt while it is on.
  • Changing the tag filter's pin exemption or the folder-pin exemption.
  • Changing pause for any other status chip.

What changed (motivation → approach → change)

Pinned rows skip the status chips, whatever the Pinned chip says. So once another status chip was on, the Pinned chip never decided anything, active or paused.

Now a paused Pinned chip turns that skip off for the status chips. A pinned session stays only if an unpaused chip matches it, such as In progress. The "Pinned · always shown" caption is not shown while that happens, even when a tag filter also narrows.

The paused Pinned chip says what it does on its face: it reads Pinned (N) · paused, filtered too, and so does its row in the filter menu. It keeps the word "paused" that every other paused chip shows, and adds what the pause changes: the pinned sessions are filtered too. This wording and the tooltip appear only while another status chip is on. With no other chip narrowing, pins still pass every filter, so a paused Pinned chip reads plain "paused" and "Resume Pinned filter", like any other chip. Its count N is the pinned sessions still listed. Its tooltip reads "Pinned sessions follow the other status chips. Click to resume." The two new strings, pages.chatSidebar.pinned_paused_suffix and pages.chatSidebar.paused_pinned_chip_title in website/src/i18n/locales/en.manual.json, are translated in every locale file. Tag filters and folder pins keep their exemption.

Revealing a session from the chat header clears only the filters that actually hide it. The status chips still ask list membership first, as before. They now also ask their own match, so a reveal of a pinned row that only the search dropped keeps the chips. Without that, pausing Pinned made such a reveal clear both chips.

The spec, the feature map and website/scripts/capture-status-chip-pause.mjs match this.

Backwards compatibility

Compatible: no key, field or stored value changes, and the stored chip values '0', '1', '2' read as before.

Behaviour change: someone whose Pinned chip was already paused (stored '2') beside another status chip sees fewer pinned rows after upgrading, because the pause now narrows pins. Resuming Pinned shows them again.

Removes nothing: no reader of a key, field or stored filter value is removed.

Tests

rows.test.ts gains a paused Pinned chip lets the other status chips narrow pinned rows:

  • a paused Pinned chip beside In progress drops an idle pin, keeps a running pin, and drops the band caption;
  • an active Pinned chip still keeps both pins and the caption;
  • a folder-pinned row still passes;
  • the tag filter still exempts pins;
  • the paused Pinned count is the pinned rows still listed.

The narrowing and count cases fail on main's rows.ts; the others guard what must not change.

ChatSidebar.filterSuspend.test.tsx checks that only the paused Pinned chip reads "paused, filtered too" and carries the new tooltip, that a paused Unread chip still reads "paused" with "Resume Unread filter", and that resuming Pinned restores "Pause Pinned filter". It fails without the chip change.

Proof: not provable -- frontend test (prove.py runs Python only)

Manual verification

Captured the sidebar with stubbed sessions (two pinned, one running each way) on main 11e9453ae3 and on branch head 1916d737b0, with In progress on. Each shot carries a header naming its build and state.

Build Pinned active Pinned paused
main idle pin shown idle pin shown, chip Pinned (2) · paused
branch idle pin shown idle pin hidden, chip and menu row Pinned (1) · paused, filtered too

On the branch the paused chip's title reads "Pinned sessions follow the other status chips. Click to resume." (read from the DOM; a headless browser does not paint native tooltips).

Screenshots / video

Main, Pinned paused: the idle pin is still listed and the chip says only "paused".

main, Pinned paused

Branch, Pinned on (unchanged):

branch, Pinned on

Branch, Pinned paused: only the running pin is left, the caption is gone, and the chip reads Pinned (1) · paused, filtered too.

branch, Pinned paused

Branch, Pinned paused with the filter menu open: the Pinned row reads Pinned (1) · paused, filtered too beside the pause icon.

branch, Pinned paused, filter menu open

Related Issues

Closes #38883

Sibling sweep

Swept: git grep -nE "pinnedBypass|matches.pinned(" -- website/src
Sibling: website/src/pages/chat-sidebar/rows.ts:635 -- not affected -- the tag filter's pin exemption (its filter and reveal sides) is a separate answer and stays on

Pattern harvest

Not generalizable: the defect is one exemption that ignored the state of the chip whose predicate it shares; no other chip carries an exemption.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@rnoack1
rnoack1 requested review from a team and KiroCrewCaptain as code owners November 18, 2026 01:54
@rnoack1
rnoack1 requested a review from dodgeblaster November 18, 2026 01:54
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 18, 2026
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 3901207f58c50ecc89c1f6625e46aeee0954d497 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 3901207

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 3901207f58c50ecc89c1f6625e46aeee0954d497 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 18, 2026
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 3901207f58c50ecc89c1f6625e46aeee0954d497 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks. The blind reader read the new paused chip correctly: "the pinned chats now also go through the other filters". It rated that reading only "a guess" and called the wording "hard".

Notes

  • paused_pinned_chip_title says "status chips", which is internal vocabulary. Suggest "Pinned sessions now follow your other filters. Click to resume."
  • pinned_paused_suffix "paused, filtered too": the reader called this wording "hard" and could only guess at "filtered too". Suggest "paused · filtered like the rest" or "paused, not always shown", which echoes the "Pinned · always shown" caption it replaces.
  • No screenshot shows the tooltip. The PR says it was read from the DOM. A still with the tooltip painted, or a DOM dump next to shot-03, would let reviewers check it against the chip.

[UX-REVIEWED] 3901207

Description read

[DESCRIPTION-READ] 4f4e01c58cb74b1447aabcb28eaff55117ec7473a0b1f8d03a803f3bbaf01373

That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 3901207f58c50ecc89c1f6625e46aeee0954d497 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the paused Pinned chip's special meaning is scoped to the status dimension, labelled on the chip itself, recorded in the spec, and backed by four screenshots.

Notes

  • The paused Pinned chip now means something different from every other paused chip: "stop exempting pins" instead of "stop narrowing". pinnedFollowsStatus is the only gate for that difference. If another chip ever gets an exemption, make it a field on the dimension, not a second key check.
  • The status dimension's hides now also asks the chips' own predicate. That fixes reveal for every pinned row the search dropped, not only those under a paused Pinned chip. It is wider than the Goal line, so it is fine as part of this fix, but the description should say so.

[DESIGN-REVIEWED] 3901207

Description read

[DESCRIPTION-READ] 6ea5e408b987c399157fa5260763ca1544f35c28f8948f629dea25b99bbac2d4

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 3901207f58c50ecc89c1f6625e46aeee0954d497 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 3901207

Verdict parsed from the review's SHA-scoped output markers for commit 3901207f58c50ecc89c1f6625e46aeee0954d497.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 3901207f58c50ecc89c1f6625e46aeee0954d497 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 3901207f58c50ecc89c1f6625e46aeee0954d497 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. The fix is at mechanism level (statusBypass withdraws the row-pin exemption) and has provenance in #38883 plus tests that fail on main. Two riders change the paused Pinned chip's count and tooltip, and the fix does not need either.

Notes

  • Item 4 — rides along: the paused Pinned count changes to "the pinned sessions still listed", but the unchanged feature-map sentence still says "the chip counts still count matches". No reported defect asks for this count change. Subtraction: delete the if (pinsFollowStatus) branch in countStatus, along with its new parameters and the extra reuse deps.
  • Item 3 — rides along: the paused Pinned chip's title changes from "Resume Pinned filter" to paused_pinned_chip_title, which means 15 new locale strings, and the chip already reads "paused, filtered too". Subtraction: delete paused_pinned_chip_title and keep resume_named_filter.

What this change ships

Inventory (7 items) — 4 justified

Intent: let someone who pins many sessions see only the pinned ones the other status chips match, by pausing Pinned. FIX.

  1. Paused Pinned beside another active status chip: the other chips now narrow pinned rows — justified
  2. The "Pinned · always shown" caption is hidden in that state — justified
  3. The paused Pinned chip and its menu row read "paused, filtered too", and the chip tooltip is reworded — rides along
  4. The paused Pinned count now counts only the pinned rows still listed — rides along, contradicts the spec's "counts still count matches"
  5. A reveal no longer clears the status chips for a row that only the search hid, for every row, not just pinned ones — justified
  6. Folder-pin and tag exemptions stay as they were — justified
  7. The capture script expects the new wording — rides along

[FIRST-PRINCIPLES-REVIEWED] 3901207

Description read

[DESCRIPTION-READ] b7d7b1bac45f32824fe8c55859810fbc0d72c6e0fe2392d4ecbcd9f54bd6be70

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@rnoack1
rnoack1 force-pushed the fix/paused-pinned-chip-hides-pins branch from a4b5b1d to 134ab68 Compare November 18, 2026 04:51
@rnoack1
rnoack1 force-pushed the fix/paused-pinned-chip-hides-pins branch from 134ab68 to cfcd11c Compare November 18, 2026 06:06
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 18, 2026
@rnoack1

rnoack1 commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/feature-map/README.md and sibling docs/system-specs/modules/*.md since this head went green (d3b0877 -> 2bac55e); CI re-running. The previous head's CI run had sat queued for 7h while newer runs got runners, so it was cancelled.

@rnoack1
rnoack1 force-pushed the fix/paused-pinned-chip-hides-pins branch from cfcd11c to 9af21aa Compare November 18, 2026 13:29
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 18, 2026
@KiroCrewCaptain

KiroCrewCaptain commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: A person should decide

Why: the decider estimates a 12% chance that this change introduces a defect, within the 12% limit for approving on its own, but it is held at tier 2: design-doc-gate: D.

Pausing the Pinned chip while another status chip is on now stops pinned rows from passing the status filter automatically. The tag filter and folder pins still let them through, as the PR's non-goals require. The filter cache is keyed on the active and paused chip sets, so it recomputes when they change. The caption and the chip and menu wording all use the same check as the filtering. Reveal now clears the status chips only when they really hide the row. Lifecycle cases (pause all, resume all, turning a chip on while the others are paused) fall back to the old behaviour. New tests cover each change and would fail without it, and CI is green. I found no regression or contradiction with the spec, only notes on documentation and wording.

Tier: 2, held for a person: design-doc-gate: D.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit 3901207f58 · 237 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@rnoack1
rnoack1 enabled auto-merge (squash) November 18, 2026 15:23
@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

This PR edits docs/feature-map/README.md, so a maintainer needs to approve it. This reviewer does not approve changes to that file. A maintainer will post the decision here.

To propose a design, follow the request-for-change process in CONTRIBUTING.md (docs/request-for-change/).

Review result on this head: no blocking findings.

  • In rows.ts, pinsExemptFromStatus drives the status dimension's filtersRow, hides and exemptsPinned together. The row list, the reveal path and the "Pinned · always shown" caption therefore stay in sync.
  • The tag exemption and the folder-pin exemption still use pinnedBypass, so they do not change.
  • The new rows tests pin both the change and the behaviour that must stay the same: active Pinned, folder pin, and tag exemption. The first and third tests fail against main's logic.
  • The UI test waits on findByText and waitFor with no sleeps. The new i18n key is in all 13 locale files.
  • The history.md spec and the feature map line match the code.

Done well: one flag in the one place that declares the filter dimensions, with a mutation-sensitive test for each over-broad version of the fix.

Optional:

  • The paused Pinned tooltip says pinned sessions follow "the other filters", but they still skip the tag filter. A wording like "the other status chips" would match the code. The 12 translations and the filterSuspend assertion would change with it.
  • With Pinned paused, an unpaused status chip on, and a tag filter selected, the "always shown" caption still appears while some pinned rows are hidden (rows.ts:908, ChatSidebar.tsx:551). This is a low-impact edge, and a follow-up is fine.
  • feat(sidebar): keep the open chat listed under the Unread filter #37210 edits the same status-dimension lines in rows.ts. Whichever PR merges second will need a small rebase.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 20, 2026
@rnoack1
rnoack1 force-pushed the fix/paused-pinned-chip-hides-pins branch from 9af21aa to c6668e8 Compare November 20, 2026 09:27
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 20, 2026
@github-actions github-actions Bot added the readiness: passed Eligible automated validation passed for the current revision label Nov 20, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the focused fix. One evidence gap blocks this head.

  1. website/src/pages/chat-sidebar/SearchDock.tsx:467: when Pinned is paused, the filter-menu row now ends in · filtered too instead of · paused. None of the three attached screenshots shows the menu open, so the UX review could not evaluate that row ("cannot evaluate: missing the filter-menu row for a paused Pinned chip"). A changed control with no rendered evidence counts as a block, even though the lane line reads PASS. Fix: run website/scripts/capture-status-chip-pause.mjs on this head and attach the frame with the menu open, In progress on and Pinned paused (shot-05). Give it a header naming the head commit, then re-run the UX lane.

The rest of the review found no blocking defect. One flag in the status dimension drives filtersRow, hides and exemptsPinned together, and the new rows.test.ts block goes red when any one production hunk is reverted. This PR also edits docs/feature-map/README.md, so a maintainer gives the final approval once the evidence is in.

Optional:

  • With a tag filter on, In progress on and Pinned paused, an idle pin is hidden, but pinnedExemptNarrowing (rows.ts:972) stays true because the tag dimension still exempts pins. The "Pinned · always shown" caption then still shows. The tooltip's "follow the other filters" also overclaims, because pins still skip the tag filter. "the other status chips" would be accurate.
  • The paused Pinned count (rows.ts:799) counts pins that the status chips keep, but a model, creator or search filter can still drop them. So "the pinned sessions still listed" in the body and the feature map is not exact. That rule also conflicts with the "counts read the predicates" comment at rows.ts:632-635.
  • The status reveal hides now reads the chips' own predicate for every row, not only pinned rows. This is a sound change, but "What changed" and history.md do not mention it. Users who already have Pinned paused will also see fewer rows after upgrading. Stating that under Backwards compatibility would help readers.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: passed Eligible automated validation passed for the current revision labels Nov 20, 2026
@rnoack1
rnoack1 force-pushed the fix/paused-pinned-chip-hides-pins branch from ec78f2c to c1e27a9 Compare November 21, 2026 00:09
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 21, 2026
@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

This PR edits docs/feature-map/README.md, so a maintainer needs to approve it. This reviewer does not approve changes to that file. A maintainer will post the decision here.

To propose a design, follow the request-for-change process in CONTRIBUTING.md (docs/request-for-change/).

Earlier request on ec78f2c: fixed. The body now has the shot with the filter menu open (In progress on, Pinned paused). It shows Pinned (1) · filtered too, under a header that names this head.

Review result on this head: no blocking findings.

  • statusBypass (rows.ts:650-651) withdraws the row-pin exemption only from the status chips, and only while Pinned is active and paused. The tag exemption (pinnedBypass) and the folder-pin exemption (inPinnedFolder) are unchanged.
  • The new rows.test.ts block fails when any production hunk is reverted. It also has a guard case for each "Not a goal" bullet: active Pinned, the folder pin, and the tag exemption.

Done well: the reveal loop test (rows.test.ts:552-571) turns the status hides change into a concrete contract. Revealing a pinned row that only the search dropped clears the search and leaves the chips alone.

Readiness still shows the UX and First Principles BLOCKs with no disposition. Each one needs a fix or a disposition before a maintainer can merge.

Optional:

  • First Principles BLOCK on rows.ts:706: the code supports a rebuttal. At this head, hides is exactly !filtersRow while chips narrow. matches.unread reads a local set (rows.ts:586). If excluded(slot) were restored next to statusBypass, revealing a running pin that only the search dropped would clear the status chips again. The change also affects reveal for unpinned rows (for example, a row a tag filter drops). Please say so under Backwards compatibility.
  • Paused Pinned count (rows.ts:798-803): it ignores search, tag, model, creator and status-hide filters. So "the pinned rows still listed" in the feature map and history.md is not exact. "The pinned rows the other status chips still pass" would match the code. Dropping the count override is also an option, since the Goal holds without it.
  • No test covers the four new statusCounts reuse keys (rows.ts:965). The "never served stale" table at rows.test.ts:914 never pauses Pinned. One incremental case would pin them: build with Pinned and In progress active, then build again with Pinned paused, and compare against a fresh build.

@KiroCrewCaptain
KiroCrewCaptain dismissed their stale review November 21, 2026 01:21

Withdrawn: every item in this review is fixed or answered on the current head (see the follow-up comment). Other holds on this PR are listed there.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 21, 2026
@rnoack1
rnoack1 force-pushed the fix/paused-pinned-chip-hides-pins branch from c1e27a9 to fc5bf4b Compare November 21, 2026 01:43
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 21, 2026
@rnoack1
rnoack1 force-pushed the fix/paused-pinned-chip-hides-pins branch from fc5bf4b to 1916d73 Compare November 21, 2026 02:58
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 21, 2026
@rnoack1
rnoack1 force-pushed the fix/paused-pinned-chip-hides-pins branch from 1916d73 to 3901207 Compare November 21, 2026 04:12
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 21, 2026
@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

This changes behaviour users already rely on, so it needs a design sign-off from a maintainer before it can merge. A maintainer will post the decision here.

This PR also edits docs/feature-map/README.md. This reviewer does not approve changes to that file.

To propose a design, follow the request-for-change process in CONTRIBUTING.md (docs/request-for-change/).

Earlier request on ec78f2c: fixed. The body has the frame with the filter menu open (In progress on, Pinned paused), and the frame has a header that names the build.

Review result on this head: no blocking findings.

  • statusBypass (rows.ts:651) removes only the row-pin exemption, and only from the status chips. The tag exemption and the folder-pin exemption do not change.
  • With Pinned active, with Pinned paused alone, and with all chips paused, behaviour is the same as on main.
  • Each new rows.test.ts case fails when its production hunk is reverted. Paired cases pin what must not change.

The design question for the maintainer: with Pinned off, pins stay exempt. With Pinned paused, pins now follow the other status chips. For every other chip, paused narrows nothing, like off. Users whose Pinned chip is already paused will see fewer rows after they upgrade.

Done well: one shared pinnedFollowsStatus predicate drives both the row model and the chip wording, so the label cannot disagree with the filtering.

Optional:

  • The paused-Pinned count override in countStatus (rows.ts:790-805) is not needed for the fix. It ignores search, hides, model and creator filters, so "the pinned rows still listed" is not exact. It also conflicts with "the chip counts still count matches" in the same feature-map row. You could drop it, or reword it to "the pinned rows the other status chips match".
  • No test covers the new statusCounts reuse keys (rows.ts:972). The "never served stale" fixture never enters the paused-Pinned state. One incremental case would cover them: build with Pinned and In progress active, then rebuild with Pinned paused and previous set, and compare with a fresh build.
  • The status hides change (rows.ts:705-706) also changes reveal for unpinned rows. Backwards compatibility could say so. The comment at ChatSidebar.revealFilterDimensions.test.tsx:223 should say that hides asks list membership and the chips' own predicate.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pausing the Pinned status chip does not hide pinned sessions

2 participants