Skip to content

chore: bump the bundled kas node runtime to 22.23.4 - #39211

Merged
bolichen97 merged 1 commit into
mainfrom
chore/kas-node-22.23.4
Nov 19, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
chore/kas-node-22.23.4

Conversation

@dodgeblaster

@dodgeblaster dodgeblaster commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The KAS engine Kiro Crew installs runs on Node 22.23.4 instead of 22.23.3.

Every published engine bundle, including the current pin 0.66.117, ships Node 22.23.3. Node 22.23.4 is the 2026-10-21 security release for the 22.x line.

Why it matters

The bundled Node is a private runtime Kiro Crew installs under engines/kas/<version>/node/. Operators cannot patch it themselves, because the manifest pins every Node build by sha256, so a newer Node only reaches them through a new bundle and a new pin.

Not a goal

What changed (motivation → approach → change)

The 0.66.117 engine build was republished with scripts/kas_bundle_publish.py --node-version 22.23.4 under a new key, kas/0.66.117-node22.23.4/, rather than overwriting kas/0.66.117/, whose manifest is already pinned by sha. The new manifest's sha256 is 58600c49bdd758709982051b11043f0f91194b9fe0dfa1cfd34d086ea341d95e, and every file it lists was downloaded back from kas.crew.kiro.dev and matched on sha256 and size.

Part Change
Pin acp/kas_pin.py: KAS_PIN_VERSION = "0.66.117-node22.23.4" and the new manifest sha
Engine release KAS_PIN_ENGINE_RELEASE, the pin without its -node suffix, for anything comparing engine versions
Tests test_kas_pin.py accepts a release with an optional -node<X.Y.Z> suffix and refuses other shapes; test_real_adapter_fixture_pins.py compares captures against KAS_PIN_ENGINE_RELEASE, since the engine still reports 0.66.117
Spec acp-client.md names the suffix and why a Node fix is a new key

The other readers of KAS_PIN_VERSION use it as a directory name, as display text, or in an equality check against the manifest's own version (kas_bundle.py fetch_manifest, cli_kas.py), which the published manifest satisfies, so the suffix passes through unchanged.

Backwards compatibility

Compatible: the installer and kirocrew kas install resolve whatever directory the pin names; kas/0.66.117/ stays published, so builds pinned to it keep installing.

Removes nothing: the published 0.66.117 bundle and its manifest are untouched.

Tests

  • test_kas_pin.py: the pin shape, the accepted and refused version shapes, and that KAS_PIN_ENGINE_RELEASE is a plain release that prefixes the pin.
  • 620 tests across the KAS pin, bundle, route, CLI, permissions and fixture-pin suites pass locally.

Proof: not provable -- test-only change

Manual verification

  • Downloaded kas.crew.kiro.dev/kas/0.66.117-node22.23.4/manifest.json: sha256 58600c49…d95e, top-level version 0.66.117-node22.23.4 (equal to the pin), node.version 22.23.4.
  • Downloaded all nine artifacts it lists from the CDN: every sha256 and size matches.
  • The engine entries are identical to the 0.66.117 manifest.

Real-machine verification

N/A -- the change is a pin constant and tests; the published bundle was verified byte-for-byte above.

Related Issues

Part of #20727

Checklist

  • A Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...); PR Hygiene does not count commits
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 18, 2026
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision d17495eca980446b0da2bee1cbe21111dee20893 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of d17495eca980446b0da2bee1cbe21111dee20893 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. The pin bump fixes a real problem: the bundled Node is pinned by sha and operators cannot patch it. One new exported constant is read only by tests.

Notes

  • Item 3 — zero consumers: KAS_PIN_ENGINE_RELEASE "for anything comparing engine versions" has no reader in src/. Grepping KAS_PIN_ENGINE_RELEASE outside test/ finds 0 hits beyond the defining module and the spec. The one runtime version comparison, engine_spec_permissions_supported, already drops the suffix through parse_kiro_cli_version's prefix _VERSION_RE. Subtraction: delete the constant and its __all__ row. Do the .split("-node", 1)[0] inside test_real_adapter_fixture_pins.py, where its only readers are.

What this change ships

Inventory (6 items) — 5 justified

Intent: operators get the engine bundle with the Node 22.23.4 security release, without overwriting the published, sha-pinned 0.66.117 key. This is a FIX.

  1. New installs and engine refreshes download the 0.66.117-node22.23.4 bundle, verified by a new manifest sha — justified
  2. Doctor, kas status, diagnostics and the dashboard now show the pin as 0.66.117-node22.23.4 — justified
  3. New public constant KAS_PIN_ENGINE_RELEASE in kas_pin.__all__ — zero consumers, read only by tests
  4. The pin-shape test now accepts a -node<X.Y.Z> suffix and refuses other suffixes — justified
  5. The fixture-floor tests hold KAS captures to the engine release, not the directory name — justified
  6. The acp-client spec describes the suffix and the no-overwrite rule — justified

[FIRST-PRINCIPLES-REVIEWED] d17495e

Description read

[DESCRIPTION-READ] bd72d8ec401af133df54c69f58c05df0423fc2a5c5fcec3ec54f1c961d8e1fac

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of d17495eca980446b0da2bee1cbe21111dee20893 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks. Every version-comparing reader I traced still works with the -node suffix: parse_kiro_cli_version reads only the leading 0.66.117, and the directory and equality readers take the string unchanged.

Notes

  • KAS_PIN_ENGINE_RELEASE is defined but nothing in src/ reads it. The engine-version gate gets its version from the install record, and it only works because the shared parser happens to stop at the leading release. Routing engine_spec_permissions_supported through the same suffix split would make the spec's "anything comparing engine versions reads that" rule hold in code, not only in prose.

[DESIGN-REVIEWED] d17495e

Description read

[DESCRIPTION-READ] 3d84a2272307b6302c6a82c688f7ea1a6ec270d6f300b3f0e4f2c0516f28c7d1

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed d17495eca980446b0da2bee1cbe21111dee20893 — this comment is updated in place on each push.

Review details

I found no defects in the changed lines. The candidate list was empty, and I couldn't ground any new finding to the required bar.

  • Version gates still work with the suffix: the engine-version checks (spec permissions, chat sharing, OAuth, late model select) all read the version through parse_kiro_cli_version. That parser stops at the -node22.23.4 suffix and still reads 0.66.117.
  • Lookups use the full name on purpose: install, installed_bundle() and the doctor and diagnostics output compare the full KAS_PIN_VERSION, which is the directory name.
  • Fixture checks use the bare release: the fixture floor checks now use KAS_PIN_ENGINE_RELEASE, which matches the version the engine reports about itself.

This was a read-only pass, so I ran no tests.

No findings.

[OPUS-REVIEWED] d17495e

Verdict parsed from the review's SHA-scoped output markers for commit d17495eca980446b0da2bee1cbe21111dee20893.

False positive or not applicable? A repository writer can comment:
/ai-review override fable d17495eca980446b0da2bee1cbe21111dee20893 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of d17495eca980446b0da2bee1cbe21111dee20893 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] d17495e

False positive or not applicable? A repository writer can comment:
/ai-review override gpt d17495eca980446b0da2bee1cbe21111dee20893 false-positive: <reason, 20 to 500 characters>

@dodgeblaster
dodgeblaster force-pushed the chore/kas-node-22.23.4 branch from 5aba903 to 18b92ce Compare November 18, 2026 20:46
@dodgeblaster

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/system-specs/modules/acp-client.md and nearby src/kiro_crew/acp/ files since this head went green (be0b414 -> bdc5e2f); CI re-running.

@dodgeblaster
dodgeblaster marked this pull request as ready for review November 18, 2026 20:46
@dodgeblaster
dodgeblaster requested review from a team and KiroCrewCaptain as code owners November 18, 2026 20:46
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 18, 2026
@dodgeblaster

Copy link
Copy Markdown
Contributor Author

Backend Tests shard 8 (Linux and Windows) fail on test/test_bare_session_handle_guard.py::test_no_test_builds_a_bare_session_handle_directly, flagging test/test_kas_token_refresh_recovery.py:245. Neither file is in this diff: main carries both since #38978 and #38996 landed separately. #39262 / #39274 fix it; this PR waits for one to merge, then rebases. Coverage Gate fails closed downstream of the same red.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author
  • span=4e0f9bc6658e Unverified manifest version on the default engine install path

Rebutted: confirmed. The published https://kas.crew.kiro.dev/kas/0.66.117-node22.23.4/manifest.json has top-level "version": "0.66.117-node22.23.4" (the publish ran with --version 0.66.117-node22.23.4, and kas_bundle_publish.py writes "version": args.version).
The same downloaded manifest hashes to the pinned 58600c49bdd758709982051b11043f0f91194b9fe0dfa1cfd34d086ea341d95e, so kas_bundle.py:429 and cli_kas.py:337/:344 see manifest.version == KAS_PIN_VERSION.
The PR description's Manual verification now states the top-level version, and its reader sentence names those three equality checks.

Republish the 0.66.117 engine build with Node 22.23.4 under a new
kas/0.66.117-node22.23.4/ key and pin it. The engine tarballs are
byte-identical to 0.66.117; only the bundled Node changes. The pin's
version may now carry a -node<N> suffix, and KAS_PIN_ENGINE_RELEASE is
the engine release before it, for anything comparing engine versions.
@dodgeblaster
dodgeblaster force-pushed the chore/kas-node-22.23.4 branch from 18b92ce to d17495e Compare November 18, 2026 21:59
@dodgeblaster

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in test/test_kas_token_refresh_recovery.py (#39262, the bare-session-handle guard fix) since this head ran (bdc5e2f -> 6e059d7); CI re-running.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 18, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision labels Nov 18, 2026
@bolichen97
bolichen97 enabled auto-merge (squash) November 18, 2026 23:45
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 19, 2026
@bolichen97
bolichen97 merged commit 5525caa into main Nov 19, 2026
109 of 112 checks passed
@bolichen97
bolichen97 deleted the chore/kas-node-22.23.4 branch November 19, 2026 00:49
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 19, 2026
bolichen97 added a commit that referenced this pull request Nov 19, 2026
… 22.23.4 (#38228, #39211) (#39376)

Backports two main PRs to release/0.13.0, in pick order:

- #38228 chore: bump the bundled KAS engine pin to 0.66.117
  (cherry picked from commit b490cdf)
- #39211 chore: bump the bundled kas node runtime to 22.23.4
  (cherry picked from commit 5525caa)

Both picks applied without conflicts and without edits. #39211 pins the
0.66.117 engine republished with Node 22.23.4, so it needs #38228 first.

Nothing left out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants