Repository navigation
chore: bump the bundled kas node runtime to 22.23.4 - #39211
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. The pin bump fixes a real problem: the bundled Node is pinned by sha and operators cannot patch it. One new exported constant is read only by tests. Notes
What this change shipsInventory (6 items) — 5 justifiedIntent: operators get the engine bundle with the Node 22.23.4 security release, without overwriting the published, sha-pinned 0.66.117 key. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] d17495e Description read[DESCRIPTION-READ] bd72d8ec401af133df54c69f58c05df0423fc2a5c5fcec3ec54f1c961d8e1fac That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks. Every version-comparing reader I traced still works with the Notes
[DESIGN-REVIEWED] d17495e Description read[DESCRIPTION-READ] 3d84a2272307b6302c6a82c688f7ea1a6ec270d6f300b3f0e4f2c0516f28c7d1 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Review detailsI found no defects in the changed lines. The candidate list was empty, and I couldn't ground any new finding to the required bar.
This was a read-only pass, so I ran no tests. No findings. [OPUS-REVIEWED] d17495e Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
5aba903 to
18b92ce
Compare
|
Backend Tests shard 8 (Linux and Windows) fail on test/test_bare_session_handle_guard.py::test_no_test_builds_a_bare_session_handle_directly, flagging test/test_kas_token_refresh_recovery.py:245. Neither file is in this diff: main carries both since #38978 and #38996 landed separately. #39262 / #39274 fix it; this PR waits for one to merge, then rebases. Coverage Gate fails closed downstream of the same red. |
|
Republish the 0.66.117 engine build with Node 22.23.4 under a new kas/0.66.117-node22.23.4/ key and pin it. The engine tarballs are byte-identical to 0.66.117; only the bundled Node changes. The pin's version may now carry a -node<N> suffix, and KAS_PIN_ENGINE_RELEASE is the engine release before it, for anything comparing engine versions.
18b92ce to
d17495e
Compare
… 22.23.4 (#38228, #39211) (#39376) Backports two main PRs to release/0.13.0, in pick order: - #38228 chore: bump the bundled KAS engine pin to 0.66.117 (cherry picked from commit b490cdf) - #39211 chore: bump the bundled kas node runtime to 22.23.4 (cherry picked from commit 5525caa) Both picks applied without conflicts and without edits. #39211 pins the 0.66.117 engine republished with Node 22.23.4, so it needs #38228 first. Nothing left out.
Problem / Motivation
Goal: The KAS engine Kiro Crew installs runs on Node 22.23.4 instead of 22.23.3.
Every published engine bundle, including the current pin 0.66.117, ships Node 22.23.3. Node 22.23.4 is the 2026-10-21 security release for the 22.x line.
Why it matters
The bundled Node is a private runtime Kiro Crew installs under
engines/kas/<version>/node/. Operators cannot patch it themselves, because the manifest pins every Node build by sha256, so a newer Node only reaches them through a new bundle and a new pin.Not a goal
What changed (motivation → approach → change)
The 0.66.117 engine build was republished with
scripts/kas_bundle_publish.py --node-version 22.23.4under a new key,kas/0.66.117-node22.23.4/, rather than overwritingkas/0.66.117/, whose manifest is already pinned by sha. The new manifest's sha256 is58600c49bdd758709982051b11043f0f91194b9fe0dfa1cfd34d086ea341d95e, and every file it lists was downloaded back fromkas.crew.kiro.devand matched on sha256 and size.acp/kas_pin.py:KAS_PIN_VERSION = "0.66.117-node22.23.4"and the new manifest shaKAS_PIN_ENGINE_RELEASE, the pin without its-nodesuffix, for anything comparing engine versionstest_kas_pin.pyaccepts a release with an optional-node<X.Y.Z>suffix and refuses other shapes;test_real_adapter_fixture_pins.pycompares captures againstKAS_PIN_ENGINE_RELEASE, since the engine still reports 0.66.117acp-client.mdnames the suffix and why a Node fix is a new keyThe other readers of
KAS_PIN_VERSIONuse it as a directory name, as display text, or in an equality check against the manifest's ownversion(kas_bundle.pyfetch_manifest,cli_kas.py), which the published manifest satisfies, so the suffix passes through unchanged.Backwards compatibility
Compatible: the installer and
kirocrew kas installresolve whatever directory the pin names;kas/0.66.117/stays published, so builds pinned to it keep installing.Removes nothing: the published 0.66.117 bundle and its manifest are untouched.
Tests
test_kas_pin.py: the pin shape, the accepted and refused version shapes, and thatKAS_PIN_ENGINE_RELEASEis a plain release that prefixes the pin.Proof: not provable -- test-only change
Manual verification
kas.crew.kiro.dev/kas/0.66.117-node22.23.4/manifest.json: sha25658600c49…d95e, top-levelversion0.66.117-node22.23.4(equal to the pin),node.version22.23.4.Real-machine verification
N/A -- the change is a pin constant and tests; the published bundle was verified byte-for-byte above.
Related Issues
Part of #20727
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...); PR Hygiene does not count commits