Skip to content

feat(dashboard): setting to turn off the conductor mode Board auto-open - #39224

Merged
bolichen97 merged 1 commit into
kirodotdev:mainfrom
gsboylan:feat/board-auto-open-setting
Nov 19, 2026
Merged

bolichen97 merged 1 commit into
kirodotdev:mainfrom
gsboylan:feat/board-auto-open-setting

Conversation

@gsboylan

@gsboylan gsboylan commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A person can turn off the side panel opening on the Board when a conductor mode chat is opened for the first time.

The first entry to a conductor mode chat opens the side panel on its Board tab. A person whose default agent is a conductor gets that on every new chat, because every new chat enters conductor mode. They close the panel each time. Nothing lets them turn it off.

Why it matters

The panel takes screen width the person did not ask for, on every new chat. One setting ends the repeated close.

Not a goal

  • Changing what the composer chip does. Turning conductor mode on in a chat still opens the Board.
  • Changing what a return to an existing chat does. A chat keeps its own saved panel state (mc-activity-open:<slot>), as it does today.
  • A per-chat choice. This is one setting for the whole dashboard.
  • Phone layouts. The panel is a sheet there and never opens on its own.

What changed (motivation → approach → change)

The auto-open lives in one place: the enter-root effect in website/src/pages/chat/page/crewModeSwitch.ts. A new dashboard setting gates that effect. Everything else is the plumbing a dashboard setting needs.

Part What it does
dashboard.auto_open_conductor_board New config field, on by default. src/kiro_crew/config/sections_dashboard.py, loader_builders.py, and the GET,PUT /api/dashboard/config handler in src/kiro_crew/dashboard/file_api/dashboard_config.py carry it like its neighbors.
Settings → Chat → Side panel → Auto-Open Board in Side Panel The toggle in website/src/pages/settings/ChatPanel.tsx, shown wherever conductor mode is offered. LTS hides it, as it hides Start New Chats in conductor mode. The palette entry in website/src/components/commandPalette/settingsSearchCore.ts follows the same rule.
The gate pageEnvironment.ts reads the setting from the dashboard config query the chat page already makes. crewModeSwitch.ts takes it as autoOpenBoard: undefined while the read is in flight, so the first entry waits for it. Off, the effect returns before it opens anything. The entry is decided once, so a change during the visit opens nothing. A failed read counts as on.
Strings English plus the 11 shipped languages under website/src/i18n/locales/, verified with i18n-translate.mjs verify (0 findings).
Docs and generated files docs/system-specs/modules/crew-mode.md, docs/feature-map/README.md, src/kiro_crew/docs/agents.md; regenerated config-baseline.json, the settings registry, the UI index, and en-XA.

Why gate the effect and not the pin: the Board tab stays pinned first on every conductor chat (usePinnedViews.ts), so a person who opens the panel by hand still lands on the Board. Only the opening changes.

Backwards compatibility

Compatible: a config that never sets the key reads as on, so every install behaves as before until a person turns the setting off. Keep Side Panel Open still wins when it is on.

Removes nothing: the change adds one optional boolean and gates one effect that is open by default.

Tests

Backend:

  • test/test_auto_open_conductor_board_config.py: default on, a config that never sets it loads as on, off round-trips through save and load, a non-boolean falls back to on, the generated schema carries label and help.
  • test/test_dashboard_files_coverage.py: the field joins the PUT boolean validation table, the coded-error table, and the full PUT/GET round trip.

Frontend:

  • website/src/pages/chat/page/crewModeSwitch.test.tsx: an existing chat entered with the setting off stays closed; the entry waits for the setting to load, then opens (on) or stays closed (off); a setting turned on during the visit opens nothing; a new chat on a conductor default agent opens the Board (on) or stays closed (off); a chat created in conductor mode with the setting off stays closed.
  • website/src/test/SettingsChatPanelCoverage.test.tsx: the toggle reads on by default and persists turning it off.
  • website/src/test/ltsFeaturePreviewsOff.test.tsx: the palette offers the setting in oss and hides it in LTS.

All new frontend tests fail on the old hook (6 failures) and pass on the new one.

Manual verification

Scripted Playwright on the worktree's built SPA, with every /api/** call answered from fixtures (no gateway). Default agent kirocrew-conductor:

  • Setting on: press New → the new chat is in conductor mode and the side panel opens on the Board.
  • Setting off (turned off in Settings): press New → the new chat is in conductor mode and the panel stays closed; the panel button opens it with the Board in front.
  • Setting off, default agent kirocrew: pressing the Conductor mode chip in a new chat still opens the Board.

Real-machine verification

Machine: own computer (the development host), Amazon Linux 2, x86_64
Before (main 44769db): npx vitest run src/pages/chat/page/crewModeSwitch.test.tsx with the new tests against the base crewModeSwitch.ts -> 6 failed, 22 passed. Settings → Chat → Side panel has no Auto-Open Board row, and every first entry to a conductor mode chat opens the Board.
After (head 1853bd3): the same command -> 28 passed. The capture harness (scripted Playwright over the built SPA) -> 10 of 10 checks pass, including "the new conductor mode chat opens with the side panel closed" with the setting off.
Cleanup: own computer

Screenshots / video

Settings → Chat → Side panel, dark theme, with the tip open:

image

Light theme:

image

Setting on (the default): pressing New opens the new conductor mode chat with the Board in front.

new-on.mp4

Setting off: turned off in Settings, then New. The chat opens with the panel closed; the panel button opens it on the Board.

new-off.mp4

Setting off, default agent kirocrew: pressing the Conductor mode chip still opens the Board.

off-chip.mp4

Related Issues

Closes #39121

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license.

@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 18, 2026
@gsboylan
gsboylan marked this pull request as ready for review November 18, 2026 19:56
@gsboylan
gsboylan requested review from a team and KiroCrewCaptain as code owners November 18, 2026 19:56
@gsboylan
gsboylan requested a review from bolichen97 November 18, 2026 19:56
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed 5938ea708b6167e8b4c4e1056d4177eef8a5765b via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 5938ea7

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed 5938ea708b6167e8b4c4e1056d4177eef8a5765b via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 5938ea7

@bolichen97

Copy link
Copy Markdown
Contributor

Bundle Size Gate: first-load-0 is a few bytes over the old 1003.0 KB ceiling. Main raised that ceiling to 1053 KB in #39203 a few hours ago, so a rebase onto current main should clear it with no other change.

AI-assisted, sent by Bolin Review bot

@bolichen97

Copy link
Copy Markdown
Contributor

Maintainer design sign-off from @bolichen97: a dashboard.auto_open_conductor_board setting, on by default, is the direction we want. It lets people whose default agent is a conductor stop the Board from opening on every new chat. Turning conductor mode on from the chip still opens the Board, and an existing chat keeps its own panel state.

I'll review the code and approve once the checks are green (the Bundle Size Gate should clear with a rebase onto main, see my earlier comment).

AI-assisted, sent by Bolin Review bot

@gsboylan
gsboylan force-pushed the feat/board-auto-open-setting branch from 4643a9c to f1d96a1 Compare November 18, 2026 20:51
@bolichen97

Copy link
Copy Markdown
Contributor

The only red on f1d96a1 is Backend Tests (3.12, 8): test_bare_session_handle_guard.py::test_no_test_builds_a_bare_session_handle_directly. That is not from this PR. Main broke it in #38978 (test_kas_token_refresh_recovery.py:245) and fixed it in #39262, but this PR's test merge was built on an older main (c5ac14c). Please rebase onto current main and push. I'll approve the new head as soon as it is green; the design sign-off stands.

AI-assisted, sent by Bolin Review bot

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 18, 2026
The first entry to a conductor mode chat opens the side panel on its
Board tab. A person whose default agent is a conductor gets that on
every new chat and closes the panel each time, with no way to turn it
off.

Adds dashboard.auto_open_conductor_board, on by default, shown under
Settings > Chat > Side panel as Auto-Open Board in Side Panel wherever
conductor mode is offered. Off, a conductor mode chat is entered like
any other chat: its panel stays closed unless Keep Side Panel Open is
on, and the Board stays the panel's first tab. Turning conductor mode
on with the composer chip still opens the Board. The entry waits for
the setting to load and is decided once per visit, so a change made
during the visit opens nothing.

Closes kirodotdev#39121
@gsboylan
gsboylan force-pushed the feat/board-auto-open-setting branch from f1d96a1 to 5938ea7 Compare November 19, 2026 00:07
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of 5938ea708b6167e8b4c4e1056d4177eef8a5765b via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

No design-level concerns: one additive boolean that is on by default and gates the single effect that opens the Board, with rendered evidence attached.

Notes

  • Every first entry to a conductor chat now waits for the dashboard config read. That is the same ['dashboardConfig'] query ChatPage already makes, so a slow read only delays the Board opening and does not drop it.

[DESIGN-REVIEWED] 5938ea7

Description read

[DESCRIPTION-READ] 32cb35d79f37ecc81e52034c0af82d4555e3332ab773eac5197559f8d64c747e

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ✅ PASS

UX-level review of 5938ea708b6167e8b4c4e1056d4177eef8a5765b via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks. The dark and light screenshots show the new toggle, and three recordings cover the on, off and chip paths. This fork lane has no blind read, so nobody has cold-read the label; pushing the branch to this repository adds that pass.

Notes

  • auto_open_conductor_board: the label "Auto-Open Board in Side Panel" never says conductor mode, so "Board" could mean anything out of context. Rename it "Auto-Open Conductor Board in Side Panel".
  • auto_open_conductor_board_hint: the four-sentence tooltip is hard to scan. Keep the first sentence and the "Turning on conductor mode in a chat still opens the Board" exception, and drop the Keep Side Panel Open and phone sentences.

[UX-REVIEWED] 5938ea7

Description read

[DESCRIPTION-READ] aec46c779817c2b87ea7241fdcf8c54085062ae4d147548dbc414eee03defa19

That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ✅ PASS

Premise-level review of 5938ea708b6167e8b4c4e1056d4177eef8a5765b via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. Issue #39121 is the source of the need. The new setting defaults to on, so everyone keeps today's behaviour unless they turn it off. It gates the one place that does the auto-open.

What this change ships

Inventory (6 items) — 6 justified

Intent: let a person whose default agent is a conductor stop the side panel opening on the Board in every new chat. This is an ADDITION: an opt-out setting.

  1. New toggle under Settings → Chat → Side panel → Auto-Open Board in Side Panel, hidden in LTS — justified
  2. With the toggle off, the first time a conductor mode chat is opened its panel stays closed, and the Board tab is still pinned first — justified
  3. New config key dashboard.auto_open_conductor_board, on by default, read and written through GET,PUT /api/dashboard/config — justified
  4. The first-entry auto-open now waits for the dashboard config read; a failed read counts as on — justified
  5. The command palette offers the setting, except in LTS — justified
  6. Strings in the 12 shipped locales, plus the spec, feature-map and agents doc rows — justified

[FIRST-PRINCIPLES-REVIEWED] 5938ea7

Description read

[DESCRIPTION-READ] 9fbccd22d03070ca57259da97de32bbbe4d7bb3597f5ff3436ac2ab3e2d01e7a

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 19, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving 5938ea7. It is a clean rebase of f1d96a1: the PR-only diff is byte-identical, and the earlier Backend Tests red (from main's #38978, fixed by #39262) is gone. Design, UX and First Principles reviews pass, and PR Readiness is green. The setting matches the design sign-off above.

AI-assisted, sent by Bolin Review bot

@bolichen97
bolichen97 merged commit f23c699 into kirodotdev:main Nov 19, 2026
95 of 96 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conductor Mode: setting to turn off the auto-open of the Board tab

2 participants