Repository navigation
feat(dashboard): setting to turn off the conductor mode Board auto-open - #39224
Conversation
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
|
Bundle Size Gate: AI-assisted, sent by Bolin Review bot |
|
Maintainer design sign-off from @bolichen97: a I'll review the code and approve once the checks are green (the Bundle Size Gate should clear with a rebase onto main, see my earlier comment). AI-assisted, sent by Bolin Review bot |
4643a9c to
f1d96a1
Compare
|
The only red on f1d96a1 is Backend Tests (3.12, 8): AI-assisted, sent by Bolin Review bot |
The first entry to a conductor mode chat opens the side panel on its Board tab. A person whose default agent is a conductor gets that on every new chat and closes the panel each time, with no way to turn it off. Adds dashboard.auto_open_conductor_board, on by default, shown under Settings > Chat > Side panel as Auto-Open Board in Side Panel wherever conductor mode is offered. Off, a conductor mode chat is entered like any other chat: its panel stays closed unless Keep Side Panel Open is on, and the Board stays the panel's first tab. Turning conductor mode on with the composer chip still opens the Board. The entry waits for the setting to load and is decided once per visit, so a change made during the visit opens nothing. Closes kirodotdev#39121
f1d96a1 to
5938ea7
Compare
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS No design-level concerns: one additive boolean that is on by default and gates the single effect that opens the Board, with rendered evidence attached. Notes
[DESIGN-REVIEWED] 5938ea7 Description read[DESCRIPTION-READ] 32cb35d79f37ecc81e52034c0af82d4555e3332ab773eac5197559f8d64c747e That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5, fork) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. The dark and light screenshots show the new toggle, and three recordings cover the on, off and chip paths. This fork lane has no blind read, so nobody has cold-read the label; pushing the branch to this repository adds that pass. Notes
[UX-REVIEWED] 5938ea7 Description read[DESCRIPTION-READ] aec46c779817c2b87ea7241fdcf8c54085062ae4d147548dbc414eee03defa19 That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. Issue #39121 is the source of the need. The new setting defaults to on, so everyone keeps today's behaviour unless they turn it off. It gates the one place that does the auto-open. What this change shipsInventory (6 items) — 6 justifiedIntent: let a person whose default agent is a conductor stop the side panel opening on the Board in every new chat. This is an ADDITION: an opt-out setting.
[FIRST-PRINCIPLES-REVIEWED] 5938ea7 Description read[DESCRIPTION-READ] 9fbccd22d03070ca57259da97de32bbbe4d7bb3597f5ff3436ac2ab3e2d01e7a That sha256 names the PR description this verdict read. Recompute it with |
bolichen97
left a comment
There was a problem hiding this comment.
Approving 5938ea7. It is a clean rebase of f1d96a1: the PR-only diff is byte-identical, and the earlier Backend Tests red (from main's #38978, fixed by #39262) is gone. Design, UX and First Principles reviews pass, and PR Readiness is green. The setting matches the design sign-off above.
AI-assisted, sent by Bolin Review bot
Problem / Motivation
Goal: A person can turn off the side panel opening on the Board when a conductor mode chat is opened for the first time.
The first entry to a conductor mode chat opens the side panel on its Board tab. A person whose default agent is a conductor gets that on every new chat, because every new chat enters conductor mode. They close the panel each time. Nothing lets them turn it off.
Why it matters
The panel takes screen width the person did not ask for, on every new chat. One setting ends the repeated close.
Not a goal
mc-activity-open:<slot>), as it does today.What changed (motivation → approach → change)
The auto-open lives in one place: the enter-root effect in
website/src/pages/chat/page/crewModeSwitch.ts. A new dashboard setting gates that effect. Everything else is the plumbing a dashboard setting needs.dashboard.auto_open_conductor_boardsrc/kiro_crew/config/sections_dashboard.py,loader_builders.py, and theGET,PUT /api/dashboard/confighandler insrc/kiro_crew/dashboard/file_api/dashboard_config.pycarry it like its neighbors.website/src/pages/settings/ChatPanel.tsx, shown wherever conductor mode is offered. LTS hides it, as it hides Start New Chats in conductor mode. The palette entry inwebsite/src/components/commandPalette/settingsSearchCore.tsfollows the same rule.pageEnvironment.tsreads the setting from the dashboard config query the chat page already makes.crewModeSwitch.tstakes it asautoOpenBoard:undefinedwhile the read is in flight, so the first entry waits for it. Off, the effect returns before it opens anything. The entry is decided once, so a change during the visit opens nothing. A failed read counts as on.website/src/i18n/locales/, verified withi18n-translate.mjs verify(0 findings).docs/system-specs/modules/crew-mode.md,docs/feature-map/README.md,src/kiro_crew/docs/agents.md; regeneratedconfig-baseline.json, the settings registry, the UI index, anden-XA.Why gate the effect and not the pin: the Board tab stays pinned first on every conductor chat (
usePinnedViews.ts), so a person who opens the panel by hand still lands on the Board. Only the opening changes.Backwards compatibility
Compatible: a config that never sets the key reads as on, so every install behaves as before until a person turns the setting off. Keep Side Panel Open still wins when it is on.
Removes nothing: the change adds one optional boolean and gates one effect that is open by default.
Tests
Backend:
test/test_auto_open_conductor_board_config.py: default on, a config that never sets it loads as on, off round-trips through save and load, a non-boolean falls back to on, the generated schema carries label and help.test/test_dashboard_files_coverage.py: the field joins the PUT boolean validation table, the coded-error table, and the full PUT/GET round trip.Frontend:
website/src/pages/chat/page/crewModeSwitch.test.tsx: an existing chat entered with the setting off stays closed; the entry waits for the setting to load, then opens (on) or stays closed (off); a setting turned on during the visit opens nothing; a new chat on a conductor default agent opens the Board (on) or stays closed (off); a chat created in conductor mode with the setting off stays closed.website/src/test/SettingsChatPanelCoverage.test.tsx: the toggle reads on by default and persists turning it off.website/src/test/ltsFeaturePreviewsOff.test.tsx: the palette offers the setting in oss and hides it in LTS.All new frontend tests fail on the old hook (6 failures) and pass on the new one.
Manual verification
Scripted Playwright on the worktree's built SPA, with every
/api/**call answered from fixtures (no gateway). Default agentkirocrew-conductor:kirocrew: pressing the Conductor mode chip in a new chat still opens the Board.Real-machine verification
Machine: own computer (the development host), Amazon Linux 2, x86_64
Before (main 44769db):
npx vitest run src/pages/chat/page/crewModeSwitch.test.tsxwith the new tests against the basecrewModeSwitch.ts-> 6 failed, 22 passed. Settings → Chat → Side panel has no Auto-Open Board row, and every first entry to a conductor mode chat opens the Board.After (head 1853bd3): the same command -> 28 passed. The capture harness (scripted Playwright over the built SPA) -> 10 of 10 checks pass, including "the new conductor mode chat opens with the side panel closed" with the setting off.
Cleanup: own computer
Screenshots / video
Settings → Chat → Side panel, dark theme, with the tip open:
Light theme:
Setting on (the default): pressing New opens the new conductor mode chat with the Board in front.
new-on.mp4
Setting off: turned off in Settings, then New. The chat opens with the panel closed; the panel button opens it on the Board.
new-off.mp4
Setting off, default agent
kirocrew: pressing the Conductor mode chip still opens the Board.off-chip.mp4
Related Issues
Closes #39121
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license.