Skip to content

fix(dashboard): show a worker-hosted discussion on the conductor mode Board - #39263

Merged
KiroCrewCaptain merged 1 commit into
mainfrom
feat/board-discussing-row
Nov 19, 2026
Merged

KiroCrewCaptain merged 1 commit into
mainfrom
feat/board-discussing-row

Conversation

@iamwhatever

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The conductor mode Board side panel shows a worker-hosted discussion as "Discussing", with its round, minutes and counts, and a panel that opens to show what the discussion holds.

When a worker hosts a discussion, the Board tab shows that milestone as plain "In progress". The person cannot tell a discussion is running, which round it is on, or what has been agreed. #37340 taught only the goal-board template (the Dashboard tab) to draw this row; the Board tab is a different component that never reads discussion.

Why it matters

The Board is the tab a conductor chat opens by default, so it is where people look. Every worker-hosted discussion today looks like ordinary work there, and the agreed / disputed points are only visible by opening the worker's chat.

Not a goal

  • The discussion card in the chat (AssistantMessage.tsx and the card component): another PR owns it.
  • Any server change: /api/crew-board already sends discussion (a test here pins it).
  • Changing the goal-board template or its rule.

What changed (motivation → approach → change)

Symptom: a discussing milestone reads "In progress". Cause: ConductorModeCrewPanel has no discussing state and WorkBoardItem has no discussion field, though the board payload carries it.

  • milestoneState gains discussing, placed after needs-you and before running, with goal-board's own rule: item open, discussion.phase set, worker not closed, not orphaned, not stale. A closed item or a stale worker falls back to its plain state.
  • The row carries the speech-bubble state icon and reads "Discussing · Round N · M min", then "Agreed a · Disputed d · Being checked c". A toggle opens direction, agreed, disputed (point and sides), being checked, latest lines, and the thread link. The link is drawn only when it matches the server's own allowed shape.
  • A discussing milestone counts as moving in the run line and recap while its worker is mid-turn.
  • WorkBoardItem.discussion is typed in website/src/api/crewBoard.ts. New copy in all 13 catalogs under website/src/i18n/locales/ (en-XA.json regenerated), worded as goal-board's.
  • A capture page website/capture/conductor-mode-discussing.tsx renders the real panel with fixtures.

Backwards compatibility

Compatible: the new field is optional; an item without discussion keeps every state it had.

Removes nothing: the diff only adds a state, a field, copy and tests.

Tests

  • ConductorModeCrewPanel.test.ts: discussing for a running or idle host; needs-you still wins; accepted / abandoned close it; stale → quiet, closed or orphaned → stuck; no phase → no discussion.
  • ConductorModeCrewPanel.discussion.test.tsx: the row text, counts, toggle and every panel section render; an unsafe thread link is not drawn; a closed item and a stale worker show no discussion.
  • test/test_work_ledger_board.py::test_a_hosted_discussion_reaches_the_board_row: /api/crew-board carries the report's discussion.

Proof: not provable -- frontend test (prove.py runs Python only)

Manual verification

Rendered the capture page in Chromium (dark, light, zh-CN, panel closed and open); screenshots below.

Real-machine verification

N/A -- a dashboard render change with no host or install path; unit tests and the capture page cover it.

Screenshots / video

Panel open (dark):

Board discussing row, open

Closed, zh-CN, light

closed
zh-CN
light

Related Issues

Closes #39227

Sibling sweep

Swept: git grep -n "discussion" -- website/src
Sibling: src/kiro_crew/dashboard_templates/builtin/goal-board/template.html -- not affected -- already draws the row since #37340

Pattern harvest

Not generalizable: one server field gained a second UI reader that was never written; the field itself is generic.

Checklist

  • A Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...); PR Hygiene does not count commits
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners November 18, 2026 21:00
@iamwhatever
iamwhatever requested a review from buluoray November 18, 2026 21:00
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of d67dffac7fed4c242feca093c52373579aa0f576 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the change adds a missing UI reader for a field the server already sends, follows the goal-board rule, removes nothing, and its rendered evidence matches the diff.

Notes

  • The discussing predicate and the THREAD_LINK shape now exist in three places: ConductorModeCrewPanel.tsx, goal-board/template.html:442, and the server's work_vocab.py LINKABLE rule. If any one of them changes, the Board and Dashboard tabs can disagree. A comment at each site naming the others would make that drift easy to catch.

[DESIGN-REVIEWED] d67dffa

Description read

[DESCRIPTION-READ] 429a3a1bd732b136ec051680dbb565ef50ece42c25cf47134a47397ee33d7c71

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of d67dffac7fed4c242feca093c52373579aa0f576 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing to check. Every item fixes the reported defect (#39227): the Board tab shows a discussing milestone as "In progress" because ConductorModeCrewPanel never reads discussion, even though the board payload sends it.

What this change ships

Inventory (9 items) — 9 justified

Intent: let a person see on the default Board tab that a worker-hosted discussion is running, and what it has agreed so far. FIX.

  1. A milestone whose worker hosts a live discussion reads "Discussing" instead of "In progress" — justified
  2. The row shows "Round N · M min", then the agreed / disputed / being-checked counts — justified
  3. A show/hide toggle opens direction, agreed, disputed with sides, being checked, latest lines and the thread link — justified
  4. A speech-bubble state icon for the discussing row — justified
  5. A discussing milestone counts as moving in the run pulse and the recap while its host is mid-turn — justified
  6. A closed item, or a stale, closed or orphaned worker, falls back to its plain state instead of showing the discussion — justified
  7. WorkBoardItem.discussion / WorkDiscussion typed in crewBoard.ts — justified
  8. New strings in all 13 locale catalogs — justified
  9. A capture page for the panel (the repo's existing website/capture/ convention) and a backend test pinning that /api/crew-board carries discussion — justified

[FIRST-PRINCIPLES-REVIEWED] d67dffa

Description read

[DESCRIPTION-READ] 188ffc25d3ea29efaff581e412bfea2b7c4fa7f70426b29fab3b4e8ee39565ed

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of d67dffac7fed4c242feca093c52373579aa0f576 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks. The primary toggle ("Show/Hide the discussion") was read correctly with confidence, and every new state appears in a screenshot.

Notes

  • On the discussing row, the minutes in the sub-line ("Discussing · Round 2 · 12m") and the right-column "3m" read as two unexplained times; the blind reader asked "which time is which". Label one of them, e.g. "12m discussing", or drop the duplicate.
  • The recap now counts a discussing milestone as running ("2 running"), while its row says "Discussing". The reader saw this as two words for one state. Name it in the recap instead, e.g. "1 running, 1 discussing".

[UX-REVIEWED] d67dffa

Description read

[DESCRIPTION-READ] cec2a3be7898933653f051d1d4a65114140226bef29cbc37d0cf5d69a6d42cc2

That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 18, 2026
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed d67dffac7fed4c242feca093c52373579aa0f576 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] d67dffa

Verdict parsed from the review's SHA-scoped output markers for commit d67dffac7fed4c242feca093c52373579aa0f576.

False positive or not applicable? A repository writer can comment:
/ai-review override fable d67dffac7fed4c242feca093c52373579aa0f576 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of d67dffac7fed4c242feca093c52373579aa0f576 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] d67dffa

False positive or not applicable? A repository writer can comment:
/ai-review override gpt d67dffac7fed4c242feca093c52373579aa0f576 false-positive: <reason, 20 to 500 characters>

@iamwhatever
iamwhatever force-pushed the feat/board-discussing-row branch from c7cdfde to d67dffa Compare November 18, 2026 22:00
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in test/test_kas_token_refresh_recovery.py (the red bare-session-handle guard, fixed by #39262) and website/src/i18n/locales/* since head c7cdfde (c5ac14c -> 6e059d7). Same push fixes the hi/bn register of this PR's own new strings (tum/tumi forms) flagged by hiStyle/bnStyle. CI re-running.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 19, 2026
@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: A person should decide

Why: the decider estimates a 10% chance that this change introduces a defect, within the 12% limit for approving on its own, but it changes 446 lines, more than the 400 it may approve on its own.

This adds a read-only "discussing" state to the conductor mode Board, using the Dashboard tab template's own rule (goal-board/template.html:442). The server already sends and validates discussion. The thread link is drawn only if it matches the server's allowed pattern, and every field is rendered as plain text. Rows whose worker is closed, orphaned or stale keep their old state. The other readers of the milestone state (done, needs-you, stuck and quiet counts) are unaffected; the recap and the "moving" pulse were extended on purpose. There are unit, render and backend tests, and CI is green.

Tier: pending: being reviewed.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit d67dffac7f · 446 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@KiroCrewCaptain
KiroCrewCaptain enabled auto-merge (squash) November 19, 2026 00:55

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. On this head the review checked these points. The new discussing state uses the same rule, in the same order, as the goal-board template, and needs-you still wins. A closed, orphaned or stale item still falls through as before. Every discussion field renders as React text. The thread link is drawn only when it matches the server's own pattern and is under the length cap, and a test proves a javascript: link draws nothing. The new pytest pins that /api/crew-board sends discussion. The milestoneState tests cover both sides of every guard. PR Readiness is green.

Done well: the Board tab and the Dashboard tab now agree, and there is no server change.

Optional:

  • ConductorModeCrewPanel.tsx:319: a worker's final done report that still carries a discussion now reads "Discussing" instead of Done until the conductor accepts it. You could skip the discussing branch when item.status === 'done'.
  • ConductorModeCrewPanel.tsx:858: the recap counts a discussion as running even when its host is idle. The body says this happens only while the worker is mid-turn. Neither the recap nor the pulse at line 833 has a test, so you could gate the recap on alive === 'running' (or reword the body) and pin it.
  • src/kiro_crew/docs/work-ledger.md:215 still names only the goal board as a reader of discussion.

@KiroCrewCaptain
KiroCrewCaptain merged commit ba05643 into main Nov 19, 2026
102 of 107 checks passed
@KiroCrewCaptain
KiroCrewCaptain deleted the feat/board-discussing-row branch November 19, 2026 00:55
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conductor mode Board shows a worker-hosted discussion as plain "In progress"

2 participants