Repository navigation
docs: record that emoji are replaced only in the web ui - #39271
Conversation
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Docs only, and it records a decision the owner made. Nothing renders and nothing is taken away. [DESIGN-REVIEWED] a450a2f Description read[DESCRIPTION-READ] 5e78cc7d36923667157f3bf2512500182a09051bfd67a61a2f5f8b3678dc3356 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. The diff only changes markdown (a new decision entry, its index row and two link lines), so no user-visible control needs a screenshot. [UX-REVIEWED] a450a2f Description read[DESCRIPTION-READ] 3d81854aa3b4b977221a7bbf71b4fb8f61354adf24917185171d6f8f5f300583 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Add a decision entry for the owner's 2026-11-18 ruling: emoji become lucide icons only where a person sees the web UI, while the CLI, doctor, CI output, Slack and other chat apps may keep them. Link it from the two icon rules. Refs #39269
670fbc2 to
a450a2f
Compare
Problem / Motivation
Goal: The decision that emoji are replaced with icons only in the web UI is written down, so nobody takes the emoji out of the CLI, doctor, CI, Slack or chat apps again by mistake.
On 2026-11-18 the owner, Zezhen, decided that emoji become lucide icons only where a person sees the web UI. The command line,
kirocrew doctor, CI output, Slack and the other chat apps may keep emoji. #39210 removed the backend emoji CI check, and #39228, #39226, #39230 and #39222 bring the emoji back. No decision entry records this yet.Why it matters
Without an entry, a review lane, the nightly tester or an agent can read the earlier backend removal as the rule and strip the emoji from the CLI or Slack again.
Not a goal
docs/system-specs/common/code-style.mdorwebsite/AGENTS.mdbeyond one link line each.What changed (motivation → approach → change)
Owner decision with no record → a decision entry in the repo's decision ledger → three small additions:
docs/decisions/2026-11-18-emoji-are-replaced-only-in-the-web-ui.md, in the ledger's entry format, citing revert: drop the backend emoji ci guard #39210 (Zezhen's PR that states the decision) and the related PRs.docs/decisions/README.md.docs/system-specs/common/code-style.mdand inwebsite/AGENTS.md.Backwards compatibility
Compatible: docs only; nothing that works today changes.
Removes nothing: three docs gain lines and one new entry is added.
Tests
Proof: not provable -- docs or config only
bash scripts/docs-lint.shpassed.DECISIONS_BASE_REF=origin/main python3 scripts/check_decisions_history.pypassed (122 entries intact). The comment-history and brand-name gates passed.Manual verification
N/A -- docs only; the links were checked by
scripts/docs-lint.sh.Real-machine verification
N/A -- the diff is markdown only and runs nothing.
Related Issues
Closes #39269
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...); PR Hygiene does not count commits