Skip to content

docs: record that emoji are replaced only in the web ui - #39271

Merged
CrysisDeu merged 1 commit into
mainfrom
docs/emoji-decision-web-ui-only
Nov 18, 2026
Merged

CrysisDeu merged 1 commit into
mainfrom
docs/emoji-decision-web-ui-only

Conversation

@CrysisDeu

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The decision that emoji are replaced with icons only in the web UI is written down, so nobody takes the emoji out of the CLI, doctor, CI, Slack or chat apps again by mistake.

On 2026-11-18 the owner, Zezhen, decided that emoji become lucide icons only where a person sees the web UI. The command line, kirocrew doctor, CI output, Slack and the other chat apps may keep emoji. #39210 removed the backend emoji CI check, and #39228, #39226, #39230 and #39222 bring the emoji back. No decision entry records this yet.

Why it matters

Without an entry, a review lane, the nightly tester or an agent can read the earlier backend removal as the rule and strip the emoji from the CLI or Slack again.

Not a goal

What changed (motivation → approach → change)

Owner decision with no record → a decision entry in the repo's decision ledger → three small additions:

  • New entry docs/decisions/2026-11-18-emoji-are-replaced-only-in-the-web-ui.md, in the ledger's entry format, citing revert: drop the backend emoji ci guard #39210 (Zezhen's PR that states the decision) and the related PRs.
  • Its index row in docs/decisions/README.md.
  • One link line to the entry under the icon rule in docs/system-specs/common/code-style.md and in website/AGENTS.md.

Backwards compatibility

Compatible: docs only; nothing that works today changes.

Removes nothing: three docs gain lines and one new entry is added.

Tests

Proof: not provable -- docs or config only

bash scripts/docs-lint.sh passed. DECISIONS_BASE_REF=origin/main python3 scripts/check_decisions_history.py passed (122 entries intact). The comment-history and brand-name gates passed.

Manual verification

N/A -- docs only; the links were checked by scripts/docs-lint.sh.

Real-machine verification

N/A -- the diff is markdown only and runs nothing.

Related Issues

Closes #39269

Checklist

  • A Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...); PR Hygiene does not count commits
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@CrysisDeu
CrysisDeu requested review from a team and KiroCrewCaptain as code owners November 18, 2026 21:18
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision a450a2fe7b01a116b81613413db429d198072489 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of a450a2fe7b01a116b81613413db429d198072489 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Docs only, and it records a decision the owner made. Nothing renders and nothing is taken away.

[DESIGN-REVIEWED] a450a2f

Description read

[DESCRIPTION-READ] 5e78cc7d36923667157f3bf2512500182a09051bfd67a61a2f5f8b3678dc3356

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of a450a2fe7b01a116b81613413db429d198072489 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing to check. The diff only changes markdown (a new decision entry, its index row and two link lines), so no user-visible control needs a screenshot.

[UX-REVIEWED] a450a2f

Description read

[DESCRIPTION-READ] 3d81854aa3b4b977221a7bbf71b4fb8f61354adf24917185171d6f8f5f300583

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed a450a2fe7b01a116b81613413db429d198072489 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] a450a2f

Verdict parsed from the review's SHA-scoped output markers for commit a450a2fe7b01a116b81613413db429d198072489.

False positive or not applicable? A repository writer can comment:
/ai-review override fable a450a2fe7b01a116b81613413db429d198072489 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of a450a2fe7b01a116b81613413db429d198072489 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] a450a2f

False positive or not applicable? A repository writer can comment:
/ai-review override gpt a450a2fe7b01a116b81613413db429d198072489 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 18, 2026
Add a decision entry for the owner's 2026-11-18 ruling: emoji become
lucide icons only where a person sees the web UI, while the CLI,
doctor, CI output, Slack and other chat apps may keep them. Link it
from the two icon rules.

Refs #39269
@CrysisDeu
CrysisDeu force-pushed the docs/emoji-decision-web-ui-only branch from 670fbc2 to a450a2f Compare November 18, 2026 21:57
@CrysisDeu
CrysisDeu merged commit 5cf87d8 into main Nov 18, 2026
99 of 101 checks passed
@CrysisDeu
CrysisDeu deleted the docs/emoji-decision-web-ui-only branch November 18, 2026 22:38
@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: record the decision that emoji are replaced only in the web UI

1 participant