Repository navigation
docs(rfc): resource control: CPU in the host posture, re-wakes while tight, add-only remote probe - #39344
docs(rfc): resource control: CPU in the host posture, re-wakes while tight, add-only remote probe#39344iamwhatever wants to merge 1 commit into
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this is a docs-only draft RFC, it removes nothing, and the design questions it raises are left for maintainers to accept. [DESIGN-REVIEWED] 6211951 Description read[DESCRIPTION-READ] 5234afff80afec0de9adca8ab7519dba84651306aa64ddd7608af628748ac3d7 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — 🔴 changes requested (blocking)Reviewed The RFC's §5.3 says BLOCKING — docs/request-for-change/rfc-resource-control.md:371
Trigger: An implementer follows §5.3 and puts a probe at Outcome: The resolver refuses the probe script. A probe that needs a cloud credential can never receive the grant rule 8 promises. If the resolver is widened to make it run, a granted probe can still read and write the other boards' probe scripts, because the hide list was never extended to that tree. That is the mutable-sibling route the hide list exists to close. Anchor: defect Fix: Put probes under [BLOCK-MERGE] 3f71bc6 Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
…tight, add-only remote probe Extends rfc-host-memory-guard without editing it. Proposes CPU load as a posture input capped at tight, a re-wake per step of decline while tight or critical and a per-worker growth wake inside the existing hourly wake budget, and a default-off, add-only, sandboxed probe script the conductor writes to be woken about remote or cloud resources.
3f71bc6 to
6211951
Compare
|
Opus 5.5 BLOCKING finding on 3f71bc6 (rfc-resource-control.md §5.3, probe path outside the script-cron tree): fixed in 6211951.
|
Problem / Motivation
Goal: Record one reviewable design for the three resource-control gaps left after the host memory guard, so the owner's team can review it before any of it is built.
The host memory guard (#39188, merged; fast layer #39270 and slow layer #39289, open) protects one host's memory and disk. Three gaps remain:
_classifyinsrc/kiro_crew/resource_status.pyreads memory only;load_per_cpuis reported but never part of the posture, so a CPU-saturated host never wakes its conductor.tightwhile free memory or disk keeps falling, or one worker that grows fast, never re-wakes the conductor until the host reachescritical, when the fast layer is already stopping trees.Why it matters
Without (1) and (2), the conductor's "Keep the host healthy" rule from #39289 gets no chance to act gently before forced action. Without (3), every conductor that depends on cloud resources pays a model turn per patrol (12 an hour at the 300 s default) to watch them, or does not watch them at all.
Not a goal
docs/request-for-change/rfc-host-memory-guard.md(docs(rfc): mark rfc-host-memory-guard accepted #39290 owns its Status line).What changed (motivation → approach → change)
docs/request-for-change/rfc-resource-control.md(statusdraft), which extendsrfc-host-memory-guard.md:tightat 1.5, leave below 1.0), capped attight. It never enters the memory posture, so the fast-layer trigger, the create refusal and the spawn floor cannot act on CPU.tightorcritical(memory 1 GB / 0.5 GB, disk 2 / 1 points), and a per-worker wake (25% of RAM in any posture, +2 GB growth while tight). Both use readings the gateway already takes, make no model call, and charge existing hourly budgets (ITEM_PULLS_PER_HOUR,MAX_WAKES_PER_ITEM_PER_HOUR). A separate PR implements this section.{"level", "reading"}schema, wake on level change only, sandboxed through the existing script-cron runnerrun_script_sandboxed, 20 s timeout, auto-disable after 5 failures, every registration announced with a digest, credentials only through the owner-approved, digest-pinned vault grant script crons already use. Covers file location, edit path, owner disable, threat model and a cost comparison against waking every patrol and against themonitor_startjudge.docs/request-for-change/README.md: one index row for the new RFC.Backwards compatibility
Compatible: docs only; no code, config key or persisted format changes.
Removes nothing: the PR adds one document and one index row.
Tests
Proof: not provable -- docs or config only
./scripts/docs-lint.shpasses locally ("All documentation checks passed").Manual verification
Every code reference was read at
dcc312174e(origin/main) and in the live diffs of #39270 and #39289; the RFC labels what is only in an open PR.Real-machine verification
N/A -- the diff is a Markdown document and an index row; nothing in it runs.
Related Issues
Refs #22681. Extends #39188; builds on #39189, #39270, #39289.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...); PR Hygiene does not count commitsContribution License Agreement
Contributions are accepted under the project's Apache-2.0 license.