Repository navigation
feat(dashboard): waiting-on-you cards pin an agent's ask above the composer - #39362
unstablebrainiac wants to merge 1 commit into
Conversation
UX Review (Opus 5.5, fork) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)UX-level review of UX-Verdict: PASS cannot evaluate: missing screenshots of most of the card's states and of three of the five places it appears. The six frames show only the resting decision card, the action card, "+2 more" collapsed, "Answered elsewhere", the sidebar row and the hover card. Evidence gaps
Notes
[UX-REVIEWED] 1791f6f Description read[DESCRIPTION-READ] 1a062ff5354319e4fd6b49fd8c88763d9581eb801660971c21e487f9d5b26f43 That sha256 names everything this verdict read: the PR description, plus the 9 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks. Everything is additive (new tools, store, routes, slot field, context block), the six committed screenshots count as rendered evidence, and the take-away check found no reader that breaks. Notes
[DESIGN-REVIEWED] 1791f6f Description read[DESCRIPTION-READ] 9d38ea58323aba4e5e64c4fa42c9645039d0836481be47bd72723f2deeb966ef That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. Each item answers the ask-scrolls-away harm from #20961, and the existing ask mechanisms do a different job: What this change shipsInventory (10 items) — 10 justifiedIntent: let an agent keep what it needs from the person in view, above the composer, until it is answered or cleared. This is an ADDITION.
[FIRST-PRINCIPLES-REVIEWED] 1791f6f Description read[DESCRIPTION-READ] 965698c390785d89c464c3289fee7d743d5accacec97e4b7fbfafa41593a92fd That sha256 names the PR description this verdict read. Recompute it with |
47bb33c to
519eae8
Compare
Opus 5.5 Review (fork) — 🔴 changes requested (blocking)Reviewed Blocks merge: an option label the agent writes is sent as the owner's own chat turn with commands enabled. One selection plus Send on a BLOCKING — src/kiro_crew/dashboard/handlers/waiting_on_you.py:584 |
GPT 6.1 Review (fork) — 🔴 changes requested (blocking)Reviewed 1 of 4 blocking finding(s) are security-class and were withheld from adjudication, so the blocking verdict stands. BLOCKING -- website/src/pages/ChatPage.tsx:1273 -- Return rejected answers to their originating session
BLOCKING -- src/kiro_crew/dashboard/waiting_on_you.py:521 -- Do not classify pending reservations as completed answers
BLOCKING -- src/kiro_crew/dashboard/waiting_on_you.py:341 -- Persist candidate records before exposing them to readers
BLOCKING -- src/kiro_crew/dashboard/waiting_on_you_events.py:299 -- Preserve answer identification after retirement is consumed
[BLOCK-MERGE] 1791f6f Adjudication (Opus 5.5) — is blocking on each finding proportionate?I've ruled on all three findings and kept all of them blocking. The fenced finding (F2) also stays blocking. F1 ( F3 ( F4 ( F2 (fenced): A concurrent answer gets |
519eae8 to
1791f6f
Compare
|
Rebased: main moved in docs/feature-map/README.md, src/kiro_crew/dashboard/file_api/dashboard_config.py, test/test_dashboard_files_coverage.py and the website/src/i18n/locales catalogs since this head's base (74e9123 -> f23c699); CI re-running. Related tests (test_dashboard_files_coverage, test_waiting_on_you_*), mypy, tsc, the feature-map check and the i18n suite pass locally on 1791f6f. |
1791f6f to
19c1fa7
Compare
|
Rebased: main moved in test/conftest.py, test/conftest_resets.py and website/src/i18n/en.context.json (all three conflicted; resolved as unions) since this head's base (f23c699 -> b8a2db9); CI re-running. This head also carries the UX Review blocker fix: an ask answered elsewhere, replaced or cleared now turns into its notice in place, with a regression test, and "composer" becomes "message box" in the UI text in all 12 locales. The capture script now covers the missing states; their frames and recordings are committed on #39616. Locally: isort, flake8, black, mypy, docs lint, 301 related backend tests, tsc, eslint, and 1,317 frontend and i18n tests pass. |
|
Superseded by #39616: the same commit on a kirodotdev branch, so Sensitive Change Review can pass. |
Problem / Motivation
Goal: An agent can pin what it needs from the person above the composer, as an "Action for you" card that stays until the person answers it or writes, the agent clears it, or it expires.
When an agent is blocked on the person, only the turn that first said so explains the ask. In a watch loop every later cycle adds another "still waiting on you" reply on top, so the person scrolls back to find what is needed.
[OPTIONS:]chips come only from the newest reply. Theask_questioncard blocks the turn for 30 minutes, then is withdrawn. Nothing keeps an ask in view across turns.Why it matters
Loops that wait on a person for hours produce one reply per cycle that says nothing new, and the actual ask scrolls out of view. Non-loop chats lose the ask too, as soon as the person asks a side question. The sidebar cannot say "waiting on you" for a plain-text ask (#20961).
Not a goal
babysitand goal-conductor guidance that would tell a loop to stop restating its ask. That changes default loop behaviour and waits for the RFC to be accepted. The tool description stays neutral on it.ask_question, native question cards,[OPTIONS:]chips orneeds_input.[OPTIONS:].What changed (motivation → approach → change)
An agent can now pin what it needs from you, an action or a decision with options, as an "Action for you" card above the message box. The card stays across turns, loop cycles and restarts until you answer it or write in the chat, the agent clears it, or 7 days pass, so the ask no longer scrolls away. This is Phase 1 of the design in PR #39294 (
docs/request-for-change/rfc-waiting-on-you-cards.md, stilldraft); the packaged doc issrc/kiro_crew/docs/waiting-on-you.md.waiting_on_youpins or replaces one ask: a key, a title, optional detail, and 0 to 6 options.waiting_on_you_clearremoves it. Up to 4 per session. Over-length text is refused, never cut.mcp_tools/control_parts/waiting.pyandschemas.py,validation_parts/server_registries.py,mcp_core_parts/identity.py,data/mcp_tool_titles.json,mcp_listing_relay.py, shared limits inwaiting_on_you_contract.pywaiting_on_you.jsonunder the data home, MAC'd likechange_cards.json. It survives restarts and lazy tab restore. Incognito sessions keep asks in memory only.dashboard/waiting_on_you.pymeta.human, owner as author) retires every ask. Auto-nudges, crons, sub-agents, peersession_send, apps and teammates retire none. Answering a card retires only that card. Fork starts empty; rewind and edit-and-resend clear.dashboard/waiting_on_you_events.py,dashboard/state_parts/slot_transcript.pyask_idand the stored options, and are idempotent peranswer_id. Only the chosen label or typed text becomes the user row, so agent-written text never arrives with the owner's authority. A gateway restart mid-answer leaves the card marked "may already have been sent", never re-sent.dashboard/handlers/waiting_on_you.py(a registered redaction sink insecurity_posture_sinks_gateway.py)[WAITING ON YOU]block lists pinned asks, names retired ones once with their full text, and says which ask a card answer answers. It is capped at 6,000 characters.context_blocks.py,dashboard/chat_turn/--aim, separate from "Waiting on you". The needs-me hover card and the Questions tab list asks too. Strings ship in all 12 locales.website/src/components/waitingOnYou/,website/src/api/client/approvals.ts,website/src/types/,website/src/i18n/Where this build differs from the draft RFC: a paused crew queues the answer instead of refusing it (that is how chat send behaves), edit-and-resend clears asks like rewind, and Shared Crew teammates get 403 on the answer and dismiss routes. The RFC will be updated to match.
PR Size(shadow, not enforced) reports 93 files over its 80: backend, frontend, 13 locale catalogs, tests and 6 screenshots. The two halves share one contract and land together.Backwards compatibility
Compatible: the tools, store, routes, slot field and context block are all new. Agents that never call the tools see no change. An older build ignores
waiting_on_you.jsonand thewaiting_on_youslot field, and skips the unknownwaitingcard surface.Removes nothing: no existing key, route, field, row, validator or capability is taken away;
needs_inputand every reader of it are unchanged.Tests
test/test_waiting_on_you_store.py: survival across restart and lazy restore, tamper-evident records, an oversized file left alone, a failed write that broadcasts nothing and keeps every slot, expiry, incognito.test/test_waiting_on_you_retirement.py: only a live owner row retires; replays, nudges, crons, peers, apps, Issue Radar and teammates do not; fork, rewind and delete; restored asks are pushed after load.test/test_waiting_on_you_answers.py: exact label sent with its meta; oldask_id, label not among the options, a second window, retries and concurrent answers; a refused send keeps the ask; a send refused after its row landed becomesuncertain; queued answers never merge.test/test_waiting_on_you_agent.py: tool and gateway refusals with SEL audit; the per-turn block's cap, boundary escaping and answered line, including no answered line on a machine-opened turn; no loop guidance in the tool, the doc or the block.WaitingOnYouStack.test.tsx,waitingOnYou.test.ts,NeedsMeHoverCard.waiting.test.tsxandcommandCenterPanel.waitingOnYou.test.tsxcover render, answer, every 409, retry reuse, dismiss, the kept draft, the stale answer returned to its own session's draft, status precedence and the selectable list.Each fix found in local review has a regression test that fails when the fix is reverted.
Manual verification
website/scripts/capture-waiting-on-you.mjsmounts the realChatPagein a capture harness with intercepted API answers. It asserts each state, then writes the frames below in light and dark. All 102 checks pass. Each frame was also inspected by eye. That inspection found one defect: "Show more" appeared when nothing was hidden. It is fixed by measuring the clamp after layout.Real-machine verification
Machine: Amazon Linux 2023 cloud desktop, x86_64, 192 vCPU / 740 GiB.
Before (main
6e059d769e):git grep -c WaitingOnYouStack -- website/src-> no matches; no card, tool or route exists.After (head
47bb33c8af):node scripts/capture-waiting-on-you.mjs ../temp-screenshots/waiting-on-you-> exit 0, 102 checks pass, 18 frames written.Cleanup: own machine; the capture server ran in-process on 127.0.0.1 and exited with the script.
Screenshots / video
A decision card, dark. Options form one list with a single Send:
A stack of three asks, collapsed to "+2 more", light:
More frames: action card, answered elsewhere, needs-me hover card, 390px
Related Issues
Part of #20961
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...); PR Hygiene does not count commitsContribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.