Repository navigation
Conversation
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. The diff adds and changes no on-screen controls, labels or dialog text. It only touches backend Feishu import timing, how the Electron app checks the Windows port, log lines and a guide, so no screenshot is needed. [UX-REVIEWED] f4552b6 Description read[DESCRIPTION-READ] 957a3fd6bf5ef4039769037f180fbe273703422c1d5d6db3ad2e47ade7741ffc That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Both picks are clean backports of fixes already on main, and the seams they depend on ( Notes
[DESIGN-REVIEWED] f4552b6 Description read[DESCRIPTION-READ] 22c5dc5d1cf51e1e99fff3e2f42ea47e3bea55728491e1769e5b91bab77089e7 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Two undeclared riders ship beside the declared fixes. Both remove a real harm, and neither carries a product-shape change. Notes
What this change shipsInventory (6 items) — 4 justifiedIntent: 0.13 users get two P0 fixes from main: the Windows gateway starts when netstat cannot finish, and a slow Feishu SDK import no longer causes a restart loop. This is a FIX (backport).
[FIRST-PRINCIPLES-REVIEWED] f4552b6 Description read[DESCRIPTION-READ] 749a549bc924201c3ccf39f30edafe86a7624ca3ecf0f34edce7a4b4088f1e71 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
|
Closing: #39397 (merged 04:57Z) already carries #37927 and #38025 on release/0.13.0, so this PR is redundant. Its tree differs from the release tip only by the version bump. The two CI reds here (test_kas_policy_hidden_readiness, the memory-UI E2E) also fail on the release tip's own runs, and #39417 fixed the first. |
Problem / Motivation
Goal: 0.13 users get two fixes Bolin flagged as P0 when #39387 replaced #39342: the Windows desktop app starts its gateway when netstat cannot finish, and a slow Feishu SDK import no longer restarts the gateway.
Both are merged on main but in neither #39387 nor the release branch. Bolin named them in his closing comment on #39342 as P0 fixes that "cherry-pick cleanly onto #39387's base and can follow separately".
Why it matters
Not a goal
What changed (motivation → approach → change)
Two clean
git cherry-pick -xof the main commits, in main's order, no conflicts and no prerequisites:b5d70c535f7): importslark-oapiin a worker thread before the Feishu client starts.061fa0378e8): the Windows port check treats a netstat that cannot finish as unknown and starts the gateway when the port binds.Backwards compatibility
Compatible: both are code already on main; nothing that works on 0.13 stops working.
Removes nothing: no setting, route or stored value changes.
Tests
The tests each fix added come with it. On this branch:
test/test_feishu*.py: 286 passed, 1 skipped. flake8 and mypy onsrc/kiro_crew/feishupass.gateway-stop,windows-portandwindows-recovery-port-probetests (node test runner): 105 passed, 1 skipped.Proof: not provable -- other: a backport of fixes whose proof ran on their own main PRs (#37927, #38025)
Manual verification
N/A — each fix was verified on its own main PR; this PR only carries them.
Related Issues
Flagged by Bolin on #39342 when #39387 replaced it.
Sibling sweep
Siblings: none -- a backport; each fix's sweep is recorded on its own main PR
Pattern harvest
Not generalizable: a backport; the patterns are recorded on #37927 and #38025
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)