Skip to content

test: 0.13 backport, give the policy-readiness test handle its runtime (#38961, #38941) - #39416

Closed
CrysisDeu wants to merge 2 commits into
release/0.13.0from
crew/build-watcher/backport-0.13-policy-readiness-test
Closed

CrysisDeu wants to merge 2 commits into
release/0.13.0from
crew/build-watcher/backport-0.13-policy-readiness-test

Conversation

@CrysisDeu

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Make the release/0.13.0 Release run's Test Release Candidate SHA (2) job pass so the 0.13.0 release can ship.

Release run 44465089078 (tag v0.13.0-rc.6, sha aa0c14c) fails two tests in test/test_kas_policy_hidden_readiness.py:

  • test_a_server_the_policy_empties_does_not_hold_the_start
  • TestTheLaunchedAppSpec::test_crew_s_default_servers_on_an_unrecognised_app_agent_still_start

Both: AttributeError: 'AcpSessionHandle' object has no attribute '_runtime'.

Why it matters

The release-candidate test job is red, so rc.6 cannot be promoted and the 0.13.0 stable cannot be cut from it.

Not a goal

What changed (motivation → approach → change)

Test-only; one file, +13 / -6.

Backwards compatibility

Compatible: test-only change, no product code touched.

Removes nothing: only a test fixture gains fields; no path, key, record or function is taken away.

Tests

test/test_kas_policy_hidden_readiness.py fixture now gives the bare handle the runtime the start barrier reads, as on main.

Proof: not provable -- test-only change

Manual verification

N/A — the fix is the failing CI test itself; the release-candidate test job on this PR proves it.

Related Issues

Release run: https://github.com/kirodotdev/KiroCrew/actions/runs/44465089078
Backports #38961 and #38941. Follow-up to #39387.

Sibling sweep

Swept: git grep -n "AcpSessionHandle.new" origin/release/0.13.0 -- test/
Sibling: test/test_kas_policy_hidden_readiness.py -- changed here
Siblings: none -- 23 test files build a bare handle, but only this file failed in run 44465089078; the other 22 passed there.

Pattern harvest

Not generalizable: on main this class is already stopped by #38996 (one guarded bare_session_handle factory); this PR only catches the release branch up on the two fixes that predate it.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license.

bolichen97 and others added 2 commits November 19, 2026 06:03
…ness handle (#38961)

The start barrier awaits settle_kas_model_select after its drain. The
bare AcpSessionHandle these tests build has no runtime, so the call
raised AttributeError and both _wait_managed_mcp cases failed on main.
Stub it as the other _wait_managed_mcp tests do.

(cherry picked from commit 3a18079)
…l-select settle reads (#38941)

(cherry picked from commit 5ca1430)
@CrysisDeu
CrysisDeu requested review from a team and KiroCrewCaptain as code owners November 19, 2026 06:03
@CrysisDeu
CrysisDeu requested review from cruisercohen and removed request for a team November 19, 2026 06:03
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision bbb0369c8c3d66345906994daed93fa960f34d1a ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision bbb0369c8c3d66345906994daed93fa960f34d1a touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of bbb0369c8c3d66345906994daed93fa960f34d1a — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

This change only touches a test fixture. It cherry-picks the two fixes from main that the earlier backport left out, so there is no design question to settle.

Notes

  • The two backported fixes overlap: _runtime is set on the handle, and settle_kas_model_select is also replaced with a mock, so the comment "The bare handle has no runtime" is no longer true. Keeping the cherry-picks unchanged matches main, which is fine.

[DESIGN-REVIEWED] bbb0369

Description read

[DESCRIPTION-READ] 9373f7663a9e1cf9c72a54a34dd5be4885881fc1a7634c64202a9b34224e17be

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ⚠️ review incomplete

GPT 6.1 did not produce a complete verdict for bbb0369c8c3d66345906994daed93fa960f34d1a; inspect the workflow logs and re-run it.

This comment is updated in place on each push.

See the GPT 6.1 Review job logs; this commit has no completed GPT verdict.

False positive or not applicable? A repository writer can comment:
/ai-review override gpt bbb0369c8c3d66345906994daed93fa960f34d1a false-positive: <reason, 20 to 500 characters>

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

Superseded by #39417 (merged 06:05Z), which backports #38941 and gives the handle its _runtime. The only delta left here is the #38961 AsyncMock stub, which main itself dropped in #38996, so it is not needed. rc.7 is already tagged; Release run 44469692718 tests it.

@CrysisDeu CrysisDeu closed this Nov 19, 2026
@CrysisDeu
CrysisDeu deleted the crew/build-watcher/backport-0.13-policy-readiness-test branch November 19, 2026 06:19
@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants