Repository navigation
Conversation
…ness handle (#38961) The start barrier awaits settle_kas_model_select after its drain. The bare AcpSessionHandle these tests build has no runtime, so the call raised AttributeError and both _wait_managed_mcp cases failed on main. Stub it as the other _wait_managed_mcp tests do. (cherry picked from commit 3a18079)
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS This change only touches a test fixture. It cherry-picks the two fixes from main that the earlier backport left out, so there is no design question to settle. Notes
[DESIGN-REVIEWED] bbb0369 Description read[DESCRIPTION-READ] 9373f7663a9e1cf9c72a54a34dd5be4885881fc1a7634c64202a9b34224e17be That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review —
|
Problem / Motivation
Goal: Make the release/0.13.0 Release run's
Test Release Candidate SHA (2)job pass so the 0.13.0 release can ship.Release run 44465089078 (tag v0.13.0-rc.6, sha aa0c14c) fails two tests in
test/test_kas_policy_hidden_readiness.py:test_a_server_the_policy_empties_does_not_hold_the_startTestTheLaunchedAppSpec::test_crew_s_default_servers_on_an_unrecognised_app_agent_still_startBoth:
AttributeError: 'AcpSessionHandle' object has no attribute '_runtime'.Why it matters
The release-candidate test job is red, so rc.6 cannot be promoted and the 0.13.0 stable cannot be cut from it.
Not a goal
bare_session_handlefactory and its guard across ~25 test files). It is a wide refactor andtest/session_handle_helpers.pydoes not exist on release/0.13.0.What changed (motivation → approach → change)
AttributeError: ... '_runtime'._wait_managed_mcpawaitshandle.settle_kas_model_select()(src/kiro_crew/acp/runtime_session_load.py:1040), which readsself._runtime.acp_backend(src/kiro_crew/acp/session_handle_model_selection.py). The test builds a bareAcpSessionHandle.__new__with no_runtime. On main this was fixed by test(kas): stub the late model-select read on the policy-hidden readiness handle #38961 and test(kas): give the policy-readiness test handle the runtime the model-select settle reads #38941 (both 11/18), which fix: 0.13 backport, 55 KAS, security, Bot, MCP and browser fixes from main #39387 did not include.git cherry-pick -x):settle_kas_model_selectwithAsyncMockon the bare handle.runtimeinto_handle()/_app_handle()and set_runtimeandkas_bundle_engine_versionon the handle.Test-only; one file, +13 / -6.
Backwards compatibility
Compatible: test-only change, no product code touched.
Removes nothing: only a test fixture gains fields; no path, key, record or function is taken away.
Tests
test/test_kas_policy_hidden_readiness.pyfixture now gives the bare handle the runtime the start barrier reads, as on main.Proof: not provable -- test-only change
Manual verification
N/A — the fix is the failing CI test itself; the release-candidate test job on this PR proves it.
Related Issues
Release run: https://github.com/kirodotdev/KiroCrew/actions/runs/44465089078
Backports #38961 and #38941. Follow-up to #39387.
Sibling sweep
Swept: git grep -n "AcpSessionHandle.new" origin/release/0.13.0 -- test/
Sibling: test/test_kas_policy_hidden_readiness.py -- changed here
Siblings: none -- 23 test files build a bare handle, but only this file failed in run 44465089078; the other 22 passed there.
Pattern harvest
Not generalizable: on main this class is already stopped by #38996 (one guarded
bare_session_handlefactory); this PR only catches the release branch up on the two fixes that predate it.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license.