Repository navigation
fix: ask before an editor link opens a file on another machine - #39472
Conversation
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks: this is one fix to the one key that remembers the choice. The defect has an issue (#38570) and a test that fails on base. What this change shipsInventory (3 items) — 3 justifiedIntent: in the desktop app, a "Don't ask again" choice made for local files should stop covering editor links that open a file on another machine's share. FIX.
[FIRST-PRINCIPLES-REVIEWED] 74ebb4d Description read[DESCRIPTION-READ] 85a06c5899bdc461c1b468f70879bee4a494e19731da9cb06b8c571980d37993 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks: the diff changes no dialog, label or control. It only changes when the existing editor-link dialog appears, so no screenshot is needed and the missing blind read leaves no gap. Notes
[UX-REVIEWED] 74ebb4d Description read[DESCRIPTION-READ] 130a18437125d95dd1709beb7f41af18144969ae39c512fe0692452724c9c2fe That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the fix changes the one place the choice is remembered, it can only add prompts, and the choice is never written to disk. [DESIGN-REVIEWED] 74ebb4d Description read[DESCRIPTION-READ] 069b6c80931fee2e69389e114bca60b25f80a9613b28a90fbb81d378be339cc7 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Review detailsNo findings. Notes:
[OPUS-REVIEWED] 74ebb4d Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
Rebased: main moved in website/electron/window-lifecycle.js, other website/electron files and docs/system-specs/modules/ files beside this PR's (none of this PR's own files) since this head's CI ran (433d99b -> dc531c1); CI re-running. The red [operator: bolichen97] |
d85a385 to
74ebb4d
Compare
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
I reviewed head 74ebb4d. A share link (a local editor link whose decoded path starts with two slashes and has no drive letter) now gets its own remembered key, so a "Don't ask again" choice made for local files or an SSH host no longer opens it without a prompt. I ran the desktop-app test file on this head and all 49 tests pass. The new test fails when the base version of the module is swapped in, so it really pins the fix. I also checked the encoded and repeated-slash forms of share links. All of them prompt, and the share key cannot collide with a local or host key. The change can only add prompts, never remove one, so nothing blocks.
Code change approver recommendation: A person should decideWhy: the decider estimates a 7% chance that this change introduces a defect, within the 12% limit for approving on its own, but it is held at tier 2: reviewer-finding: Design Review. I'd approve this. The fix does what the PR says, it can only add prompts, and it comes with a test that would fail without it. What changed. The PR adds a capture group for the drive letter to Remembered choices. The set of remembered choices has one writer and one reader, both in
Edge cases checked.
Tier: 2, held for a person: reviewer-finding: Design Review. An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
Problem / Motivation
Goal: In the desktop app, a "Don't ask again" choice made for an editor link to a file on this computer no longer opens an editor link to a file on another machine's network share without asking.
After someone ticks "Don't ask again" on an ordinary editor link, a later editor link that names a file on another machine's share opens with no prompt. The dialog promises "this machine", and the remembered choice reaches a different one.
Why it matters
A person who chose not to be asked again about their own files should still see, and agree to, every link that opens a file on someone else's machine. Today one tick on a local link silently covers those links for the rest of the session.
Not a goal
kiro://editor links proposed in fix(dashboard): open remote-editor links as a file or a folder, and offer Kiro #38292.What changed (motivation → approach → change)
The desktop app remembers "Don't ask again" per editor and per machine, but it filed a link to another machine's share under the same entry as local files. A share link is now remembered on its own, for that one path. A choice made for local files, an SSH host or a different share therefore never opens it without asking, and ticking the box on a share link skips the prompt only for that same file. Local files, drive-letter paths and SSH hosts keep their current behaviour. The change is in the desktop app (
website/electron), and the computer-use spec states the share rule next to the existing one.Backwards compatibility
Compatible: every editor link that opened before still opens. A link whose path starts with two slashes, on any platform, may ask once more per path where it used to open silently.
Removes nothing: no link is refused, and no stored setting changes (the choice lives in memory until the app quits).
Tests
One desktop-app test drives the app's link handling with a dialog that answers "Open" and "Don't ask again": after a local-file choice, a drive-letter path stays covered, a share link asks, the same share path then opens without asking, and a second path on that share asks again. It fails on the parent commit, where the share links open with no prompt, and passes with the fix. The existing local, drive-letter and SSH-host cases are unchanged.
Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
Reproduced with the reporter's recorder harness (no link is really opened and no share is contacted): on the parent commit the share link opens with no prompt after a remembered local choice; with the fix it prompts first.
Run three times each on a clean Linux machine (Ubuntu 24.04.5 LTS, Node v24.22.3), with the same result every run:
Real-machine verification
Machine: EC2 m7i.2xlarge, Ubuntu 24.04.5 LTS x86_64, 8 vCPU / 32 GiB, Node v24.22.3
Before (main dc531c1):
node harness.cjs website/electron/external-scheme.js-> after a remembered local choice the share link opens with no prompt (1 prompt, both links opened), 3 of 3 runs; the new test failsAfter (head 74ebb4d):
node harness.cjs website/electron/external-scheme.js-> the share link asks before it opens (2 prompts, both links opened), 3 of 3 runs; local and SSH-host links unchanged (2 prompts, 4 links opened); the desktop-app test file passes 49/49 in 5 repeats and 3 random ordersCleanup: disposable instance with no inbound rules and no key pair, terminated by its pool's idle reaper after the run; the harness opens nothing (a recorder stands in for the OS opener)
Related Issues
Closes #38570
Sibling sweep
Siblings: none -- the desktop app remembers this choice in one place only
Pattern harvest
Not generalizable: the desktop app has one remembered consent, keyed in one place, and this fix is to that key
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...); PR Hygiene does not count commits