Skip to content

feat(settings): link Settings → Slack to the Slack card in Connections - #39631

Merged
KiroCrewCaptain merged 1 commit into
mainfrom
feat/slack-panel-connections-link
Nov 20, 2026
Merged

KiroCrewCaptain merged 1 commit into
mainfrom
feat/slack-panel-connections-link

Conversation

@kyleseaman

@kyleseaman kyleseaman commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Someone setting up the Slack bot under Settings → Messaging Channels → Slack can get to the Slack card under Settings → Connections in one click, so they can also let their agents use Slack's MCP tools.

The Slack bot (Settings → Messaging Channels → Slack) and Slack's MCP server (the Slack card under Settings → Connections, "Let agents use Slack through its official MCP server") are set up in two places. The Slack page never mentions the Connections card, so a person who sets up the bot has no path to the setting that lets their agents search and read Slack.

Why it matters

Without a pointer, people who finish the bot setup assume that is all Slack can do, and never find the Slack MCP connection.

Not a goal

What changed (motivation → approach → change)

In pages/settings/SlackPanel.tsx, under the Slack page's one-line description there is now a second muted line: "Your agents can also search and read Slack as you, through Slack's MCP server." followed by a text link, "Set it up on the Slack card in Connections", with the external-link icon the page already uses for its setup guide.

The link opens /settings/connections?provider=slack in a new tab (target="_blank", rel="noopener noreferrer"), so unsaved edits stay put: the Slack form is never unmounted, and it needs no unsaved-edit tracking. provider is the Connections page's own card param (connectionCardHref, the one the MCP Servers page uses for managed rows): it clears the gallery search, rings the Slack card, opens its OAuth app part and scrolls to it. The new tab is signed in because the dashboard session is the gateway's httponly mc_token_<port> cookie on path /, and the desktop app opens same-origin window.open targets in-app (createWindowOpenHandler in electron/external-scheme.js).

The line is hidden while the Connections gallery is turned off (connections_ui: false, read through useConnectionsUiEnabled), since there is no card to land on then.

The two new strings are in all 12 catalogs under i18n/locales/ (website/src/i18n) in each style guide's informal register, and en-XA is regenerated.

Backwards compatibility

Compatible: one added line of text with a link; no setting, route or API changes.

Removes nothing: the diff only adds a line and two catalog keys.

Tests

website/src/test/SlackPanelConnectionsLink.test.tsx:

  • opens the Slack card on Settings → Connections in a new tab: the link's text, href /settings/connections?provider=slack, target="_blank" and rel="noopener noreferrer".
  • is absent while the Connections gallery is off: once the config read has landed with connections_ui: false, there is no link.

Fail-first: both fail on the base panel; dropping target fails the first. Determinism: 5 runs with --sequence.shuffle and seeds 7919 to 39595, all 2/2 passing; the test stubs every API seam and the schema fetch, with no timers or wall-clock reads.

Proof: not provable -- frontend test (prove.py runs Python only)

Also ran src/test/SettingsSlackPanelCoverage.test.tsx, every src/i18n test with I18N_BASE_REF set as CI does, tsc -p tsconfig.app.json, npm run i18n:check, npm run lint:i18n and eslint on the changed files. gen:ui and gen:settings produce no diff.

Manual verification

Built SPA with a stubbed /api, headless Playwright, light and dark: opened /settings/channels/slack, typed into the slash-command field without saving, and clicked the link. A new tab opened on /settings/connections?provider=slack, and the original tab still held the typed value. The same URL in a fresh tab of that browser session sent the session cookie on its /api/connections/* requests and rendered #connection-slack ringed with its OAuth app part open.

Real-machine verification

N/A -- the diff is one dashboard link and its strings; it runs no backend, CLI or host code.

Screenshots / video

Settings → Messaging Channels → Slack, the new line under the description:

Slack settings, light

Slack settings, dark

The new tab: the Slack card on Settings → Connections, ringed with its OAuth app part open

Connections Slack card, light

Connections Slack card, dark

Related Issues

N/A -- no tracking issue.

Checklist

  • A Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...); PR Hygiene does not count commits
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@kyleseaman
kyleseaman requested review from a team and KiroCrewCaptain as code owners November 19, 2026 21:59
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 19, 2026
@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 6766dde43580c5531441b70acedfca6ee887739d — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks: the blind reader understood the new link correctly and said they would click it. Their doubts are about labelling, covered in the notes.

Notes

  • The blind reader saw Slack as "Connected" on this page, then saw the Slack card it lands on say "Not connected", and read that as the app contradicting itself. Changing slack_tools_hint to say this is a separate sign-in (e.g. "Your agents can also search and read Slack as you. That's a separate sign-in from this bot.") would explain the mismatch before the click.
  • The link text names "Connections", but the landing tab scrolls straight to the card, and the reader "can't find anything with that name on any screen" (shot-03). Shortening slack_tools_link to "Connect Slack for your agents" would name what the click gets you instead of a place the user can't see.

[UX-REVIEWED] 6766dde

Description read

[DESCRIPTION-READ] d3ccc6dc03ff0cbecaf53690774c9729d6870528d9f589215603956776a7b2a2

That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 6766dde43580c5531441b70acedfca6ee887739d — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the change only adds a link. It reuses the existing connectionCardHref and useConnectionsUiEnabled helpers, and the description includes rendered screenshots.

[DESIGN-REVIEWED] 6766dde

Description read

[DESCRIPTION-READ] ed43534920e13141e03a0352aaba84c8129be0e55bda837b374ca01576ddd4e1

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 6766dde43580c5531441b70acedfca6ee887739d and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 6766dde

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 6766dde43580c5531441b70acedfca6ee887739d false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 6766dde43580c5531441b70acedfca6ee887739d — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. The new link reuses connectionCardHref and the existing gallery flag. The only weak spot is that no one is shown to have missed the Slack MCP card.

Notes

  • Item 1 — inherited: the harm rests only on "people who finish the bot setup assume that is all Slack can do, and never find the Slack MCP connection", and the PR cites no issue for it ("N/A -- no tracking issue"). It is reversible, so this is a note only.

What this change ships

Inventory (4 items) — 3 justified

Intent: help someone setting up the Slack bot find the Slack card in Connections, which turns on Slack's MCP tools for their agents. ADDITION.

  1. The Slack settings page shows a new muted line saying agents can also search and read Slack through its MCP server — inherited: no reported user failed to find it
  2. The line ends with a link that opens the Slack card in Connections in a new tab, ringed and expanded, through the existing connectionCardHref (1 prior consumer, McpPage.tsx:70) — justified
  3. The line is hidden while the Connections gallery is turned off (connections_ui: false) — justified
  4. Two new strings in all 12 catalogs, plus a regenerated en-XA — justified

[FIRST-PRINCIPLES-REVIEWED] 6766dde

Description read

[DESCRIPTION-READ] 79dd23292f20f339995f389d05c4319a7248d9e9d1d04d9a846cefcc8723e3a8

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 6766dde43580c5531441b70acedfca6ee887739d — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 6766dde

Verdict parsed from the review's SHA-scoped output markers for commit 6766dde43580c5531441b70acedfca6ee887739d.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 6766dde43580c5531441b70acedfca6ee887739d false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 19, 2026
@kyleseaman
kyleseaman force-pushed the feat/slack-panel-connections-link branch from 9b45582 to c22b278 Compare November 20, 2026 00:13
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 20, 2026
@kyleseaman
kyleseaman force-pushed the feat/slack-panel-connections-link branch from c22b278 to 6766dde Compare November 20, 2026 03:13
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 20, 2026
@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: A person should decide

Why: the decider estimates a 6% chance that this change introduces a defect, within the 12% limit for approving on its own, but it is held at tier 2: reviewer-finding: Design Review.

A small UI-only change: a hint line and link on the Slack settings panel that opens /settings/connections?provider=slack in a new tab. I checked it against the code:

  • The URL comes from the existing connectionCardHref, the same helper the MCP page uses.
  • The line is hidden by the existing useConnectionsUiEnabled hook. That hook treats an unread or failed config read as off, so the link never points at a gallery that isn't there.
  • The Slack registry entry has launch_gate_passed: false, but it is a pre-registered provider with vendor_approval_pending: false. Under CONNECTION_PROVIDERS that still makes its card visible, so the link lands on a real card.
  • ExternalLink was already imported.
  • Opening in a new tab leaves the form's unsaved state alone. No other state is written.
  • Both strings are added to every catalog.
  • Two new tests cover the href, target and rel on the link, and that the link is absent once connections_ui: false has been read; both would fail on the base panel.
  • CI is green, including the i18n and frontend gates.

There are no trust, limit or lifecycle concerns.

Tier: 2, held for a person: reviewer-finding: Design Review.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit 6766dde435 · 110 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@KiroCrewCaptain
KiroCrewCaptain enabled auto-merge (squash) November 20, 2026 04:32

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. On this head the review checked these points. The link builds its URL with the existing connectionCardHref('slack') helper, so it points to /settings/connections?provider=slack, and the Connections page reads that param. The Slack card is listed in the gallery because it is a preregistered provider. The link shows only when useConnectionsUiEnabled() is true, which is the same gate the gallery uses, and a config that has not loaded or failed to load counts as off. The link sets rel="noopener noreferrer" and has a fixed href. Both new tests fail without the change, and they use no sleeps or clocks.

Well done: the absence test waits until the config cache holds connections_ui:false before it checks that the link is gone. An unread config cannot make that check pass.

Optional:

  • The hint "Your agents can also search and read Slack as you" does not say this is a separate sign-in. The bot page can show "Connected" while the card shows "Not connected". A wording like "That's a separate sign-in, made on the Slack card in Connections" would make this clear.
  • #39005 also edits SlackPanel.tsx and the locale catalogs near this change, so whichever merges second may need a small rebase.

@KiroCrewCaptain
KiroCrewCaptain merged commit 727ed48 into main Nov 20, 2026
99 of 101 checks passed
@KiroCrewCaptain
KiroCrewCaptain deleted the feat/slack-panel-connections-link branch November 20, 2026 04:32
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants