Repository navigation
feat(settings): link Settings → Slack to the Slack card in Connections - #39631
Conversation
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks: the blind reader understood the new link correctly and said they would click it. Their doubts are about labelling, covered in the notes. Notes
[UX-REVIEWED] 6766dde Description read[DESCRIPTION-READ] d3ccc6dc03ff0cbecaf53690774c9729d6870528d9f589215603956776a7b2a2 That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the change only adds a link. It reuses the existing [DESIGN-REVIEWED] 6766dde Description read[DESCRIPTION-READ] ed43534920e13141e03a0352aaba84c8129be0e55bda837b374ca01576ddd4e1 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. The new link reuses Notes
What this change shipsInventory (4 items) — 3 justifiedIntent: help someone setting up the Slack bot find the Slack card in Connections, which turns on Slack's MCP tools for their agents. ADDITION.
[FIRST-PRINCIPLES-REVIEWED] 6766dde Description read[DESCRIPTION-READ] 79dd23292f20f339995f389d05c4319a7248d9e9d1d04d9a846cefcc8723e3a8 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
9b45582 to
c22b278
Compare
c22b278 to
6766dde
Compare
Code change approver recommendation: A person should decideWhy: the decider estimates a 6% chance that this change introduces a defect, within the 12% limit for approving on its own, but it is held at tier 2: reviewer-finding: Design Review. A small UI-only change: a hint line and link on the Slack settings panel that opens
There are no trust, limit or lifecycle concerns. Tier: 2, held for a person: reviewer-finding: Design Review. An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Approving. On this head the review checked these points. The link builds its URL with the existing connectionCardHref('slack') helper, so it points to /settings/connections?provider=slack, and the Connections page reads that param. The Slack card is listed in the gallery because it is a preregistered provider. The link shows only when useConnectionsUiEnabled() is true, which is the same gate the gallery uses, and a config that has not loaded or failed to load counts as off. The link sets rel="noopener noreferrer" and has a fixed href. Both new tests fail without the change, and they use no sleeps or clocks.
Well done: the absence test waits until the config cache holds connections_ui:false before it checks that the link is gone. An unread config cannot make that check pass.
Optional:
- The hint "Your agents can also search and read Slack as you" does not say this is a separate sign-in. The bot page can show "Connected" while the card shows "Not connected". A wording like "That's a separate sign-in, made on the Slack card in Connections" would make this clear.
- #39005 also edits SlackPanel.tsx and the locale catalogs near this change, so whichever merges second may need a small rebase.
Problem / Motivation
Goal: Someone setting up the Slack bot under Settings → Messaging Channels → Slack can get to the Slack card under Settings → Connections in one click, so they can also let their agents use Slack's MCP tools.
The Slack bot (Settings → Messaging Channels → Slack) and Slack's MCP server (the Slack card under Settings → Connections, "Let agents use Slack through its official MCP server") are set up in two places. The Slack page never mentions the Connections card, so a person who sets up the bot has no path to the setting that lets their agents search and read Slack.
Why it matters
Without a pointer, people who finish the bot setup assume that is all Slack can do, and never find the Slack MCP connection.
Not a goal
SlackCodePanel.tsx, PR feat(slack): opt-in Slack MCP switch in the generated app manifest #38169).What changed (motivation → approach → change)
In
pages/settings/SlackPanel.tsx, under the Slack page's one-line description there is now a second muted line: "Your agents can also search and read Slack as you, through Slack's MCP server." followed by a text link, "Set it up on the Slack card in Connections", with the external-link icon the page already uses for its setup guide.The link opens
/settings/connections?provider=slackin a new tab (target="_blank",rel="noopener noreferrer"), so unsaved edits stay put: the Slack form is never unmounted, and it needs no unsaved-edit tracking.provideris the Connections page's own card param (connectionCardHref, the one the MCP Servers page uses for managed rows): it clears the gallery search, rings the Slack card, opens its OAuth app part and scrolls to it. The new tab is signed in because the dashboard session is the gateway'shttponlymc_token_<port>cookie on path/, and the desktop app opens same-originwindow.opentargets in-app (createWindowOpenHandlerinelectron/external-scheme.js).The line is hidden while the Connections gallery is turned off (
connections_ui: false, read throughuseConnectionsUiEnabled), since there is no card to land on then.The two new strings are in all 12 catalogs under
i18n/locales/(website/src/i18n) in each style guide's informal register, anden-XAis regenerated.Backwards compatibility
Compatible: one added line of text with a link; no setting, route or API changes.
Removes nothing: the diff only adds a line and two catalog keys.
Tests
website/src/test/SlackPanelConnectionsLink.test.tsx:opens the Slack card on Settings → Connections in a new tab: the link's text,href/settings/connections?provider=slack,target="_blank"andrel="noopener noreferrer".is absent while the Connections gallery is off: once the config read has landed withconnections_ui: false, there is no link.Fail-first: both fail on the base panel; dropping
targetfails the first. Determinism: 5 runs with--sequence.shuffleand seeds 7919 to 39595, all 2/2 passing; the test stubs every API seam and the schemafetch, with no timers or wall-clock reads.Proof: not provable -- frontend test (prove.py runs Python only)
Also ran
src/test/SettingsSlackPanelCoverage.test.tsx, everysrc/i18ntest withI18N_BASE_REFset as CI does,tsc -p tsconfig.app.json,npm run i18n:check,npm run lint:i18nand eslint on the changed files.gen:uiandgen:settingsproduce no diff.Manual verification
Built SPA with a stubbed
/api, headless Playwright, light and dark: opened/settings/channels/slack, typed into the slash-command field without saving, and clicked the link. A new tab opened on/settings/connections?provider=slack, and the original tab still held the typed value. The same URL in a fresh tab of that browser session sent the session cookie on its/api/connections/*requests and rendered#connection-slackringed with its OAuth app part open.Real-machine verification
N/A -- the diff is one dashboard link and its strings; it runs no backend, CLI or host code.
Screenshots / video
Settings → Messaging Channels → Slack, the new line under the description:
The new tab: the Slack card on Settings → Connections, ringed with its OAuth app part open
Related Issues
N/A -- no tracking issue.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...); PR Hygiene does not count commits