Repository navigation
fix(sidebar): draw no Bot row while none of its sessions is in the Sessions list (0.13 pick of #39577) - #39730
Conversation
UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)UX-level review of UX-Verdict: PASS cannot evaluate: missing a screenshot of the Sessions list on this branch. No image was supplied, so the blind read was not performed, and nobody has looked at the 0.13 sidebar with the Bot rows gone. Evidence gaps
Notes
[UX-REVIEWED] 83175aa Description read[DESCRIPTION-READ] 8a4b0a02cf1e68c7ad74aa87f4f79ad5da51a03b9ede26bee7c05448eab69d0a That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. This is a cherry-pick of #39577, which fixes a bug users reported. The tests added here fail on 0.13's code, and each item counts as part of the fix. What this change shipsInventory (5 items) — 5 justifiedIntent: on 0.13, Bot owners stop seeing empty
[FIRST-PRINCIPLES-REVIEWED] 83175aa Description read[DESCRIPTION-READ] bdad4370326d5cb1a1a7cadf23f87264e14acb6e193ff78c5c19e581e297df9e That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)Design-level review of Design-Verdict: PASS cannot evaluate: missing a screenshot of the 0.13 Sessions list with a hidden Bot home. The diff changes which rows the sidebar draws, and the only evidence offered is #39577's screenshots from main, which is a different codebase. BlockersNo rendered evidence of this revision's sidebar change Notes
[DESIGN-REVIEWED] 83175aa Description read[DESCRIPTION-READ] 22adc8e156b75fc7a2eda9e5ba7dab9c0d61e2ed8532fad19ce16a42476a39a3 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Problem / Motivation
Goal: On 0.13, a Bot whose sessions are not shown in the Sessions list draws no empty row there.
A user reported on 0.13.0 that after the upgrade the Sessions list shows one row per Bot, each with a
0count and nothing under it, so they thought their Bot sessions were gone. #39577 fixed it on main.Why it matters
Every Bot owner on 0.13 sees these rows. An empty
0row under a Bot's name reads as lost data. Bots leaving the Sessions list is new in 0.13 (#37713).Not a goal
What changed (motivation → approach → change)
Every commit in this PR is a cherry-pick from main (
git cherry-pick -x); its message carries the main commit it came from.355ba1efc6abPrerequisites: none. Conflicts came from code on main that 0.13 does not have, and each was resolved by keeping 0.13's code and adding only #39577's lines:
website/src/utils/mateFolders.ts: 0.13 has nomateHomeOforisEmptyBotSubfolder; onlyfoldersForSessionListis added, and its comment names 0.13'sisMateManaged.website/src/pages/chat-sidebar/reveal.tsandwebsite/src/pages/ChatSidebar.tsx: 0.13'suseSidebarRevealhas nohideEmptyFoldersand the scope has nofoldersHoldingSessions; onlydrawnFolders/allFoldersare added.website/src/test/ChatSidebar.mateFolderWrites.test.tsx: the Delete-empty-sub-folder cases from main are left out (0.13 lacks that feature);renderSidebargains theslotsargument the new cases need.The author is reset to the public identity of the same person (the main squash commit used the GitHub noreply address, which the repo's commit guard refuses).
Backwards compatibility
Compatible: no API, config or stored data changes; only which folder rows the Sessions list draws.
Reader: website/src/pages/chat-sidebar/reveal.ts:useSidebarReveal -- crew page -- a session reveal reads the full folder list; a folder reveal reads the drawn list, so a hidden Bot home changes no filter (
a folder reveal of the hidden home keeps the search text)Reader: website/src/pages/chat-sidebar/HistoryPane.tsx:renderHistoryPane -- crew page -- groups search hits by the full folder list (
groups a search hit filed inside a hidden Bot home under its folder)Reader: website/src/pages/chat-sidebar/FolderCleanupPanel.tsx:FolderCleanupPanel -- crew page -- gets the full folder list (
the empty-folder cleanup still names a folder inside the hidden home)Tests
On this branch:
npx vitest run src/test/ChatSidebar.mateFolderWrites.test.tsx src/test/ChatSidebarCoverage.test.tsx66 passed; with 0.13'sChatSidebar.tsxput back, 6 of them fail.npx vitest run ChatSidebar FolderCleanup HistoryPane reveal mateFolder: 188 files, 2123 tests passed.tsc -p tsconfig.app.jsonand eslint on the changed files: clean.Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
Component capture of this branch's
ChatSidebar(see Screenshots): Bot rows drawn 3 onrelease/0.13.0, 0 with this pick, in both themes.Real-machine verification
N/A -- a dashboard list rendering change, covered by the component tests above.
Screenshots / video
Component render, not the live page. Mocked data. The real
ChatSidebaron this branch, with three Bot homes whose sessions belong to live Bot threads; the harness counted Bot rows: 3 onrelease/0.13.0, 0 with this pick.Related Issues
Part of #39575
Sibling sweep
Siblings: none -- this pick carries one commit whose sweep is in #39577.
Pattern harvest
Not generalizable: a release pick of a one-off list fix; see #39577.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...); PR Hygiene does not count commits