Skip to content

fix(sidebar): draw no Bot row while none of its sessions is in the Sessions list (0.13 pick of #39577) - #39730

Merged
buluoray merged 1 commit into
release/0.13.0from
crew/slack/pick-39577-0.13
Nov 20, 2026
Merged

buluoray merged 1 commit into
release/0.13.0from
crew/slack/pick-39577-0.13

Conversation

@buluoray

@buluoray buluoray commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: On 0.13, a Bot whose sessions are not shown in the Sessions list draws no empty row there.

A user reported on 0.13.0 that after the upgrade the Sessions list shows one row per Bot, each with a 0 count and nothing under it, so they thought their Bot sessions were gone. #39577 fixed it on main.

Why it matters

Every Bot owner on 0.13 sees these rows. An empty 0 row under a Bot's name reads as lost data. Bots leaving the Sessions list is new in 0.13 (#37713).

Not a goal

What changed (motivation → approach → change)

Every commit in this PR is a cherry-pick from main (git cherry-pick -x); its message carries the main commit it came from.

Pick Main commit Why
#39577 fix(sidebar): draw no Bot row while none of its sessions is in the Sessions list 355ba1efc6ab Slack-reported bug in a 0.13 feature

Prerequisites: none. Conflicts came from code on main that 0.13 does not have, and each was resolved by keeping 0.13's code and adding only #39577's lines:

  • website/src/utils/mateFolders.ts: 0.13 has no mateHomeOf or isEmptyBotSubfolder; only foldersForSessionList is added, and its comment names 0.13's isMateManaged.
  • website/src/pages/chat-sidebar/reveal.ts and website/src/pages/ChatSidebar.tsx: 0.13's useSidebarReveal has no hideEmptyFolders and the scope has no foldersHoldingSessions; only drawnFolders / allFolders are added.
  • website/src/test/ChatSidebar.mateFolderWrites.test.tsx: the Delete-empty-sub-folder cases from main are left out (0.13 lacks that feature); renderSidebar gains the slots argument the new cases need.

The author is reset to the public identity of the same person (the main squash commit used the GitHub noreply address, which the repo's commit guard refuses).

Backwards compatibility

Compatible: no API, config or stored data changes; only which folder rows the Sessions list draws.

Reader: website/src/pages/chat-sidebar/reveal.ts:useSidebarReveal -- crew page -- a session reveal reads the full folder list; a folder reveal reads the drawn list, so a hidden Bot home changes no filter (a folder reveal of the hidden home keeps the search text)
Reader: website/src/pages/chat-sidebar/HistoryPane.tsx:renderHistoryPane -- crew page -- groups search hits by the full folder list (groups a search hit filed inside a hidden Bot home under its folder)
Reader: website/src/pages/chat-sidebar/FolderCleanupPanel.tsx:FolderCleanupPanel -- crew page -- gets the full folder list (the empty-folder cleanup still names a folder inside the hidden home)

Tests

On this branch: npx vitest run src/test/ChatSidebar.mateFolderWrites.test.tsx src/test/ChatSidebarCoverage.test.tsx 66 passed; with 0.13's ChatSidebar.tsx put back, 6 of them fail. npx vitest run ChatSidebar FolderCleanup HistoryPane reveal mateFolder: 188 files, 2123 tests passed. tsc -p tsconfig.app.json and eslint on the changed files: clean.

Proof: not provable -- frontend test (prove.py runs Python only)

Manual verification

Component capture of this branch's ChatSidebar (see Screenshots): Bot rows drawn 3 on release/0.13.0, 0 with this pick, in both themes.

Real-machine verification

N/A -- a dashboard list rendering change, covered by the component tests above.

Screenshots / video

Component render, not the live page. Mocked data. The real ChatSidebar on this branch, with three Bot homes whose sessions belong to live Bot threads; the harness counted Bot rows: 3 on release/0.13.0, 0 with this pick.

Dark Light
Before (release/0.13.0) before dark before light
After (this pick) after dark after light

Related Issues

Part of #39575

Sibling sweep

Siblings: none -- this pick carries one commit whose sweep is in #39577.

Pattern harvest

Not generalizable: a release pick of a one-off list fix; see #39577.

Checklist

  • A Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...); PR Hygiene does not count commits
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

…ssions list (#39577)

(cherry picked from commit 355ba1e)

# Conflicts:
#	website/src/pages/ChatSidebar.tsx
#	website/src/pages/chat-sidebar/reveal.ts
#	website/src/test/ChatSidebar.mateFolderWrites.test.tsx
#	website/src/utils/mateFolders.ts
@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 20, 2026 01:47
@buluoray
buluoray requested review from dodgeblaster and removed request for a team November 20, 2026 01:47
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of 83175aaba1db327a3efa9665bc2cf30f0de61aaa — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing a screenshot of the Sessions list on this branch. No image was supplied, so the blind read was not performed, and nobody has looked at the 0.13 sidebar with the Bot rows gone.

Evidence gaps

  • Sessions list with a Bot whose sessions are all on its own page. foldersForSessionList(allFolders, localSlots) removes that Bot's home row from the sidebar. Nothing shows this state. To close the gap, attach a screenshot of the 0.13 sidebar with no empty 0 Bot row.
  • Sessions list with a Bot whose "Show in my Sessions list" switch is on. The PR says that Bot keeps its row. Nothing shows it does. To close the gap, attach a screenshot with that row and its sessions in place.
  • The "Why no screenshot" line points to fix(sidebar): draw no Bot row while none of its sessions is in the Sessions list #39577's screenshots. Those show main's code, and the PR says this branch's code differs ("0.13 has no mateHomeOf or isEmptyBotSubfolder"). They are not evidence for this revision.

Notes

  • In reveal.ts, a request to reveal a hidden Bot home now stops after logging console.debug('reveal-in-sidebar: no folder for id', …). The user who clicked sees nothing happen. Either open the Bot's own page or show a one-line message that this Bot's sessions live on its page.

[UX-REVIEWED] 83175aa

Description read

[DESCRIPTION-READ] 8a4b0a02cf1e68c7ad74aa87f4f79ad5da51a03b9ede26bee7c05448eab69d0a

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 83175aaba1db327a3efa9665bc2cf30f0de61aaa — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. This is a cherry-pick of #39577, which fixes a bug users reported. The tests added here fail on 0.13's code, and each item counts as part of the fix.

What this change ships

Inventory (5 items) — 5 justified

Intent: on 0.13, Bot owners stop seeing empty 0 rows in the Sessions list that look like lost sessions. This is a FIX.

  1. A Bot's home folder and the folders inside it draw no row in the Sessions list while none of their sessions is listed there — justified
  2. Board columns also draw no copy of that hidden home — justified
  3. A row comes back as soon as one listed session sits in the home or any folder below it — justified
  4. Picking a hidden Bot home from the command bar does nothing and keeps the search text — justified
  5. History search grouping and the empty-folder cleanup still name folders inside a hidden home (both read the new allFolders field) — justified

[FIRST-PRINCIPLES-REVIEWED] 83175aa

Description read

[DESCRIPTION-READ] bdad4370326d5cb1a1a7cadf23f87264e14acb6e193ff78c5c19e581e297df9e

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

Design-level review of 83175aaba1db327a3efa9665bc2cf30f0de61aaa — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

cannot evaluate: missing a screenshot of the 0.13 Sessions list with a hidden Bot home. The diff changes which rows the sidebar draws, and the only evidence offered is #39577's screenshots from main, which is a different codebase.

Blockers

No rendered evidence of this revision's sidebar change
Trigger: the description says "the main PR #39577 carries the component-render before/after screenshots; this pick changes the same lines", while the diff changes what ChatSidebar.tsx draws (const folders = useMemo(() => foldersForSessionList(allFolders, localSlots), …)), and the evidence file lists 0 images, 0 recordings and 0 committed media.
Outcome: conflicts were resolved by hand against 0.13 (no hideEmptyFolders, no foldersHoldingSessions, no isEmptyBotSubfolder), so main's screenshots show main's code, not 0.13's → nothing shows how this branch actually renders the list or the board columns → a release pick ships a list change no one has seen.
Fix: attach a before/after render from this branch: a Bot home with only hidden sessions, and one with a listed session.
Clears when: the description carries a github.com/user-attachments image or recording of the 0.13 branch's Sessions list showing the Bot row gone when its sessions are hidden and drawn when one is listed, or such media is committed under temp-screenshots/.

Notes

  • I found no design problem in the pick itself. Splitting the drawn list (folders) from the full list (allFolders) keeps History grouping, cleanup and session reveal on the full list, and the description lists those readers under Backwards compatibility.

[DESIGN-REVIEWED] 83175aa

Description read

[DESCRIPTION-READ] 22adc8e156b75fc7a2eda9e5ba7dab9c0d61e2ed8532fad19ce16a42476a39a3

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 83175aaba1db327a3efa9665bc2cf30f0de61aaa — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 83175aa

Verdict parsed from the review's SHA-scoped output markers for commit 83175aaba1db327a3efa9665bc2cf30f0de61aaa.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 83175aaba1db327a3efa9665bc2cf30f0de61aaa false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 83175aaba1db327a3efa9665bc2cf30f0de61aaa and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 83175aa

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 83175aaba1db327a3efa9665bc2cf30f0de61aaa false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 20, 2026
@buluoray
buluoray merged commit dfc0729 into release/0.13.0 Nov 20, 2026
97 checks passed
@buluoray
buluoray deleted the crew/slack/pick-39577-0.13 branch November 20, 2026 03:02
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant