Repository navigation
fix(i18n): put the patrol time limit after the noun in English - #39786
Conversation
A patrol stopped by its time budget read "Hit its 7 days time limit": the duration now arrives in unit words, which do not work as an attributive modifier. It now reads "Hit its time limit of 7 days". Fixes #36711
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks. The change rewords one English catalog value so the duration is no longer used as an adjective, and there's a screenshot of this revision. [DESIGN-REVIEWED] d87bd49 Description read[DESCRIPTION-READ] 602527784d6360d5cffea7fc5bd9ad257c5cc7d9c135719063bb840730e20238 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing to check. What this change shipsInventory (5 items) — 5 justifiedIntent: make the English stop reason for a patrol that hit its time budget read as grammatical English. FIX (#36711).
[FIRST-PRINCIPLES-REVIEWED] d87bd49 Description read[DESCRIPTION-READ] 82396a3c65374bc1de5673f405a3e5f01aea4a3716bc8a509fe69b385d08687b That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks: the one changed English string, "Hit its time limit of 7 days", shows up in shot-01, and the blind reader understood it correctly. [UX-REVIEWED] d87bd49 Description read[DESCRIPTION-READ] 68d4369185101bc2f970e0a2fe2f1889c962c21b9119120338b967c6d5c9410f That sha256 names everything this verdict read: the PR description, plus the 4 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Code change approver recommendation: ApproveWhy: the decider estimates a 3% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes. The PR rewords one English catalog value (patrol_stopped_runtime) to "Hit its time limit of {{limit}}". It also updates the pseudo-locale, the translator note, the spec line, the capture-harness expectation and the tests to match. A repo search finds no remaining reference to the old phrase. The key is read in only one place (CrewOnItsOwn.tsx:37). The other locales already put the duration after the noun. The new it.each cases would fail on main. All CI checks pass. Tier: 1, every tier gate passed. An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Approved automatically by the code change approver, not by a person. The decider estimates a 3% chance that this change introduces a defect, within the 12% limit for approving on its own, and the change has at most 400 changed lines.
The PR rewords one English catalog value (patrol_stopped_runtime) to "Hit its time limit of {{limit}}". It also updates the pseudo-locale, the translator note, the spec line, the capture-harness expectation and the tests to match. A repo search finds no remaining reference to the old phrase. The key is read in only one place (CrewOnItsOwn.tsx:37). The other locales already put the duration after the noun. The new it.each cases would fail on main. All CI checks pass.
Tier: 1, every tier gate passed.
Criteria: no merge conflict, no owner block, no change request, the default branch, no security-sensitive path, no design document to agree on, the readiness status, the review lanes, the P0 history, the linked issues' tier, the review lessons, no concern label, the file count, a safe change category, not its own change, the decider, the security checklist, the change matches its title, no competing change.
Design documents ride along with the code (docs/system-specs/modules/crew-mode.md): they were not reviewed as a design, and a person who changes what they decide should ask for that review.
Decider v3c (217fe607). To overrule it, request changes or dismiss this review.
Problem / Motivation
Goal: A crewmate patrol stopped by its time budget reads as natural English, "Hit its time limit of 7 days", instead of "Hit its 7 days time limit".
Since #36734 the limit is said in unit words (
7 days,2 days 3 hr), and the English value put that phrase in front of the noun, where English wants7-day. The Schedules tab of a crewmate's profile card showed "Hit its 7 days time limit".Why it matters
Every English user whose patrol hits its runtime budget sees an ungrammatical sentence on the crewmate card.
Not a goal
inDurationformats durations.What changed (motivation → approach → change)
Symptom: "Hit its 7 days time limit". Cause:
pages.membersPage.patrol_stopped_runtimeinen.jsonwasHit its {{limit}} time limit, which used the duration as an attributive modifier. Change: the value is nowHit its time limit of {{limit}}, so the duration names the amount whatever unit or count it has.website/src/i18n/locales/en.json: the reworded value.website/src/i18n/locales/en-XA.json: regenerated withnpm run i18n:pseudo.website/src/i18n/en.context.json: the translator note gives more example durations and says the duration names the amount, not an adjective.docs/system-specs/modules/crew-mode.md: the spec line quoting the phrase.website/scripts/capture-crewmate-panel-ia.mjs: the phrase the capture harness checks.website/src/pages/members/CrewOnItsOwn.test.tsx: the English expectation, plus a case per limit shape.The other 11 catalogs need no edit: none of them puts the duration in front of the noun (see Not a goal).
Backwards compatibility
Compatible: one English display string changes; no key, type or API changes.
Removes nothing: only a catalog value's wording changes.
Tests
CrewOnItsOwn.test.tsx: the stop-reason table now expectsHit its time limit of 7 days; a newit.eachrenders a stopped patrol with limits of 1 day (singular), 2 days 3 hr (plural with two units), 1 hr and 4 hr (hours only), and expectsHit its time limit of <duration>for each. With main'sen.jsonall four fail (Hit its 1 day time limit,Hit its 2 days 3 hr time limit,Hit its 1 hr time limit,Hit its 4 hr time limit).npx vitest run src/pages/members/CrewOnItsOwn.test.tsx src/i18n/: 84 files, 1313 tests pass.npm run i18n:check,npm run lint:i18n,scripts/docs-lint.sh: pass.Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
Ran the capture harness (
KIROCREW_PROFILE_ONLY=1 node scripts/capture-crewmate-panel-ia.mjs) against the built SPA: theledger-stoppedvariant's checkSchedules shows Hit its time limit of 7 dayspasses, screenshot below.Real-machine verification
Machine: own Linux x86_64 dev host, headless Chromium via Playwright
Before (main 9bad2b1):
npx vitest run src/pages/members/CrewOnItsOwn.test.tsx -t 36711with main'sen.json-> 4 failed, renderingHit its 1 day time limit,Hit its 2 days 3 hr time limit,Hit its 1 hr time limit,Hit its 4 hr time limitAfter (head d87bd49): same command -> 4 passed, rendering
Hit its time limit of 1 dayand so onCleanup: own computer; scratch screenshots and logs live in the session scratch directory, reclaimed with the session
Screenshots / video
The paused patrol on the crewmate profile card's Schedules tab, light theme, after the fix:
Related Issues
Fixes #36711. Follows #36734.
Sibling sweep
Swept: git grep -n "Hit its" -- website docs; grep -nE "{{(limit|time|duration|interval|ttl|timeout)}} [a-z]+ (limit|budget|window|timeout|cap)" on en.json and en.manual.json (no hit)
Sibling: website/src/i18n/locales/en.json:9579 -- not affected -- "Hit its check limit" has no interpolated duration
Pattern harvest
Not generalizable: one English value put a unit-word duration before a noun; no other value interpolates a duration that way.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...); PR Hygiene does not count commitsContribution License Agreement
Contributed under the project's Apache-2.0 license.