Skip to content

DO NOT MERGE: #39551 real-machine evidence (head) - #39807

Closed
chenmingwei23 wants to merge 4 commits into
mainfrom
evidence-39551-head
Closed

chenmingwei23 wants to merge 4 commits into
mainfrom
evidence-39551-head

Conversation

@chenmingwei23

Copy link
Copy Markdown
Contributor

Evidence only for #39551; will be closed.

Plan-level tests for both backends: a caller-provided hidden file under a
writable parent gets a guard on the parent and its ancestors, the file stays
write-sealed, and the built-in guard set is unchanged. The namespace
expectations fail on main.
Hidden paths a caller passes to the sandbox now get the same parent-folder
rename guards as the built-in hidden paths on the Linux backend, limited to
the folders this user could rename. The macOS guards are unchanged. Parents
stay writable and the hidden set is unchanged.
Evidence only. Spawns the namespace sandbox with a caller-hidden file and
reports whether renaming its parent folder is refused.
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 20, 2026
@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Sensitive Change Review

Sensitive files changed:

  • src/kiro_crew/sandbox_argv.py

  • src/kiro_crew/sandbox_plan.py

  • No reasoning template for 2aca059 yet.

How to clear this check:

  1. The PR author posts the template below as a PR comment, with
    every field filled (N/A needs a reason). Keep the
    Head commit line: it must name the current head SHA.
  2. The check turns green within a minute, with no push.
  3. A new push resets this check: post it again for the new head.

Only the author's comment counts this way. A reviewer can instead
paste the filled template into an "Approve" review on this head.
Merging still needs a reviewer's approval.

## Sensitive change review
- Head commit: 2aca059558913e726174df0d50d97e038221dbbc
- What rule changed:
- Before -> after (what was allowed/blocked, now):
- Worst case if wrong (breaks commands / leaks secret / locks user out):
- Evidence checked (which sandbox result proves it):
- No regression:
  - Tools still work (which tools/commands were run, result):
  - Backward compatible (old config / old data / old callers still work, how checked):
  - Existing tests (which suites passed on this head):
- How to undo:

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 2aca059558913e726174df0d50d97e038221dbbc touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 2aca059558913e726174df0d50d97e038221dbbc — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing to judge here: this is an evidence-only branch for #39551 that the description says will be closed, so the design decision belongs to #39551.

Notes

[DESIGN-REVIEWED] 2aca059

Description read

[DESCRIPTION-READ] e496db547e7fbe4c99c0536e017c1d0c43cff80242774d00c7da5d0f7c24bc97

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 2aca059558913e726174df0d50d97e038221dbbc — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

This is an evidence-only PR, and every item reuses the namespace rename guard that core hidden leaves already have. The description doesn't mention that it reverses a recorded pin, but the base already records the harm.

Notes

  • Item 3 — undeclared: the diff deletes the pin assert sandbox._live_plan_host(replace(request, backend=BACKEND_NAMESPACE)).caller_ancestor_guards == () and the "Seatbelt only" comment. The description says only "Evidence only for fix: guard parent folders of caller-provided hidden paths in the Linux sandbox #39551". What justifies the reversal is the base docstring of test_sandbox_hidden_leaf_parent_pins.py: "on disk the leaf now sits at a name no mask covers, so the NEXT spawn reads it there".

What this change ships

Inventory (4 items) — 3 justified

Intent: on Linux, stop a sandboxed child from renaming a parent folder of a caller-hidden file, which would leave the file unmasked for the next spawn; FIX (evidence copy of #39551).

  1. On Linux, renaming a parent folder of a caller-hidden file is now refused (EBUSY) — justified
  2. When that parent is an app's folder, it is pinned after the masks, the same as for core leaves — justified
  3. The pin "namespace lists no caller guards" is deleted and its test rewritten — undeclared
  4. A real-machine test that runs the namespace child and emits a REALMACHINE-39551 warning — justified

[FIRST-PRINCIPLES-REVIEWED] 2aca059

Description read

[DESCRIPTION-READ] d026c18b321501f764ab129da59334e917467cfb1cbcf998a03893ca86e2fa8a

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 2aca059558913e726174df0d50d97e038221dbbc — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 2aca059

Verdict parsed from the review's SHA-scoped output markers for commit 2aca059558913e726174df0d50d97e038221dbbc.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 2aca059558913e726174df0d50d97e038221dbbc false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 2aca059558913e726174df0d50d97e038221dbbc and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 2aca059

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 2aca059558913e726174df0d50d97e038221dbbc false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 20, 2026
@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Evidence for #39551 recorded in its body; closing (not merging).

@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant