Repository navigation
DO NOT MERGE: #39551 real-machine evidence (head) - #39807
chenmingwei23 wants to merge 4 commits into
Conversation
Plan-level tests for both backends: a caller-provided hidden file under a writable parent gets a guard on the parent and its ancestors, the file stays write-sealed, and the built-in guard set is unchanged. The namespace expectations fail on main.
Hidden paths a caller passes to the sandbox now get the same parent-folder rename guards as the built-in hidden paths on the Linux backend, limited to the folders this user could rename. The macOS guards are unchanged. Parents stay writable and the hidden set is unchanged.
Evidence only. Spawns the namespace sandbox with a caller-hidden file and reports whether renaming its parent folder is refused.
Sensitive Change ReviewSensitive files changed:
How to clear this check:
Only the author's comment counts this way. A reviewer can instead |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to judge here: this is an evidence-only branch for #39551 that the description says will be closed, so the design decision belongs to #39551. Notes
[DESIGN-REVIEWED] 2aca059 Description read[DESCRIPTION-READ] e496db547e7fbe4c99c0536e017c1d0c43cff80242774d00c7da5d0f7c24bc97 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS This is an evidence-only PR, and every item reuses the namespace rename guard that core hidden leaves already have. The description doesn't mention that it reverses a recorded pin, but the base already records the harm. Notes
What this change shipsInventory (4 items) — 3 justifiedIntent: on Linux, stop a sandboxed child from renaming a parent folder of a caller-hidden file, which would leave the file unmasked for the next spawn; FIX (evidence copy of #39551).
[FIRST-PRINCIPLES-REVIEWED] 2aca059 Description read[DESCRIPTION-READ] d026c18b321501f764ab129da59334e917467cfb1cbcf998a03893ca86e2fa8a That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
Evidence for #39551 recorded in its body; closing (not merging). |
Evidence only for #39551; will be closed.