Repository navigation
docs(rfc): re-check every RFC status against main - #39948
Conversation
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Docs-only status and Index-row corrections under Notes
[DESIGN-REVIEWED] fcfda80 Description read[DESCRIPTION-READ] a8ccde44d1b0b9993578314ab018ea6ebe3b356ceab9d09b8241ae0194ab7596 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Code change approver recommendation: A person should decideWhy: the decider raised 1 possible problem and estimates a 55% chance that this change introduces a defect; a person should check it. This is a docs-only sweep of RFC statuses and README Index rows, and most of it is well evidenced and consistent. One change contradicts the PR's own rule: rfc-browser-live-harness moves from draft to implemented on an owner decision that explicitly defers acceptance to a maintainer design review, and no such review is recorded. Similar RFCs in the same PR (code on main, no acceptance) stay draft. The First Principles lane reads Things to check (possible problems the decider raised; at this confidence many turn out to be fine):
Tier: 2, held for a person: design-doc-gate: D. An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
I reviewed head fcfda80. It changes only RFC front matter, the in-body status lines and the README Index rows under docs/request-for-change. The docs lint passes on this head. Every status value is in the documented vocabulary, every Index row now matches its document's front matter, and every superseded-by target exists. No test reads these fields, and the review gate that does reads them from the base branch, so nothing here changes behaviour. One non-blocking note for a maintainer: the browser live harness RFC now reads implemented, while the owner decision it cites deferred acceptance to a later design review, so please confirm that status or revert it to draft.
Problem / Motivation
Goal: Make the status of every RFC, and its README Index row, match the code on main after a full re-check.
The earlier passes checked mostly symbol names. A full re-check found RFCs whose status lags shipped work, README rows that disagree with their own front matter (one uses
in-review, which is not a status value),partialRFCs that understate what is built, anddraftRFCs that say "nothing built" while code is on main.Why it matters
The First Principles review reads RFC status from the base branch as the product decision record. A wrong status lets a change through, or blocks one, on a false premise.
Not a goal
- Status:line and the Index row change.acceptedwithout a recorded maintainer decision; RFCs with code on main but no acceptance staydraft.docs/request-for-change/. Prose docs are in docs: sync user docs with main #39884; code-owned agent docs are in docs: sync skills, AGENTS.md and bundled skill docs with main #39941.What changed (motivation → approach → change)
All 227 RFCs were re-checked against main: every
implementation-prsnumber read live, README row vs front matter vs body status line, a merged-PR search per RFC name, and definition+caller checks for each candidate deliverable with the maintainer decision looked up on the doc and implementation PRs. Status moves pastdraftonly with a recorded maintainer decision.For the reviewer:
rfc-browser-live-harnessmoves toimplementedon the owner decision on #26950, which also says its status "moves to accepted after a maintainer design review". If that review is still owed, it should staydraft.rfc-delayed-task-briefshould list the two greeting RFCs insupersedes(left for its owner).Per-RFC table and evidence
/home/bolichen/.kiro/crew/scratch/29751d83/wt-rfc2, branchdocs/sweep-r1b-rfc-status-2, base origin/main0c5d8bd5f3(2026-11-20).2d635e295b,77bdd207e8,3d17187c88(not pushed)../scripts/docs-lint.shexited 0 before each commit.status,last-audited,audited-at,implementation-prs,superseded-by; the in-body status line; README Index rows. No RFC body was rewritten and no file was deleted. CHANGELOG.md was not touched.How each RFC was checked
rfc-*.mdfiles was extracted. Everyimplementation-prsnumber (398 PRs) was read live through the GitHub GraphQL API: 376 merged, 12 closed, 10 open.gh search prs --merged "<rfc-name>"ran for every RFC. Merged non-docs PRs that name an RFC but are missing from itsimplementation-prswere listed and triaged./ai-review override first-principlescomments. Maintainers per MAINTAINERS.md: bolichen97, iamwhatever, buluoray, CrysisDeu.Status changes
acp_failover.py, read bydashboard/messaging_api/spawn.py(#26123, merged). Decision: the approving review of doc PR #27581 says "A maintainer has signed off on this RFC's design". Phase 2 (runtime failover) is not built.acceptedwhen the document merges"; it merged in #26859 with the owner's §12/§13 decisions. On main:apps/app_frame.pymessageActions (#26878), shared frame (#26875, #26899), selectionActions (#27700), composerActionsapps/composer_action_frame.py(#27718), linkOpenapps/link_open_frame.py(#27737), agentToolsapps/manifest_agent_tools.py(#32660). The §8 roadmap is not built._requested_backendrefusals. Phase 2 is not built:api_spawn_continuehas no backend refusal.connections/crew_oauth*.pybehind thecrew_oauthflag inFEATURE_PREVIEW_FLAGS(default off). The phase 3 default-on flip is not done.src/kiro_crew/browser_harness/, and removedbrowser/command_bus.pyandbrowser_cli/. Decision: bolichen97's owner decision on #26950 (issuecomment-6569794150) plus the matching/ai-review override first-principlescomments.WarmBriefCard.tsx). #23829 removed the cold Recap on the owner's decision.useMateGreeting,COLD_AFTER_MSandmateGreeting.tsare gone.implementation-prs).MateResumeCardandMateWelcomeCardare gone after #23829 and the warm brief replaced them.stop_helpers.py(#38243), #38112, #38240,actions.pyandcomments.py(#22370),tabs.py(#38998), #38181. The §3 "Stop: What happens next" brake is not built; it is in open #38882.src/kiro_crew/tracing/. Phase 2b (SigV4) and phases 6 to 9 are not built.Stale README rows fixed (front matter was already right)
_apply_chat_renameindashboard/session_directive_apply_slot.pydelete_empty_bot_subfolder, called fromapi_chat_folder_delete_snapshot_write_target(#25650) is on main; nofile_change_recordedundersrc/pressure_reclaim(called insidesession_memory_guard.py),apply_guard_reportsession_head.pychat_folder_file_selfstill grantedcloud/microvm/security/rm_floor.pyin-review(not a status value)slack.shared_accessupdate_capability.py,wheel_engine.py,update_stepup.pyon mainRow path fixes with the status unchanged:
apps/builtins/issue_radar/backend/agent_tools.py, notmcp_tools/apps.py.member-records/member-goals/, nottrust/member-goals/.Draft or accepted kept, with the status line,
implementation-prsand row correctedapp_browser_sdk(#39018, #39022, #39020). bolichen97's comment on #38322 says it is "not a sign-off".metrics/crew_log_export.py, installed fromserver_runtime/maintenance.py) and S2 (#21308) are on main. Both were merged by chenmingwei23 while iamwhatever's HOLD reviews waited on design agreement.implementation-prswas empty; 13 merged wave PRs were added.power_source()) toimplementation-prs.Audit-field-only bumps (
last-audited2026-11-20,audited-at0c5d8bd5f3)temp_reclaim.pyis on main (feat: kirocrew tmp reclaim removes provably unused temp leftovers #32853, called fromcli.py). The status line already says draft with code. No accept comment on docs(rfc): a checked way for agents to remove temp trees they left behind #25401 or feat: kirocrew tmp reclaim removes provably unused temp leftovers #32853.autonudge_service/gate.pystill callsirq.poll. No override on feat: show bounded monitors in the dashboard #5185, refactor: route babysit through structured monitors #5186, feat: monitor pull requests across source providers #5305 or fix(autonudge): let members arm their own loops; report arm outcome #8919.break_glasshas no hits._OWNERS_FILE = "owners.json"is inmate_config.py.bridge_approvalsis still a preview flag and there is no mute innotifications/.in-progress.Needs a maintainer ruling
implementedon bolichen97's owner decision on feat: add the live browser harness to chat #26950, which also says "its status moves to accepted after a maintainer design review". If that review is still owed, revert it todraft.supersedes. That key was outside the editable set. Its line 39 also still says the cold-welcome decision "remains fully in force", which feat(crew): remove the cold Recap greeting; the warm brief is the only return greeting #23829 reversed.Not done (left for a later pass)
partialandimplementedRFCs were checked through PR state, row/front-matter consistency, the merged-PR mention search and the row token check, and no issue was found. They were not re-read phase by phase, and their audit fields were not bumped.implementation-prs(mostly refactors). It is in$KIROCREW_SCRATCH/r1b/missing.txt, andimplementation-prswas completed only where a status depended on it.statusfront matter or status line, so they were not changed.version-compliance-framework.mdhas an Index row but is not anrfc-*.md; it was not checked.Risk: decisions recorded only in conductor chats or off GitHub were not visible, so any
draftabove may already have an off-repo acceptance.Backwards compatibility
Compatible: documentation only; no code, config or API changes.
Removes nothing: only doc wording changes; no file, key or function is removed.
Tests
Proof: not provable -- docs or config only
./scripts/docs-lint.shexits 0.Manual verification
Each status was checked against the symbols and PRs named in the table above.
Real-machine verification
N/A -- docs only: the diff changes Markdown front matter and index rows and runs nothing.
Related Issues
Follows #39909. Open questions for a maintainer are in the "Needs a maintainer ruling" part of the table above.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...); PR Hygiene does not count commitsContribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.