Repository navigation
docs: sync metrics and monitor-architecture specs with main - #39952
Conversation
…obe keys to code Section 5 names the irq watch file and MonitorState fields as stored; patrol interval is 300 s; all-accepted/all-closed are wake keys; current module paths for the tool-policy table.
Retention caps default on, consent pin order, missing signals and gauges in the inventory, product-metrics export, bucket table, history prose.
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Docs-only sync of two specs to the code on Not checked: the 11 code and RFC files in the supplied patch match What this change shipsInventory (8 items) — 8 justifiedIntent: contributors reading
[FIRST-PRINCIPLES-REVIEWED] 5698549 Description read[DESCRIPTION-READ] db36798cd954ca6fe73602b979594eafc16af5f811e22534ab11c41f1d062fa6 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the diff touches only two spec files, renders nothing and removes no code, key or path. [DESIGN-REVIEWED] 5698549 Description read[DESCRIPTION-READ] a51105e5ee691607b0bf7278fc7586fb8350faf4fd1904313659515c0e9924c2 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Review detailsNo findings. Notes:
[OPUS-REVIEWED] 5698549 Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Code change approver recommendation: A person should decideWhy: the decider estimates a 5% chance that this change introduces a defect, within the 12% limit for approving on its own, but it is held at tier 2: design-doc-gate: A. The PR changes only metrics.md and monitor-architecture.md, and every claim I spot-checked matches the code at head. Retention defaults are 30 days / 100 MB (sections_telemetry.py), env_pin() checks DO_NOT_TRACK, then KIROCREW_TELEMETRY, then the KIROCREW_TELEMETRY_DISABLED hold, and the notice counts an ack at or above the current version. handoff is in the op list, there are 25 _counted routes and the six unlisted ones count as other, so the 640-series ceiling holds. The fold catalogue matches FOLD_NAMES, and the voice, redaction, runtime_reconcile and inventory.voice.provider instruments exist, with the inventory and voice gauges in PRODUCT_METRICS. In the monitor spec, PATROL_INTERVAL_SECS is 300, _TERMINAL_SUCCESS_KEYS holds only merged, decision.py imports metrics.monitor_loops, and the irq watch-file path, digest and mode match the code, as do the MonitorState fields and the quarantine and unsupported-version handling. No behaviour, key or trust boundary changes; the text about egress and recording-on-by-default now matches the code. Tier: 2, held for a person: design-doc-gate: A. An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
I reviewed head 5698549. The diff changes only the metrics and monitor architecture specs; no code, test or configuration is touched. I compared the changed claims with the source at this head: the patrol interval, which keys count as terminal versus wake, how a privacy notice acknowledgement is compared, and the order in which consent env pins are resolved. Each one matches. One optional wording point: the paragraph on consent resolution could say that the legacy disabled variable gives way to a written telemetry.enabled value, although the module table already says so. Nothing here blocks merge.
Problem / Motivation
Goal:
metrics.mdandmonitor-architecture.mdstate what the code onmaindoes today.Many of these specs name merged PRs and closed issues as provenance, carry history prose ("used to", "this PR", "the fix"), and in places describe behaviour, middleware order or opt-outs that the code no longer matches.
Why it matters
These specs are what agents and contributors read before they change the code. A wrong layer order, a stale opt-out list or a closed issue named as an open gap sends a reader to the wrong place or makes them re-solve a solved problem.
Not a goal
modules/README.md, the list-A specs,docs/decisions/, or code.What changed (motivation → approach → change)
Follow-up to #39914, which merged before these two full reads finished. Both files were read from the first line to the last against the code on
main.metrics.md: retention caps default to 30 days / 100 MB (not 0);env_pin()order isDO_NOT_TRACK,KIROCREW_TELEMETRY, then the disabled hold; the notice counts an ack at or above the current version; the inventory gainskirocrew.session.runtime_reconcile, the voice STT/TTS signals,kirocrew.security.redaction.fail_closed,kirocrew.inventory.voice.provider, thehandoffsession-control op and six fold names; the inventory gauges export throughPRODUCT_METRICSby default;host.*_peakare declared, never emitted; bucket table gainsloop.lag_msandturn.completed.duration; history prose rewritten.monitor-architecture.md: section 5 names the two stored records (the irq watch file andMonitorState) and their real fields instead of a table no document matches; the default patrol interval is 300 s;all-accepted/all-closedare wake keys, not terminal keys; the tool-policy table citesmcp_shared_policyandagent_materialization/worker_agent.Backwards compatibility
Compatible: docs only.
Removes nothing: only doc prose changes; no code, key or path is removed.
Tests
Proof: not provable -- docs or config only
./scripts/docs-lint.shexits 0 on the head.Manual verification
N/A — docs only; each changed claim was checked against the cited source on
main.Real-machine verification
N/A -- docs only, the diff runs nothing.
Related Issues
Round-1b docs sweep, module specs list B.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...); PR Hygiene does not count commitsContribution License Agreement
Contributed under the project's Apache-2.0 license.