Skip to content

feat(kas): insider and stable builds prefer the built-in engine - #39998

Merged
KiroCrewCaptain merged 2 commits into
mainfrom
feat/kas-prefer-bundle-default
Nov 21, 2026
Merged

KiroCrewCaptain merged 2 commits into
mainfrom
feat/kas-prefer-bundle-default

Conversation

@CrysisDeu

@CrysisDeu CrysisDeu commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Insider and stable builds run KAS on Kiro Crew's own built-in engine by default, with a fallback that never strands a kiro-cli user.

Only nightly defaults agent.kas_bundle on today. Insider and stable ship the same bytes, so a lane stamp cannot make insider differ from stable. The default has to come from "this is a packaged build" instead, and the failure cases need defined behaviour first. That behaviour was reviewed and approved by the owner (issue #39611).

Why it matters

Bundle-route bugs show up only on nightly, or only after stable. Insider users never open the setting, so they never use the engine. A default switch with no fallback would break kiro-cli users whose Kiro Crew sign-in is missing or whose engine will not start.

Not a goal

What changed (motivation → approach → change)

Goal → the default reads the baked distribution (beacon.baked_distribution(): a desktop app, wheel or image, never source), not the release lane, so insider and stable behave alike. A saved agent.kas_bundle always wins, and the loaded field is only ever the saved value; the build's preference is applied per spawn (kas_route rule 1b, new acp/kas_build_default.py).

Case Behaviour
unset, packaged, Kiro Crew signed in built-in engine (REASON_BUILD_DEFAULT)
unset, kiro-cli signed in, Kiro Crew not stays on kiro-cli; the chat shows Sign in once to use Kiro Crew's built-in engine
no kiro-cli or signed out, Kiro Crew not engine route; the existing Sign in to Kiro prompt
first engine start the default caused fails that chat runs on kiro-cli once, with a notice; new chats retry the engine after 10 min
engine already ran here (marker kas_engine_ran), or a saved true fixed in place: 3 starts 5 s apart, then Kiro Crew's engine didn't start. + Resume; details in the log only; kiro-cli never offered
source checkout, or a host the engine cannot run on no preference: today's rules
--no-kas (cli.sh, install.sh) Kiro CLI only: saves agent.kas_bundle: false and skips the download

The engine choice moves from Settings → Developer → Feature previews to the KAS row of Settings → Agent Harness, as a two-way choice (Built-in harness / Kiro CLI). It reuses the shared KiroSignInStrip / KiroSignInDialog from #36888 and #39373 for the sign-in prompt.

Product-shape change (a changed default): the owner's sign-off is on #39611 (comment); no RFC is on main, so the First Principles lane may need an owner decision.

Backwards compatibility

Compatible: a saved agent.kas_bundle keeps its exact meaning; source checkouts keep today's routing; the loaded field still reads the saved value.

Reader: src/kiro_crew/config/loader_document.py:acp_backend_bundle_route -- chat -- now answers only for a saved true; a defaulted engine leaves a Kiro CLI pick on the v3 relay (test_kas_bundle_nightly_default.py::TestTheLoadedFieldIsOnlyTheSavedValue)
Reader: src/kiro_crew/config/loader_builders.py:_resolved_kas_bundle -- chat -- returns the saved value, else False; the build preference is per spawn (test_kas_bundle_nightly_default.py::TestTheLoadedFieldIsOnlyTheSavedValue::test_load_resolution)
Reader: src/kiro_crew/build_channel.py:is_nightly_build -- release -- removed; no reader left on main (git grep is_nightly_build), and the lane stamp stays baked and read (TestBakedBuildChannel)
Reader: src/kiro_crew/config/loader_document.py:kas_bundle_build_default -- chat -- removed; its four callers (loader.py, loader_builders.py, loader_pipeline.py, sections_agent.py help) now read the saved value, and the build preference is acp/kas_build_default.kas_bundle_preferred_by_build (test_kas_bundle_nightly_default.py::TestAPackagedBuildPrefersTheEngine)
Reader: website/src/pages/settings/FeaturePreviewsSection.tsx:KasBundleCard -- crew page -- the card moved to the KAS row of Agent Harness (AgentBackendTab.detailCard.test.tsx, FeaturePreviewIntro.test.tsx); the all-settings deep link and search entry follow it (config_all_settings.py, settingsRegistry.gen.ts)
Reader: cli.sh:--no-kas -- release -- now also saves the Kiro CLI choice (test_installer_kas_default.py::test_cli_sh_no_kas_means_kiro_cli_only)

Tests

  • test/test_kas_build_default_route.py (new): rule 1b holds only with nothing saved, a packaged build, an open route and a Kiro Crew sign-in; the sign-in-once prompt; a failed first switch runs that chat on kiro-cli and cools down; a host the engine ran on retries 3 times 5 s apart, then fails plainly, never moving to kiro-cli.
  • test/test_kas_bundle_nightly_default.py: every packaged distribution prefers the engine, a source checkout does not, the lane does not decide, an unsupported host does not; the loaded field is only the saved value.
  • test/test_kas_bundle_api.py: engine_choice, choice_saved, sign_in_moves_to_engine.
  • test/test_installer_kas_default.py: --no-kas saves agent.kas_bundle false.
  • Frontend: KasBundleCard.test.tsx (two-way choice, build's pick unsaved), KiroSignInPrompt.test.tsx, AgentBackendTab.detailCard.test.tsx, FeaturePreviewIntro.test.tsx, previewSurfaces.test.tsx.

Proof: not provable -- other: a feature PR with a new route rule, not a fix of an existing defect

Manual verification

Isolated gateways on this host with throwaway HOME and KIROCREW_HOME, _build_info.py stamped wheel, main vs head, shots below.

Signed-in proofs, run on a fresh throwaway home (gw7, real kiro-cli 3.5.0, company SSO for both sign-ins, KIRO_HOME=<data home>/kiro), code of head 3f1dbc668f:

Real-machine verification

Machine: cloud desktop, Amazon Linux 2023, aarch64, 16 vCPU / 64 GB
Before (main 56c1969): isolated gateway, engine acp-server.js replaced with process.exit(1), send "hello" -> raw process exited (rc=1) during initialize ..., one start per message
After (head 572ab43): same setup and message -> log shows did not start (attempt 1 of 3), 2 of 3, 3 of 3, 5 s apart; chat shows Kiro Crew's engine didn't start. with Resume
Cleanup: own computer; test gateways and pods are stopped after the PR's last proof, throwaway homes under ~/kc-work/kas-insider/ deleted then

Screenshots / video

All shots are full page, on a build stamped as a packaged wheel. Before: main cbffcd8fcb (this PR's merge base after the last rebase). After: #1-#5 from head 02c2944018 (head 701113614a only fixes what the built-in choice saves for a Kiro CLI pick, no screen change; engine choice Built-in harness / Kiro CLI, the owner's labels, tick on the selected one; a Chats switch after a restart. line; a Sign in link on the line saying why the built-in harness is not in use yet; Sign in to Kiro Crew once on every signed-out chat prompt). The #6/#7 shots are from the signed-in test home on 3f1dbc668f (chats) and 91e1d28004 (6b Settings, same labels as the head). In #5 the chat already holds earlier "hello" turns from repeated runs on the same throwaway home; the last row is this run.

#1 Settings → Agent Harness, KAS row (Kiro Crew signed out, so the choice shows the engine chats really use)

Before: before 1

After: after 1

#2 Settings → Developer → Feature previews (the engine switch leaves this page)

Before: before 2

After: after 2

#3 Chat, kiro-cli store present, Kiro Crew signed out

Before: before 3

After: after 3

#4 Chat, kiro-cli signed out, Kiro Crew signed out

Before: before 4

After: after 4

#5 Chat, engine will not start (host already on the engine)

Before: before 5

After: after 5

#6a Chat, kiro-cli signed in, Kiro Crew signed out (the KAS row in this state is #1)

after 6a chat

#6b After one Kiro Crew sign-in: new chat on the engine

after 6b settings

after 6b chat

#7 First switch fails: this chat on Kiro CLI with the notice

after 7

Wording (head 91e1d28): the engine options are Built-in harness / Kiro CLI (UX Review's fix), with a tick on the selected one. The chat prompt says Sign in to Kiro Crew once and does not name the engine (decision 2026-11-18-signed-out-sign-in-prompts-do-not-name-the-engine-route.md).

Review answers

  • GPT: rule 1b honours the sharing preview's failure cooldown (test_a_failed_preview_start_keeps_the_relay_for_its_cooldown); ?highlight=agent.engine and key:agent.kas_bundle open the KAS detail (KasEngineDeepLink); pressing the shown, unsaved choice saves it.
  • Opus: the unsaved choice is the route the next spawn takes; sign-in sources never offer kiro-cli on a host the engine already ran on (test_sign_in_surfaces_never_promise_kiro_cli_on_a_host_the_engine_ran_on).
  • Design: a host the engine already ran on keeps it when Kiro Crew signs out and shows the sign-in prompt.
  • UX: every card line says "built-in engine" instead of "KAS"; a reason line says why the recommended option is not chosen while signed out.
  • Boundary: the dashboard reaches the route through agent_sdk.kas_bundle.
  • Ratchet: the in-place retry wait has its own seam (_retry_wait).

Related Issues

Closes #39611

Checklist

  • A Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...); PR Hygiene does not count commits
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 20, 2026
@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ human override accepted

@CrysisDeu overrode this lane for 701113614a9b953a532f89620d9c1c4d963095b7 via /ai-review override (this commit only).

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 701113614a9b953a532f89620d9c1c4d963095b7 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the default is applied per spawn, a saved agent.kas_bundle still wins, the change is reversible with false/--no-kas, the owner signed off, and evidence is attached.

Notes

  • Some readers still treat the loaded agent.kas_bundle as the route: kiro_sandbox_conflict._kas_runs_on_the_relay, kiro_prerequisite_probe._relay_route_configured and cli_doctor.py:515. That field is now False for a session that rule 1b sent to the engine, so on packaged builds, including nightly where the field used to default to true, they misreport it as a relay session (wrong hints, wrong doctor rows). Point them at kas_route().
  • The first-switch cooldown (_FIRST_SWITCH_FAILED_AT) lives only in process memory. Every gateway restart retries the engine at once and shows the fallback notice again. Recording the failure next to kas_engine_ran would make it survive a restart.

[DESIGN-REVIEWED] 7011136

Description read

[DESCRIPTION-READ] 6dcaf55a7fbaacbc50cf7993bc2f1edddd1b303bf05d4cb335d38065a583e99f

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ human override accepted

@CrysisDeu overrode this lane for 701113614a9b953a532f89620d9c1c4d963095b7 via /ai-review override (this commit only).

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 701113614a9b953a532f89620d9c1c4d963095b7 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 7011136

Verdict parsed from the review's SHA-scoped output markers for commit 701113614a9b953a532f89620d9c1c4d963095b7.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 701113614a9b953a532f89620d9c1c4d963095b7 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 701113614a9b953a532f89620d9c1c4d963095b7 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 7011136

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 701113614a9b953a532f89620d9c1c4d963095b7 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 20, 2026
@CrysisDeu
CrysisDeu force-pushed the feat/kas-prefer-bundle-default branch from b5383cf to 413a74c Compare November 20, 2026 16:29
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 20, 2026
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

Owner decision (product shape): packaged builds (insider and stable, same bytes) prefer Kiro Crew's built-in KAS engine when agent.kas_bundle is unset, with the fallback rules in this PR. A saved value always wins; source checkouts stay on today's rules.

I reviewed and approved the fallback design ("这个可以保留,开始写代码吧" — keep it, start writing the code) and signed off on #39611: #39611 (comment)

This decision stands in for an RFC for the First Principles lane.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 413a74c owner-decision: Owner approved packaged builds preferring the built-in KAS engine with this fallback: #39998 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@CrysisDeu recorded a owner-decision release (class owner-decision) for the first-principles AI finding on 413a74cf86011c59e8bacf1a649443a1ce286a69.

Owner approved packaged builds preferring the built-in KAS engine with this fallback: #39998 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded, but the following reviewer lane(s) could not be re-run automatically: First Principles Review. Re-run the lane's latest workflow run for 413a74cf86011c59e8bacf1a649443a1ce286a69 manually from the Actions tab.

@CrysisDeu
CrysisDeu force-pushed the feat/kas-prefer-bundle-default branch from 413a74c to bbc8372 Compare November 20, 2026 16:34
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 20, 2026
@CrysisDeu
CrysisDeu force-pushed the feat/kas-prefer-bundle-default branch from bbc8372 to a5c9fc3 Compare November 20, 2026 16:43
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles a5c9fc3 owner-decision: Owner approved packaged builds preferring the built-in KAS engine with this fallback: #39998 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@CrysisDeu recorded a owner-decision release (class owner-decision) for the first-principles AI finding on a5c9fc3a86270bebaabbf0c69f03c8dd2f4558ae.

Owner approved packaged builds preferring the built-in KAS engine with this fallback: #39998 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 20, 2026
@CrysisDeu
CrysisDeu force-pushed the feat/kas-prefer-bundle-default branch from a5c9fc3 to cd99f1b Compare November 20, 2026 16:55
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles cd99f1b owner-decision: Owner approved packaged builds preferring the built-in KAS engine with this fallback: #39998 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@CrysisDeu recorded a owner-decision release (class owner-decision) for the first-principles AI finding on cd99f1b8e47eb69abd5cd7ae9763c747e7cde178.

Owner approved packaged builds preferring the built-in KAS engine with this fallback: #39998 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 20, 2026
@CrysisDeu
CrysisDeu force-pushed the feat/kas-prefer-bundle-default branch from cd99f1b to b9034eb Compare November 20, 2026 17:18
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles b9034eb owner-decision: Owner approved packaged builds preferring the built-in KAS engine with this fallback: #39998 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@CrysisDeu recorded a owner-decision release (class owner-decision) for the first-principles AI finding on b9034eb06048e0ad093ee68b696be632d35426d2.

Owner approved packaged builds preferring the built-in KAS engine with this fallback: #39998 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 20, 2026
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 21, 2026
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 02c2944018f0b8c00e0d5c6c1ea4b1d6a0e6ca21 owner-decision: Owner approved packaged builds preferring the built-in KAS engine with this fallback: #39998 (comment)

@CrysisDeu
CrysisDeu force-pushed the feat/kas-prefer-bundle-default branch from cb31e0d to 02c2944 Compare November 21, 2026 02:22
@github-actions

Copy link
Copy Markdown
Contributor

AI-review override not recorded: 02c2944018f0b8c00e0d5c6c1ea4b1d6a0e6ca21 is not the current PR head. Re-run the command with 02c29440183f9765ca73632182363131707aeb68.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 02c2944 owner-decision: Owner approved packaged builds preferring the built-in KAS engine with this fallback: #39998 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@CrysisDeu recorded a owner-decision release (class owner-decision) for the first-principles AI finding on 02c29440183f9765ca73632182363131707aeb68.

Owner approved packaged builds preferring the built-in KAS engine with this fallback: #39998 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision labels Nov 21, 2026
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

/ai-review override ux 02c2944 owner-decision: Owner ruled the engine choice labels "Built-in harness" / "Kiro CLI": #39998 (comment)

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@CrysisDeu recorded a owner-decision release (class owner-decision) for the ux AI finding on 02c29440183f9765ca73632182363131707aeb68.

Owner ruled the engine choice labels "Built-in harness" / "Kiro CLI": #39998 (comment)

This decision applies only to this commit. A new push requires a new judgment.

A packaged build (desktop app, wheel, image; never a source checkout)
now prefers Kiro Crew's own KAS engine when agent.kas_bundle is unset.
The decision reads the baked distribution, not the release lane, so
insider and stable, which ship the same bytes, behave alike. A saved
value always wins, and the loaded field is only ever the saved value.

KAS takes the engine once Kiro Crew's own sign-in is usable. A host
signed in only to kiro-cli stays on kiro-cli, and the chat asks the
owner to sign in once; kiro-cli's login is never copied.

The default's first move to the engine that fails runs that chat on
kiro-cli, with a notice, and new chats retry the engine after 10
minutes. Once the engine has started on a host, a failure is fixed in
place instead: three tries 5 s apart, then a plain error and the
chat's own Resume, the cause in the log only, and kiro-cli is never
offered.

The engine choice moves from Feature previews to the KAS row of
Settings > Agent Harness, as a two-way choice: built-in engine or
Kiro CLI.

Closes #39611
With packaged builds preferring the built-in engine, --no-kas must
never mean "on but with no engine". It now saves agent.kas_bundle off
as well as skipping the engine download, in cli.sh and install.sh, so
the install stays on Kiro CLI until the user picks the engine in
Settings > Agent Harness.
@CrysisDeu
CrysisDeu force-pushed the feat/kas-prefer-bundle-default branch from 02c2944 to 7011136 Compare November 21, 2026 02:53
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 7011136 owner-decision: Owner approved packaged builds preferring the built-in KAS engine with this fallback: #39998 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@CrysisDeu recorded a owner-decision release (class owner-decision) for the first-principles AI finding on 701113614a9b953a532f89620d9c1c4d963095b7.

Owner approved packaged builds preferring the built-in KAS engine with this fallback: #39998 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 21, 2026
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

/ai-review override ux 7011136 owner-decision: Owner ruled the engine choice labels "Built-in harness" / "Kiro CLI": #39998 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@CrysisDeu recorded a owner-decision release (class owner-decision) for the ux AI finding on 701113614a9b953a532f89620d9c1c4d963095b7.

Owner ruled the engine choice labels "Built-in harness" / "Kiro CLI": #39998 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 21, 2026
@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: A person should decide

Why: the decider thinks the change is probably fine but estimates a 20% chance that this change introduces a defect, above the 12% limit for approving on its own.

Packaged builds (any distribution stamp except source) now prefer the built-in KAS engine through a per-spawn rule (1b) instead of folding a nightly default into the loaded agent.kas_bundle field. The loaded field is now only the saved value. Readers that affect routing go through kas_spawn_takes_bundle/kas_route, so they pick up rule 1b: the spec permissions gate, kirocrew kas route for cloud sign-in, the usage vault check and the bootstrap floor. The fallback and retry paths match the table in the PR description: a failed first switch falls back once to kiro-cli with a notice and a 10-minute cooldown; a host where the engine already ran retries in place 3 times, then fails plainly. Only process death or an unanswered initialize counts as an engine failure. --no-kas saves false, and no update path passes it. The owner signed off, tests are extensive and CI is green. The remaining gaps are diagnostic readers that misreport the route and an in-memory cooldown; neither blocks.

Tier: 2, held for a person: security-sensitive path.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit 701113614a · 2466 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@KiroCrewCaptain
KiroCrewCaptain enabled auto-merge (squash) November 21, 2026 04:20

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of 7011136: PR Readiness is green on this head. The code review lanes report no findings and Design passes. A reviewer run of test_kas_build_default_route.py passed 25 of 25. Mutating the preview cooldown check, the engine-ran cooldown exemption and the retry cap each turns a test red. Nothing on main or in another open PR duplicates this change.

Done well: the loaded agent.kas_bundle stays exactly the saved value, and rule 1b applies the build preference per spawn. A saved choice always wins, and nothing is written to disk that the user did not choose.

Security: the change touches the shared sign-in prompt, and the risk is not realized. The prompt reuses the existing sign-in strip and dialog. sign_in_moves_to_engine is shown to the owner only. The kas_engine_ran marker holds no secret, and writing it can only turn off the Kiro CLI fallback. No sandbox, token or gate code changes, and credential choice still goes through resolve_kas_route.

The design is signed off under the standing maintainer sign-off for changes by team members.

Optional:

  • runtime_spawn_entry.py:243: the in-place retries and their 5 s waits run while the cold-start admission permit is held. A hung engine can hold a permit for about 280 s and stall other cold starts. Consider releasing the permit between attempts.
  • kas_build_default.py:81: LTS wheel and desktop builds also get rule 1b. RFC D6 still lists only two triggers for the engine route. Amend D6, or keep LTS out until its owners decide.
  • bootstrap.py:749: on nightly, the boot-time Kiro CLI floor can now move KAS to the Kiro CLI harness before Crew is signed in, which hides the new sign-in prompt. Consider skipping that step while the build default could still take the engine.

@KiroCrewCaptain
KiroCrewCaptain merged commit 612411e into main Nov 21, 2026
111 of 117 checks passed
@KiroCrewCaptain
KiroCrewCaptain deleted the feat/kas-prefer-bundle-default branch November 21, 2026 04:20
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default agent.kas_bundle on in insider builds, like nightly

2 participants