Skip to content

docs: sync learn-cron-dashboard spec with main - #40010

Merged
bolichen97 merged 1 commit into
mainfrom
docs/sweep-r1b-modules-a-learncron
Nov 20, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
docs/sweep-r1b-modules-a-learncron

Conversation

@bolichen97

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: docs/system-specs/modules/learn-cron-dashboard.md matches the code on current main.

Several module specs name functions, owners and grant rows that moved or changed in code merged after the spec's last edit, and their prose still carries closed-issue and merged-PR numbers that docs/system-specs/README.md ("Writing a spec") forbids.

Why it matters

A spec that names a function that does not exist, or leaves out a grant row the gate applies, sends the next reader (human or agent) to the wrong code and hides a real permission path.

Not a goal

  • The other half of modules/ (sweep list B) and modules/README.md.
  • Deleting, renaming or merging docs, index edits, and .github/docs-lint-baseline.txt pruning: a separate finisher PR does those.
  • Rewriting every design-rationale paragraph that explains a past defect; only lines that are plain changelog prose are changed.
  • New sections for behaviour no spec sentence contradicts (listed in a PR comment instead).

What changed (motivation → approach → change)

Split out of #39898 because this one file's diff (about 1.5 MB) is over the Design Review 1 MB cap on its own: its paragraphs are single lines of up to ~180 KB, so any edit re-sends the whole line.

Approach: the file was read line by line against origin/main in 11 slices; each slice listed its concrete claims (names, paths, routes, config keys and defaults, events, numbers, behaviour), checked them in the source, and recorded a fix for each wrong, removed or missing item and each changelog-style sentence. Closed-issue and merged-PR numbers were removed from prose.

257 fixes across the cron store and runs, the dashboard routes (skills, prompts, MCP, memory stores, project tree, capability routes), the chat and sidebar sections, the terminal and app-backend sections, and the monitor and loop sections. Examples: the shadow counting site is shadow.py::run_shadow_probe; the mid-turn model pick answers 200 {..., deferred: true}; review submission carries contentDigest; the /api/capability/* routes are described in present tense; the product name is spelled Kiro Crew in prose.

Backwards compatibility

Removes nothing: no code, key, route or file is removed; only doc sentences change.

Tests

Proof: not provable -- docs or config only

./scripts/docs-lint.sh exits 0.

Manual verification

N/A -- docs only; each changed claim was checked against the named symbol on main.

Real-machine verification

N/A -- docs only, the diff runs nothing.

Related Issues

Split from #39898.

Checklist

  • A Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...); PR Hygiene does not count commits
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license.

@bolichen97
bolichen97 enabled auto-merge (squash) November 20, 2026 16:40
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision a5a41477a70be4d925a141675aa6e07e6bf2c5d5 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision a5a41477a70be4d925a141675aa6e07e6bf2c5d5 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed a5a41477a70be4d925a141675aa6e07e6bf2c5d5 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] a5a4147

Verdict parsed from the review's SHA-scoped output markers for commit a5a41477a70be4d925a141675aa6e07e6bf2c5d5.

False positive or not applicable? A repository writer can comment:
/ai-review override fable a5a41477a70be4d925a141675aa6e07e6bf2c5d5 false-positive: <reason, 20 to 500 characters>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of a5a41477a70be4d925a141675aa6e07e6bf2c5d5 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] a5a4147

False positive or not applicable? A repository writer can comment:
/ai-review override gpt a5a41477a70be4d925a141675aa6e07e6bf2c5d5 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 20, 2026
@bolichen97
bolichen97 disabled auto-merge November 20, 2026 19:04
@bolichen97
bolichen97 merged commit cfccd70 into main Nov 20, 2026
96 of 98 checks passed
@bolichen97
bolichen97 deleted the docs/sweep-r1b-modules-a-learncron branch November 20, 2026 19:04
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant