Skip to content

feat(dashboard): remove a not-done milestone from the conductor mode list - #40213

Merged
Zedmor merged 1 commit into
mainfrom
feat/conductor-remove-failed-milestone
Nov 21, 2026
Merged

Zedmor merged 1 commit into
mainfrom
feat/conductor-remove-failed-milestone

Conversation

@Zedmor

@Zedmor Zedmor commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: In a conductor mode chat, a person can remove a milestone that was not done from the Milestones list, and bring it back.

In the Status view of the conductor mode Board, a milestone closed without being accepted stays in the Milestones list for the life of the board. A dropped one reads "Not done · dropped", a failed one "Not done · failed its check". The person has no control on the row, so a milestone they have already read and set aside keeps its place among the live ones.

Why it matters

The Milestones list is where the owner checks what is running and what needs them. Every not-done row there looks like something to read again. On a long goal that changes plan the list fills with rows that need no action, and the only way to a clean list is a new session.

Not a goal

  • No change to the work ledger, the crew log or GET /api/crew-board: a closed item takes no write, and every item stays on the board.
  • No removal that follows the person to another browser or device.
  • No change to the run line in Overview ("Finished. Some milestones were not done."), the Workers view or the Crew page.
  • No fold for dropped milestones: that is fix(dashboard): fold dropped milestones into one row on the conductor mode Board #39201.

What changed (motivation → approach → change)

A not-done row had no control, and nothing let the person say "I have seen this one".

What the person sees Where it comes from
A "Hide" button (eye-off icon and the word) on each "Not done" row MilestoneRow in website/src/pages/chat/command-center/ConductorModeCrewPanel.tsx
Only the row leaves the list a hidden set filters the not-done rows as they render
"Hidden: N" and "Show again" under the list the same panel, from the same set
The Milestones count, the Recap and the Overview are unchanged they read items, every item on the board, as on main

The button says "Hide" because that is all it does: the row is hidden in this browser, the ledger keeps the item, and the score does not move. A hidden failed milestone still counts in "N of M" and in the Recap, so the panel never reports a better result than the run had. The choice is kept in localStorage under mc-conductor-milestones-removed as {root: [item_id]}. I chose that over a ledger write because the ledger refuses a write to a closed item and its files are rebuilt from the crew log, so a server-side delete would change the store, the record and the rebuild for a row the person only wants out of sight.

Only a milestone that is closed and not accepted can be hidden. A stored id that names an open or accepted milestone, or another main chat, hides nothing. The stored list is pruned to the items still on the board. Each write starts from what is stored then, so a row hidden in another tab stays hidden. When the browser refuses the write, the change is applied to what the panel already holds, so a second Hide does not bring the first row back.

Pressing Hide moves keyboard focus to "Show again", never to another row's Hide, so a second Enter cannot hide a second milestone. Pressing "Show again" moves focus to the Milestones heading. The hidden line is a role="status". With every milestone hidden the list shows that line, the count still reads "0 of N", and "No milestones yet." shows only on a board with no items.

The four strings are in all twelve languages under website/src/i18n/locales/, with the regenerated en-XA.json. docs/system-specs/modules/crew-mode.md and the user doc src/kiro_crew/docs/work-ledger.md describe the button.

#39201 folds dropped milestones into one "N dropped" row. It touches the same list. The two fit together: with both, Hide sits on the rows inside the fold and on rejected rows. Whichever lands second rebases.

Backwards compatibility

Compatible: the panel reads the same board fields, and with nothing stored in the browser it draws the list as before plus one button per not-done row.

Reader: website/src/pages/chat/command-center/ConductorModeCrewPanel.tsx:ConductorModeCrewPanel -- crew page -- a row is hidden only after the person presses Hide and "Show again" restores it; shows the hidden rows again in one click and never hides an open or accepted milestone, and keeps each main chat separate check both

Tests

website/src/pages/chat/command-center/ConductorModeCrewPanel.remove.test.tsx (new, 10 tests):

  • offers Hide only on rows closed without being accepted: the button is on the rejected and the abandoned row, not on an open or accepted one.
  • hides only the row: the count and the Recap keep it, nothing is written to the ledger, and it survives a reload: the header stays "1 of 4", the Recap text is the same before and after, crewBoardAction is never called, and a fresh mount still hides the row.
  • shows the hidden rows again in one click: "Show again" restores both rows and clears the stored list.
  • never hides an open or accepted milestone, and keeps each main chat separate: stored ids for those, or for another root, hide nothing.
  • moves focus to Show again after a Hide, and to the heading after Show again: focus lands on "Show again", then on the heading; the line has role="status".
  • still counts every milestone, never "No milestones yet.", when all of them are hidden: a board with one rejected and one abandoned item, both hidden, reads "0 of 2 done", never "2 of 2".
  • keeps a row another tab hid after this panel mounted: a write merges with what another tab stored, for this main chat and another.
  • keeps the run line in the Overview when every milestone is hidden: with the patrol on, the run line still reads Working.
  • keeps every Hide when browser storage refuses the write: setItem throws, two rows are hidden one after the other, and both stay hidden.
  • reads an unusable stored value as nothing hidden: bad JSON and wrong shapes read as empty.

Determinism: the file passed 10 of 10 runs under --sequence.shuffle with seeds 1 to 10. The tests use no timers, no network and no wall clock; each clears localStorage first.

Manual verification

I opened the real panel on a loopback Vite server with the done-some fixtures of website/capture/conductor-mode-run-states.tsx (one rejected and one abandoned milestone), through an uncommitted copy of that page without its PREVIEW_CREW_MODE import, which no longer exists on main and stops the page loading. I drove it with scripted Playwright: hovered Hide, pressed it, and read the list. The row left the list, the header stayed "Milestones · 1 of 3", the Recap stayed "1 of 3 done." and the line "Hidden: 1 · Show again" appeared, in dark and light.

Real-machine verification

Machine: my own computer, Amazon Linux 2023, x86_64, 32 vCPU / 123 GiB
Before (main 0d11173): npx vitest run src/pages/chat/command-center/ConductorModeCrewPanel.remove.test.tsx with the test file run against main's panel -> fails (TypeError: readRemovedMilestones is not a function); the captured Status view shows no Hide button
After (head 1653305): the same command -> 10 passed; the captured Status view shows the button and the hidden line
Cleanup: own computer

Screenshots / video

Scripted Playwright against the real panel component, 460 px wide (the side panel), 2x.

Before (main) After After pressing Hide
Dark Status view on main, dark Hide button hovered, dark One milestone hidden, dark
Light Status view on main, light Hide button hovered, light One milestone hidden, light

Related Issues

Closes #40199

Checklist

  • A Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...); PR Hygiene does not count commits
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@Zedmor
Zedmor requested review from a team and KiroCrewCaptain as code owners November 20, 2026 23:35
@Zedmor
Zedmor requested a review from cruisercohen November 20, 2026 23:35
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 20, 2026
@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 165330560d6aff950fcf84113a16552979e3484e — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. The new control is opt-in, only affects what this browser shows, comes from issue #40199, and nothing in the repo already does it.

What this change ships

Inventory (7 items) — 7 justified

Intent: a person in a conductor mode chat can hide not-done milestones they have already read from the Milestones list, and bring them back. ADDITION.

  1. A "Hide" button (eye-off icon) on each rejected or abandoned milestone row — justified
  2. A hidden row leaves the list; the count, the Recap and the Overview still count it — justified
  3. A "Hidden: N · Show again" line under the list, and one click restores every hidden row — justified
  4. The choice is kept per browser in localStorage mc-conductor-milestones-removed, per main chat, trimmed to items still on the board — justified
  5. A row hidden in another tab stays hidden, and when the storage write fails each Hide still adds up in the panel — justified
  6. Focus moves to "Show again" after Hide, and to the Milestones heading after Show again — justified
  7. Four new strings in all locales; the spec and the user doc describe the button — justified

[FIRST-PRINCIPLES-REVIEWED] 1653305

Description read

[DESCRIPTION-READ] acbce368bec7281e389dd4a97d6bad8f18db23667034aaff1faf8bf1315209fa

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 165330560d6aff950fcf84113a16552979e3484e — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the hide state lives only in the browser and can be undone, the ledger and score are untouched, and screenshots of this revision are attached.

Notes

  • The PR title and the storage key say "remove" (mc-conductor-milestones-removed, readRemovedMilestones), but the button and docs say "Hide". Once this ships, that key is persisted in people's browsers, so align the name now or accept "removed" for good.

[DESIGN-REVIEWED] 1653305

Description read

[DESCRIPTION-READ] 7278e0ce286b419aab9f0096e489bcd99e019860d703f1c0c640077ef9519c5a

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 165330560d6aff950fcf84113a16552979e3484e — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks. The blind reader correctly identified both "Hide" and "Show again", said it would use them, and the screenshots cover the hide and undo states in both themes.

Notes

  • The state where every milestone is hidden (the list shows only "Hidden: N · Show again") is in no screenshot. Attach one so this branch gets reviewed too.
  • The reader could not tell whether hiding "changes the result" ("I can only see two steps listed under '3'"). Change conductor_mode_ms_hidden to say the row still counts, for example "Hidden: {{n}} (still counted)".

[UX-REVIEWED] 1653305

Description read

[DESCRIPTION-READ] 4e22dcc702a1e58172ec4e004ec5eb2035632de56b71d60c9c9bb066f0ca8827

That sha256 names everything this verdict read: the PR description, plus the 9 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 165330560d6aff950fcf84113a16552979e3484e — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 1653305

Verdict parsed from the review's SHA-scoped output markers for commit 165330560d6aff950fcf84113a16552979e3484e.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 165330560d6aff950fcf84113a16552979e3484e false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings (all downgraded on adjudication)

GPT 6.1 flagged blocking issues on 165330560d6aff950fcf84113a16552979e3484e; Opus 5.5 adjudication downgraded every one of them. Downgraded: the remedy each one needs is disproportionate to the harm it prevents. Adjudication downgraded all 1 blocking finding(s): the remedy each one requires is disproportionate to the harm it prevents.

This comment is updated in place on each push.

Review details

BLOCKING -- website/src/pages/chat/command-center/ConductorModeCrewPanel.tsx:912 -- Pruning against a stale board undoes another tab’s Hide

const ids = change(next[root] ?? []).filter(id => onBoard.has(id))
Trigger: Two tabs show the same root between board polls. Tab A hides a newly closed milestone absent from tab B’s older snapshot; B then hides an older row. setRemoved reads A’s stored ID, filters it against B’s snapshot, and saves without it.
Outcome: The newly hidden milestone reappears on reload without anyone pressing “Show again”.
Anchor: defect
Fix: Preserve merged stored IDs instead of pruning against the panel’s potentially stale snapshot; the render-time filter already ignores IDs absent from the board.

[BLOCK-MERGE-DOWNGRADED] 1653305
[GPT-REVIEWED] 1653305

Adjudication (Opus 5.5) — is blocking on each finding proportionate?

F1: I'm downgrading this one; it stops blocking.

  • Harm: LOW. The failure needs everything below to happen together:

    • two tabs open on the same root;
    • both actions inside one 10-second poll window (website/src/api/crewBoard.ts:203);
    • tab A hides a milestone that is not yet in tab B's items, which tab B uses to build onBoard (ConductorModeCrewPanel.tsx:909);
    • tab B then hides another row. Its write re-reads storage (:918), filters against its own older board copy (:912), and saves the result (:919).

    What gets lost is one per-browser "hide this row" choice for a dropped or rejected milestone. The ledger is never written (:196), and the count and Recap still read every item (:893-894). The row simply reappears where the person can see it, and one click on Hide (:1097) fixes it. There is no recovery path in the code beyond that click.

  • Fix cost: the prune keeps the stored list bounded, so it can't just be dropped. The page can't tell an id that left the board from one this tab hasn't polled yet. Handling that means new state, such as which ids this tab has seen or timestamps on the stored entries, kept for this one cosmetic path. That cost is higher than the harm.

    [ADJUDICATION] 1653305 total=1 uphold=0 downgrade=1
    DOWNGRADE F1 website/src/pages/chat/command-center/ConductorModeCrewPanel.tsx:912 reason=disproportionate-remedy
    [GPT-ADJUDICATED] 1653305

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 165330560d6aff950fcf84113a16552979e3484e false-positive: <reason, 20 to 500 characters>

@Zedmor

Zedmor commented Nov 21, 2026

Copy link
Copy Markdown
Contributor Author
  • The trash icon promises deletion, but the button only hides the row (span=9cbf5d038a8f)

fixed in 82906c9: the control is an eye-off icon with the visible word "Hide", and the line under the list reads "Hidden: N" with "Show again". The description and screenshots show the new control.

@Zedmor

Zedmor commented Nov 21, 2026

Copy link
Copy Markdown
Contributor Author
  • Removing milestones in this browser also changes the run's own state (span=5f67cc0e92bf)

fixed in 82906c9: conductorModeRunState and the Overview's "Done when" line read boardItems, every item on the board; only the list, its count and the Recap read the filtered items. Test: keeps the run line in the Overview when every milestone is hidden.

@Zedmor

Zedmor commented Nov 21, 2026

Copy link
Copy Markdown
Contributor Author
  • Preserve earlier removals when browser storage is unavailable (span=7f14b9820b0c)

fixed in 82906c9: when the write does not land, the change is applied to the state the panel already holds instead of the empty stored value. Test: keeps every Hide when browser storage refuses the write.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 21, 2026
@Zedmor
Zedmor force-pushed the feat/conductor-remove-failed-milestone branch from 64e6d3b to 82906c9 Compare November 21, 2026 00:08
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 21, 2026
…list

A milestone closed without being accepted (rejected or abandoned) stayed in
the Status view's Milestones list for the life of the board, with no way to
clear it. Its row now has a Remove button.

The removal is a per-browser view choice (localStorage,
mc-conductor-milestones-removed, {root: [item_id]}): the work ledger is not
written, because a closed item takes no write and every item stays on the
board. The panel's count, rows and Recap leave removed items out, and
"Show again" under the list restores them. An open or accepted item is
never hidden.
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 21, 2026
@Zedmor

Zedmor commented Nov 21, 2026

Copy link
Copy Markdown
Contributor Author
  • "Hide" also drops the milestone from the totals (span=9cbf5d038a8f)

fixed in 1653305: Hide removes only the row. The Milestones count and the Recap read every item on the board, as on main, and the "Hidden: N" line under the list reports the hidden ones. Test: hides only the row: the count and the Recap keep it.

@Zedmor

Zedmor commented Nov 21, 2026

Copy link
Copy Markdown
Contributor Author
  • Hiding every milestone makes the Recap count failed work as done (span=7f14b9820b0c)

fixed in 1653305: the Recap is built from the full board list again, so with every milestone hidden it never reaches the worker-count fallback. Test: still counts every milestone, never "No milestones yet.", when all of them are hidden (asserts "0 of 2 done", never "2 of 2").

@Zedmor
Zedmor force-pushed the feat/conductor-remove-failed-milestone branch from 82906c9 to 1653305 Compare November 21, 2026 00:42
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 21, 2026
@Zedmor

Zedmor commented Nov 21, 2026

Copy link
Copy Markdown
Contributor Author
  • Pruning against a stale board undoes another tab’s Hide (span=7f14b9820b0c)

Rebutted: disproportional. It needs two tabs on the same main chat acting inside one 10-second board poll, and what is lost is one per-browser Hide of a closed row, which reappears in view and takes one click to hide again. The ledger, the count and the Recap are untouched. The prune keeps the stored list bounded; telling an id that left the board from one this tab has not polled yet needs new per-id state for this path alone. The lane adjudication downgraded it on the same grounds.

@Zedmor
Zedmor enabled auto-merge (squash) November 21, 2026 01:36
@KiroCrewCaptain

KiroCrewCaptain commented Nov 21, 2026 •

Copy link
Copy Markdown
Collaborator

Code change approver deep review: Approve

Approved on commit 165330560d: the review says why.

Tier: 2, cleared by a deep review: a review lane's finding, the size and category tally.

A deep review by the code change approver, not by a person · commit 165330560d · 335 changed lines. If it is wrong, reply here: replies are how the approver is evaluated.

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by the code change approver's deep review, not by a person.

Approved. I read the diff and the panel at head 165330560d. I did not run the tests myself; PR Readiness is green, and Frontend Tests 1 to 4, New-test stability (ubuntu and windows) and the en-XA i18n Render Gate passed on this head.

Verified in the code: Hide is offered only on rows that are closed and not accepted. The hidden set is checked again at render through milestoneRemovable (ConductorModeCrewPanel.tsx:897-900), so a stale or hand-edited stored id cannot hide an open or accepted milestone. The count, the Recap and the Overview still read every board item, and the ledger takes no write. Not on main already, and not a duplicate of #39201 (different issue, different behaviour).

Done well: hiding a row cannot make a run read better than it went, and a test pins "0 of 2 done" with every milestone hidden.

The stale-board prune finding from one AI lane (ConductorModeCrewPanel.tsx:912) is real but narrow. It needs two tabs on the same main chat inside one 10-second board poll, and the only loss is one row coming back into view. It does not block.

Optional:

  • Delete the prune at ConductorModeCrewPanel.tsx:908-912 (onBoard and the .filter). The render already ignores ids that are not on the board, no test pins the prune, and the deletion removes the two-tab case above. Update the matching sentence in crew-mode.md if you do.
  • Add one comment on #40199 that says hidden milestones stay in the count and the Recap, and why. The issue asks for the opposite, and it closes with this merge.
  • Attach a dark and a light screenshot of the list with every milestone hidden. No screenshot shows that state yet.

Tier: 2, cleared by a deep review: a review lane's finding, the size and category tally.
Criteria: no merge conflict, no owner block, no change request, the default branch, no security-sensitive path, no design document to agree on, the readiness status, the review lanes, the P0 history, the linked issues' tier, the review lessons, no concern label, the file count, a safe change category, not its own change, the decider.
Design documents ride along with the code (docs/system-specs/modules/crew-mode.md): they were not reviewed as a design, and a person who changes what they decide should ask for that review.

To overrule it, request changes or dismiss this review.

@Zedmor
Zedmor merged commit cbffcd8 into main Nov 21, 2026
101 checks passed
@Zedmor
Zedmor deleted the feat/conductor-remove-failed-milestone branch November 21, 2026 02:10
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conductor mode: let a person remove a not-done milestone from the Milestones list

2 participants