Repository navigation
feat(dashboard): remove a not-done milestone from the conductor mode list - #40213
Conversation
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. The new control is opt-in, only affects what this browser shows, comes from issue #40199, and nothing in the repo already does it. What this change shipsInventory (7 items) — 7 justifiedIntent: a person in a conductor mode chat can hide not-done milestones they have already read from the Milestones list, and bring them back. ADDITION.
[FIRST-PRINCIPLES-REVIEWED] 1653305 Description read[DESCRIPTION-READ] acbce368bec7281e389dd4a97d6bad8f18db23667034aaff1faf8bf1315209fa That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the hide state lives only in the browser and can be undone, the ledger and score are untouched, and screenshots of this revision are attached. Notes
[DESIGN-REVIEWED] 1653305 Description read[DESCRIPTION-READ] 7278e0ce286b419aab9f0096e489bcd99e019860d703f1c0c640077ef9519c5a That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. The blind reader correctly identified both "Hide" and "Show again", said it would use them, and the screenshots cover the hide and undo states in both themes. Notes
[UX-REVIEWED] 1653305 Description read[DESCRIPTION-READ] 4e22dcc702a1e58172ec4e004ec5eb2035632de56b71d60c9c9bb066f0ca8827 That sha256 names everything this verdict read: the PR description, plus the 9 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findings (all downgraded on adjudication)GPT 6.1 flagged blocking issues on This comment is updated in place on each push. Review detailsBLOCKING -- website/src/pages/chat/command-center/ConductorModeCrewPanel.tsx:912 -- Pruning against a stale board undoes another tab’s Hide
Adjudication (Opus 5.5) — is blocking on each finding proportionate?F1: I'm downgrading this one; it stops blocking.
False positive or not applicable? A repository writer can comment: |
|
|
|
64e6d3b to
82906c9
Compare
…list
A milestone closed without being accepted (rejected or abandoned) stayed in
the Status view's Milestones list for the life of the board, with no way to
clear it. Its row now has a Remove button.
The removal is a per-browser view choice (localStorage,
mc-conductor-milestones-removed, {root: [item_id]}): the work ledger is not
written, because a closed item takes no write and every item stays on the
board. The panel's count, rows and Recap leave removed items out, and
"Show again" under the list restores them. An open or accepted item is
never hidden.
|
|
82906c9 to
1653305
Compare
|
Code change approver deep review: ApproveApproved on commit Tier: 2, cleared by a deep review: a review lane's finding, the size and category tally. A deep review by the code change approver, not by a person · commit |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Approved by the code change approver's deep review, not by a person.
Approved. I read the diff and the panel at head 165330560d. I did not run the tests myself; PR Readiness is green, and Frontend Tests 1 to 4, New-test stability (ubuntu and windows) and the en-XA i18n Render Gate passed on this head.
Verified in the code: Hide is offered only on rows that are closed and not accepted. The hidden set is checked again at render through milestoneRemovable (ConductorModeCrewPanel.tsx:897-900), so a stale or hand-edited stored id cannot hide an open or accepted milestone. The count, the Recap and the Overview still read every board item, and the ledger takes no write. Not on main already, and not a duplicate of #39201 (different issue, different behaviour).
Done well: hiding a row cannot make a run read better than it went, and a test pins "0 of 2 done" with every milestone hidden.
The stale-board prune finding from one AI lane (ConductorModeCrewPanel.tsx:912) is real but narrow. It needs two tabs on the same main chat inside one 10-second board poll, and the only loss is one row coming back into view. It does not block.
Optional:
- Delete the prune at
ConductorModeCrewPanel.tsx:908-912(onBoardand the.filter). The render already ignores ids that are not on the board, no test pins the prune, and the deletion removes the two-tab case above. Update the matching sentence increw-mode.mdif you do. - Add one comment on #40199 that says hidden milestones stay in the count and the Recap, and why. The issue asks for the opposite, and it closes with this merge.
- Attach a dark and a light screenshot of the list with every milestone hidden. No screenshot shows that state yet.
Tier: 2, cleared by a deep review: a review lane's finding, the size and category tally.
Criteria: no merge conflict, no owner block, no change request, the default branch, no security-sensitive path, no design document to agree on, the readiness status, the review lanes, the P0 history, the linked issues' tier, the review lessons, no concern label, the file count, a safe change category, not its own change, the decider.
Design documents ride along with the code (docs/system-specs/modules/crew-mode.md): they were not reviewed as a design, and a person who changes what they decide should ask for that review.
To overrule it, request changes or dismiss this review.
Problem / Motivation
Goal: In a conductor mode chat, a person can remove a milestone that was not done from the Milestones list, and bring it back.
In the Status view of the conductor mode Board, a milestone closed without being accepted stays in the Milestones list for the life of the board. A dropped one reads "Not done · dropped", a failed one "Not done · failed its check". The person has no control on the row, so a milestone they have already read and set aside keeps its place among the live ones.
Why it matters
The Milestones list is where the owner checks what is running and what needs them. Every not-done row there looks like something to read again. On a long goal that changes plan the list fills with rows that need no action, and the only way to a clean list is a new session.
Not a goal
GET /api/crew-board: a closed item takes no write, and every item stays on the board.What changed (motivation → approach → change)
A not-done row had no control, and nothing let the person say "I have seen this one".
MilestoneRowinwebsite/src/pages/chat/command-center/ConductorModeCrewPanel.tsxhiddenset filters the not-done rows as they renderitems, every item on the board, as on mainThe button says "Hide" because that is all it does: the row is hidden in this browser, the ledger keeps the item, and the score does not move. A hidden failed milestone still counts in "N of M" and in the Recap, so the panel never reports a better result than the run had. The choice is kept in localStorage under
mc-conductor-milestones-removedas{root: [item_id]}. I chose that over a ledger write because the ledger refuses a write to a closed item and its files are rebuilt from the crew log, so a server-side delete would change the store, the record and the rebuild for a row the person only wants out of sight.Only a milestone that is closed and not accepted can be hidden. A stored id that names an open or accepted milestone, or another main chat, hides nothing. The stored list is pruned to the items still on the board. Each write starts from what is stored then, so a row hidden in another tab stays hidden. When the browser refuses the write, the change is applied to what the panel already holds, so a second Hide does not bring the first row back.
Pressing Hide moves keyboard focus to "Show again", never to another row's Hide, so a second Enter cannot hide a second milestone. Pressing "Show again" moves focus to the Milestones heading. The hidden line is a
role="status". With every milestone hidden the list shows that line, the count still reads "0 of N", and "No milestones yet." shows only on a board with no items.The four strings are in all twelve languages under
website/src/i18n/locales/, with the regenerateden-XA.json.docs/system-specs/modules/crew-mode.mdand the user docsrc/kiro_crew/docs/work-ledger.mddescribe the button.#39201 folds dropped milestones into one "N dropped" row. It touches the same list. The two fit together: with both, Hide sits on the rows inside the fold and on rejected rows. Whichever lands second rebases.
Backwards compatibility
Compatible: the panel reads the same board fields, and with nothing stored in the browser it draws the list as before plus one button per not-done row.
Reader: website/src/pages/chat/command-center/ConductorModeCrewPanel.tsx:ConductorModeCrewPanel -- crew page -- a row is hidden only after the person presses Hide and "Show again" restores it;
shows the hidden rows again in one clickandnever hides an open or accepted milestone, and keeps each main chat separatecheck bothTests
website/src/pages/chat/command-center/ConductorModeCrewPanel.remove.test.tsx(new, 10 tests):offers Hide only on rows closed without being accepted: the button is on the rejected and the abandoned row, not on an open or accepted one.hides only the row: the count and the Recap keep it, nothing is written to the ledger, and it survives a reload: the header stays "1 of 4", the Recap text is the same before and after,crewBoardActionis never called, and a fresh mount still hides the row.shows the hidden rows again in one click: "Show again" restores both rows and clears the stored list.never hides an open or accepted milestone, and keeps each main chat separate: stored ids for those, or for another root, hide nothing.moves focus to Show again after a Hide, and to the heading after Show again: focus lands on "Show again", then on the heading; the line hasrole="status".still counts every milestone, never "No milestones yet.", when all of them are hidden: a board with one rejected and one abandoned item, both hidden, reads "0 of 2 done", never "2 of 2".keeps a row another tab hid after this panel mounted: a write merges with what another tab stored, for this main chat and another.keeps the run line in the Overview when every milestone is hidden: with the patrol on, the run line still reads Working.keeps every Hide when browser storage refuses the write:setItemthrows, two rows are hidden one after the other, and both stay hidden.reads an unusable stored value as nothing hidden: bad JSON and wrong shapes read as empty.Determinism: the file passed 10 of 10 runs under
--sequence.shufflewith seeds 1 to 10. The tests use no timers, no network and no wall clock; each clears localStorage first.Manual verification
I opened the real panel on a loopback Vite server with the
done-somefixtures ofwebsite/capture/conductor-mode-run-states.tsx(one rejected and one abandoned milestone), through an uncommitted copy of that page without itsPREVIEW_CREW_MODEimport, which no longer exists on main and stops the page loading. I drove it with scripted Playwright: hovered Hide, pressed it, and read the list. The row left the list, the header stayed "Milestones · 1 of 3", the Recap stayed "1 of 3 done." and the line "Hidden: 1 · Show again" appeared, in dark and light.Real-machine verification
Machine: my own computer, Amazon Linux 2023, x86_64, 32 vCPU / 123 GiB
Before (main 0d11173):
npx vitest run src/pages/chat/command-center/ConductorModeCrewPanel.remove.test.tsxwith the test file run against main's panel -> fails (TypeError: readRemovedMilestones is not a function); the captured Status view shows no Hide buttonAfter (head 1653305): the same command -> 10 passed; the captured Status view shows the button and the hidden line
Cleanup: own computer
Screenshots / video
Scripted Playwright against the real panel component, 460 px wide (the side panel), 2x.
Related Issues
Closes #40199
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...); PR Hygiene does not count commits