Skip to content

fix(settings): keep the restart row while the update card has none - #40331

Draft
KiroCrewAutoBuilder wants to merge 1 commit into
mainfrom
autobuild/39354
Draft

KiroCrewAutoBuilder wants to merge 1 commit into
mainfrom
autobuild/39354

Conversation

@KiroCrewAutoBuilder

Copy link
Copy Markdown
Collaborator

Problem / Motivation

Goal: Settings → About always offers a way to restart the gateway while an update is pending or has been applied.

During the update lifecycle the About panel showed no restart control at all. The standing "Restart gateway" row hid whenever any update card was on screen, but only the installer card that shows a command draws its own Restart button. The in-app arm/apply flow, the policy-managed note and an installer card with no command draw none. So a managed-venv install that applied its own update had to be restarted from the CLI.

Why it matters

Restarting is the step that loads the new version. Without a control, a dashboard-only user (a remote or mobile session, say) cannot finish the update they just approved.

Not a goal

- Changing the applying-phase copy (`applying_restart_note`). The catalogs already say the new version starts on the next restart.
- Adding a Restart button inside the in-app update flow itself.

What changed (motivation → approach → change)

The row hid on `showManualUpdate`, which means "an update card is on screen", not "a card has a Restart button". `AboutPanelGatewayUpdates` (`website/src/pages/settings/AboutPanelGatewayUpdate.tsx`) now works out `cardHasRestart`: the installer branch is showing (not the in-app arm flow, not policy-managed) and it has a command. The standing row and its error notice hide only when that is true. So there is still never more than one Restart button on screen.

The `about` row of `docs/feature-map/README.md` now states the rule: in a browser the standing Restart row stays through the whole update lifecycle, hidden only while the installer card shows its command. No module spec under `docs/system-specs/` documented this visibility rule; the feature map is where the About panel's restart behaviour is recorded.

Backwards compatibility

Compatible: the row only appears in more states. The installer card that has a command still has the only Restart button.

Removes nothing: the change only shows an existing control in states where it was hidden.

Tests

Every test red on the patched tree in Verify, in backend-1, backend-2, backend-3, backend-5, backend-6, backend-10, backend-11, backend-12, fails at the base commit in the Builder's verify run as well (below, Red without this patch too, and Red only after other tests for those that passed when Verify ran each again alone).

Proof: not provable -- frontend test (prove.py runs Python only)

`website/src/test/AboutPanel.gatewayChannelRestart.test.tsx`:
- `keeps the standing Restart beside the in-app update flow, which draws none`: an arm-capable install with a pending update shows the standing row, and two clicks POST `/api/restart`.
- `keeps the standing Restart when the installer card has no command`: an installer card with no command shows the standing row.
- The existing `does not render two Restart buttons at once` still passes.

Ran `npx vitest run src/test/AboutPanel.gatewayChannelRestart.test.tsx src/test/AboutPanel.desktopRestart.test.tsx` (35 passed), eslint and `tsc -p tsconfig.app.json` (no errors), `bash scripts/docs-lint.sh` (passed) and `test/gui_user/test_features_catalog.py` (36 passed).

Red without this patch too

These tests fail with the patch, and fail at the base commit in the Builder's verify run as well: the draft PR is opened with them red, and GitHub's CI is likely red on them too. Verify lists at most 50 a shard.

backend-1: test/test_living_ui_harness.py::test_the_dashboard_mode_reruns_under_the_runtime_python
backend-1: test/test_prepare_pr_prove_line.py::test_a_hooks_path_inherited_through_git_config_parameters_does_not_run
backend-1: test/test_prepare_pr_prove_line.py::test_a_post_checkout_hook_does_not_run_in_the_proof_worktree
backend-1: test/test_prepare_pr_prove_line.py::test_a_global_hooks_path_does_not_run_either
backend-1: test/test_prepare_pr_prove_line.py::test_an_exported_git_dir_does_not_retarget_prove
backend-1: test/test_prepare_pr_prove_line.py::test_a_head_that_moves_during_the_run_does_not_change_what_was_proven
backend-1: test/test_prepare_pr_prove_line.py::test_the_proof_runs_on_the_pinned_commit_not_on_head
backend-1: test/test_service.py::TestLinuxEnvironmentFile::test_uninstall_preserves_an_operator_edited_env_file
backend-1: test/test_service.py::TestLinuxEnvironmentFile::test_uninstall_removes_our_untouched_seed
backend-2: test/test_cli_manifest_signature.py::test_a_wedged_grandchild_does_not_outlive_the_bounded_run
backend-2: test/test_find_ui_auto.py::test_the_generated_auto_tier_answers_labels_only_it_carries[continue with github-en-Continue with GitHub-path0]
backend-3: test/test_codex_session_mcp.py::test_the_driver_runner_reaps_descendants_on_the_timeout_path
backend-5: test/test_governance_chokepoints.py::TestFilesystemEgressAtGate::test_an_expansion_dependent_argument_keeps_the_reading_title[/srv/$PWD/note.txt]
backend-5: test/test_pod_e2e_harness_paths.py::test_health_accepts_the_pods_own_serving_codes
backend-5: test/test_pod_e2e_harness_paths.py::test_health_refuses_a_foreign_port_holder_and_names_the_conflict
backend-5: test/test_pod_e2e_harness_paths.py::test_health_survives_every_bad_timeout_override[abc-read as a variable NAME inside $(( )); set -u kills the run]
backend-5: test/test_pod_e2e_harness_paths.py::test_health_survives_every_bad_timeout_override[6 0-whitespace is not a digit]
backend-5: test/test_pod_e2e_harness_paths.py::test_health_accepts_a_valid_timeout_override[5]
backend-5: test/test_pod_e2e_harness_paths.py::test_health_accepts_a_valid_timeout_override[08]
backend-5: test/test_pod_e2e_harness_paths.py::test_health_survives_every_bad_timeout_override[-5-leading '-' is a non-digit, and a past deadline fakes a timeout]
backend-5: test/test_pod_e2e_harness_paths.py::test_health_survives_every_bad_timeout_override[999999999999999999999999-no error, but the deadline lands centuries out]
backend-5: test/test_pod_e2e_harness_paths.py::test_health_accepts_a_valid_timeout_override[999999]
backend-5: test/test_pod_e2e_harness_paths.py::test_health_probes_at_least_once_when_the_clock_ticks_past_the_deadline
backend-5: test/test_pod_e2e_harness_paths.py::test_handle_refuses_a_name_that_differs_from_the_argument
backend-5: test/test_pod_e2e_harness_paths.py::test_handle_refuses_a_missing_name
backend-5: test/test_pod_e2e_harness_paths.py::test_handle_refuses_a_name_that_is_not_a_non_empty_string[]
backend-5: test/test_pod_e2e_harness_paths.py::test_handle_refuses_a_name_that_is_not_a_non_empty_string[0]
backend-5: test/test_pod_e2e_harness_paths.py::test_handle_refuses_a_name_that_is_not_a_non_empty_string[None]
backend-5: test/test_pod_e2e_harness_paths.py::test_handle_accepts_a_name_that_matches_the_argument
backend-5: test/test_pod_e2e_harness_paths.py::test_handle_refuses_a_missing_health_at_the_door
backend-5: test/test_pod_e2e_harness_paths.py::test_a_bad_handle_is_refused_at_the_door[{"name": "smoke", "base_url": "http://127.0.0.1:7811", "token": "[redacted]", "port": 7811, "health": 200}-None]
backend-5: test/test_pod_e2e_harness_paths.py::test_a_bad_handle_is_refused_at_the_door[{"name": "smoke", "base_url": "http://localhost:7811", "token": "[redacted]", "port": "7811", "health": 200}-None]
backend-5: test/test_pod_e2e_harness_paths.py::test_a_bad_handle_is_refused_at_the_door[{"name": "smoke", "base_url": "http://[::1]:7811", "token": "[redacted]", "port": 7811, "health": 200}-None]
backend-5: test/test_pod_e2e_harness_paths.py::test_a_bad_handle_is_refused_at_the_door[not json at all-not readable JSON]
backend-5: test/test_pod_e2e_harness_paths.py::test_a_bad_handle_is_refused_at_the_door[["base_url"]-not a JSON object]
backend-5: test/test_pod_e2e_harness_paths.py::test_a_bad_handle_is_refused_at_the_door[{"name": "smoke", "base_url": "http://127.0.0.1:7811"}-needs a non-empty base_url and token]
backend-5: test/test_pod_e2e_harness_paths.py::test_a_bad_handle_is_refused_at_the_door[{"token": "[redacted]"}-needs a non-empty base_url and token]
backend-5: test/test_pod_e2e_harness_paths.py::test_a_bad_handle_is_refused_at_the_door[{"name": "smoke", "base_url": "", "token": ""}-needs a non-empty base_url and token]
backend-5: test/test_pod_e2e_harness_paths.py::test_a_bad_handle_is_refused_at_the_door[{"name": "smoke", "base_url": "http://127.0.0.1:5476", "token": "[redacted]", "port": "05476", "health": 200}-port must be a canonical decimal integer in 1..65535]
backend-5: test/test_pod_e2e_harness_paths.py::test_a_bad_handle_is_refused_at_the_door[{"name": "smoke", "base_url": "http://127.0.0.1:7811", "token": "[redacted]", "port": " 7811", "health": 200}-port must be a canonical decimal integer in 1..65535]
backend-5: test/test_pod_e2e_harness_paths.py::test_a_bad_handle_is_refused_at_the_door[{"name": "smoke", "base_url": "http://127.0.0.1:7811", "token": "[redacted]", "port": "+7811", "health": 200}-port must be a canonical decimal integer in 1..65535]
backend-5: test/test_pod_e2e_harness_paths.py::test_a_bad_handle_is_refused_at_the_door[{"name": "smoke", "base_url": "http://127.0.0.1:7811", "token": "[redacted]", "port": 7811.0, "health": 200}-port must be a canonical decimal integer in 1..65535]
backend-5: test/test_pod_e2e_harness_paths.py::test_a_bad_handle_is_refused_at_the_door[{"name": "smoke", "base_url": "http://127.0.0.1:1", "token": "[redacted]", "port": 0, "health": 200}-port must be a canonical decimal integer in 1..65535]
backend-5: test/test_pod_e2e_harness_paths.py::test_a_bad_handle_is_refused_at_the_door[{"name": "smoke", "base_url": "http://127.0.0.1:65535", "token": "[redacted]", "port": 65536, "health": 200}-port must be a canonical decimal integer in 1..65535]
backend-5: test/test_pod_e2e_harness_paths.py::test_a_bad_handle_is_refused_at_the_door[{"name": "smoke", "base_url": "http://127.0.0.1:5476", "token": "[redacted]", "port": 5476, "health": 200}-base_url port 5476 is the configured live plane]
backend-5: test/test_pod_e2e_harness_paths.py::test_a_bad_handle_is_refused_at_the_door[{"name": "smoke", "base_url": "http://127.0.0.1:7777", "token": "[redacted]", "port": 7777, "health": 200}-base_url port 7777 is reserved for a production gateway]
backend-5: test/test_pod_e2e_harness_paths.py::test_a_bad_handle_is_refused_at_the_door[{"name": "smoke", "base_url": "http://127.0.0.1:7812", "token": "[redacted]", "port": 7811, "health": 200}-does not match base_url port]
backend-5: test/test_pod_e2e_harness_paths.py::test_a_bad_handle_is_refused_at_the_door[{"name": "smoke", "base_url": "http://127.0.0.1:7811", "token": "[redacted]"}-canonical decimal]
backend-5: test/test_pod_e2e_harness_paths.py::test_a_bad_handle_is_refused_at_the_door[{"name": "smoke", "base_url": "http://127.0.0.1:7811", "token": "[redacted]", "port": 7811, "health": 200}-token contains whitespace or a control character]
backend-5: test/test_pod_e2e_harness_paths.py::test_a_bad_handle_is_refused_at_the_door[{"name": "smoke", "base_url": "http://127.0.0.1:7811", "token": "[redacted]", "port": 7811, "health": 200}-token contains characters outside the generated token format]
backend-5: test/test_pod_e2e_harness_paths.py::test_a_bad_handle_is_refused_at_the_door[{"name": "smoke", "base_url": "http://127.0.0.1:7811/ bad", "token": "[redacted]", "port": 7811, "health": 200}-base_url contains whitespace or a control character]
backend-5: test/test_pod_e2e_harness_paths.py::test_a_bad_handle_is_refused_at_the_door[{"name": "smoke", "base_url": "http://10.0.0.5:7811", "token": "[redacted]", "port": 7811, "health": 200}-is not loopback]
backend-5: test/test_pod_e2e_harness_paths.py::test_a_bad_handle_is_refused_at_the_door[{"name": "smoke", "base_url": "http://127.0.0.1", "token": "[redacted]", "port": 7811, "health": 200}-explicit port]
backend-5: test/test_pod_e2e_harness_paths.py::test_a_bad_handle_is_refused_at_the_door[{"name": "smoke", "base_url": "https://127.0.0.1:7811", "token": "[redacted]", "port": 7811, "health": 200}-must be http]
backend-5: test/test_pod_e2e_harness_paths.py::test_a_bad_handle_is_refused_at_the_door[{"name": "smoke", "base_url": "http://127.0.0.1:7811", "token": "[redacted]", "port": 7811, "health": 200, "checkout": 42}-checkout must be a string]
backend-5: test/test_pod_e2e_harness_paths.py::test_handle_refuses_the_configured_live_port
backend-5: test/test_pod_e2e_harness_paths.py::test_handle_refuses_the_default_live_port_when_unset
backend-5: test/test_pod_e2e_harness_paths.py::test_handle_accepts_a_pod_port_that_is_not_the_configured_live_port
backend-5: test/test_pod_e2e_harness_paths.py::test_bad_live_port_falls_back_to_the_default_and_warns[abc]
backend-5: test/test_pod_e2e_harness_paths.py::test_bad_live_port_falls_back_to_the_default_and_warns[0]
backend-5: test/test_pod_e2e_harness_paths.py::test_bad_live_port_falls_back_to_the_default_and_warns[65536]
backend-5: test/test_pod_e2e_harness_paths.py::test_bad_live_port_falls_back_to_the_default_and_warns[999999999999999999999999]
backend-6: test/test_pipeline_conductor_skill_contract.py::[redacted]::test_a_malformed_spec_is_named_rather_than_traced
backend-6: test/test_pipeline_conductor_skill_contract.py::[redacted]::test_a_valid_spec_starts_the_run_under_an_interpreter_without_the_package
backend-6: test/test_usage.py::TestApiKiroUsage::test_slow_session_scan_returns_billing_then_refreshes
backend-6: test/test_usage.py::TestApiKiroUsage::test_fresh_fetch
backend-6: test/test_usage.py::TestApiKiroUsage::test_error_not_cached
backend-6: test/test_usage.py::TestApiKiroUsage::test_carries_the_token_history_of_the_usage_shards
backend-6: test/test_usage.py::TestApiKiroUsage::test_an_unreadable_directory_still_answers_the_full_shape
backend-6: test/test_usage.py::TestApiKiroUsage::test_missing_directory_preserves_billing_and_refreshes
backend-6: test/test_usage.py::TestApiKiroUsage::test_unavailable_sentinel_yields_empty_billing
backend-10: test/test_codex_host_binary.py::TestVersionChild::test_timeout_kills_and_reaps_the_probe_tree
backend-10: test/test_docker_entrypoint.py::test_explicit_kirocrew_home_env_is_honored
backend-10: test/test_docker_entrypoint.py::test_kirocrew_home_tilde_is_expanded_like_the_backend
backend-10: test/test_opencode_session_mcp.py::test_the_driver_runner_reaps_descendants_on_the_timeout_path
backend-11: test/test_platform_compat_pinned_tools.py::test_process_owner_uid_ignores_a_planted_ps_on_path
backend-11: test/test_node_modules_txn.py::TestAsyncBuild::test_a_cancel_while_npm_starts_kills_its_group
backend-12: test/test_cli_server_more_coverage_lifecycle.py::TestStopViaService::test_explicit_port_bypasses_the_service
backend-12: test/test_env.py::TestAugmentedPath::test_windows_drops_the_fixed_posix_roots
backend-12: test/test_home_pin_survives_monkeypatch_undo.py::test_the_import_time_floor_leaves_no_unset_state_to_fall_back_from
backend-12: test/test_home_pin_survives_monkeypatch_undo.py::test_a_faked_home_still_guards_the_accounts_real_data_home
backend-12: test/test_home_pin_survives_monkeypatch_undo.py::test_the_guarded_homes_match_what_the_product_resolves

Red only after other tests

These tests failed in Verify's run of their shard, passed when Verify ran each again alone on the patched tree, and failed in the same run at the base commit too: they depend on what ran before them, at the base as with the patch. GitHub's CI may be red on them, by the order its runners give them.

backend-1: test/test_prepare_pr_prove_line.py::test_proven_prints_the_line_naming_only_the_tests_that_fail
backend-1: test/test_prepare_pr_prove_line.py::test_the_record_is_keyed_by_tree_and_names_the_line
backend-1: test/test_prepare_pr_prove_line.py::test_a_record_written_by_prove_satisfies_the_check
backend-1: test/test_prepare_pr_prove_line.py::test_a_message_only_amend_keeps_the_record_valid
backend-1: test/test_prepare_pr_prove_line.py::test_a_stale_record_fails_the_comparison_after_the_code_changes
backend-1: test/test_prepare_pr_prove_line.py::test_a_proven_record_cannot_be_answered_with_a_not_provable_line
backend-1: test/test_prepare_pr_prove_line.py::test_the_recorded_line_passes_in_any_of_its_spellings
backend-1: test/test_prepare_pr_prove_line.py::test_another_tree_or_no_record_leaves_a_not_provable_line_alone
backend-1: test/test_prepare_pr_prove_line.py::test_a_not_proven_run_prints_no_line_and_records_the_verdict

Manual verification

Still required: on a managed-venv nightly install, approve the in-app update and confirm the "Restart gateway" row shows under the update card and restarts the gateway.

Real-machine verification

Not run yet. This patch came from an unattended build session with no network, no credentials and no managed-venv install, so it could not reproduce the base or check the head on a real machine. This is an open blocker for review, not a waiver: the diff changes runtime UI, so the runs-nothing exemption does not apply. The code is unchanged in answer to the review finding, because the finding asks for a machine run, not a code change. The PR is not ready to pass until a maintainer runs this, on one machine, and fills in the lines:

  Machine: <to be filled by the verifier>
  Before (main): on a managed-venv nightly install, approve the in-app update in Settings → About and let the apply finish -> no restart control on the panel
  After (head): the same steps -> the "Restart gateway" row shows under the update card, and two clicks restart the gateway onto the new version
  Cleanup: <to be filled by the verifier>

Screenshots / video

The Builder captured no screenshots or video. This patch touches UI paths, so the screenshot gate stays red until the owner adds them. The UI paths:

website/src/pages/settings/AboutPanelGatewayUpdate.tsx
Still needed: the build session could not capture any. The change makes the existing "Restart gateway" row (label plus button, below the auto-update switch) appear in Settings → About during an in-app update, so it does render differently.

Related Issues

Closes #39354

The issue this implements is linked automatically.

Sibling sweep

Swept: git grep -n "showManualUpdate" -- website/src/

Sibling: website/src/pages/settings/AboutPanelGatewayUpdate.tsx -- changed here (the row and its error notice, both now on cardHasRestart)

Sibling: website/src/pages/settings/DesktopGatewayRestartRow.tsx -- not affected -- the desktop app renders its own restart row, gated by restartControls

Pattern harvest

Not generalizable: a visibility guard keyed on a broader state than the duplicate it meant to avoid; specific to this panel's layout.

Checklist

- [x] A Conventional Commits title (`feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...`); PR Hygiene does not count commits
- [x] Existing tests pass and new tests added for new functionality
- [x] Self-review completed; code follows project style guidelines
- [x] Documentation updated (if applicable)
- [x] No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

Local review blocked

Local review blocked: the Builder's own review of this patch did not pass it (a reviewer still blocked it after the agent's fix pass, or could not be reached, unavailable), and the patch went to verify anyway (review_blocked). Verify passed it and Check judged it as any patch; the repository's own review lanes judge it here. What each reviewer said, the blocking ones' items in their own words:

- GPT-6.1 Sol: [high] website/src/pages/settings/AboutPanelGatewayUpdate.tsx:414: Required real-machine verification is missing. AGENTS.md requires reproducing the missing behavior on the base, verifying the head on the same machine with the same procedure, and recording cleanup before a runtime change passes. The PR description explicitly says these runs have not happened; mocked component tests…

Draft PR by the Autobuilder (its agent's own words are quoted as code), run build-39354-7b990ef73db4. The owner marks it ready for review.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of 21071a38b8fc2b5cbeef653843dcc4a56871ff95 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing screenshots of the standing "Restart gateway" row next to the in-app update flow and next to the installer card that has no command. The PR attaches no images, so the blind read was not performed.

Evidence gaps

  • The Restart row next to the in-app update flow. The diff changes {restartControls && !showManualUpdate && ( to !cardHasRestart, so the gateway-restart-row now shows while in-app-update is on screen. Nobody can tell from the code whether two separate update actions a few rows apart read as one next step or as competing ones. To close the gap, attach a screenshot of Settings → About on an arm-capable install with an update pending.
  • The Restart row next to an installer card with no command (update_command: '', policy-managed). To close the gap, attach a screenshot of About showing manual-update-instructions and the standing row together.
  • The restart error notice (gateway-restart-error) in these new states. To close the gap, attach a screenshot of a refused restart while an update card is showing.

[UX-REVIEWED] 21071a3

Description read

[DESCRIPTION-READ] 9ade2a8d10b25340e0212a868519e7f9b6fc77827eb329ebe452befaa92b0561

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 21071a38b8fc2b5cbeef653843dcc4a56871ff95 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

This is a fix aimed at the mechanism: the standing row now hides only when the update card draws its own Restart button. The new test for the in-app flow fails on the base commit, so the defect has checkable provenance.

Notes

  • Item 1 — symptom-level: cardHasRestart = showManualUpdate && !effectiveGwCanArm && !gwManagedByCommand && !!effectiveCommand copies the branch conditions of the card at lines 457–518. If that branch tree changes, the two will drift apart. Subtraction: replace the four-term copy with a single flag taken from the branch that renders testId="gateway-restart", so the render tree is the only place the condition is written.

What this change ships

Inventory (5 items) — 4 justified

Intent: let a dashboard-only user restart the gateway to finish an update they approved. This is a FIX.

  1. The standing Restart row stays visible beside the in-app arm/apply update flow — symptom-level (the card's branch conditions are written twice)
  2. The standing Restart row stays visible beside the policy-managed update note — justified
  3. The standing Restart row stays visible when the installer card has no command — justified
  4. The restart error notice follows the same visibility as the row — justified
  5. The feature-map about row states the new visibility rule — justified

[FIRST-PRINCIPLES-REVIEWED] 21071a3

Description read

[DESCRIPTION-READ] 883d5c72f6bc1feb3786212de6ec02aac6306d8233f7bd4cf042b511e2bd67fb

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

Design-level review of 21071a38b8fc2b5cbeef653843dcc4a56871ff95 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

cannot evaluate: missing screenshot of Settings → About with the standing Restart row beside the in-app update flow and beside the command-less installer card. The diff changes which controls those states show, and no rendered evidence came with it.

Blockers

Changed control set in two update states, with no rendered evidence
Trigger: {restartControls && !cardHasRestart && ( now draws the gateway-restart-row (and its error notice) under InAppUpdateFlow, under policy-managed-update-note and under the installer card with no command. Before this patch, all three hid it. design-evidence.txt lists 0 attachments and 0 committed images. Outcome: no image of the new layout → I cannot check whether the standing row next to the arm/approve flow still reads as one next action, or whether it looks like a competing primary button → the user-visible shape of the About panel during an update ships without review.Fix: attach screenshots of the arm-capable pending-update state and the command-less installer state (also the policy-managed note, if it is reachable) at this head.Clears when: the description carries github.com/user-attachments images (or committed images under temp-screenshots/) of About → Updates in the in-app arm flow and the command-less installer card, each showing the standing Restart row at 21071a3.`

Notes

  • cardHasRestart restates the branch conditions of the card ternary at lines 457–511. If that ternary changes, this flag drifts silently and you get two Restart buttons or none. Deriving both from one shared discriminant (e.g. cardKind) would keep them in sync.

[DESIGN-REVIEWED] 21071a3

Description read

[DESCRIPTION-READ] 8b4f7a2965b2b2f0fab242272a297aa0eeab27c4e78f986915cac63486220302

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 21071a38b8fc2b5cbeef653843dcc4a56871ff95 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 21071a3

Verdict parsed from the review's SHA-scoped output markers for commit 21071a38b8fc2b5cbeef653843dcc4a56871ff95.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 21071a38b8fc2b5cbeef653843dcc4a56871ff95 false-positive: <reason, 20 to 500 characters>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 21071a38b8fc2b5cbeef653843dcc4a56871ff95 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 21071a3

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 21071a38b8fc2b5cbeef653843dcc4a56871ff95 false-positive: <reason, 20 to 500 characters>

@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

This PR and #39370 make the same fix for part 1 of #39354. Both add the same cardHasRestart = showManualUpdate && !effectiveGwCanArm && !gwManagedByCommand && !!effectiveCommand check in website/src/pages/settings/AboutPanelGatewayUpdate.tsx and change both restartControls && !showManualUpdate guards to !cardHasRestart, with a matching test in AboutPanel.gatewayChannelRestart.test.tsx.

Please keep one of #39370 and #40331 and close the other, carrying over anything only this one has.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autobuild readiness: checking Automated validation is still running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Settings → About: no restart control during the update lifecycle — standing row hidden and card button requires a manual command

2 participants