Repository navigation
feat(remote-crew): one Remote Crews list in the switcher - #40332
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks. The diff only changes frontend presentation. The new pane-relay field is optional and reads as the host alone when it is missing. The dropped Notes
[DESIGN-REVIEWED] 7275b51 Description read[DESCRIPTION-READ] 73c68375ab1a95fcb8697205915a1022a0c69719bc2ab23affe5e2425497b220 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks: Bug Bash rows 41/42 and the maintainer's sign-off on #38790 explain the regrouping and the relabel, and each new field has real consumers. What this change shipsInventory (7 items) — 7 justifiedIntent: a person picking a Crew in the header switcher sees one list of remote Crews, each saying how it is reached. This is a FIX that finishes #38790.
[FIRST-PRINCIPLES-REVIEWED] 7275b51 Description read[DESCRIPTION-READ] d49b5260470ae102bcd2620380fbccab57fa1d446ec82e8c91cdeae5d8e3bd83 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. The screenshots show every changed element: the single "Remote Crews" heading, the "Private · SSH/SSM · " row line and the "Remote Crew is off" title. The blind reader read each one correctly. Notes
[UX-REVIEWED] 7275b51 Description read[DESCRIPTION-READ] 5400ecccf58a536eeeb0b64404f3dab4479b403c4c22888e1ad178fa1d58cc95 That sha256 names everything this verdict read: the PR description, plus the 9 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
The header Crew switcher drew the SSH and SSM Crews under "My Crews" and the relay Crews under "Remote Crews" (Bug Bash rows 41 and 42). Both now sit under one "Remote Crews" heading, and an SSH, SSM or Fargate row reads "Private" with a lock and its source tag, in the window and in an SSH Crew's own pane. The card shown while remote crew management is off is titled "Remote Crew is off". The shared-crew spec says the switcher is one list, and that the People heading counts the rows shown. Closes #38790
c4cb4fc to
7275b51
Compare
|
self-added: yes
|
Code change approver recommendation: A person should decideWhy: the decider estimates a 10% chance that this change introduces a defect, within the 12% limit for approving on its own, but it is held at tier 2: tier-gate: T3. I found nothing that should block this PR, so I'm approving it. What it does. It joins the two switcher lists into one. The heading that used to say "My Crews" (shown at row index 1 when a relay group exists) now reads "Remote Crews", the same key the relay group used. The relay groups, in both the window and the pane, get a Edge cases I checked:
Private · source line. SSH, SSM and Fargate rows get a new Tier: 2, held for a person: tier-gate: T3. An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Reviewed head 7275b51. I checked the switcher regrouping, the new optional pane transport field and the shared transport label helper against the code, and ran the touched frontend suites: all 235 tests pass. The new switcher tests fail against the previous switcher code, and the pane one-heading test fails when the headed flag is not passed down, so they test the behaviour they describe. The headed condition is the same one that draws the menu's own heading, so the list never shows two headings and never shows none. An older window that sends no transport still shows the host alone. I found no code errors, and nothing blocks.
Problem / Motivation
Goal: The header Crew switcher shows one "Remote Crews" list in which a Crew you reach over SSH or SSM reads "Private" with a lock and its source, and the turned-off Remote Crew card says "Remote Crew is off", finishing #38790.
Most of #38790 is already on main through #38803 (
a228ee35325): the Remote Crew page's My Crews / Shared with me sections, the "+ Add Crew" modal, the new Crew rows, the one Settings section (items 1-4), the People source cards and one People list (items 6-7), and the switcher's "Remote Crews" / Private / Shared wording (item 8). Two things from the maintainer's sign-off on the issue are still missing:instances.enabledis false is titled "Remote crew management is off", while the page and the switcher call the feature "Remote Crew".Why it matters
The switcher is the one place a person picks a Crew. Two headings over what is one set of remote Crews, and SSH rows with no type, make it look like two different kinds of thing, which is what Bug Bash 41 and 42 reported.
Not a goal
What changed (motivation → approach → change)
The switcher reads as one list of remote Crews, and the off card uses the page's name.
InstanceTabBar.tsx,TeamCrewsGroup.tsx,embeddedTeamCrewsGroups.tsxHostTab.transport); a window that sends none shows the host alone. OnecrewTransportLabelgives the tag to both the switcher and the Remote Crew rows.InstanceTabBar.tsx,InstancesViewport.tsx,EmbeddedHostBridge.tsx,instancesSlice.ts,utils/remoteCrew.ts,RemoteCrewPanelCrewRow.tsxgroup_my_crewskey is dropped.website/src/i18n/locales/*.jsonshared-crew.mdsays the switcher is one list and how its SSH rows read, and that the People heading counts rows.docs/system-specs/modules/shared-crew.mdBackwards compatibility
Compatible: the pane relay gains one optional field; an older window sends none and its pane shows the host as before.
Removes nothing: the only key dropped,
components.instanceTabBar.group_my_crews, had one reader (InstanceTabBar.tsx's group label), which now readscomponents.relayCrews.group_team_crews.Tests
TeamCrewsGroup.test.tsx"lists SSH Crews and Team Crews under one Remote Crews heading, the SSH row read as Private": one heading, no "My Crews", the SSH row reads "Private · SSH" with a lock. Red on main's switcher code, green here.EmbeddedSwitcher.test.tsx: in a pane with relay rows there is one "Remote Crews" heading and no "My Crews" (red withoutheaded); a relayed SSM tab reads "Private · SSM · i-0abc", a tab from an older window shows its host alone;parseHostModelkeeps onlyssh/ssm/fargate.RemoteCrewPanel.test.tsx,RemoteCrewPanel.sharedCrewsOff.test.tsx,InstancesPanel.test.tsx: the off card's title is exactly "Remote Crew is off". Red with the old string.Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
See Real-machine verification.
Real-machine verification
Machine: EC2
t3.xlarge-class demo viewer (i-089781885b3950d7b), Ubuntu, x86_64, Kiro Crew desktop app (Electron) built from the tree under test, signed in to Kiro (IAM Identity Center). One SSH Crew (r38-dev) and one SSM Crew (r38-ssm) connected to a second gateway on the same box, plus the account's relay Crews.Before (main
276eaffebdb5): open the header switcher on Local -> "This computer", then a "My Crews" group withr38-devreading onlyr38-ssh, then a separate "Remote Crews" group. Withinstances.enabled=falsethe Remote Crew card reads "Remote crew management is off".After (
2cb7a27accb6, this change before the rebase): the same steps -> one "Remote Crews" heading overr38-dev("🔒 Private · SSH · r38-ssh"),r38-ssm("🔒 Private · SSM · i-…") and the relay Crews; no "My Crews". The off card reads "Remote Crew is off".After (head
7275b516a07c, on top of #40260): inside ther38-devSSH pane, its own switcher shows "This computer", then one "Remote Crews" heading overr38-devandr38-ssm(Private · SSH / SSM with the source) and the relay Crews (Private and Shared) in the same group; no "My Crews".r38-ssmreads "tunnel error" in that shot only because the temporary SSM permission from the earlier run was not added again; its row still shows Private · SSM and its source.Cleanup: the box is a shared demo machine and stays running. The temporary SSM inline policy and AppArmor profile the tester added for the SSM Crew are removed by the tester when its run ends.
Merge order with #40260
#40260 merged first, so this PR carries the follow-up: an SSH Crew's own pane shows the relay Crews (
EmbeddedTeamCrewsGroup), and that group now draws no second "Remote Crews" heading when the pane's own SSH / SSM rows already opened the list (embeddedTeamCrewsGroups.tsxpassesheaded; test inEmbeddedSwitcher.test.tsx).Screenshots / video
Switcher, before (main): two groups, SSH row with no type.
Switcher, after: one Remote Crews list, SSH and SSM rows read Private with their source.
Switcher inside the SSH Crew's pane, before the rebase onto #40260 (
2cb7a27accb6, no relay rows in a pane yet).Switcher inside the SSH Crew's pane, on this head (
7275b516a07c): one Remote Crews list with the relay Crews.r38-ssm's tunnel error is the test box's missing SSM permission, not this change.Off card, before and after.
Related Issues
Closes #38790
Items 6-7 (People) are on main via #38803; item 5 is not done (see Not a goal).
Checklist
Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license.